Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139691/?format=api
{ "id": 139691, "url": "https://patches.dpdk.org/api/patches/139691/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240426074831.1729792-4-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240426074831.1729792-4-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240426074831.1729792-4-chaoyong.he@corigine.com", "date": "2024-04-26T07:48:24", "name": "[03/10] vdpa/nfp: fix the logic of reconfiguration", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "007236202af4fc37b8fbeb40e6f0e2ef6457aa91", "submitter": { "id": 2554, "url": "https://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240426074831.1729792-4-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 31827, "url": "https://patches.dpdk.org/api/series/31827/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31827", "date": "2024-04-26T07:48:21", "name": "support software live migration", "version": 1, "mbox": "https://patches.dpdk.org/series/31827/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139691/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139691/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EE77343F12;\n\tFri, 26 Apr 2024 09:49:22 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AB62D43C87;\n\tFri, 26 Apr 2024 09:49:00 +0200 (CEST)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2113.outbound.protection.outlook.com [40.107.94.113])\n by mails.dpdk.org (Postfix) with ESMTP id F07C443C7F;\n Fri, 26 Apr 2024 09:48:59 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by SN4PR13MB5279.namprd13.prod.outlook.com (2603:10b6:806:206::7)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.22; Fri, 26 Apr\n 2024 07:48:58 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7544.010; Fri, 26 Apr 2024\n 07:48:58 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=CX1HKIbGvtpfaG3HcHT2Dh7mDzWpq2Yfo6hIErzdOb3h8dI/a178c0JU+HoiTHHXjyYlxRdq/v9P19pHLgvFJWSJsimcygtvNXvmWRpyYMoE1YuSjrziP9j2qpbI/2jqNNgyp812TsSCtEn2jUxhZh3IW0z1StnxCUozLQq6nWWe12441pPcNtEO17ZpFUszmmsYNvIZHqhVQCSrRlH7c9sY+IJPwQD9+H3jMWNLv1m9hZlA07jx3xo7KGJ35gW+l2KpEhQdewUUb6uX94rHrj/L5+V5NotyWKfrnPvRzbziZUaN8K8lyhiYi4j7MAt8AyT9+rxzwIem03x+Ivaq6A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=YTY/WVf+V0442ecn3lqK67icri8AUxZ9OO4UavpX7/g=;\n b=VAdZxy1PhWl/j+G0ljmm2KXTkEWWZYN80uGpt4VJIlN1Kk8xiU8qmYBUHmZqz9CGyNfliRAwnVCB1iCdiVwtFKwnrZ2q2fj0n7aVav5D1N/wtDBwUMqCXjH91OzpBSyOlYjec0peC6Y4DIUOet+4WuHEt4uilJbXhBHSr+OHQOPiPf83Dw9p0Rbqd235Gm/0mdsHISoU79v5AIOJk2RbnMaBUvbwy/z4irti2XcyPsweTQnMXBJUJwupxLkCKS476tTDbxjraaAxE3Xu0FfWBh7Up2DgoLmwLUhesbC0OJ7jBuyTRsqTjELVPQx1+uIPs4BJ35lGZzW3VdGgYZYD1Q==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=YTY/WVf+V0442ecn3lqK67icri8AUxZ9OO4UavpX7/g=;\n b=CLYKcJM0cMBie8hDEjfTNxKrz8y0Q/ai4oBqSPZ2jseA9kMpGKK09j9PC4rOsWz1IbgeGjcOTGmKC63uDIdLLYNoyfb0xmPSwMF1QbjNR9OnUaJukppF3e19bfVnmnvuu9AQDdM9pPlN+tis9pLxAXJNkBfydGIiBMfomBWXP9k=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Xinying Yu <xinying.yu@corigine.com>,\n chaoyong.he@corigine.com, stable@dpdk.org, Long Wu <long.wu@corigine.com>,\n Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH 03/10] vdpa/nfp: fix the logic of reconfiguration", "Date": "Fri, 26 Apr 2024 15:48:24 +0800", "Message-Id": "<20240426074831.1729792-4-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20240426074831.1729792-1-chaoyong.he@corigine.com>", "References": "<20240426074831.1729792-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "BYAPR02CA0007.namprd02.prod.outlook.com\n (2603:10b6:a02:ee::20) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|SN4PR13MB5279:EE_", "X-MS-Office365-Filtering-Correlation-Id": "9d19a6e1-36b5-45f9-3b8c-08dc65c5545f", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230031|52116005|1800799015|366007|376005|38350700005;", "X-Microsoft-Antispam-Message-Info": "\n s8+WSLehGSiOOBb3MdOGwISDgtLGwXafLo+UBahmMFaoi7gUFS0EdGJOjwrw1RXJgSc1a8HqVXQy45KPt0tMr5+TcIfzp/2KIrbXKlrLl+ANuAxLRrfh8NHI+THO5JVQQOH3Hk0rbiwYoxDPSZcMRV/FRNiksgtskt+Gs2XmNiCqK41gvNQiJFFwAdlFXp9tHIsWw6gzq/tW5EuJIX7IQV1mOmu4haisdZfUpF2AV8VcGjrr5ty1kMjIo3gwkgxxb+l+CjEbLhXcHzw/BqIpvke5+pHlHzG3n3EnPuc63+NPUT7RuJSu90w2QQT8V5tuQP1amr9X1+57go5XcRticYWJzZJhXb0K0jQQU36RkuRmEHmPM3cjazufcatquLqdUxfLZf8TLFV5kToBQH7qAl/QcIGDNjccgzgT/Ob2ZcwGVezaJAkkIpUdMpxG7qbAYWZMPecq7J/SuPogse29ACiZtoiSjH3j1rE1X1Ai5JFql/MpJwswJAgmK3IkZOXDJWott6YbsCpfAZiY1hK6GjSJ7FTC4pSUdqkfiIKGh1YsaiDhNma5nPNMzq5Cfcnsbq8fsTS4zQCAiuiRW8R/dBhtAFaYExpd2lInP5vbbYXdhOEOcmKx9rJ/uB0XG0AekAWMb6l6FkCwo9L41Xs9xOnYdoJIlSZLOREf6tKV+4xXfa2k74D2qy54JeD1NOHYpnmSmD55Bfvx/l7vojKzUVzvgw0zH1YHCQFb69xB2cRnaiVQVHa5ENMfbGMUt8HTXRCMQkm2zuPakhzjp0131i0azyjg+g3QES0dsd9pnbYmVoV8fwLRB5ywGRdab0spnZS9IJ+B4eX+PuDuBJCleREgrUVk/muPXsfv5D6YN5mmBSipvHoNWnUqKfA46+7UO0JZ71wStkMKV5k/3RYh+tFaScAW0qMkL4PLuqOGPCzTfnXwdy9nolD4t9y7Or6hIGWjAtvTfZHKPE+v5tlVQnOAyATqjPY9I4YD4Mfwv89LD4c6VH1UiLejTRFaRW8fV2+h7OxMN0cELxksMDxr4Aai2DJ75DMsR9Xz2bMIloOAa04e3FxUD1lY2erzLEdBAu7fUT7Ad4g28Q8GQ0JWrodUr2+hNkl4upwCZTU2IfAQPhsKD6j4+991jUUjHJ/EnWQ/GDYhGzT0gwGvLEZ8Ewrjw8sOekV9R+OXNSCVxXKtt7G2pzh7yT1NrAPmHTQ22BimrJeDgcNAdkKrUBhGC0JGpYEL4w65W9fmLwVSb8Xin+BOL1Pp/RNbAVTf9tleIMSU1+pqo5rO4GRsfp8ugqrQXW8Gnzf2YgnspSHWULR0i6aBOJnPZ+kG5/yEqiv+1gagAHD6J6hMzV8EaC68eA==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(52116005)(1800799015)(366007)(376005)(38350700005); DIR:OUT;\n SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n 8RT2aDGkLnc+qtsXdt5kERIHtM8Lj3m0VEDlwU4lcWRY8bEGKe3wyM5QFCxykA8lTLcOhWFPFKYv8hTLW+PDX7yFW/QM8OEqM4SwvMG1ewtVFoKXwfunmUkdm7xbsumaGYoYd5WQdQKbBK4Xu/zi0UpVRI0rRMggGfnXE2b8RTqGWw+DutVFHtAc5Rc5sPO9oVq99/8jG1uTKTKQNQuMU1WA8q7DYe0CseNf+Ab0mlsY30toFZuJSKW/8AT73NwKzRr3a45Z6Sm6AbTO1GW6UOFOXJoiYk2JLOqF7I5jLlU6fFfqQArp8yXJZKyu8+Fs/F1b4PBYgWOCzsAdMX8r/RA17SjAiPrlwYa2UN4l9k9AbTGFrFKgoo/pBQGIW16OX2R1xdqbzGCxT0KMrAiCWA8lo+fW7qPSnCo8gnjzuezr+z/CP61Y5cucsv1NNxcVr0bF4Z6xTjKFbS3i2TcYoc7YCGrMUQ6G1MT307ojn9pRhq8LlmOoAG8JjOZfuOHJVOyb8bmVpb4KgyG8O0tmh0pZdl2Vl39VgYL8MwOP52n1RIDb+uRcXlifZiOGotrVZjnARuh+fZI5sitO8LlJtGy6C17oeq4IbtpPqyb+cYHmxiS1VKOse7xCqWXbUgt5YI28nn+2GmdhRczUWg1OxdMMQauCvAZ013pEkOsxUwf5GqD6jus0KoUitOd7Gjr3jlDiUWemTLzQINtZ/x30Fhk1cCss02qE+mxM3N4fokQO7yzf9HgkdeUGDDCjRo9G4i9Zi3PP0wiGsw0Y6nYl250Ew4oZe0pWdW0WKjSpbbvPXwA2waONMcPkbO8HdpJGzeY8Rn4Fj7tTpjUwtnSKtwD498Rq9sGjr1snitsCX7rTvpxtBA5DuQ7tWn9b6Y+TSKcU1HrrqhoRWnX4edwSVe5/0nlTvfvItCmpil9q2bnNcF9MXaql10qTspKVBawuhcrsH4NVviUyaKbqFUB27JPgPSGKEppBkDmM0sIUMs4/4tPy10FguYGijQ6sKbcriBQkTFrRj1avv4+fAAwa+bHnd/LCJUoPVzmp2E32kGIgQ14WHOhAxFA9zeBmlEm0/JRV3hyk/cXeSVPQq6mzS4QE9MrZ/5+ocsJ2oxSWcBUnAOk/kEpbn/hqdCVS8mDMryeKnIJF5DCXaeXZ0RsfSlLevS8lqKLgAa7OYop44ZLz+GMXIG/FjmdJ2pksGJiZRQ7SVIPTHP84xveCPmH5d7smAGq1XFvL0t+c+6WUL1RSYrVNTVPwN8FR8KLweLg7p0B0RiwrtpDI9LQ1BEWC6zykpzSWMm7KJpNOpnZfNkX9yNYq68yB2jMmI+XF2CYWZ/VeuiTMVeeGrIzTeT/GYo7tSfzq1FbsyBwO5/zgLBkFnDQc54PNjI4xwcUkBtPSRVs0GW1NqXGin4PP/g8FNRH1HPopBP8fjQ8ovpJK/AYVsuCo3L0FsbtA+53WnkyPAlBl39SEWoW09OHVpw1gcofPORNOMoak4lK+mrxZFGVKEKtHz4vHWZ+Ap0z7vAAuKQyY5mkfTSVVfYmNFs3+zSKKbg1C/w6jXq/kMGk1GDYfvO2vE0VFnN341/N1/qx+E2SMnQS3nDXrlcJUD7b16A==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 9d19a6e1-36b5-45f9-3b8c-08dc65c5545f", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "26 Apr 2024 07:48:58.0862 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n fsHOPYLqPkwlZjBIV1jkQguBkP6Ee8iqd5zrBMOMMXaVTJUcoFQuDX5pF3vN0K51mnuSRkQ3k554qs3rL1cUMYm4prhRcNq9lkaTyRbRa1E=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SN4PR13MB5279", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Xinying Yu <xinying.yu@corigine.com>\n\nThe ctrl words of vDPA is locate on the extend word, so should\nuse the 'nfp_ext_reconfig()' rather than 'nfp_reconfig()'.\n\nAlso replace the misuse of 'NFP_NET_CFG_CTRL_SCATTER' macro\nwith 'NFP_NET_CFG_CTRL_VIRTIO'.\n\nFixes: b47a0373903f (\"vdpa/nfp: add datapath update\")\nCc: chaoyong.he@corigine.com\nCc: stable@dpdk.org\n\nSigned-off-by: Xinying Yu <xinying.yu@corigine.com>\nReviewed-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/common/nfp/nfp_common_ctrl.h | 1 +\n drivers/vdpa/nfp/nfp_vdpa_core.c | 16 ++++++++++++----\n 2 files changed, 13 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/common/nfp/nfp_common_ctrl.h b/drivers/common/nfp/nfp_common_ctrl.h\nindex 6badf769fc..a0e62b063d 100644\n--- a/drivers/common/nfp/nfp_common_ctrl.h\n+++ b/drivers/common/nfp/nfp_common_ctrl.h\n@@ -184,6 +184,7 @@ struct nfp_net_fw_ver {\n #define NFP_NET_CFG_CTRL_IPSEC_LM_LOOKUP (0x1 << 4) /**< SA long match lookup */\n #define NFP_NET_CFG_CTRL_MULTI_PF (0x1 << 5)\n #define NFP_NET_CFG_CTRL_FLOW_STEER (0x1 << 8) /**< Flow Steering */\n+#define NFP_NET_CFG_CTRL_VIRTIO (0x1 << 10) /**< Virtio offload */\n #define NFP_NET_CFG_CTRL_IN_ORDER (0x1 << 11) /**< Virtio in-order flag */\n #define NFP_NET_CFG_CTRL_USO (0x1 << 16) /**< UDP segmentation offload */\n \ndiff --git a/drivers/vdpa/nfp/nfp_vdpa_core.c b/drivers/vdpa/nfp/nfp_vdpa_core.c\nindex 291798196c..6d07356581 100644\n--- a/drivers/vdpa/nfp/nfp_vdpa_core.c\n+++ b/drivers/vdpa/nfp/nfp_vdpa_core.c\n@@ -101,7 +101,7 @@ nfp_vdpa_hw_init(struct nfp_vdpa_hw *vdpa_hw,\n static uint32_t\n nfp_vdpa_check_offloads(void)\n {\n-\treturn NFP_NET_CFG_CTRL_SCATTER |\n+\treturn NFP_NET_CFG_CTRL_VIRTIO |\n \t\t\tNFP_NET_CFG_CTRL_IN_ORDER;\n }\n \n@@ -112,6 +112,7 @@ nfp_vdpa_hw_start(struct nfp_vdpa_hw *vdpa_hw,\n \tint ret;\n \tuint32_t update;\n \tuint32_t new_ctrl;\n+\tuint32_t new_ext_ctrl;\n \tstruct timespec wait_tst;\n \tstruct nfp_hw *hw = &vdpa_hw->super;\n \tuint8_t mac_addr[RTE_ETHER_ADDR_LEN];\n@@ -131,8 +132,6 @@ nfp_vdpa_hw_start(struct nfp_vdpa_hw *vdpa_hw,\n \tnfp_disable_queues(hw);\n \tnfp_enable_queues(hw, NFP_VDPA_MAX_QUEUES, NFP_VDPA_MAX_QUEUES);\n \n-\tnew_ctrl = nfp_vdpa_check_offloads();\n-\n \tnn_cfg_writel(hw, NFP_NET_CFG_MTU, 9216);\n \tnn_cfg_writel(hw, NFP_NET_CFG_FLBUFSZ, 10240);\n \n@@ -147,8 +146,17 @@ nfp_vdpa_hw_start(struct nfp_vdpa_hw *vdpa_hw,\n \t/* Writing new MAC to the specific port BAR address */\n \tnfp_write_mac(hw, (uint8_t *)mac_addr);\n \n+\tnew_ext_ctrl = nfp_vdpa_check_offloads();\n+\n+\tupdate = NFP_NET_CFG_UPDATE_GEN;\n+\tret = nfp_ext_reconfig(hw, new_ext_ctrl, update);\n+\tif (ret != 0)\n+\t\treturn -EIO;\n+\n+\thw->ctrl_ext = new_ext_ctrl;\n+\n \t/* Enable device */\n-\tnew_ctrl |= NFP_NET_CFG_CTRL_ENABLE;\n+\tnew_ctrl = NFP_NET_CFG_CTRL_ENABLE;\n \n \t/* Signal the NIC about the change */\n \tupdate = NFP_NET_CFG_UPDATE_MACADDR |\n", "prefixes": [ "03/10" ] }