Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139688/?format=api
{ "id": 139688, "url": "https://patches.dpdk.org/api/patches/139688/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240426073824.100386-1-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240426073824.100386-1-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240426073824.100386-1-mattias.ronnblom@ericsson.com", "date": "2024-04-26T07:38:24", "name": "net/af_packet: cache align Rx/Tx structs", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "33681fe36bf6ea91120425d5df6b9b4afdf2ca37", "submitter": { "id": 1077, "url": "https://patches.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240426073824.100386-1-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 31826, "url": "https://patches.dpdk.org/api/series/31826/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31826", "date": "2024-04-26T07:38:24", "name": "net/af_packet: cache align Rx/Tx structs", "version": 1, "mbox": "https://patches.dpdk.org/series/31826/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139688/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/139688/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A9C9A43F12;\n\tFri, 26 Apr 2024 09:48:51 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8130D43AE0;\n\tFri, 26 Apr 2024 09:48:51 +0200 (CEST)", "from EUR04-DB3-obe.outbound.protection.outlook.com\n (mail-db3eur04on2051.outbound.protection.outlook.com [40.107.6.51])\n by mails.dpdk.org (Postfix) with ESMTP id DE01E402EF;\n Fri, 26 Apr 2024 09:48:49 +0200 (CEST)", "from DB3PR08CA0024.eurprd08.prod.outlook.com (2603:10a6:8::37) by\n PA4PR07MB7695.eurprd07.prod.outlook.com (2603:10a6:102:fb::9) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7519.22; Fri, 26 Apr 2024 07:48:48 +0000", "from DB1PEPF000509E2.eurprd03.prod.outlook.com\n (2603:10a6:8:0:cafe::15) by DB3PR08CA0024.outlook.office365.com\n (2603:10a6:8::37) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.29 via Frontend\n Transport; Fri, 26 Apr 2024 07:48:48 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n DB1PEPF000509E2.mail.protection.outlook.com (10.167.242.52) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7519.19 via Frontend Transport; Fri, 26 Apr 2024 07:48:48 +0000", "from seliicinfr00050.seli.gic.ericsson.se (153.88.142.248) by\n smtp-central.internal.ericsson.com (100.87.178.64) with Microsoft SMTP Server\n id 15.2.1258.12; Fri, 26 Apr 2024 09:48:47 +0200", "from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100])\n by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id\n 82E051C006A; Fri, 26 Apr 2024 09:48:47 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Dt61qjTtkTc6lwcnuB9idXlc6sHtH+p9SFhmL5Ixkk3FbXzKXJurNU2SwBRuwahYikVj+xNQGp5H8wxg8C9QlGMnSE3xOWZJ8fCQlZNXa2gDpXSsXqijNUR97Jm/XIGL50iCxbcOh25/sREsm+1EaaV7H+ClR3xEP1w1HoEdMRicyljDAXccHKEHlUvlXMNdVy+V0T6s7vxFFYryDYu1mM3Bk2uJzXumnnD8oMNNVWsFGlYqdZUGA4X4e8cz8sYTsotlwQEtXRRHhwALcqIAM6YGnCyEsn7uFqhNhTJ5OoRbjKPaIMqinyjlwo4pfEfIZm+nr9BgsIsu4WgZ2GDBZw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=/dCMlHpTRYHqhwJaEftB9GagGgUSi4nt1eX5Xc/VPg4=;\n b=DZC4rK4d5w8Yx49C1FtDCh5MMiEoe5MberFlHY6521xag2f1XvvJgnha9uXFtPT0KEY4C4pXhxGlf/0lXiWmyi9ivT0z6y4lHyl/1qf3tzDRaErs8AM9pt9Z1hvi7FynlZqyAlELWpZ+2LpBESsuS1m6F5vjELdNkENAtBFF2nx+LDcO8ih+71FAsTctHGDlUrZvr5/ScWOYZjl9ycZSl2y31e9JLbK9EIoJjiSwdK0N2ac7dDXTtGvlbnx1PJ4ZA8LBUrU45+f4RpOAlYUVB8iph/SajazJMIJDok1OGv2rU22apbmLRE/gN8yZOxUOLFiYzLEC+2iJWC8DpU2eOw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=amd.com smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=/dCMlHpTRYHqhwJaEftB9GagGgUSi4nt1eX5Xc/VPg4=;\n b=fcQNDdboXK9k/MR658PUdFi8lLmhWyRS3MvFIZiIOazy6zjPnE4PY6gCVJAxbzCnRlhmU5Dq5m3K9uat7NAG7Obhw+98NDI6R4aL7O9+7svqPMSuMowx4n4lkBhbXPL9ol95UqW4yR0EEoQ5fMrJvA6bfVh1yYWV5qtgs68nJZqE7EHp7ZjKgKdem7UPRXJ+8nCwnAb5405wCAtoRgoxfazNSnf1UA3G8PWV9/pHkgDmIMpF6IH1mzL85iHyp2xB6oi03tAy6yj0lsB03CGW0pjWpkMiOAOtdHLy3a/OiZUYWqcyyX1stxncx09EVB8NGoKv7Vmqleln0jX6UQQcNw==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<dev@dpdk.org>", "CC": "<hofors@lysator.liu.se>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Thomas Monjalon <thomas@monjalon.net>,\n \"John W . Linville\" <linville@tuxdriver.com>,\n Ferruh Yigit <ferruh.yigit@amd.com>,\n =?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n <stable@dpdk.org>", "Subject": "[PATCH] net/af_packet: cache align Rx/Tx structs", "Date": "Fri, 26 Apr 2024 09:38:24 +0200", "Message-ID": "<20240426073824.100386-1-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240423090813.94110-1-mattias.ronnblom@ericsson.com>", "References": "<20240423090813.94110-1-mattias.ronnblom@ericsson.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DB1PEPF000509E2:EE_|PA4PR07MB7695:EE_", "X-MS-Office365-Filtering-Correlation-Id": "319a6740-8e91-4e8c-9bdf-08dc65c54eb9", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230031|36860700004|1800799015|82310400014|376005;", "X-Microsoft-Antispam-Message-Info": "=?utf-8?q?bB5oh9cizAX+syQRhNZUh2yV8q1xX+7?=\n\t=?utf-8?q?mTUvrbJUeMWxtDYzMsnxjPbllhUY/ASJVKlXuyW+yQestxLUztuLovo3lj5p32aqo?=\n\t=?utf-8?q?fsDjw8B0mys0H5h7/F2SPYIJ9Fmez+sp1QD7kXBYkQZe4JDf1Lmiscj2mxl7ylh/E?=\n\t=?utf-8?q?G/R4UAGNFqAx4JNoJJnS6j7n3HIuFkfqj3Z1gxd20Ttqqy8DzNSu9KlUM7dla5w9j?=\n\t=?utf-8?q?ECkeaG8Rp0QQzwIxgNubxe+W67W3bdL8isLxveecEhKSmYNINRMadauVhusVjX8tv?=\n\t=?utf-8?q?61F/+23FCgE8PCaLdrruF3n1MtNXpWENG+W36m3l2F5krGfQS9Aa3GfdsGVovNPAb?=\n\t=?utf-8?q?caSVS7KaV3GaCRGc2S8CY6lZuT0dijihgXEx1Yr8jJ5/udbIlAvNBBcVtFNPBtWDF?=\n\t=?utf-8?q?+kNjEPucoYvWSnjtX4kpp3USBkitzw2p3NjhGEkIyS1r01imk6NafP6CP0lFBNwE3?=\n\t=?utf-8?q?MoU8q5Oro/5iakc3IZHIMbPha0BHIIlQBC+dmVKjEoeFHjRHoKwBSc3AESNH1sfhJ?=\n\t=?utf-8?q?DSFAa/sPIuOGEbnHBEKvGcdssMtqNhkBRi0/w64nL4WLPQ2c7CXAW6FyzCJP71MQm?=\n\t=?utf-8?q?MNwLRG9wF48UFyZ6JnRSW5/l0/rhc66Y+woH5MmDl4jzEXvIkjGW3VadVktKGvBdb?=\n\t=?utf-8?q?fO3juy1/ANVfDQbQAdnEe4ayreXJ8Iv5Y6LdTEpI5vTXI/w0hfx7TnatmhV9Q2x1M?=\n\t=?utf-8?q?ciib29VVcH1ZF2BxrTG6fde2bRWZlFklblh/de3vnr968yCjpLB0zl1/SBTDUwdgG?=\n\t=?utf-8?q?hghIoDuofel6P1dOSzKDgxFYSYOvIKn0chSASvoPE/Ec/M+6vAD13HvKDDaQP1rPV?=\n\t=?utf-8?q?mFlL37e0vPgBvAxsQckLqzcQehMdwVFOb6znXu1iSABGEh4WniUq0sSUk3Dxvhlu2?=\n\t=?utf-8?q?EQaTTu32TRL/xZLWRgP3g7ZX+UCcnTWnqomkKdGTVi7CB1i/RqLkyIcQUG3Jio8HO?=\n\t=?utf-8?q?EtsDgg00DaQXmcdrm6d1HdXndIiXoOZpux3EteG/KNW509WtUhE0F0E1g6HkXFqxS?=\n\t=?utf-8?q?piXZQx2P+it3nvEVZJkeaJ7nLSL1tDf/ZldUHMYCOqiiZYKaMCQGQFhT9duaQQ2MV?=\n\t=?utf-8?q?9nfMfa5ZPujIwJE5lV0OyP2Vg5PnGdSLXQVRB7UzqhH+sh71a9y/lFDH5UTzrIS+c?=\n\t=?utf-8?q?stN5BQB7mrYrACmSGaF+r+ySNp7D+fkzYk4boyikd6/HLhuzSi3cutZiwklyCRm+R?=\n\t=?utf-8?q?iHw7jkqD4zI0I27TOGn+Mi+ITcYYUA9snlMaSC5VxJ/izKT4Gq4fi/mfhwEVyRjbh?=\n\t=?utf-8?q?OGMI7KmagsYN2QIw/UZERlqFnVBa9RnOU4tdTXox94z/6idgIyjNHJAw=3D?=", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;\n CAT:NONE; SFS:(13230031)(36860700004)(1800799015)(82310400014)(376005);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "26 Apr 2024 07:48:48.2736 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 319a6740-8e91-4e8c-9bdf-08dc65c54eb9", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DB1PEPF000509E2.eurprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PA4PR07MB7695", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Cache align Rx and Tx queue struct to avoid false sharing.\n\nRX struct happens to be 64 bytes on x86_64 already, so cache alignment\nhas no effect there, but it does on 32-bit ISAs.\n\nTX struct is 56 bytes on x86_64.\n\nBoth structs keep counters, and in the RX case they are updated even\nfor empty polls.\n\nFixes: 364e08f2bbc0 (\"af_packet: add PMD for AF_PACKET-based virtual devices\")\nCc: stable@dpdk.org\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\n---\n drivers/net/af_packet/rte_eth_af_packet.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c\nindex 397a32db58..28aeb7d08e 100644\n--- a/drivers/net/af_packet/rte_eth_af_packet.c\n+++ b/drivers/net/af_packet/rte_eth_af_packet.c\n@@ -6,6 +6,7 @@\n * All rights reserved.\n */\n \n+#include <rte_common.h>\n #include <rte_string_fns.h>\n #include <rte_mbuf.h>\n #include <ethdev_driver.h>\n@@ -53,7 +54,7 @@ struct pkt_rx_queue {\n \n \tvolatile unsigned long rx_pkts;\n \tvolatile unsigned long rx_bytes;\n-};\n+} __rte_cache_aligned;\n \n struct pkt_tx_queue {\n \tint sockfd;\n@@ -67,7 +68,7 @@ struct pkt_tx_queue {\n \tvolatile unsigned long tx_pkts;\n \tvolatile unsigned long err_pkts;\n \tvolatile unsigned long tx_bytes;\n-};\n+} __rte_cache_aligned;\n \n struct pmd_internals {\n \tunsigned nb_queues;\n", "prefixes": [] }