Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139658/?format=api
{ "id": 139658, "url": "https://patches.dpdk.org/api/patches/139658/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/f906c4563ebce7d39fa2611a93fc652715272d8d.1713964708.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<f906c4563ebce7d39fa2611a93fc652715272d8d.1713964708.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/f906c4563ebce7d39fa2611a93fc652715272d8d.1713964708.git.anatoly.burakov@intel.com", "date": "2024-04-24T13:21:47", "name": "[v1,13/22] net/ixgbe/base: handle -Wimplicit-fallthrough", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "00aec8549964422083f44a5faebc7ce8fe602b96", "submitter": { "id": 4, "url": "https://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 10, "url": "https://patches.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/f906c4563ebce7d39fa2611a93fc652715272d8d.1713964708.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 31814, "url": "https://patches.dpdk.org/api/series/31814/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31814", "date": "2024-04-24T13:21:34", "name": "Update IXGBE base driver", "version": 1, "mbox": "https://patches.dpdk.org/series/31814/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139658/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/139658/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 974F843EAD;\n\tWed, 24 Apr 2024 15:23:51 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B44D4434D0;\n\tWed, 24 Apr 2024 15:22:48 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.9])\n by mails.dpdk.org (Postfix) with ESMTP id A6ACC434C4\n for <dev@dpdk.org>; Wed, 24 Apr 2024 15:22:46 +0200 (CEST)", "from fmviesa006.fm.intel.com ([10.60.135.146])\n by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Apr 2024 06:22:46 -0700", "from silpixa00401119.ir.intel.com ([10.55.129.167])\n by fmviesa006.fm.intel.com with ESMTP; 24 Apr 2024 06:22:44 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1713964967; x=1745500967;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=dePQDzWCecIc5qVMytR5k7/yBC+DFM9dedoM3jAXfY8=;\n b=B7M1Xw082P/q58QDA8WGIe9rGkchR4274U4oHq98ZFd+Rccu3b5BaJKp\n hksVRggu4Km/kKu8ByOWNnTYR5aPaBWoRFutEPPC0e7Hkaf0DGctxut5O\n OQF0E3tlVmZbikJsWskDfkReWRo9LwFxDZQfMWFzsS8gn7hzeBjqnc9I/\n wQmdo2/cGehpGQTjPri8wZ6wwBAyvCizFHYP4LRLFJEDLSRBCndzkRaCM\n UxLGbMYDWthCO9FtYHQu/pkh7/1H95E5qqmlrczxV+XbF6dgpy8ruvGFd\n 44tn6CDdahEZ+mWznruNhieI+BS/hvLSSbRGLpoFg0+7DK64MlbU6RfFl A==;", "X-CSE-ConnectionGUID": [ "jN/F7exxTteqGiyDHpHf8Q==", "wu0XAbs8QTyPYzY82FnnZg==" ], "X-CSE-MsgGUID": [ "iV27lvEyTFitppM/TRqerQ==", "SdMjq9r1QgmyAPkIibM5XA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11054\"; a=\"20289271\"", "E=Sophos;i=\"6.07,226,1708416000\"; d=\"scan'208\";a=\"20289271\"", "E=Sophos;i=\"6.07,226,1708416000\"; d=\"scan'208\";a=\"24749457\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Piotr Skajewski <piotrx.skajewski@intel.com>,\n\tvladimir.medvedkin@intel.com, bruce.richardson@intel.com,\n\tMichael@dpdk.org, Alice <alice.michael@intel.com>", "Subject": "[PATCH v1 13/22] net/ixgbe/base: handle -Wimplicit-fallthrough", "Date": "Wed, 24 Apr 2024 14:21:47 +0100", "Message-ID": "\n <f906c4563ebce7d39fa2611a93fc652715272d8d.1713964708.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<cover.1713964707.git.anatoly.burakov@intel.com>", "References": "<cover.1713964707.git.anatoly.burakov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Piotr Skajewski <piotrx.skajewski@intel.com>\n\nAs there have been a long list of flaws due to missing \"break\" statement\nkernel no longer allow implict fall-through and reports warning during\ncompilation. Convert all \"fall-through\" comments to actual code.\n\nSigned-off-by: Piotr Skajewski <piotrx.skajewski@intel.com>\nReviewed-by: Michael, Alice <alice.michael@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_82599.c | 7 +++++--\n drivers/net/ixgbe/base/ixgbe_common.c | 8 ++++++--\n drivers/net/ixgbe/base/ixgbe_x550.c | 11 +++++++----\n 3 files changed, 18 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_82599.c b/drivers/net/ixgbe/base/ixgbe_82599.c\nindex 73c7766ecf..562034b242 100644\n--- a/drivers/net/ixgbe/base/ixgbe_82599.c\n+++ b/drivers/net/ixgbe/base/ixgbe_82599.c\n@@ -1719,7 +1719,8 @@ s32 ixgbe_fdir_set_input_mask_82599(struct ixgbe_hw *hw,\n \tcase 0x0000:\n \t\t/* mask VLAN ID */\n \t\tfdirm |= IXGBE_FDIRM_VLANID;\n-\t\t/* fall through */\n+\t\tfdirm |= IXGBE_FDIRM_VLANP;\n+\t\tbreak;\n \tcase 0x0FFF:\n \t\t/* mask VLAN priority */\n \t\tfdirm |= IXGBE_FDIRM_VLANP;\n@@ -2009,7 +2010,9 @@ s32 ixgbe_fdir_add_perfect_filter_82599(struct ixgbe_hw *hw,\n \t\t\tDEBUGOUT(\" Error on src/dst port\\n\");\n \t\t\treturn IXGBE_ERR_CONFIG;\n \t\t}\n-\t\t/* fall through */\n+\t\tinput_mask->formatted.flow_type = IXGBE_ATR_L4TYPE_IPV6_MASK |\n+\t\t\t\t\t\t IXGBE_ATR_L4TYPE_MASK;\n+\t\tbreak;\n \tcase IXGBE_ATR_FLOW_TYPE_TCPV4:\n \tcase IXGBE_ATR_FLOW_TYPE_TUNNELED_TCPV4:\n \tcase IXGBE_ATR_FLOW_TYPE_UDPV4:\ndiff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c\nindex dd8310748b..27f633bc2f 100644\n--- a/drivers/net/ixgbe/base/ixgbe_common.c\n+++ b/drivers/net/ixgbe/base/ixgbe_common.c\n@@ -231,7 +231,8 @@ s32 ixgbe_setup_fc_generic(struct ixgbe_hw *hw)\n \t\tif (ret_val != IXGBE_SUCCESS)\n \t\t\tgoto out;\n \n-\t\t/* fall through - only backplane uses autoc */\n+\t\treg = IXGBE_READ_REG(hw, IXGBE_PCS1GANA);\n+\t\tbreak;\n \tcase ixgbe_media_type_fiber_qsfp:\n \tcase ixgbe_media_type_fiber:\n \t\treg = IXGBE_READ_REG(hw, IXGBE_PCS1GANA);\n@@ -4725,7 +4726,10 @@ void ixgbe_set_rxpba_generic(struct ixgbe_hw *hw, int num_pb, u32 headroom,\n \t\trxpktsize <<= IXGBE_RXPBSIZE_SHIFT;\n \t\tfor (; i < (num_pb / 2); i++)\n \t\t\tIXGBE_WRITE_REG(hw, IXGBE_RXPBSIZE(i), rxpktsize);\n-\t\t/* fall through - configure remaining packet buffers */\n+\t\trxpktsize = (pbsize / (num_pb - i)) << IXGBE_RXPBSIZE_SHIFT;\n+\t\tfor (; i < num_pb; i++)\n+\t\t\tIXGBE_WRITE_REG(hw, IXGBE_RXPBSIZE(i), rxpktsize);\n+\t\tbreak;\n \tcase PBA_STRATEGY_EQUAL:\n \t\trxpktsize = (pbsize / (num_pb - i)) << IXGBE_RXPBSIZE_SHIFT;\n \t\tfor (; i < num_pb; i++)\ndiff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c\nindex ebfc78235e..29055a818a 100644\n--- a/drivers/net/ixgbe/base/ixgbe_x550.c\n+++ b/drivers/net/ixgbe/base/ixgbe_x550.c\n@@ -326,8 +326,7 @@ STATIC s32 ixgbe_identify_phy_x550em(struct ixgbe_hw *hw)\n \t\t/* set up for CS4227 usage */\n \t\tixgbe_setup_mux_ctl(hw);\n \t\tixgbe_check_cs4227(hw);\n-\t\t/* Fallthrough */\n-\n+\t\treturn ixgbe_identify_sfp_module_X550em(hw);\n \tcase IXGBE_DEV_ID_X550EM_A_SFP_N:\n \t\treturn ixgbe_identify_sfp_module_X550em(hw);\n \t\tbreak;\n@@ -1838,7 +1837,9 @@ s32 ixgbe_get_link_capabilities_X550em(struct ixgbe_hw *hw,\n \t\t\t\t\tbreak;\n \t\t\t\t}\n \t\t\t}\n-\t\t\t/* fall through */\n+\t\t\t*speed = IXGBE_LINK_SPEED_10GB_FULL |\n+\t\t\t\t IXGBE_LINK_SPEED_1GB_FULL;\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\t*speed = IXGBE_LINK_SPEED_10GB_FULL |\n \t\t\t\t IXGBE_LINK_SPEED_1GB_FULL;\n@@ -3558,7 +3559,9 @@ u64 ixgbe_get_supported_physical_layer_X550em(struct ixgbe_hw *hw)\n \t\t\t\tbreak;\n \t\t\t}\n \t\t}\n-\t\t/* fall through */\n+\t\tphysical_layer = IXGBE_PHYSICAL_LAYER_10GBASE_KR |\n+\t\t\t\t IXGBE_PHYSICAL_LAYER_1000BASE_KX;\n+\t\tbreak;\n \tcase ixgbe_phy_x550em_xfi:\n \t\tphysical_layer = IXGBE_PHYSICAL_LAYER_10GBASE_KR |\n \t\t\t\t IXGBE_PHYSICAL_LAYER_1000BASE_KX;\n", "prefixes": [ "v1", "13/22" ] }