Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139615/?format=api
{ "id": 139615, "url": "https://patches.dpdk.org/api/patches/139615/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240422152336.147553-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240422152336.147553-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240422152336.147553-5-stephen@networkplumber.org", "date": "2024-04-22T15:21:34", "name": "[v5,4/9] latencystats: fix log messages", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "72756729c0f617335288f4a1c4da2bd053f49f05", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240422152336.147553-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 31803, "url": "https://patches.dpdk.org/api/series/31803/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31803", "date": "2024-04-22T15:21:30", "name": "latencystats: improve algorithms and tests", "version": 5, "mbox": "https://patches.dpdk.org/series/31803/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139615/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139615/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0B2BB43EDB;\n\tMon, 22 Apr 2024 17:24:12 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B167540A81;\n\tMon, 22 Apr 2024 17:23:55 +0200 (CEST)", "from mail-pf1-f174.google.com (mail-pf1-f174.google.com\n [209.85.210.174])\n by mails.dpdk.org (Postfix) with ESMTP id 7690C406B7\n for <dev@dpdk.org>; Mon, 22 Apr 2024 17:23:50 +0200 (CEST)", "by mail-pf1-f174.google.com with SMTP id\n d2e1a72fcca58-6ed01c63657so3957517b3a.2\n for <dev@dpdk.org>; Mon, 22 Apr 2024 08:23:50 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n cb17-20020a056a02071100b0060063c4be3bsm1402783pgb.14.2024.04.22.08.23.49\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 22 Apr 2024 08:23:49 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1713799429;\n x=1714404229; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=i3+egRrx4JI9E2plWMu17CiEVJ7H/AoXfNFkJLwKwko=;\n b=TP7bnMRYSz40M7kq+oseGHymVGMlj5EdkbpXL3iprMpj3RkBIfRJnj+Wl/67ZoHD4x\n lexv3H+w28G7TLyeMq0pWS6dV8FXYM3YsX3e5/IB8aDkeOWdD7rWaWQfkppAdqWCEK+w\n uwLysugcC+JZoVIHAX+jY0Q2/wSxsNDrmkF8Dibo479vrmHU9sZrtK/OYyDAcRxm4TXT\n 7oa1NlOuJYvUFIsx2gGTTS05lHmMikpIRCwgvNkDHHr8GoOQFQOl+3ysk47aqu2D8Kdn\n rH6ypanAQXERKIHVOoX+xu3eR2kKUIotXWRshkqVt/W7NsCt1UYPQl0WC2LkQtZA5AaE\n NDTw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1713799429; x=1714404229;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=i3+egRrx4JI9E2plWMu17CiEVJ7H/AoXfNFkJLwKwko=;\n b=nTvpcwUkJyPMgprkCu4Ffq7hnpA/dy55aLHxbJeUDQ4dvVNcMSp1qZd2bUBINH1oK7\n l6x+MoEZyuIly38RubZemOOCbJy4BkQlZcqEOsL75ZSg7EnWUPXKISOzgN3LVoFHEBZi\n V8UTPPK1pxi5RRTDjItqM/yD6rpeZOkE4PmtRdBS5seRRYS5luAfUqSNmFvmQ9jNnYW4\n /6x0SjjvgWyfX8CcPaNExn389n2xuqyXaO2RX7xc3fbDtwoEwDc3IkflQOGLB0hGeFzt\n fSg84yBmnjCTheSMWsMqmHKwF/DcTKqN0ausQiSrVGpLYfivihe7MPadu7jNzGal6rwW\n MJvA==", "X-Gm-Message-State": "AOJu0Yye4IdcOH3ZkF9q6l4tpFf0z9BM9gNLEwgUKamud3+6uhISKjW1\n m5pPPc1BtNrWmwwn5CaOwv5Vn2slcDQnnmg90gPPMQNuVIKNKLttDzsEB9fVhN0qp/scDSowJVn\n e", "X-Google-Smtp-Source": "\n AGHT+IHHow9ot34WXg8/KPsgx1WBiJluvPuRXlUK5SuHpOa8GX9Fu7iBb6aXzq6KVRUQyD8mym1qOA==", "X-Received": "by 2002:a05:6a20:6a1f:b0:1a9:b2a6:1d23 with SMTP id\n p31-20020a056a206a1f00b001a9b2a61d23mr11233977pzk.20.1713799429649;\n Mon, 22 Apr 2024 08:23:49 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Reshma Pattan <reshma.pattan@intel.com>", "Subject": "[PATCH v5 4/9] latencystats: fix log messages", "Date": "Mon, 22 Apr 2024 08:21:34 -0700", "Message-ID": "<20240422152336.147553-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240422152336.147553-1-stephen@networkplumber.org>", "References": "<20240408195036.182545-1-stephen@networkplumber.org>\n <20240422152336.147553-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "All messages that because of an error should be at log level\nNOTICE or above. Do not break log messages across lines.\nReword message for the case where getting info about a port\nfails and it is skipped.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/latencystats/rte_latencystats.c | 35 ++++++++++++++---------------\n 1 file changed, 17 insertions(+), 18 deletions(-)", "diff": "diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c\nindex 2140ab87c4..c0ac60134f 100644\n--- a/lib/latencystats/rte_latencystats.c\n+++ b/lib/latencystats/rte_latencystats.c\n@@ -259,7 +259,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \tlatency_stats_index = rte_metrics_reg_names(ptr_strings,\n \t\t\t\t\t\t\tNUM_LATENCY_STATS);\n \tif (latency_stats_index < 0) {\n-\t\tLATENCY_STATS_LOG(DEBUG,\n+\t\tLATENCY_STATS_LOG(ERR,\n \t\t\t\"Failed to register latency stats names\");\n \t\treturn -1;\n \t}\n@@ -279,8 +279,8 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \n \t\tret = rte_eth_dev_info_get(pid, &dev_info);\n \t\tif (ret != 0) {\n-\t\t\tLATENCY_STATS_LOG(INFO,\n-\t\t\t\t\"Error during getting device (port %u) info: %s\",\n+\t\t\tLATENCY_STATS_LOG(NOTICE,\n+\t\t\t\t\"Can not get info for device (port %u): %s\",\n \t\t\t\tpid, strerror(-ret));\n \n \t\t\tcontinue;\n@@ -291,18 +291,18 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \t\t\tcbs->cb = rte_eth_add_first_rx_callback(pid, qid,\n \t\t\t\t\tadd_time_stamps, user_cb);\n \t\t\tif (!cbs->cb)\n-\t\t\t\tLATENCY_STATS_LOG(INFO, \"Failed to \"\n-\t\t\t\t\t\"register Rx callback for pid=%d, \"\n-\t\t\t\t\t\"qid=%d\", pid, qid);\n+\t\t\t\tLATENCY_STATS_LOG(NOTICE,\n+\t\t\t\t\t\"Failed to register Rx callback for pid=%u, qid=%u\",\n+\t\t\t\t\tpid, qid);\n \t\t}\n \t\tfor (qid = 0; qid < dev_info.nb_tx_queues; qid++) {\n \t\t\tcbs = &tx_cbs[pid][qid];\n \t\t\tcbs->cb = rte_eth_add_tx_callback(pid, qid,\n \t\t\t\t\tcalc_latency, user_cb);\n \t\t\tif (!cbs->cb)\n-\t\t\t\tLATENCY_STATS_LOG(INFO, \"Failed to \"\n-\t\t\t\t\t\"register Tx callback for pid=%d, \"\n-\t\t\t\t\t\"qid=%d\", pid, qid);\n+\t\t\t\tLATENCY_STATS_LOG(NOTICE,\n+\t\t\t\t\t\"Failed to register Tx callback for pid=%u, qid=%u\",\n+\t\t\t\t\tpid, qid);\n \t\t}\n \t}\n \treturn 0;\n@@ -323,10 +323,9 @@ rte_latencystats_uninit(void)\n \n \t\tret = rte_eth_dev_info_get(pid, &dev_info);\n \t\tif (ret != 0) {\n-\t\t\tLATENCY_STATS_LOG(INFO,\n-\t\t\t\t\"Error during getting device (port %u) info: %s\",\n+\t\t\tLATENCY_STATS_LOG(NOTICE,\n+\t\t\t\t\"Can not get info for device (port %u): %s\",\n \t\t\t\tpid, strerror(-ret));\n-\n \t\t\tcontinue;\n \t\t}\n \n@@ -334,17 +333,17 @@ rte_latencystats_uninit(void)\n \t\t\tcbs = &rx_cbs[pid][qid];\n \t\t\tret = rte_eth_remove_rx_callback(pid, qid, cbs->cb);\n \t\t\tif (ret)\n-\t\t\t\tLATENCY_STATS_LOG(INFO, \"failed to \"\n-\t\t\t\t\t\"remove Rx callback for pid=%d, \"\n-\t\t\t\t\t\"qid=%d\", pid, qid);\n+\t\t\t\tLATENCY_STATS_LOG(NOTICE,\n+\t\t\t\t\t\"Failed to remove Rx callback for pid=%u, qid=%u\",\n+\t\t\t\t\tpid, qid);\n \t\t}\n \t\tfor (qid = 0; qid < dev_info.nb_tx_queues; qid++) {\n \t\t\tcbs = &tx_cbs[pid][qid];\n \t\t\tret = rte_eth_remove_tx_callback(pid, qid, cbs->cb);\n \t\t\tif (ret)\n-\t\t\t\tLATENCY_STATS_LOG(INFO, \"failed to \"\n-\t\t\t\t\t\"remove Tx callback for pid=%d, \"\n-\t\t\t\t\t\"qid=%d\", pid, qid);\n+\t\t\t\tLATENCY_STATS_LOG(NOTICE,\n+\t\t\t\t\t\"Failed to remove Tx callback for pid=%u, qid=%u\",\n+\t\t\t\t\tpid, qid);\n \t\t}\n \t}\n \n", "prefixes": [ "v5", "4/9" ] }