Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139608/?format=api
{ "id": 139608, "url": "https://patches.dpdk.org/api/patches/139608/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240422134917.3740545-1-ferruh.yigit@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240422134917.3740545-1-ferruh.yigit@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240422134917.3740545-1-ferruh.yigit@amd.com", "date": "2024-04-22T13:49:17", "name": "eal/linux: enhanced error handling for affinity", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "eff6e30ce785205aacd01d98586901855cec5291", "submitter": { "id": 2700, "url": "https://patches.dpdk.org/api/people/2700/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@amd.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240422134917.3740545-1-ferruh.yigit@amd.com/mbox/", "series": [ { "id": 31801, "url": "https://patches.dpdk.org/api/series/31801/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31801", "date": "2024-04-22T13:49:17", "name": "eal/linux: enhanced error handling for affinity", "version": 1, "mbox": "https://patches.dpdk.org/series/31801/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139608/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/139608/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 54EAE43EDA;\n\tMon, 22 Apr 2024 15:49:33 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C02C640265;\n\tMon, 22 Apr 2024 15:49:32 +0200 (CEST)", "from NAM02-DM3-obe.outbound.protection.outlook.com\n (mail-dm3nam02on2073.outbound.protection.outlook.com [40.107.95.73])\n by mails.dpdk.org (Postfix) with ESMTP id 011CB4021F\n for <dev@dpdk.org>; Mon, 22 Apr 2024 15:49:31 +0200 (CEST)", "from CH0PR03CA0446.namprd03.prod.outlook.com (2603:10b6:610:10e::35)\n by DM4PR12MB5913.namprd12.prod.outlook.com (2603:10b6:8:66::22) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Mon, 22 Apr\n 2024 13:49:26 +0000", "from CH1PEPF0000AD81.namprd04.prod.outlook.com\n (2603:10b6:610:10e:cafe::17) by CH0PR03CA0446.outlook.office365.com\n (2603:10b6:610:10e::35) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.33 via Frontend\n Transport; Mon, 22 Apr 2024 13:49:26 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n CH1PEPF0000AD81.mail.protection.outlook.com (10.167.244.89) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7452.22 via Frontend Transport; Mon, 22 Apr 2024 13:49:26 +0000", "from telcodpdk.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 22 Apr\n 2024 08:49:25 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=c2gkO09hcl1FS1sGmHglVWmx9+NtFmQq0HlPENhBr0SYzfyKsS2NVaNjM6wwz+vAc7Zew6/9MpuvPxE33N0eZJnGDxAvHWyGDkir8t5uzyI9k6Qcp1ZuT1GFJbuq/RWgk/67s5nu4xinZRrfrQlkHXOC3uM4nR7fBFDzWeSL/2yWWhHMcJ8EsM8EZM5MZfgRojIEGZXJMZ2F+cuCvUNT+EuxGmVoaTSyn1dvU44+3XNXqZUmSKkjMbH50yaPKaFig4qV5cjXpCAlHxmVs1P6AM4GUhy42eKyLQk7UyBZh1nxECzmCgJKqX3cZi9rRcLGJrW0dIGha8OL8+/iFH1yjQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=v+82ixKL0vi2YW9vy+bUHJulfWCY+MV4D7ZjXNr44yc=;\n b=PbZHLoLKDhuNfVtU0fp3icTb8W3IJaWAsdbZ3zD9uxVb+6h/fh1lEt/K74cnw9hAiBCbp9vEIRn7oKlJA+VOLpPi5kCzYov0Hbhh55cj4Qvp7dZj/h2POVl5qSXP81z8v3DoYFrqpQZpOFDzBxHZKJXr4tXjFnkKM2AbFTiCyhy4uYCk965rb+YMSLj9p2G+CvjraL3v03uPG9a0Jk2wNZPhkannVbywlU+dCsIFoy9q96vt5GcdXtV/xNWbSpDrw3ZzX16cypDlLptQevw1hNiVkjZXADCTHa//REWhbDb3zYwVpfrVmekjodTROfSVv5fZHV6DMcs4ezqq291AFQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=monjalon.net smtp.mailfrom=amd.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=amd.com; dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=v+82ixKL0vi2YW9vy+bUHJulfWCY+MV4D7ZjXNr44yc=;\n b=w/K/VMZH9Qf760yrpxwXT+h7UDeUA2Zq2GIWgWt/2aDNHfr9Zmvjd4mdkS2BS80WaTd0JT9CS1wElN9z/jttF264HQOF4+xCL96g29SwJ2/E58IQekwCZBy5FuC/ekTDQ63XVvBPw3fDFNEtw9k2S/MvB9L164dx1fdzhZvXujc=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Ferruh Yigit <ferruh.yigit@amd.com>", "To": "Thomas Monjalon <thomas@monjalon.net>", "CC": "<dev@dpdk.org>, David Marchand <david.marchand@redhat.com>,\n <roretzla@linux.microsoft.com>, Jianyue Wu <jianyue.wu@nokia-sbell.com>", "Subject": "[PATCH] eal/linux: enhanced error handling for affinity", "Date": "Mon, 22 Apr 2024 14:49:17 +0100", "Message-ID": "<20240422134917.3740545-1-ferruh.yigit@amd.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<fa21c475248e4a42850697eb76b0de50@nokia-sbell.com>", "References": "<fa21c475248e4a42850697eb76b0de50@nokia-sbell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CH1PEPF0000AD81:EE_|DM4PR12MB5913:EE_", "X-MS-Office365-Filtering-Correlation-Id": "679911e3-423b-4475-ad03-08dc62d3066f", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n aen6xFlJ8u9aywo8DvrReNcRHu3lmHSIC4+10SABSkWW3z8wIpBpx/Ndjc5YAWY+gEggdlDDSY8E6Y3aF40ibWkqcuqsfgmjfjJiSlALhoAE4181o9Ef15sB3VkQlT0qQy+BjZTf8TDDD1/FyT6YRzukYzU865lPg7koa/grFY+NpELyjieQdSO1xgxny2y97P2arQxl5Fgvx5XlX1y1Qf23nnVwdYREanfsuGcGdm1v/iSc82QxXi922aeTz+RevwqFCZW5QXaMuV60/XtisPTK7vWvnEbt/qUwvdiN7ftKxIvF/LtxZoVmztBxNSWVAf+LFPaHdnSmSt5eoKC4kV43KNmJqsKoQf61laMmB9aTC6sOYEBE+Kn8DO5C8cBkH8BPtiilLbfqv7jdO0q+yNY7iRYMCMnOVtKJWYffz/AQI5k0XRLML2+6kofGpgeqAJ2uTICk+HXxK5sT1AtKpOCFSck66VXFTWrngD2gtnUZ3YMYsKkF20xb9AX5Lt1EsohrXXMJ/mM3gQdyqhs+fsG3MHUFP7wiGEIRPMXYIcJHzYd/o3dbiz5MxlERRskYclxUfFKz6AkKqFvFbjm+SV5cLNamFU+J7+cqfKQJMFhvK5IKVtpf+kGxn4MSk3zmXk9fKOtCeV0B8BXLR1fIpenR9ts8x+R8uw2DEunDi3Klt/L04n9q6KVciJAGTm3SLPwZ+HPWXNyd4emMOyEHcXzn2TxLOgYwQXMwz7MOvNQcQzNo6ZeNXUuORnAuWkYU6UW+0wQIwHaWeUyPzpRbiXD+upJN0o3XGTh38LWlPTAyyEg6lLIkevekL6YzBDzvaPkQnzpmfJaJ49OMJ8T8RYDEk+Gq7FVyJU478KWJvY8Jc9Z3sTz6yOHBQEsOeHuUw/uxB20BqPR32AUw5YglnXWVYmwgopbl5joa9oxYGlMv4rHZbUaY7gDvcorREfUnagA5Tz83J83iO6AABfY4j45eZtBsleqQjlzVHqW8TR454M3Ao6yFpmntlh8S9+bz2TFLlpF2Z/1rMEArfj5jsLidZMDbqW/uK+ih/57ucVYLuNCdFINJzvoDtM7gkDlvliHMt5CaFVvhD6eW9dGH2stQp5GIaa8pcaG9Cfkwn+xMnJ4TbK72yzULfgWaKrPO2AsTjJGhDGPDLea4OaV8UGVCj8rfedm0psRwKhggCjqjTqaEuRHyfuqIT9pYlkeIsEwC3nddiWJt4iZCZX6E/e+rODrQ2FpBfBhhDUXj+krkPHVqfkjCaCO1EnsMF2qJILYPVKxDOeV77NeNKjO8cIIwYD/7S/saZdGn1Ufu5gKrL6tfmByV0/At7lLKuo1HmH7jhRpl6fR7X8p418cPRs0lObU7E0+WTw664Jhuajs=", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(36860700004)(82310400014)(1800799015)(376005); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "22 Apr 2024 13:49:26.4746 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 679911e3-423b-4475-ad03-08dc62d3066f", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CH1PEPF0000AD81.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM4PR12MB5913", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Jianyue Wu <jianyue.wu@nokia-sbell.com>\n\nImprove the robustness of setting thread affinity in DPDK\nby adding detailed error logging.\n\nChanges:\n1. Set `errno` to 0 before calling `pthread_setaffinity_np()` to ensure\nclean error status.\n2. Check the return value of `pthread_setaffinity_np()` and log an error\nif the call fails.\n3. Include the current thread name, the intended CPU set, and a detailed\nerror message in the log.\n\nSample prints:\nEAL: Cannot set affinity for thread dpdk-test with cpus 0,\nret: 22, errno: 0, error description: Success\nEAL: Cannot set affinity for thread dpdk-worker1 with cpus 1,\nret: 22, errno: 0, error description: Success\n\nSigned-off-by: Jianyue Wu <jianyue.wu@nokia-sbell.com>\n---\n .mailmap | 1 +\n lib/eal/unix/rte_thread.c | 51 +++++++++++++++++++++++++++++++++++++--\n 2 files changed, 50 insertions(+), 2 deletions(-)", "diff": "diff --git a/.mailmap b/.mailmap\nindex 3843868716bd..66cff91f30a9 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -639,6 +639,7 @@ Jianfeng Tan <jianfeng.tan@intel.com>\n Jiangu Zhao <zhaojg@arraynetworks.com.cn>\n Jianwei Ma <jianwei.ma@intel.com>\n Jianwei Mei <jianweix.mei@intel.com>\n+Jianyue Wu <jianyue.wu@nokia-sbell.com>\n Jiaqi Min <jiaqix.min@intel.com>\n Jiawei Wang <jiaweiw@nvidia.com> <jiaweiw@mellanox.com>\n Jiawei Zhu <zhujiawei12@huawei.com>\ndiff --git a/lib/eal/unix/rte_thread.c b/lib/eal/unix/rte_thread.c\nindex 1b4c73f58e91..56bc7995eb5f 100644\n--- a/lib/eal/unix/rte_thread.c\n+++ b/lib/eal/unix/rte_thread.c\n@@ -5,6 +5,7 @@\n \n #include <errno.h>\n #include <pthread.h>\n+#include <sched.h>\n #include <stdbool.h>\n #include <stdlib.h>\n #include <string.h>\n@@ -114,6 +115,35 @@ thread_start_wrapper(void *arg)\n \treturn (void *)(uintptr_t)thread_func(thread_args);\n }\n \n+/* Function to convert cpu_set_t to a string. */\n+static void cpuset_to_string(const cpu_set_t *cpuset,\n+\t\t\tchar *cpus_str, size_t cpus_str_size) {\n+\tint cpu;\n+\t// Track the current position in the string\n+\tsize_t offset = 0;\n+\n+\t// Clear the string buffer\n+\tmemset(cpus_str, 0, cpus_str_size);\n+\tcpus_str_size = RTE_MAX_LCORE < cpus_str_size ?\n+\t\tRTE_MAX_LCORE : cpus_str_size;\n+\n+\t// Iterate over each CPU core, and check if it is included in the set\n+\tfor (cpu = 0; cpu < RTE_MAX_LCORE && offset < cpus_str_size - 1; ++cpu) {\n+\t\tif (CPU_ISSET(cpu, cpuset)) {\n+\t\t\t// Append the current CPU number to the string\n+\t\t\tint written = snprintf(cpus_str + offset, cpus_str_size - offset,\n+\t\t\t\t\"%s%d\", (offset > 0 ? \",\" : \"\"), cpu);\n+\t\t\tif (written > 0)\n+\t\t\t\toffset += written;\n+\t\t\tif (offset >= cpus_str_size - 1)\n+\t\t\t\tbreak;\n+\t\t\t}\n+\t}\n+\n+\t// Ensure the string is properly terminated\n+\tcpus_str[cpus_str_size - 1] = '\\0';\n+}\n+\n int\n rte_thread_create(rte_thread_t *thread_id,\n \t\tconst rte_thread_attr_t *thread_attr,\n@@ -369,8 +399,25 @@ int\n rte_thread_set_affinity_by_id(rte_thread_t thread_id,\n \t\tconst rte_cpuset_t *cpuset)\n {\n-\treturn pthread_setaffinity_np((pthread_t)thread_id.opaque_id,\n-\t\tsizeof(*cpuset), cpuset);\n+\tint ret;\n+\tchar cpus_str[RTE_MAX_LCORE + 1] = {'\\0'};\n+\tchar thread_name[RTE_MAX_THREAD_NAME_LEN] = {'\\0'};\n+\n+\terrno = 0;\n+\tret = pthread_setaffinity_np((pthread_t)thread_id.opaque_id,\n+\t\t\t\tsizeof(*cpuset), cpuset);\n+\tif (ret != 0) {\n+\t\tif (pthread_getname_np((pthread_t)thread_id.opaque_id,\n+\t\t\t\t\tthread_name, sizeof(thread_name)) != 0)\n+\t\t\tEAL_LOG(ERR, \"pthread_getname_np failed!\");\n+\t\tcpuset_to_string(cpuset, cpus_str, sizeof(cpus_str));\n+\t\tEAL_LOG(ERR, \"Cannot set affinity for thread %s with cpus %s, \"\n+\t\t\t\"ret: %d, errno: %d, error description: %s\",\n+\t\t\tthread_name, cpus_str,\n+\t\t\tret, errno, strerror(errno));\n+\t}\n+\n+\treturn ret;\n }\n \n int\n", "prefixes": [] }