Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1396/?format=api
https://patches.dpdk.org/api/patches/1396/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1416524335-22753-2-git-send-email-olivier.matz@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1416524335-22753-2-git-send-email-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1416524335-22753-2-git-send-email-olivier.matz@6wind.com", "date": "2014-11-20T22:58:43", "name": "[dpdk-dev,v3,01/13] igb/ixgbe: fix IP checksum calculation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c1972b7bdbeb073df70ddc39eb5ad46e358d8c55", "submitter": { "id": 8, "url": "https://patches.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1416524335-22753-2-git-send-email-olivier.matz@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1396/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1396/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 03DD27F65;\n\tThu, 20 Nov 2014 23:48:46 +0100 (CET)", "from mail-wg0-f43.google.com (mail-wg0-f43.google.com\n\t[74.125.82.43]) by dpdk.org (Postfix) with ESMTP id F22347F0C\n\tfor <dev@dpdk.org>; Thu, 20 Nov 2014 23:48:31 +0100 (CET)", "by mail-wg0-f43.google.com with SMTP id l18so5087936wgh.16\n\tfor <dev@dpdk.org>; Thu, 20 Nov 2014 14:59:03 -0800 (PST)", "from glumotte.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tcz3sm5380581wjb.23.2014.11.20.14.59.02 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 20 Nov 2014 14:59:03 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-type:content-transfer-encoding;\n\tbh=Bh8v7KE+mwfoawNaynDX4M8MWOqUMV8kvh52HjLeteM=;\n\tb=KzmbVbpZ54xwLyOumQRu7L8L+oL6O7twPKjumdwg9p5vQLzjwnKHIir50aToo3Iumv\n\t3+08Z5frD5ZU9zXDnudNS52yxM6tTCLTWjI5N532ishzoJjA9t1IvZJ0CU1L+kUu6AjU\n\tsWK6i0igkOJbM+YNNhjIVGrq/Djag5zoNJ8hGTmCQ+v4k8ei7Ql9x5hWFbk5m3v+hYWi\n\t9/nqGv+EQf0Qlq0Lb7Kxi66XQX5ory9+lMy2GqryY4Q0myZ3TEUnTufaxkOaOZSZTNR2\n\tmp2lGJtnPP9LfOHhUpQTTub52crtsHkLdBOM8PzGB8ijJYO6xTJfrlkzZsKq339Uc42N\n\th7Ww==", "X-Gm-Message-State": "ALoCoQnYXwHXdS/XlHCpsVuUUNDe4xIOABPu+IvgqMnMjq+HUO/qfAD6CSfKTWKnztmbYITH8nHf", "X-Received": "by 10.194.120.164 with SMTP id ld4mr1244066wjb.67.1416524343843; \n\tThu, 20 Nov 2014 14:59:03 -0800 (PST)", "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Date": "Thu, 20 Nov 2014 23:58:43 +0100", "Message-Id": "<1416524335-22753-2-git-send-email-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1416524335-22753-1-git-send-email-olivier.matz@6wind.com>", "References": "<1415984609-2484-1-git-send-email-olivier.matz@6wind.com>\n\t<1416524335-22753-1-git-send-email-olivier.matz@6wind.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Cc": "jigsaw@gmail.com", "Subject": "[dpdk-dev] [PATCH v3 01/13] igb/ixgbe: fix IP checksum calculation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "According to Intel® 82599 10 GbE Controller Datasheet (Table 7-38), both\nL2 and L3 lengths are needed to offload the IP checksum.\n\nNote that the e1000 driver does not need to be patched as it already\ncontains the fix.\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\nAcked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n lib/librte_pmd_e1000/igb_rxtx.c | 2 +-\n lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_pmd_e1000/igb_rxtx.c b/lib/librte_pmd_e1000/igb_rxtx.c\nindex 0dca7b7..b406397 100644\n--- a/lib/librte_pmd_e1000/igb_rxtx.c\n+++ b/lib/librte_pmd_e1000/igb_rxtx.c\n@@ -262,7 +262,7 @@ igbe_set_xmit_ctx(struct igb_tx_queue* txq,\n \n \tif (ol_flags & PKT_TX_IP_CKSUM) {\n \t\ttype_tucmd_mlhl = E1000_ADVTXD_TUCMD_IPV4;\n-\t\tcmp_mask |= TX_MAC_LEN_CMP_MASK;\n+\t\tcmp_mask |= TX_MACIP_LEN_CMP_MASK;\n \t}\n \n \t/* Specify which HW CTX to upload. */\ndiff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\nindex f9b3fe3..ecebbf6 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n@@ -374,7 +374,7 @@ ixgbe_set_xmit_ctx(struct igb_tx_queue* txq,\n \n \tif (ol_flags & PKT_TX_IP_CKSUM) {\n \t\ttype_tucmd_mlhl = IXGBE_ADVTXD_TUCMD_IPV4;\n-\t\tcmp_mask |= TX_MAC_LEN_CMP_MASK;\n+\t\tcmp_mask |= TX_MACIP_LEN_CMP_MASK;\n \t}\n \n \t/* Specify which HW CTX to upload. */\n", "prefixes": [ "dpdk-dev", "v3", "01/13" ] }{ "id": 1396, "url": "