Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139559/?format=api
{ "id": 139559, "url": "https://patches.dpdk.org/api/patches/139559/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240419202556.46188-1-andrew.boyer@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240419202556.46188-1-andrew.boyer@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240419202556.46188-1-andrew.boyer@amd.com", "date": "2024-04-19T20:25:56", "name": "net/ionic: clean up logging issues", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e264d7d71416ed2427bb85dab9d80e65973e6920", "submitter": { "id": 2861, "url": "https://patches.dpdk.org/api/people/2861/?format=api", "name": "Andrew Boyer", "email": "Andrew.Boyer@amd.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240419202556.46188-1-andrew.boyer@amd.com/mbox/", "series": [ { "id": 31796, "url": "https://patches.dpdk.org/api/series/31796/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31796", "date": "2024-04-19T20:25:56", "name": "net/ionic: clean up logging issues", "version": 1, "mbox": "https://patches.dpdk.org/series/31796/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139559/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139559/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0807843EB3;\n\tFri, 19 Apr 2024 22:26:10 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EC1CB40698;\n\tFri, 19 Apr 2024 22:26:09 +0200 (CEST)", "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2045.outbound.protection.outlook.com [40.107.93.45])\n by mails.dpdk.org (Postfix) with ESMTP id B52E040696\n for <dev@dpdk.org>; Fri, 19 Apr 2024 22:26:08 +0200 (CEST)", "from BN0PR03CA0054.namprd03.prod.outlook.com (2603:10b6:408:e7::29)\n by IA1PR12MB6436.namprd12.prod.outlook.com (2603:10b6:208:3ac::12)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.40; Fri, 19 Apr\n 2024 20:26:06 +0000", "from BN2PEPF000044A0.namprd02.prod.outlook.com\n (2603:10b6:408:e7:cafe::fe) by BN0PR03CA0054.outlook.office365.com\n (2603:10b6:408:e7::29) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.31 via Frontend\n Transport; Fri, 19 Apr 2024 20:26:06 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n BN2PEPF000044A0.mail.protection.outlook.com (10.167.243.151) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7452.22 via Frontend Transport; Fri, 19 Apr 2024 20:26:06 +0000", "from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 19 Apr\n 2024 15:26:05 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Vaxn7mUMO5aC+gzFgPV0ymloO582kMfPxcmiJnp2M2v3QAliKFhS7lMWO3oUOAk/GGgtHjR4uCmPbtssHiBhfOGsqMpNyqnAPhPui+bX/rcyFKV/rWfKcRsJC9iC1BryVr/avmY6nMZIZfZtm6X6soBK6HRFc1v1I8rpFwE3aYMq+GlYUD2y8RGZ635GfjWGPo97jH5Eshj2BjlqazzZiw89AHvhf9xKrnUaA9OxBBksCOijEnIrcvvQlBPcgZuOgyM3eAbeZgCsc2UlBCRI5141lHZgD2YW3raGayXPD+3iVDs/jVrt2sEM5oxORBFVTcma96wLDLhHsz/O1jI5Xg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=sMGiDVY844yoPmqLdpcEOayBs6zC0l+KMd2igNJsZC8=;\n b=bG+ZwTSbAA2R3oZ+ihZcwJ5aYxcz92Xq6X9X608WQG7ntO3+FsJeGXrNTSUmINxqhUBoP48H5nVaFgAoWPbKaAyBwvY02Tx2R/L0wJUFTTSazjlsNPWEg4CHOsEKWQTxj0XlyYTVZWgKm2cSBQLgGE0qkEagSlFg1VHy0M5hDjs+UB1AGKqURiH67392LwLeOloBYOb/dv6rvDd7RreuXKZrQzsP5coohwx3n1TSv1dG2hOu1TLPSBw5Ds99jEXgnbDp+fuaJZ7t/U2tquhnPiQf/O9wlBxwqflIvSl6HLYK/1ej1kEt3jIpdDS9HRG9pfX9sEGK0vqkNwpByEYEIg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=sMGiDVY844yoPmqLdpcEOayBs6zC0l+KMd2igNJsZC8=;\n b=F8IM8BmKXuagrL1fP8WZ84EXRy3/SRKvaWEW8wUYhCI9a+TZ6nHDsx8vGacl+tml+zNJtqCbUxsGt1qZlsbp67R8GfZVOU3tUj2HVN55w+sl4OI6IP+7JFGoZHOujJKHcB75gcAd0PmmvAjLk6gCsNvK4VMMkShZ1LEQ3olRo5s=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Andrew Boyer <andrew.boyer@amd.com>", "To": "<dev@dpdk.org>", "CC": "Andrew Boyer <andrew.boyer@amd.com>", "Subject": "[PATCH] net/ionic: clean up logging issues", "Date": "Fri, 19 Apr 2024 13:25:56 -0700", "Message-ID": "<20240419202556.46188-1-andrew.boyer@amd.com>", "X-Mailer": "git-send-email 2.17.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BN2PEPF000044A0:EE_|IA1PR12MB6436:EE_", "X-MS-Office365-Filtering-Correlation-Id": "913301db-ed03-48b2-87da-08dc60aef0dc", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n +canCdQbMtzqh5EzR/5RN4bzqDWTSbkZqcYRytD/2siM6pP6E7DLffh+x92T3Rm3ei1R7PuAHymYEjz0ByU21hpyNNT3Xug91DrH+XLkC+ubwvGYEYDS/9SCmvN8Jx+/umW6JX8mIOWopBvUumj+Zoejb/fNr/EyvxrhGdLJGEKzUSBl+2vDBIDH5dfkVfy9lhOirQnKp5FiNaLFqNaeN5uQ+4CKAFuJEnNLDdRBLmMWb1dMAvRKiXKx4HLzI3rTyA4cPakMnxrI+tIZENnW53mL/BTDztRDhoXW7r3/1dUMpAV+YvzUGOw6soLOyRGVmDPY4YqHBjVFhN2TCgM7gYf4EpsK0kGodLdqb3UkWA1sPJeaX3T8xO0nvvEMylIE6qY1+Cky0xhJF8NzgaT2pksd2l7xzz8kbiJsCqGf3fgFiHREJaL0dENstky60ZtryVoew5emGy0rJP9b2mnxVHt+7LbcPq2eAES6hw+8c+vanvLY00DrjCJigf5mcAZCQDZp9z+Tfm0l4xa0x5moweGMWOupHgbXpgSMLUcTGcC0P0Inu0yAZYVZ+hrXXdIaQ2WujZOHdbqWW1wgrYcia2SlXdjctHG4DrUIBjZD7hY8FbS4WlOE469rw2bmc5wuyEakoHmZzW51iyhy8aANdLlyjRiCpPkxb4tGYJJ7PG5HRAKus/H897vM9FGB10G7jggjbrcFbhzkwC1Z8mwRcQlKKrE5AdtvwGmIot1ZIWEwwLLziJyjrQ3IMaFGWty4", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(36860700004)(1800799015)(376005)(82310400014); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "19 Apr 2024 20:26:06.0859 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 913301db-ed03-48b2-87da-08dc60aef0dc", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN2PEPF000044A0.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "IA1PR12MB6436", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Switch to the new RTE_LOG_LINE_PREFIX logging macro. While here, fix up\nsome trailing-newline issues reported by the new macro.\n\nSigned-off-by: Andrew Boyer <andrew.boyer@amd.com>\n---\n drivers/net/ionic/ionic_dev_pci.c | 7 +++----\n drivers/net/ionic/ionic_lif.c | 8 ++++----\n drivers/net/ionic/ionic_logs.h | 14 +++-----------\n 3 files changed, 10 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_dev_pci.c b/drivers/net/ionic/ionic_dev_pci.c\nindex 2d7b4f223e..76235cad51 100644\n--- a/drivers/net/ionic/ionic_dev_pci.c\n+++ b/drivers/net/ionic/ionic_dev_pci.c\n@@ -43,13 +43,12 @@ ionic_pci_setup(struct ionic_adapter *adapter)\n \n \t/* BAR0: dev_cmd and interrupts */\n \tif (num_bars < 1) {\n-\t\tIONIC_PRINT(ERR, \"No bars found, aborting\\n\");\n+\t\tIONIC_PRINT(ERR, \"No bars found, aborting\");\n \t\treturn -EFAULT;\n \t}\n \n \tif (bar->len < IONIC_BAR0_SIZE) {\n-\t\tIONIC_PRINT(ERR,\n-\t\t\t\"Resource bar size %lu too small, aborting\\n\",\n+\t\tIONIC_PRINT(ERR, \"Resource bar size %lu too small, aborting\",\n \t\t\tbar->len);\n \t\treturn -EFAULT;\n \t}\n@@ -84,7 +83,7 @@ ionic_pci_setup(struct ionic_adapter *adapter)\n \t/* BAR1: doorbells */\n \tbar++;\n \tif (num_bars < IONIC_BARS_MIN) {\n-\t\tIONIC_PRINT(ERR, \"Doorbell bar missing, aborting\\n\");\n+\t\tIONIC_PRINT(ERR, \"Doorbell bar missing, aborting\");\n \t\treturn -EFAULT;\n \t}\n \ndiff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c\nindex 7f02b67610..b4dc118fef 100644\n--- a/drivers/net/ionic/ionic_lif.c\n+++ b/drivers/net/ionic/ionic_lif.c\n@@ -990,13 +990,13 @@ ionic_lif_queue_identify(struct ionic_lif *lif)\n \t\t\tqtype, ionic_qtype_vers[qtype]);\n \t\terr = ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);\n \t\tif (err == -EINVAL) {\n-\t\t\tIONIC_PRINT(ERR, \"qtype %d not supported\\n\", qtype);\n+\t\t\tIONIC_PRINT(ERR, \"qtype %d not supported\", qtype);\n \t\t\tcontinue;\n \t\t} else if (err == -EIO) {\n-\t\t\tIONIC_PRINT(ERR, \"q_ident failed, older FW\\n\");\n+\t\t\tIONIC_PRINT(ERR, \"q_ident failed, older FW\");\n \t\t\treturn;\n \t\t} else if (err) {\n-\t\t\tIONIC_PRINT(ERR, \"q_ident failed, qtype %d: %d\\n\",\n+\t\t\tIONIC_PRINT(ERR, \"q_ident failed, qtype %d: %d\",\n \t\t\t\tqtype, err);\n \t\t\treturn;\n \t\t}\n@@ -1380,7 +1380,7 @@ ionic_lif_handle_fw_down(struct ionic_lif *lif)\n \n \tif (lif->state & IONIC_LIF_F_UP) {\n \t\tIONIC_PRINT(NOTICE,\n-\t\t\t\"Surprise FW stop, stopping %s\\n\", lif->name);\n+\t\t\t\"Surprise FW stop, stopping %s\", lif->name);\n \t\tionic_lif_stop(lif);\n \t}\n \ndiff --git a/drivers/net/ionic/ionic_logs.h b/drivers/net/ionic/ionic_logs.h\nindex c10b06c051..739de00af8 100644\n--- a/drivers/net/ionic/ionic_logs.h\n+++ b/drivers/net/ionic/ionic_logs.h\n@@ -8,19 +8,11 @@\n #include <rte_log.h>\n \n extern int ionic_logtype;\n+#define RTE_LOGTYPE_IONIC ionic_logtype\n \n-#define IONIC_PRINT(level, fmt, args...) rte_log(RTE_LOG_ ## level, \\\n-\tionic_logtype, \"%s(): \" fmt \"\\n\", __func__, ##args)\n+#define IONIC_PRINT(level, ...) \\\n+\tRTE_LOG_LINE_PREFIX(level, IONIC, \"%s(): \", __func__, __VA_ARGS__)\n \n #define IONIC_PRINT_CALL() IONIC_PRINT(DEBUG, \" >>\")\n \n-#ifndef IONIC_WARN_ON\n-#define IONIC_WARN_ON(x) do { \\\n-\tint ret = !!(x); \\\n-\tif (unlikely(ret)) \\\n-\t\tIONIC_PRINT(WARNING, \"WARN_ON: \\\"\" #x \"\\\" at %s:%d\\n\", \\\n-\t\t\t__func__, __LINE__); \\\n-} while (0)\n-#endif\n-\n #endif /* _IONIC_LOGS_H_ */\n", "prefixes": [] }