Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139552/?format=api
{ "id": 139552, "url": "https://patches.dpdk.org/api/patches/139552/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240419172926.55447-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240419172926.55447-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240419172926.55447-7-stephen@networkplumber.org", "date": "2024-04-19T17:28:26", "name": "[v4,6/6] latencystats: fix for pedantic warnings", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "eea5895a1b998664dfce81f8b3daca0ad4543487", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240419172926.55447-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 31794, "url": "https://patches.dpdk.org/api/series/31794/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31794", "date": "2024-04-19T17:28:20", "name": "latencystats: cleanup", "version": 4, "mbox": "https://patches.dpdk.org/series/31794/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139552/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/139552/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BFD5F43EB2;\n\tFri, 19 Apr 2024 19:30:18 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A02CB40A80;\n\tFri, 19 Apr 2024 19:29:49 +0200 (CEST)", "from mail-pf1-f174.google.com (mail-pf1-f174.google.com\n [209.85.210.174])\n by mails.dpdk.org (Postfix) with ESMTP id 8A303406FF\n for <dev@dpdk.org>; Fri, 19 Apr 2024 19:29:42 +0200 (CEST)", "by mail-pf1-f174.google.com with SMTP id\n d2e1a72fcca58-6eddff25e4eso1949413b3a.3\n for <dev@dpdk.org>; Fri, 19 Apr 2024 10:29:42 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n h16-20020a632110000000b005f3c5cf33b5sm3383074pgh.37.2024.04.19.10.29.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 19 Apr 2024 10:29:41 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1713547782;\n x=1714152582; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=muSGKLb11y4nDDcZMd/T5iJvMOH0Me1KjJrkvR0Bvuk=;\n b=BqAfy1Ugz+XnmQgpit/Y19ckl0VP8DGcx53ZXmWJ7hzYIP+fXFc1LU9pNCB59scM6I\n gwKyuILQQWDaf0U020sDG9BTYgelnDnXGVg/PW3Lzot0x8oM55aYzIFPjIJUlSTwVleC\n dgX1xnA8ga4cyJbYfoW4wHcFApWOvQMGezj+PL218JpESRtb10BoYwDcp8JivspzjNxm\n PKKMFLKqotD4Ppoy4T6zgXe4jFWgIP8F1qasTskS/8ytoXoxHVv8HCS06bSgYFU6eKPg\n 7pZvC+sRZBP/UIP3Q9x1HzjwSPF34M5TW90eWBIeZzw5XLBsI+K/aPucAwwZ78WhoSX4\n we8Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1713547782; x=1714152582;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=muSGKLb11y4nDDcZMd/T5iJvMOH0Me1KjJrkvR0Bvuk=;\n b=P/3Y1j0BAAtK5EvQy+8HWq7l+Dn5tgjuA3IMz+beoTWk7dbfcy1mAjCBxQLHDpOqkv\n k3+OVL20MBJzOPiQDRk/J0XVc+iwGC8yp0Qlp9Jp142pH9XxDFvychW3HNdJ5DusI8j6\n IA6PY+aJ7t7wNBdD4DeASCJAcxZ8Rn10aObwyQ8oeiX8z3TMilFo2Xc/JPfKQRI/s9Tv\n IjPJ7ko7Sdm8MkBLSuaMulg8x+2lc4ejFeH1SLNciUHJokI3OmSH3Z3D74fe+m1He0qd\n eSM2eno+nrAZROc9iZuBYLRVDkYB7LNlc9rvfrp1FUfpsKqAeIfQsTJqe3285w3DrU1f\n VjuQ==", "X-Gm-Message-State": "AOJu0YwT2ySH6y7WKZKkUD1y18Z9b7w6LZKlChgmaOO45i37O9e+csGm\n 5qhEA/caeLoXUOfZuDANtl65SfGWPPXNKDbWwOg3CHmJavQPSwc/fd8jIbSXtnNY1oUl4ngyq9g\n m", "X-Google-Smtp-Source": "\n AGHT+IFXVGoARxnc8sOGVi5lMe3ODeb31tY+p6uUoi7S0/kULZkby1ahkRmtV82wfIRWFnsDiJLSCA==", "X-Received": "by 2002:a05:6a00:2e85:b0:6ed:4f2e:ef22 with SMTP id\n fd5-20020a056a002e8500b006ed4f2eef22mr3378121pfb.31.1713547781717;\n Fri, 19 Apr 2024 10:29:41 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Reshma Pattan <reshma.pattan@intel.com>", "Subject": "[PATCH v4 6/6] latencystats: fix for pedantic warnings", "Date": "Fri, 19 Apr 2024 10:28:26 -0700", "Message-ID": "<20240419172926.55447-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240419172926.55447-1-stephen@networkplumber.org>", "References": "<20240408195036.182545-1-stephen@networkplumber.org>\n <20240419172926.55447-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "ISO C does not allow casting function pointer to void *.\nResolve by enforcing the reserved argument.\nThe user_cb argument for rte_latencystats_init() was not\nimplemented, and had to be NULL anyway.\n\nThe log type is local to this function and RTE_LOG_REGISTER_DEFAULT\nalread has a semicolon. So adding one here causes a warning\nif compiler is set to pedantic.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/latencystats/rte_latencystats.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c\nindex 5db896ac7b..f60c893199 100644\n--- a/lib/latencystats/rte_latencystats.c\n+++ b/lib/latencystats/rte_latencystats.c\n@@ -29,7 +29,7 @@\n \n static double cycles_per_ns;\n \n-RTE_LOG_REGISTER_DEFAULT(latencystat_logtype, INFO);\n+static RTE_LOG_REGISTER_DEFAULT(latencystat_logtype, INFO)\n #define RTE_LOGTYPE_LATENCY_STATS latencystat_logtype\n #define LATENCY_STATS_LOG(level, ...) \\\n \tRTE_LOG_LINE(level, LATENCY_STATS, \"\" __VA_ARGS__)\n@@ -229,6 +229,10 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \tif (rte_memzone_lookup(MZ_RTE_LATENCY_STATS))\n \t\treturn -EEXIST;\n \n+\t/** Reserved for possible future use */\n+\tif (user_cb != NULL)\n+\t\treturn -ENOTSUP;\n+\n \t/** Allocate stats in shared memory fo multi process support */\n \tmz = rte_memzone_reserve(MZ_RTE_LATENCY_STATS, sizeof(*glob_stats),\n \t\t\t\t\trte_socket_id(), flags);\n@@ -281,7 +285,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \t\tfor (qid = 0; qid < dev_info.nb_rx_queues; qid++) {\n \t\t\tcbs = &rx_cbs[pid][qid];\n \t\t\tcbs->cb = rte_eth_add_first_rx_callback(pid, qid,\n-\t\t\t\t\tadd_time_stamps, user_cb);\n+\t\t\t\t\tadd_time_stamps, NULL);\n \t\t\tif (!cbs->cb)\n \t\t\t\tLATENCY_STATS_LOG(NOTICE,\n \t\t\t\t\t\"Failed to register Rx callback for pid=%u, qid=%u\",\n@@ -290,7 +294,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \t\tfor (qid = 0; qid < dev_info.nb_tx_queues; qid++) {\n \t\t\tcbs = &tx_cbs[pid][qid];\n \t\t\tcbs->cb = rte_eth_add_tx_callback(pid, qid,\n-\t\t\t\t\tcalc_latency, user_cb);\n+\t\t\t\t\tcalc_latency, NULL);\n \t\t\tif (!cbs->cb)\n \t\t\t\tLATENCY_STATS_LOG(NOTICE,\n \t\t\t\t\t\"Failed to register Tx callback for pid=%u, qid=%u\",\n", "prefixes": [ "v4", "6/6" ] }