Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139550/?format=api
{ "id": 139550, "url": "https://patches.dpdk.org/api/patches/139550/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240419172926.55447-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240419172926.55447-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240419172926.55447-5-stephen@networkplumber.org", "date": "2024-04-19T17:28:24", "name": "[v4,4/6] latencystats: fix log messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "191ff4ed18bfbf106652b773e34142b88ed65e32", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240419172926.55447-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 31794, "url": "https://patches.dpdk.org/api/series/31794/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31794", "date": "2024-04-19T17:28:20", "name": "latencystats: cleanup", "version": 4, "mbox": "https://patches.dpdk.org/series/31794/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139550/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139550/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 16EC243EB2;\n\tFri, 19 Apr 2024 19:30:07 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8B00A40A77;\n\tFri, 19 Apr 2024 19:29:46 +0200 (CEST)", "from mail-oa1-f45.google.com (mail-oa1-f45.google.com\n [209.85.160.45]) by mails.dpdk.org (Postfix) with ESMTP id B1C7040698\n for <dev@dpdk.org>; Fri, 19 Apr 2024 19:29:40 +0200 (CEST)", "by mail-oa1-f45.google.com with SMTP id\n 586e51a60fabf-22efc6b8dc5so1397477fac.0\n for <dev@dpdk.org>; Fri, 19 Apr 2024 10:29:40 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n h16-20020a632110000000b005f3c5cf33b5sm3383074pgh.37.2024.04.19.10.29.39\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 19 Apr 2024 10:29:39 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1713547780;\n x=1714152580; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=rD+AnQQVFckf+DeZeU85+tMHpx0KOMG8lHuLZS0zp18=;\n b=BlfLk3hChM9rrHVPdO5Kz+/lQq6ZsRmmX+f2/4TRlvDIG7PZdQMgfCC4hKAcU/WIx7\n n4ar+MJogghphKHCO2tq0SDcDbalbomQJ/YhRZ/HBqoq7bCgYq2BQ58ZEAGhM/xBfqTv\n zvQTedlF68YRGw9VgIJWGOQk6wXwoawHPGmADcP+jF4CZWXHpAUxcK9srQyp/Md6D8F/\n fMwbt6zPwbRAObKRr+va6hWvyni1ew2AebgeagutNvLtxIdjf2Hlwcl7Hh/oFqaikwgD\n NxXMRBgIWpERtvX2VTMrdCv6qZl3+tDjXPjt/7r9q1clMLZfoLDoUNsn+oQf4NPTxCua\n 3APw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1713547780; x=1714152580;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=rD+AnQQVFckf+DeZeU85+tMHpx0KOMG8lHuLZS0zp18=;\n b=Cu8b7x/P6lYYQTFGFdZ0TWd1FBpjiAB3WDsLTKVB14MrhNcg0PQdI0wbCbVcxgvYeU\n q2WF2H5UoBVWIYTPmSie8nCvUEmqw+96yidUYD+a7P/6Bc24QlsliX1/FHCC3Sth2CpI\n KRDQezNSFWdCg99m01fUTfm973nRUNuFvkEDH4QvDLSOnwAOpBtpkjgwZEfhQ+BA8MA1\n 7XwBy918Yr95Wr6W/xFeR6Fj7G5eH0YqrXjHDq3HX21vd8Wgw8YY7LzJ+M9cggWQwwMX\n Xb000ZBFn6r9+/p8t33XB+sgYlzKjR/ELVo6rptJzjTwz5+HY1DPh/iuAP+IJMHxIlpd\n k9Ug==", "X-Gm-Message-State": "AOJu0YzbrFoxe1nVXTjRAyTzh/km8oCN3iguTfVd+dd/bqvKqJr0Xu8R\n Yv8f7G1iVQLGBI5DO7Dw+HohVH3jc2FVEFHk2E+xmsXu9e9y9dcle6P8YVzGJvEy4c+abFNa248\n v", "X-Google-Smtp-Source": "\n AGHT+IFOslDQAeGOPkjtK9uBhxb5SIhGCbJpL0acvBvju7AqPt1g2fiuRV6G3yq1Xg101k6KCDD1tQ==", "X-Received": "by 2002:a05:6870:231a:b0:220:8bd2:cd09 with SMTP id\n w26-20020a056870231a00b002208bd2cd09mr3087473oao.32.1713547780054;\n Fri, 19 Apr 2024 10:29:40 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Reshma Pattan <reshma.pattan@intel.com>", "Subject": "[PATCH v4 4/6] latencystats: fix log messages", "Date": "Fri, 19 Apr 2024 10:28:24 -0700", "Message-ID": "<20240419172926.55447-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240419172926.55447-1-stephen@networkplumber.org>", "References": "<20240408195036.182545-1-stephen@networkplumber.org>\n <20240419172926.55447-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "All messages that because of an error should be at log level\nNOTICE or above. Do not break log messages across lines.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/latencystats/rte_latencystats.c | 30 ++++++++++++++---------------\n 1 file changed, 15 insertions(+), 15 deletions(-)", "diff": "diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c\nindex 6ef8e344bf..8aff96a449 100644\n--- a/lib/latencystats/rte_latencystats.c\n+++ b/lib/latencystats/rte_latencystats.c\n@@ -243,7 +243,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \tlatency_stats_index = rte_metrics_reg_names(ptr_strings,\n \t\t\t\t\t\t\tNUM_LATENCY_STATS);\n \tif (latency_stats_index < 0) {\n-\t\tLATENCY_STATS_LOG(DEBUG,\n+\t\tLATENCY_STATS_LOG(ERR,\n \t\t\t\"Failed to register latency stats names\");\n \t\treturn -1;\n \t}\n@@ -263,7 +263,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \n \t\tret = rte_eth_dev_info_get(pid, &dev_info);\n \t\tif (ret != 0) {\n-\t\t\tLATENCY_STATS_LOG(INFO,\n+\t\t\tLATENCY_STATS_LOG(NOTICE,\n \t\t\t\t\"Error during getting device (port %u) info: %s\",\n \t\t\t\tpid, strerror(-ret));\n \n@@ -275,18 +275,18 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \t\t\tcbs->cb = rte_eth_add_first_rx_callback(pid, qid,\n \t\t\t\t\tadd_time_stamps, user_cb);\n \t\t\tif (!cbs->cb)\n-\t\t\t\tLATENCY_STATS_LOG(INFO, \"Failed to \"\n-\t\t\t\t\t\"register Rx callback for pid=%d, \"\n-\t\t\t\t\t\"qid=%d\", pid, qid);\n+\t\t\t\tLATENCY_STATS_LOG(NOTICE,\n+\t\t\t\t\t\"Failed to register Rx callback for pid=%u, qid=%u\",\n+\t\t\t\t\tpid, qid);\n \t\t}\n \t\tfor (qid = 0; qid < dev_info.nb_tx_queues; qid++) {\n \t\t\tcbs = &tx_cbs[pid][qid];\n \t\t\tcbs->cb = rte_eth_add_tx_callback(pid, qid,\n \t\t\t\t\tcalc_latency, user_cb);\n \t\t\tif (!cbs->cb)\n-\t\t\t\tLATENCY_STATS_LOG(INFO, \"Failed to \"\n-\t\t\t\t\t\"register Tx callback for pid=%d, \"\n-\t\t\t\t\t\"qid=%d\", pid, qid);\n+\t\t\t\tLATENCY_STATS_LOG(NOTICE,\n+\t\t\t\t\t\"Failed to register Tx callback for pid=%u, qid=%u\",\n+\t\t\t\t\tpid, qid);\n \t\t}\n \t}\n \treturn 0;\n@@ -307,7 +307,7 @@ rte_latencystats_uninit(void)\n \n \t\tret = rte_eth_dev_info_get(pid, &dev_info);\n \t\tif (ret != 0) {\n-\t\t\tLATENCY_STATS_LOG(INFO,\n+\t\t\tLATENCY_STATS_LOG(NOTICE,\n \t\t\t\t\"Error during getting device (port %u) info: %s\",\n \t\t\t\tpid, strerror(-ret));\n \n@@ -318,17 +318,17 @@ rte_latencystats_uninit(void)\n \t\t\tcbs = &rx_cbs[pid][qid];\n \t\t\tret = rte_eth_remove_rx_callback(pid, qid, cbs->cb);\n \t\t\tif (ret)\n-\t\t\t\tLATENCY_STATS_LOG(INFO, \"failed to \"\n-\t\t\t\t\t\"remove Rx callback for pid=%d, \"\n-\t\t\t\t\t\"qid=%d\", pid, qid);\n+\t\t\t\tLATENCY_STATS_LOG(NOTICE,\n+\t\t\t\t\t\"Failed to remove Rx callback for pid=%u, qid=%u\",\n+\t\t\t\t\tpid, qid);\n \t\t}\n \t\tfor (qid = 0; qid < dev_info.nb_tx_queues; qid++) {\n \t\t\tcbs = &tx_cbs[pid][qid];\n \t\t\tret = rte_eth_remove_tx_callback(pid, qid, cbs->cb);\n \t\t\tif (ret)\n-\t\t\t\tLATENCY_STATS_LOG(INFO, \"failed to \"\n-\t\t\t\t\t\"remove Tx callback for pid=%d, \"\n-\t\t\t\t\t\"qid=%d\", pid, qid);\n+\t\t\t\tLATENCY_STATS_LOG(NOTICE,\n+\t\t\t\t\t\"Failed to remove Tx callback for pid=%u, qid=%u\",\n+\t\t\t\t\tpid, qid);\n \t\t}\n \t}\n \n", "prefixes": [ "v4", "4/6" ] }