Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139548/?format=api
{ "id": 139548, "url": "https://patches.dpdk.org/api/patches/139548/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240419172926.55447-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240419172926.55447-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240419172926.55447-3-stephen@networkplumber.org", "date": "2024-04-19T17:28:22", "name": "[v4,2/6] latencystats: handle fractional cycles per ns", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "77372c9c9204c9bc1e94d6016fd8fc7f9db7ee09", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240419172926.55447-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 31794, "url": "https://patches.dpdk.org/api/series/31794/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31794", "date": "2024-04-19T17:28:20", "name": "latencystats: cleanup", "version": 4, "mbox": "https://patches.dpdk.org/series/31794/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139548/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139548/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 89B0043EB2;\n\tFri, 19 Apr 2024 19:29:51 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4BE1340691;\n\tFri, 19 Apr 2024 19:29:42 +0200 (CEST)", "from mail-ot1-f53.google.com (mail-ot1-f53.google.com\n [209.85.210.53]) by mails.dpdk.org (Postfix) with ESMTP id 09DF340698\n for <dev@dpdk.org>; Fri, 19 Apr 2024 19:29:39 +0200 (CEST)", "by mail-ot1-f53.google.com with SMTP id\n 46e09a7af769-6eb93ec8804so1281766a34.2\n for <dev@dpdk.org>; Fri, 19 Apr 2024 10:29:38 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n h16-20020a632110000000b005f3c5cf33b5sm3383074pgh.37.2024.04.19.10.29.37\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 19 Apr 2024 10:29:38 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1713547778;\n x=1714152578; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=sSasOgCHLIZFkxb9gF3dyAkJenIQv2QQ2b/rkOQt9Ps=;\n b=hsaRTQ3qE6Qrw2DTsG0L3/QPDztEncXNrRBCpsUGsIZbPBh056mm48O6H6mkSq8pBf\n AABrPm1zdbHGR2k0Zg6Dsv9QLsJmNVdkzVG/bTc5Dy6SCHUXTarMkyM+j+LuuxZnvh8G\n KmkJds/qUq0rlA9nHcjNK7JgCDYiGpOgmxMDJ8mi72gRlCKLyiIM9bjj6rMfWcAPADgd\n +pF7YwyXFpIdejtj8KcCKNyfV4mM66Al+gUdIIf6vtds3Gv6+7OGwSqLgxwF3x6DponB\n BLz9j9eeXo9DCyXO8Qxy4tKLi1xl+gcRs3C8QWSiKNdEWe4X3REIdI37FjT3uPjjsH8L\n d/dw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1713547778; x=1714152578;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=sSasOgCHLIZFkxb9gF3dyAkJenIQv2QQ2b/rkOQt9Ps=;\n b=kcOA8jfE92SpuoSVKRzJFe38NrUCrfzFg22p18z/DYAOeo10hbe1hvMzoZFrYOJkNc\n UwY1lHkNqpa8+swhcthhUTc3O1AkH1uSwpL6on6264cMnBf5GHJLWzCzFwt3iWFUOK7l\n 79Tw9Lu/4bDjoL7/RVFDAYjjhFWXh1hnQ3bl1ZrcBnNJGgPloAcvqc3owdhu/lSsO+T+\n mPHDvTAMapP7JOq7qHpULD4jLILvNksaPfFuh3w3HDNHtBed6BIDAYx6/bTEXG0qku8d\n hepPRGBROBh9yQahNXZH1gnCiTFf4K3QE1mUmQFtUrvdY6KzCXhNojBoRb1j7REDSr4k\n BTyg==", "X-Gm-Message-State": "AOJu0YwpnM/13vhjr/8ew7yPcO4aJI7+hfJJZVX92/wh9TBuZbHcwjbh\n /w3AcRaDDly6Zc6LH9NW0qBWcXA6qBt8Vuytj6CNRjX7EsHVY/PtQoowhiFXODvl9ZeKuAiZqLE\n F", "X-Google-Smtp-Source": "\n AGHT+IGtHOAQZYIiYfqUzlefXLi1zgDTLT1yoI9ksZj6r87jKr41RkHfyjPV1w8aEglh7Eg/R19U3g==", "X-Received": "by 2002:a05:6830:1208:b0:6eb:8435:60 with SMTP id\n r8-20020a056830120800b006eb84350060mr3374751otp.24.1713547778380;\n Fri, 19 Apr 2024 10:29:38 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Reshma Pattan <reshma.pattan@intel.com>", "Subject": "[PATCH v4 2/6] latencystats: handle fractional cycles per ns", "Date": "Fri, 19 Apr 2024 10:28:22 -0700", "Message-ID": "<20240419172926.55447-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240419172926.55447-1-stephen@networkplumber.org>", "References": "<20240408195036.182545-1-stephen@networkplumber.org>\n <20240419172926.55447-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The timer_hz is not always an integral number of nanoseconds.\nFor examples, cycles per nanoseconds on my test system is 2.8.\nFix by using floating point where needed and calculate value once.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/latencystats/rte_latencystats.c | 17 ++++++-----------\n 1 file changed, 6 insertions(+), 11 deletions(-)", "diff": "diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c\nindex 9b345bfb33..55a099c818 100644\n--- a/lib/latencystats/rte_latencystats.c\n+++ b/lib/latencystats/rte_latencystats.c\n@@ -18,12 +18,7 @@\n /** Nano seconds per second */\n #define NS_PER_SEC 1E9\n \n-/** Clock cycles per nano second */\n-static uint64_t\n-latencystat_cycles_per_ns(void)\n-{\n-\treturn rte_get_timer_hz() / NS_PER_SEC;\n-}\n+static double cycles_per_ns;\n \n RTE_LOG_REGISTER_DEFAULT(latencystat_logtype, INFO);\n #define RTE_LOGTYPE_LATENCY_STATS latencystat_logtype\n@@ -89,8 +84,7 @@ rte_latencystats_update(void)\n \tfor (i = 0; i < NUM_LATENCY_STATS; i++) {\n \t\tstats_ptr = RTE_PTR_ADD(glob_stats,\n \t\t\t\tlat_stats_strings[i].offset);\n-\t\tvalues[i] = (uint64_t)floor((*stats_ptr)/\n-\t\t\t\tlatencystat_cycles_per_ns());\n+\t\tvalues[i] = floor(*stats_ptr / cycles_per_ns);\n \t}\n \n \tret = rte_metrics_update_values(RTE_METRICS_GLOBAL,\n@@ -112,8 +106,7 @@ rte_latencystats_fill_values(struct rte_metric_value *values)\n \t\tstats_ptr = RTE_PTR_ADD(glob_stats,\n \t\t\t\tlat_stats_strings[i].offset);\n \t\tvalues[i].key = i;\n-\t\tvalues[i].value = (uint64_t)floor((*stats_ptr)/\n-\t\t\t\t\t\tlatencystat_cycles_per_ns());\n+\t\tvalues[i].value = floor(*stats_ptr / cycles_per_ns);\n \t}\n }\n \n@@ -235,9 +228,11 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \t\treturn -ENOMEM;\n \t}\n \n+\tcycles_per_ns = (double)rte_get_timer_hz() / NS_PER_SEC;\n+\n \tglob_stats = mz->addr;\n \trte_spinlock_init(&glob_stats->lock);\n-\tsamp_intvl = app_samp_intvl * latencystat_cycles_per_ns();\n+\tsamp_intvl = (uint64_t)(app_samp_intvl * cycles_per_ns);\n \n \t/** Register latency stats with stats library */\n \tfor (i = 0; i < NUM_LATENCY_STATS; i++)\n", "prefixes": [ "v4", "2/6" ] }