Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139547/?format=api
{ "id": 139547, "url": "https://patches.dpdk.org/api/patches/139547/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240419172926.55447-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240419172926.55447-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240419172926.55447-2-stephen@networkplumber.org", "date": "2024-04-19T17:28:21", "name": "[v4,1/6] latencystats: replace use of VLA", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7728e7fb3ead8e6739491719736f5cf2547ceafe", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240419172926.55447-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 31794, "url": "https://patches.dpdk.org/api/series/31794/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31794", "date": "2024-04-19T17:28:20", "name": "latencystats: cleanup", "version": 4, "mbox": "https://patches.dpdk.org/series/31794/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139547/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139547/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B4D0443EB2;\n\tFri, 19 Apr 2024 19:29:44 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C7193406B4;\n\tFri, 19 Apr 2024 19:29:40 +0200 (CEST)", "from mail-oo1-f48.google.com (mail-oo1-f48.google.com\n [209.85.161.48]) by mails.dpdk.org (Postfix) with ESMTP id 7023740689\n for <dev@dpdk.org>; Fri, 19 Apr 2024 19:29:38 +0200 (CEST)", "by mail-oo1-f48.google.com with SMTP id\n 006d021491bc7-5ad21f3e5dcso397363eaf.3\n for <dev@dpdk.org>; Fri, 19 Apr 2024 10:29:38 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n h16-20020a632110000000b005f3c5cf33b5sm3383074pgh.37.2024.04.19.10.29.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 19 Apr 2024 10:29:37 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1713547777;\n x=1714152577; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=1iMXXGjOoTwNd9pOuzO/FsZahJFsBN6I19d6MX2wr/Q=;\n b=d19Og84AG4Zines8JX1JFDLRMDNe8v9d9q8gVJgvfzNJtcgTytesvQu17Fm+DrCmM8\n R2hcsgv/Gi/NH/LRd+KmVLxhpBs2mfSB2Cwk79iGQDXtHX6IbEZHhAbQF6WC9KcQNLd5\n U0FUibA4x54us6cWyoe7iJqs4orXrtXY4hbW8Lb3Z5APyv/GDx81DndIEr4t5lO6itA/\n ZWYlh1MpKXFogAMfxHyQUhJ8QAZMgfX1ybMDvkHnY0bJBE/FpKwRrDIfajb2tYyv/Evi\n O+/plt3AHfqwhPCKyN+o0wpFwDLIBu7WicgbAdAjlpvASDyexPTEgZVxqA8zc2T2MCkk\n JTFg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1713547777; x=1714152577;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=1iMXXGjOoTwNd9pOuzO/FsZahJFsBN6I19d6MX2wr/Q=;\n b=naoY8ajd7xPHuBsB54+5lvjz6dxoMfKjEk4Ug9H5Mp5F0h8nDvWsvN4Gar6BiX/FRS\n 7Rf7VXYYAEEusK0H1W8lM++aKvwumVbLMKIbxUHFO5XpMuGuHmEIHrUM4pNDGyQdHiWB\n X6zvmVMQk05KYUpN0dnn/Nm/vrnpJHcPZM7eHzwXppwjSFTJfMFuzYi3dP1Z8Lk0BB5z\n IDpiNHRhnLU0DSMhgzAZdnapJumzoFVvG5DnFoQ5liPW/3JTHkgj4DaqT67RbySkvnrv\n WqU3Dr2lTf4z6sx98S6n+PHMmC5OBPyEtUw8+VPTymifb1ZlHw78hyGn+9JNVHpLDAEP\n gDfA==", "X-Gm-Message-State": "AOJu0YyThPeSaFBsUG8KZ7/unfnEGdOAF6VRgPoo9LLjfnD15mwN/Q58\n kBlz5rrgRDJUMx4OTa663Ak/5k2Y86hPITBjWg2VnlgpqtdOii/6WdFTiN9L6KgCINpMOonD7SO\n 8", "X-Google-Smtp-Source": "\n AGHT+IFVteU+QkJvgt5Rl+XaOJb89OaONKtlhOBBbEY3wHeByCLpxRVo26NbTX6dcecBG+WrhmQEEw==", "X-Received": "by 2002:a05:6870:e99:b0:222:1353:ad0f with SMTP id\n mm25-20020a0568700e9900b002221353ad0fmr3408676oab.24.1713547777603;\n Fri, 19 Apr 2024 10:29:37 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>, =?utf-8?q?Morten_Br?=\n\t=?utf-8?q?=C3=B8rup?= <mb@smartsharesystems.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Reshma Pattan <reshma.pattan@intel.com>", "Subject": "[PATCH v4 1/6] latencystats: replace use of VLA", "Date": "Fri, 19 Apr 2024 10:28:21 -0700", "Message-ID": "<20240419172926.55447-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240419172926.55447-1-stephen@networkplumber.org>", "References": "<20240408195036.182545-1-stephen@networkplumber.org>\n <20240419172926.55447-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The temporary array latencystats is not needed if the algorithm\nis converted into one pass.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/latencystats/rte_latencystats.c | 31 +++++++++++++++--------------\n 1 file changed, 16 insertions(+), 15 deletions(-)", "diff": "diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c\nindex 4ea9b0d75b..9b345bfb33 100644\n--- a/lib/latencystats/rte_latencystats.c\n+++ b/lib/latencystats/rte_latencystats.c\n@@ -157,9 +157,9 @@ calc_latency(uint16_t pid __rte_unused,\n \t\tuint16_t nb_pkts,\n \t\tvoid *_ __rte_unused)\n {\n-\tunsigned int i, cnt = 0;\n+\tunsigned int i;\n \tuint64_t now;\n-\tfloat latency[nb_pkts];\n+\tfloat latency;\n \tstatic float prev_latency;\n \t/*\n \t * Alpha represents degree of weighting decrease in EWMA,\n@@ -169,13 +169,14 @@ calc_latency(uint16_t pid __rte_unused,\n \tconst float alpha = 0.2;\n \n \tnow = rte_rdtsc();\n-\tfor (i = 0; i < nb_pkts; i++) {\n-\t\tif (pkts[i]->ol_flags & timestamp_dynflag)\n-\t\t\tlatency[cnt++] = now - *timestamp_dynfield(pkts[i]);\n-\t}\n \n \trte_spinlock_lock(&glob_stats->lock);\n-\tfor (i = 0; i < cnt; i++) {\n+\tfor (i = 0; i < nb_pkts; i++) {\n+\t\tif (!(pkts[i]->ol_flags & timestamp_dynflag))\n+\t\t\tcontinue;\n+\n+\t\tlatency = now - *timestamp_dynfield(pkts[i]);\n+\n \t\t/*\n \t\t * The jitter is calculated as statistical mean of interpacket\n \t\t * delay variation. The \"jitter estimate\" is computed by taking\n@@ -187,22 +188,22 @@ calc_latency(uint16_t pid __rte_unused,\n \t\t * Reference: Calculated as per RFC 5481, sec 4.1,\n \t\t * RFC 3393 sec 4.5, RFC 1889 sec.\n \t\t */\n-\t\tglob_stats->jitter += (fabsf(prev_latency - latency[i])\n+\t\tglob_stats->jitter += (fabsf(prev_latency - latency)\n \t\t\t\t\t- glob_stats->jitter)/16;\n \t\tif (glob_stats->min_latency == 0)\n-\t\t\tglob_stats->min_latency = latency[i];\n-\t\telse if (latency[i] < glob_stats->min_latency)\n-\t\t\tglob_stats->min_latency = latency[i];\n-\t\telse if (latency[i] > glob_stats->max_latency)\n-\t\t\tglob_stats->max_latency = latency[i];\n+\t\t\tglob_stats->min_latency = latency;\n+\t\telse if (latency < glob_stats->min_latency)\n+\t\t\tglob_stats->min_latency = latency;\n+\t\telse if (latency > glob_stats->max_latency)\n+\t\t\tglob_stats->max_latency = latency;\n \t\t/*\n \t\t * The average latency is measured using exponential moving\n \t\t * average, i.e. using EWMA\n \t\t * https://en.wikipedia.org/wiki/Moving_average\n \t\t */\n \t\tglob_stats->avg_latency +=\n-\t\t\talpha * (latency[i] - glob_stats->avg_latency);\n-\t\tprev_latency = latency[i];\n+\t\t\talpha * (latency - glob_stats->avg_latency);\n+\t\tprev_latency = latency;\n \t}\n \trte_spinlock_unlock(&glob_stats->lock);\n \n", "prefixes": [ "v4", "1/6" ] }