Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139525/?format=api
{ "id": 139525, "url": "https://patches.dpdk.org/api/patches/139525/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240419032630.1215256-3-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240419032630.1215256-3-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240419032630.1215256-3-chaoyong.he@corigine.com", "date": "2024-04-19T03:26:30", "name": "[v3,2/2] bus/pci: fix secondary process save 'FD' problem", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a03a28b19cfa70c3f6f6bc276973a8dd572d8d1a", "submitter": { "id": 2554, "url": "https://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240419032630.1215256-3-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 31787, "url": "https://patches.dpdk.org/api/series/31787/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31787", "date": "2024-04-19T03:26:29", "name": "[v3,1/2] bus/pci: fix secondary process PCI uio resource map problem", "version": 3, "mbox": "https://patches.dpdk.org/series/31787/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139525/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139525/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 91A8A43EA9;\n\tFri, 19 Apr 2024 05:27:04 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0C52B40693;\n\tFri, 19 Apr 2024 05:26:58 +0200 (CEST)", "from NAM11-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam11on2112.outbound.protection.outlook.com [40.107.236.112])\n by mails.dpdk.org (Postfix) with ESMTP id A8BAB40608;\n Fri, 19 Apr 2024 05:26:54 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by PH7PR13MB6170.namprd13.prod.outlook.com (2603:10b6:510:241::8)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.41; Fri, 19 Apr\n 2024 03:26:53 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7472.042; Fri, 19 Apr 2024\n 03:26:53 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=DLqa2V47bPauE+0MXnwltAUjXpbcSqibtNurLOKS2XAxcQaBjNXopA39+yc7dQwuqCmMkE4ObN1j5KcTVlYjxeOjucMPCkdpzFieS0VzWfmMh0b0BXxoVQrIgeD1Q3B/FPqf3cjTTna7cjpEP8M5RKoUERTYKkrlFlRAGtkMxG4mqQIzPihIxIQ95ITtKV1RASYei6fUIfkrvKRGEKP4v6Wz4BXC3laCyhtn/33xjspeuntr/UtkFm2PT2LrHJ35t48Oq1Gz03Bw7W60pxChD2IOe8SZeRTIyb502WKVr3tI9dc5S9mfIN3RcE9WySc/ODBMoom8Olpjh8U3ZznV1A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=sIAqd443W9sHgM64xZS4RMueawsm4oE8C1S8pBZqJFk=;\n b=f6RbOYdnKmtmBfXHjtNTaItGihQmvVM/j4EJNhSEZHTfBVobL1wuTimoRsz1gT2O0s5DL4pKN2D3BfMEzzQ+BUbQvEFUZBxUm4KVzkuzrsRnpw5h6utdd8pBnmT8X/+xzXggJWaOuKPQRhiYpkwo/gNlOYTtKCYyUiTcFwvaKwBBOXsmsTd34eu+l0S3+sW66EuQsyJZ3ueX16gnCbY+RfCHP53zBZGKWD6PJBlNmydROtE9tcfdTiCKO6VsTkVtMtBFuoUMjOQRTsRbqWff2yCnNHu2SKv2IAfd3p00Impmyre/U1sLSfEiT3kz7IazG//MGpyR01Yrad2/Qp2IVg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=sIAqd443W9sHgM64xZS4RMueawsm4oE8C1S8pBZqJFk=;\n b=eQv7QBgttDneOM7Qa+RMjHrLaiJAQH37+8voKQj4SILKcK5qzRJroybWQ6jJvxhmtE6Oj4t/HNKZ6e1/7IL30bimbOu1LBO+TLFnAnLixJfDIPbHiMcYcWdzx7jue6TbxoqZTewYaPJE5UpjrUEKnd9mrGr+7ZsY2sLrM64jUB0=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Zerun Fu <zerun.fu@corigine.com>,\n mukawa@igel.co.jp, stable@dpdk.org, Chaoyong He <chaoyong.he@corigine.com>,\n Long Wu <long.wu@corigine.com>, Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH v3 2/2] bus/pci: fix secondary process save 'FD' problem", "Date": "Fri, 19 Apr 2024 11:26:30 +0800", "Message-Id": "<20240419032630.1215256-3-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20240419032630.1215256-1-chaoyong.he@corigine.com>", "References": "<20240129092231.3531217-1-chaoyong.he@corigine.com>\n <20240419032630.1215256-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SI2PR01CA0008.apcprd01.prod.exchangelabs.com\n (2603:1096:4:191::10) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|PH7PR13MB6170:EE_", "X-MS-Office365-Filtering-Correlation-Id": "4308a3d4-0e38-4515-3d48-08dc60208ef1", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n ug0pFK9zd29/hvuB+T0EaZtHXCykU23VxGsn/sI3VGErX4i6Gmv59xbNhZ9YidOtOD2LLUnrWbFPPiqp9JgXCfg3JmrbXlyhQVHe92jRzUAzEuzHihnMPpx/tXbT5nhzN+uNhKq6ZPrn6n+Qk9j48YdgfIzvtexvYOKRhqJS6oOsaV6GdIKX4txvxjJ9dWh9Aky8woNuTaOy8sTPkTx9VrSo4O7cWDj/wK7+xsAdg4OBMSLZqqBAvmHup4eoU2n9gWdgkhyMxVgMvamgujqQ2IxSy0rZoWlvzwWGZvVFxM3Bq24Ep9oVsPjyg3blp3Li0IyJC0HDiCteeQ92OYojgVOEimN4cqaPT2Pn0F7GNqFZZRCXl49/rhgt6hf7bP8IX4CEvPfIurX4Xv9pEgjPBUA1LfWPDcjj0VD9+QZVqH8g7Qt2XxrjMMAjcijeNc4yCIkN5LEUesA3HMQLKUIFy8E9OPpZxg2Mw3SUxBEcmNY2cRyzmrzXcsaNMMwcDFL2bPgL9slEKdDqPGI3BqBInifJkWcw29O2b2Ew2FZh5jv9xT6wOvbzN9ixXgaJba/AtuMutgU7AMWvnfmzFciY7NBzW/Jl6n15h6BV8nFPTDG9d7wZRkvZzPni+QBf4GuKn76K/5ZHB9Fx1viwboT0IOCXUKK+RPyiay1fcnBic9uR668gG72vQOT8o9lvMqrkcWvcuCrQojLw3WbufkbFRBh/eTcXwOzj4jGCo0/28qFumH3RnRA81+TmZsNC0/SaGtHftrD4W7HFRl9SxDJ/uZR8gIPr2Qgw3DD3dsJPACZBfM4IJG2iRX3prq2xiXi8m1Ihg5MkRwPJlijo2gs50bN0nswPdwaV5WOJGSMST16BHQLSbdsMP5g/FXTlddd7LKXdCrLtsOXq31OCWaNT/wOZ+xq0HyxRtZ6xY/MAUbgnSiJNw239x2z/PqJR0qvWSRWK+Lv6pOXRouMKdrxL3BPlBRvkh/5R4tRscvC4qhtyuWXE5gCrFtW3w4WqPoY9Txmg1K2rtJhqeFm/s3BhiPIevc2phuvDIVX1WweA5IwgSpd2QCZnkpfq6MU3ZyVcFJMu14QfQr0xx9te9agyb2659nlSUj/BtWzER1eTZdEMV0XY+W2Ytjdj8sd9iCV321DxHEyVLRqsJc/SaCJXEHQT+IvQJrKaoVAv5P8dzSw9JoWsqNeoqEB29MDjQFA1mFWrnAaCYcX59jTdcPQztVhn2hMf/vigHM/9p9ic8aIMGhmtLlthFfI9XSxcLhFBdxswPOFnLeaL9n+9fWQ8iXrxa6EZux27p1ZE4sPy+VULSPEEOYl2b5c1IWca0CBYoN3u2mKWKU1YNiwZXDFhtA==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(1800799015)(366007)(376005)(52116005)(38350700005); DIR:OUT;\n SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n x/mjA2tKbUs6wxWFZcP1vH+uJ1VNWumnQulzEeNEPuw8Y9cKsKHUJvmOASB2gtfJYPkvCvHQSntowaMNrYBn0+eWIU8fw/KlSpMDODm8hxTBHjUM1VhRaa0CPiBy5EHnPTKIV9KpUY8RVdofftji0brq6bpSxJrzteXcGr6eC2dUWg0odXy3eM8NLRwHfEXtUuIZUD7SkTNHALKfX/v8aUXklYKSNfnkGh7qCiAmVowiPNkCYSCgGcTA2EGKftAof7Fr74olhkrPdNHeot2WAqMLRK0mx2+bhPF9RlZCLeP7Y8PaY55LvUuGzUaVMVZ+1VR+FLkwBB5P/apwKvzWm3D2B5HRW2HA01MWQ5IwugtiuzObsJC2+bEVAA2Ekv5O8V748jDxAt+AJJFEj7BS6fNEXuZynrkHX6UGb3kXjusM2PX2uivYeQq6kF4etfVXBwxz4lbt//IeQH+WVf9l7CD6jKIq6J9vAQ+Sk6nuRz0CyAKbWcdlaZW6swo7vbW1HzfHibCnQXN8AkD+GNBvTHFcSCvZ25Jq2thFuDhUlpk0tceOyjCwLDohpFVd7M0SZNe9rx2XQklV2rVSyMoVIEocyfFDOomJbIzc7B1HLRtf21+dOw5AEHEwP3QoG3EvoBHsQJtIBuve3voAgm4oJ+ig6NToBJK2xQcmXcAB+BihTgAbz0lnCPlksYGVQ306Y2MRNIOXaS/FpFKgxBs3C2eiyJcX81wh5DP7PJg716byO1UqgoQmzm/skhDaVhhGioStjAf51l5wwLp/d6AzexU98codgca5ygA5CXdhq8Ge6zHJRYslzF/jwrdzA8WpGB+uKVLAFx2Ous6xSmtd18j0ntd4gT/EpEzI8C8DBeBUF1JzZSvomORoLePHoujbGL1T7ltOiHLKQMLFZiei2WB+Dp6X1upvecVwkgwU3Z6Jh2qhT7oLfaQvMBEro5KTxNZHcpYKggINLB1LXLxVXcrbIclNp+9edIVDzboa9Bl082+yzJutnwZAcAr2xkZiX1lJbG+PR6Bmyp7IBx6n3kYAN5lwtJSOeLdtIdOpOyMan2ejXsPiT6pzYPXTkx6l/GIZzef1s+keEOhD5k3+yv6Hez+nccTNxhWTq27clWIULjnYUZOzfm5vtTut/QgKhHXCbzMnCMTsSAkQs+o6FSXxS2DaFjiITkngemRTyfC08IV8FPqNl52ZOyxIum4U6e+Xk0Ozt2p+XcJdFtN4xL7e5AVQuk+/pWdyZ3Pd9Gdq1RcEhfznn9M7831xv6T19uZDvEe9ozJ3w+hSvi8SF2X7VF8fjmRV6ounayrAMVascZGT1g6aFL2KQ8fm0LBCGvSNwzu8gwrJfWiIDjfu5JNpmpnxbRvDzpZj3vLvkEb54m+GkjbJMESu2XGWXViHpzLiFAZURiSWWDB3dw5+2MypZMD3o4BMkDYf9MYjAN3oxpoYwHNHzAVGVqdCDTnA0snNReoo5lMLf+kJ048ZgKfpL5iJ4xdYANATI5sl0y2c857kNm0dEgmCSLdiEp1mMDJdklcr+4CdwvF3N6bsa4VCzn/ufexiRlqaKWvvDqpq11V55rWgUp42diz6w9GpyqxtFNcyRXYwhWavVl+dyA==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 4308a3d4-0e38-4515-3d48-08dc60208ef1", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "19 Apr 2024 03:26:53.4664 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n j6MzpAPq1yLkNJ5ZyM7kSfBmp35u2HnFYfQ1c/fbRl65HEjjo5h+FgK8MqtEO15wNQNV/sIPgWJRdxH+qVSeiz5exb8fV1AVGnFkG56UOSc=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH7PR13MB6170", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Zerun Fu <zerun.fu@corigine.com>\n\nIn the previous logic the 'fd' was only saved in the primary process,\nbut for some devices this value is also used in the secondary logic.\n\nFor example, the call of 'rte_pci_find_ext_capability()' will fail in\nthe secondary process.\n\nFix this problem by getting and saving the value of 'fd' also in the\nsecondary process logic.\n\nFixes: 9b957f378abf (\"pci: merge uio functions for linux and bsd\")\nCc: mukawa@igel.co.jp\nCc: stable@dpdk.org\n\nSigned-off-by: Zerun Fu <zerun.fu@corigine.com>\nReviewed-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/bus/pci/linux/pci_uio.c | 5 ++++-\n drivers/bus/pci/pci_common_uio.c | 8 ++++----\n 2 files changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci_uio.c b/drivers/bus/pci/linux/pci_uio.c\nindex 97d740dfe5..6680e42efb 100644\n--- a/drivers/bus/pci/linux/pci_uio.c\n+++ b/drivers/bus/pci/linux/pci_uio.c\n@@ -237,7 +237,7 @@ pci_uio_alloc_resource(struct rte_pci_device *dev,\n \t}\n \tsnprintf(devname, sizeof(devname), \"/dev/uio%u\", uio_num);\n \n-\t/* save fd if in primary process */\n+\t/* save fd */\n \tfd = open(devname, O_RDWR);\n \tif (fd < 0) {\n \t\tRTE_LOG(ERR, EAL, \"Cannot open %s: %s\\n\",\n@@ -261,6 +261,9 @@ pci_uio_alloc_resource(struct rte_pci_device *dev,\n \tif (rte_intr_dev_fd_set(dev->intr_handle, uio_cfg_fd))\n \t\tgoto error;\n \n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn 0;\n+\n \tif (dev->kdrv == RTE_PCI_KDRV_IGB_UIO) {\n \t\tif (rte_intr_type_set(dev->intr_handle, RTE_INTR_HANDLE_UIO))\n \t\t\tgoto error;\ndiff --git a/drivers/bus/pci/pci_common_uio.c b/drivers/bus/pci/pci_common_uio.c\nindex 432d68b12c..8688862738 100644\n--- a/drivers/bus/pci/pci_common_uio.c\n+++ b/drivers/bus/pci/pci_common_uio.c\n@@ -106,15 +106,15 @@ pci_uio_map_resource(struct rte_pci_device *dev)\n \tif (rte_intr_dev_fd_set(dev->intr_handle, -1))\n \t\treturn -1;\n \n-\t/* secondary processes - use already recorded details */\n-\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n-\t\treturn pci_uio_map_secondary(dev);\n-\n \t/* allocate uio resource */\n \tret = pci_uio_alloc_resource(dev, &uio_res);\n \tif (ret)\n \t\treturn ret;\n \n+\t/* secondary processes - use already recorded details */\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn pci_uio_map_secondary(dev);\n+\n \t/* Map all BARs */\n \tfor (i = 0; i != PCI_MAX_RESOURCE; i++) {\n \t\t/* skip empty BAR */\n", "prefixes": [ "v3", "2/2" ] }