Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139472/?format=api
{ "id": 139472, "url": "https://patches.dpdk.org/api/patches/139472/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1713397319-26135-16-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1713397319-26135-16-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1713397319-26135-16-git-send-email-roretzla@linux.microsoft.com", "date": "2024-04-17T23:41:58", "name": "[15/16] net/mlx5: remove use of VLAs for Windows built code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "91370f75f7752702af2bb46f31746884b21c25bf", "submitter": { "id": 2077, "url": "https://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1713397319-26135-16-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31775, "url": "https://patches.dpdk.org/api/series/31775/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31775", "date": "2024-04-17T23:41:45", "name": "remove use of VLAs for Windows built code", "version": 1, "mbox": "https://patches.dpdk.org/series/31775/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139472/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139472/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3847E43E97;\n\tThu, 18 Apr 2024 01:43:21 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C405B40A84;\n\tThu, 18 Apr 2024 01:42:22 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 2C576402E1\n for <dev@dpdk.org>; Thu, 18 Apr 2024 01:42:04 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id BC04220FD8AD; Wed, 17 Apr 2024 16:42:02 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com BC04220FD8AD", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1713397322;\n bh=HSj9HdJwnEdAtmEF/tDCq+jm99I0k05XS3lNL6ErPpk=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=m8pbkJySbQ3Y/OadvroSYk4j0GvKNQhMR3fNXC70i8CQWUA3+SIfsEcq/mgHo9b4W\n nDs4a5KgZ0x4A5fVWvcM/IPzGKnHr0fN+m/5AgJkU6Oa3RsoXMQYGSuk2kS7cp7V2+\n C5ePHE++wOY6Qw4UOtSlDKkDveQBWHOfW83Xx9KA=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Akhil Goyal <gakhil@marvell.com>, Aman Singh <aman.deep.singh@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Fan Zhang <fanzhang.oss@gmail.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jiayu Hu <hujiayu.hu@foxmail.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>, Suanming Mou <suanmingm@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Volodymyr Fialko <vfialko@marvell.com>, Yipeng Wang <yipeng1.wang@intel.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>", "Subject": "[PATCH 15/16] net/mlx5: remove use of VLAs for Windows built code", "Date": "Wed, 17 Apr 2024 16:41:58 -0700", "Message-Id": "<1713397319-26135-16-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "MSVC does not support VLAs, replace VLAs with standard C arrays\nor alloca(). alloca() is available for all toolchain/platform\ncombinations officially supported by DPDK.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n drivers/net/mlx5/mlx5.c | 5 ++---\n drivers/net/mlx5/mlx5_flow.c | 6 +++---\n 2 files changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex d1a6382..de16acf 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -1597,14 +1597,13 @@\n mlx5_rt_timestamp_config(struct mlx5_dev_ctx_shared *sh,\n \t\t\t struct mlx5_hca_attr *hca_attr)\n {\n-\tuint32_t dw_cnt = MLX5_ST_SZ_DW(register_mtutc);\n-\tuint32_t reg[dw_cnt];\n+\tuint32_t reg[MLX5_ST_SZ_DW(register_mtutc)];\n \tint ret = ENOTSUP;\n \n \tif (hca_attr->access_register_user)\n \t\tret = mlx5_devx_cmd_register_read(sh->cdev->ctx,\n \t\t\t\t\t\t MLX5_REGISTER_ID_MTUTC, 0,\n-\t\t\t\t\t\t reg, dw_cnt);\n+\t\t\t\t\t\t reg, RTE_DIM(reg));\n \tif (!ret) {\n \t\tuint32_t ts_mode;\n \ndiff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex f31fdfb..b52fb77 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -1476,8 +1476,8 @@ struct mlx5_flow_tunnel_info {\n \t\t\t\t\t \"mask/last without a spec is not\"\n \t\t\t\t\t \" supported\");\n \tif (item->spec && item->last && !range_accepted) {\n-\t\tuint8_t spec[size];\n-\t\tuint8_t last[size];\n+\t\tuint8_t *spec = alloca(size);\n+\t\tuint8_t *last = alloca(size);\n \t\tunsigned int i;\n \t\tint ret;\n \n@@ -8344,7 +8344,7 @@ struct mlx5_flow_workspace*\n \t\t\t.type = RTE_FLOW_ITEM_TYPE_END,\n \t\t},\n \t};\n-\tuint16_t queue[priv->reta_idx_n];\n+\tuint16_t *queue = alloca(sizeof(uint16_t) * priv->reta_idx_n);\n \tstruct rte_flow_action_rss action_rss = {\n \t\t.func = RTE_ETH_HASH_FUNCTION_DEFAULT,\n \t\t.level = 0,\n", "prefixes": [ "15/16" ] }