Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139461/?format=api
https://patches.dpdk.org/api/patches/139461/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1713397319-26135-3-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1713397319-26135-3-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1713397319-26135-3-git-send-email-roretzla@linux.microsoft.com", "date": "2024-04-17T23:41:45", "name": "[02/16] hash: remove use of VLAs for Windows built code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8219bc42f6d684675ca7132d5a9c6fafee1bf228", "submitter": { "id": 2077, "url": "https://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1713397319-26135-3-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31775, "url": "https://patches.dpdk.org/api/series/31775/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31775", "date": "2024-04-17T23:41:45", "name": "remove use of VLAs for Windows built code", "version": 1, "mbox": "https://patches.dpdk.org/series/31775/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139461/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139461/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5A2BF43E97;\n\tThu, 18 Apr 2024 01:42:05 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3618C402E3;\n\tThu, 18 Apr 2024 01:42:04 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id BDA7040272\n for <dev@dpdk.org>; Thu, 18 Apr 2024 01:42:02 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id EF75220FD4CB; Wed, 17 Apr 2024 16:42:01 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com EF75220FD4CB", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1713397321;\n bh=VX1JW+TCNJFvDGb5Nd5z00eVBNn2wuTDEyeJ3OyqkYs=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=dg6CDCE7atTW+pi65MhG1OiHGMjqDOWYW9IcFMQJ8XB6n+pG6D92o02Sudul6AK9k\n shbc7Vj7wp6HUtVsJ6iDkB+dQR6sW5E56s66SaB/3MleBk2is/2SXTLb9XoQCGaU6y\n 3ESl8/C62aIRgHEjvEBT6hpDvy1c3mlrZcvpLI+4=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Akhil Goyal <gakhil@marvell.com>, Aman Singh <aman.deep.singh@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Fan Zhang <fanzhang.oss@gmail.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jiayu Hu <hujiayu.hu@foxmail.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>, Suanming Mou <suanmingm@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Volodymyr Fialko <vfialko@marvell.com>, Yipeng Wang <yipeng1.wang@intel.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>", "Subject": "[PATCH 02/16] hash: remove use of VLAs for Windows built code", "Date": "Wed, 17 Apr 2024 16:41:45 -0700", "Message-Id": "<1713397319-26135-3-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "MSVC does not support VLAs, replace VLAs with standard C arrays\nor alloca(). alloca() is available for all toolchain/platform\ncombinations officially supported by DPDK.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/hash/rte_cuckoo_hash.c | 4 ++--\n lib/hash/rte_thash.c | 2 +-\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c\nindex 9cf9464..bd2ff08 100644\n--- a/lib/hash/rte_cuckoo_hash.c\n+++ b/lib/hash/rte_cuckoo_hash.c\n@@ -2359,7 +2359,7 @@ struct rte_hash *\n \t\t\t(num_keys > RTE_HASH_LOOKUP_BULK_MAX) ||\n \t\t\t(hit_mask == NULL)), -EINVAL);\n \n-\tint32_t positions[num_keys];\n+\tint32_t *positions = alloca(sizeof(int32_t) * num_keys);\n \n \t__rte_hash_lookup_bulk(h, keys, num_keys, positions, hit_mask, data);\n \n@@ -2475,7 +2475,7 @@ struct rte_hash *\n \t\t\t(num_keys > RTE_HASH_LOOKUP_BULK_MAX) ||\n \t\t\t(hit_mask == NULL)), -EINVAL);\n \n-\tint32_t positions[num_keys];\n+\tint32_t *positions = alloca(sizeof(int32_t) * num_keys);\n \n \t__rte_hash_lookup_with_hash_bulk(h, keys, sig, num_keys,\n \t\t\tpositions, hit_mask, data);\ndiff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c\nindex 68f653f..633e211 100644\n--- a/lib/hash/rte_thash.c\n+++ b/lib/hash/rte_thash.c\n@@ -771,7 +771,7 @@ struct rte_thash_subtuple_helper *\n \tuint32_t desired_value,\tunsigned int attempts,\n \trte_thash_check_tuple_t fn, void *userdata)\n {\n-\tuint32_t tmp_tuple[tuple_len / sizeof(uint32_t)];\n+\tuint32_t *tmp_tuple = alloca(tuple_len);\n \tunsigned int i, j, ret = 0;\n \tuint32_t hash, adj_bits;\n \tconst uint8_t *hash_key;\n", "prefixes": [ "02/16" ] }{ "id": 139461, "url": "