Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139459/?format=api
{ "id": 139459, "url": "https://patches.dpdk.org/api/patches/139459/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240417170908.76701-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240417170908.76701-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240417170908.76701-5-stephen@networkplumber.org", "date": "2024-04-17T17:07:26", "name": "[v3,4/5] latencystats: fix log messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "191ff4ed18bfbf106652b773e34142b88ed65e32", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240417170908.76701-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 31774, "url": "https://patches.dpdk.org/api/series/31774/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31774", "date": "2024-04-17T17:07:22", "name": "latencystats: cleanups", "version": 3, "mbox": "https://patches.dpdk.org/series/31774/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139459/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139459/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5606A43E94;\n\tWed, 17 Apr 2024 19:09:38 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A9E174281D;\n\tWed, 17 Apr 2024 19:09:19 +0200 (CEST)", "from mail-pl1-f180.google.com (mail-pl1-f180.google.com\n [209.85.214.180])\n by mails.dpdk.org (Postfix) with ESMTP id 80A4D427D9\n for <dev@dpdk.org>; Wed, 17 Apr 2024 19:09:14 +0200 (CEST)", "by mail-pl1-f180.google.com with SMTP id\n d9443c01a7336-1e5b6e8f662so44721795ad.0\n for <dev@dpdk.org>; Wed, 17 Apr 2024 10:09:14 -0700 (PDT)", "from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n l5-20020a170903120500b001e4458831afsm11832442plh.227.2024.04.17.10.09.13\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 17 Apr 2024 10:09:13 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1713373754;\n x=1713978554; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=dONGRsVr9t79ONbmDKjHuRqpBb+5qzOoIok5RkRuGXE=;\n b=fdw5Hb9epOUcsGKD/PO8HmoOOhFHr9ZrdiGaTVtfocCtyMx/KciZuVh0r9Ad1mDs9P\n hGC0HlqtnEnII7gTXJONZO3jg8yjJUb6so7FTEFcOPM2UGkjcqp61JXevjgx5NKKdGom\n 1LSQFIFPtQ8RksCrddnwAqYXaLrjHMAF7s1bKPDlm1jl2dFRn0quNZJTQFOl/e0ip0rS\n MTdHY7pwSvJpEln9iCUaahM+R4rPOD5rbpfGQdzta2b9z05CP1X5CGIRIWY0uJGZJCA7\n KY6g58nw33maojXF0/ycZaNmuYpJW2JdJvZShtitHOMuNxpnrU+zrjhiGA1ygu0jL1tH\n 38tg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1713373754; x=1713978554;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=dONGRsVr9t79ONbmDKjHuRqpBb+5qzOoIok5RkRuGXE=;\n b=cxVfnqn5gcgcG90CWFXkkriAsAtig4Mhq5gGG5zZ56hxYSCbyFm5g0KTugFCxWPuhY\n noPOYByPG7ViRXeUA/Q8QPEwGjsJS5z29xgbjmqT4G5IFYe7W/gNOBN7mJ7iUOGCv1Es\n pqdW082hrdi7jyLoLIfeuudrQzhan4pjdh1wYQVhSk2jzPcdpDrpQeh9odjfjHeLxYHu\n vbd+hjWoPoCoBkuxlMk5TDhWPlco0SILeoAfdEICo8qvaWVgGdtkwJEK8olEOdkOKlNX\n upPWKwT2LN+O9Ha/age0Aw4b2qlEI61h8Qx/4T/6gou3lhP8Rs56sHGQkDlhr/qhIG6V\n M1UQ==", "X-Gm-Message-State": "AOJu0YzMGHTWWxbKxpMkXwzY5+B77CKt69fUU+YCnwkRAjMOrwssQW+q\n OyZHuOz6ZkciNLBbD+PyDZ0osY17XSLZFob8VIuxxhdD5wWvWRrGbok43QNOjJHmcSWmYw3GZ4p\n C", "X-Google-Smtp-Source": "\n AGHT+IHqRU+AVpdZbh8EhvI7ClewaJbOdtZk3JOmKt0oGDDvC4SgkFA3NlVa0izH6hc8I9kpzWeLRg==", "X-Received": "by 2002:a17:902:7b82:b0:1e6:413:9df1 with SMTP id\n w2-20020a1709027b8200b001e604139df1mr71465pll.41.1713373753773;\n Wed, 17 Apr 2024 10:09:13 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Reshma Pattan <reshma.pattan@intel.com>", "Subject": "[PATCH v3 4/5] latencystats: fix log messages", "Date": "Wed, 17 Apr 2024 10:07:26 -0700", "Message-ID": "<20240417170908.76701-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240417170908.76701-1-stephen@networkplumber.org>", "References": "<0240408195036.182545-1-stephen@networkplumber.org>\n <20240417170908.76701-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "All messages that because of an error should be at log level\nNOTICE or above. Do not break log messages across lines.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/latencystats/rte_latencystats.c | 30 ++++++++++++++---------------\n 1 file changed, 15 insertions(+), 15 deletions(-)", "diff": "diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c\nindex 11bd0ea4ae..62038a9f5d 100644\n--- a/lib/latencystats/rte_latencystats.c\n+++ b/lib/latencystats/rte_latencystats.c\n@@ -235,7 +235,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \tlatency_stats_index = rte_metrics_reg_names(ptr_strings,\n \t\t\t\t\t\t\tNUM_LATENCY_STATS);\n \tif (latency_stats_index < 0) {\n-\t\tLATENCY_STATS_LOG(DEBUG,\n+\t\tLATENCY_STATS_LOG(ERR,\n \t\t\t\"Failed to register latency stats names\");\n \t\treturn -1;\n \t}\n@@ -255,7 +255,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \n \t\tret = rte_eth_dev_info_get(pid, &dev_info);\n \t\tif (ret != 0) {\n-\t\t\tLATENCY_STATS_LOG(INFO,\n+\t\t\tLATENCY_STATS_LOG(NOTICE,\n \t\t\t\t\"Error during getting device (port %u) info: %s\",\n \t\t\t\tpid, strerror(-ret));\n \n@@ -267,18 +267,18 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \t\t\tcbs->cb = rte_eth_add_first_rx_callback(pid, qid,\n \t\t\t\t\tadd_time_stamps, user_cb);\n \t\t\tif (!cbs->cb)\n-\t\t\t\tLATENCY_STATS_LOG(INFO, \"Failed to \"\n-\t\t\t\t\t\"register Rx callback for pid=%d, \"\n-\t\t\t\t\t\"qid=%d\", pid, qid);\n+\t\t\t\tLATENCY_STATS_LOG(NOTICE,\n+\t\t\t\t\t\"Failed to register Rx callback for pid=%u, qid=%u\",\n+\t\t\t\t\tpid, qid);\n \t\t}\n \t\tfor (qid = 0; qid < dev_info.nb_tx_queues; qid++) {\n \t\t\tcbs = &tx_cbs[pid][qid];\n \t\t\tcbs->cb = rte_eth_add_tx_callback(pid, qid,\n \t\t\t\t\tcalc_latency, user_cb);\n \t\t\tif (!cbs->cb)\n-\t\t\t\tLATENCY_STATS_LOG(INFO, \"Failed to \"\n-\t\t\t\t\t\"register Tx callback for pid=%d, \"\n-\t\t\t\t\t\"qid=%d\", pid, qid);\n+\t\t\t\tLATENCY_STATS_LOG(NOTICE,\n+\t\t\t\t\t\"Failed to register Tx callback for pid=%u, qid=%u\",\n+\t\t\t\t\tpid, qid);\n \t\t}\n \t}\n \treturn 0;\n@@ -299,7 +299,7 @@ rte_latencystats_uninit(void)\n \n \t\tret = rte_eth_dev_info_get(pid, &dev_info);\n \t\tif (ret != 0) {\n-\t\t\tLATENCY_STATS_LOG(INFO,\n+\t\t\tLATENCY_STATS_LOG(NOTICE,\n \t\t\t\t\"Error during getting device (port %u) info: %s\",\n \t\t\t\tpid, strerror(-ret));\n \n@@ -310,17 +310,17 @@ rte_latencystats_uninit(void)\n \t\t\tcbs = &rx_cbs[pid][qid];\n \t\t\tret = rte_eth_remove_rx_callback(pid, qid, cbs->cb);\n \t\t\tif (ret)\n-\t\t\t\tLATENCY_STATS_LOG(INFO, \"failed to \"\n-\t\t\t\t\t\"remove Rx callback for pid=%d, \"\n-\t\t\t\t\t\"qid=%d\", pid, qid);\n+\t\t\t\tLATENCY_STATS_LOG(NOTICE,\n+\t\t\t\t\t\"Failed to remove Rx callback for pid=%u, qid=%u\",\n+\t\t\t\t\tpid, qid);\n \t\t}\n \t\tfor (qid = 0; qid < dev_info.nb_tx_queues; qid++) {\n \t\t\tcbs = &tx_cbs[pid][qid];\n \t\t\tret = rte_eth_remove_tx_callback(pid, qid, cbs->cb);\n \t\t\tif (ret)\n-\t\t\t\tLATENCY_STATS_LOG(INFO, \"failed to \"\n-\t\t\t\t\t\"remove Tx callback for pid=%d, \"\n-\t\t\t\t\t\"qid=%d\", pid, qid);\n+\t\t\t\tLATENCY_STATS_LOG(NOTICE,\n+\t\t\t\t\t\"Failed to remove Tx callback for pid=%u, qid=%u\",\n+\t\t\t\t\tpid, qid);\n \t\t}\n \t}\n \n", "prefixes": [ "v3", "4/5" ] }