Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1394/?format=api
https://patches.dpdk.org/api/patches/1394/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1416493033-13450-1-git-send-email-sergio.gonzalez.monroy@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1416493033-13450-1-git-send-email-sergio.gonzalez.monroy@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1416493033-13450-1-git-send-email-sergio.gonzalez.monroy@intel.com", "date": "2014-11-20T14:17:13", "name": "[dpdk-dev] cmdline: Fix broken functionality in FreeBSD", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3f20b9834e34dd366e93cc0327c7b3852278e356", "submitter": { "id": 73, "url": "https://patches.dpdk.org/api/people/73/?format=api", "name": "Sergio Gonzalez Monroy", "email": "sergio.gonzalez.monroy@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1416493033-13450-1-git-send-email-sergio.gonzalez.monroy@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1394/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1394/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id F316C7F11;\n\tThu, 20 Nov 2014 15:06:48 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id D3B4E7F0C\n\tfor <dev@dpdk.org>; Thu, 20 Nov 2014 15:06:46 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP; 20 Nov 2014 06:15:03 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga001.jf.intel.com with ESMTP; 20 Nov 2014 06:17:15 -0800", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tsAKEHEHh011458 for <dev@dpdk.org>; Thu, 20 Nov 2014 14:17:14 GMT", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id sAKEHDkA013488\n\tfor <dev@dpdk.org>; Thu, 20 Nov 2014 14:17:13 GMT", "(from smonroy@localhost)\n\tby sivswdev02.ir.intel.com with id sAKEHDak013484\n\tfor dev@dpdk.org; Thu, 20 Nov 2014 14:17:13 GMT" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,424,1413270000\"; d=\"scan'208\";a=\"611122588\"", "From": "Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 20 Nov 2014 14:17:13 +0000", "Message-Id": "<1416493033-13450-1-git-send-email-sergio.gonzalez.monroy@intel.com>", "X-Mailer": "git-send-email 1.8.5.4", "Subject": "[dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some features of the cmdline were broken in FreeBSD as a result of\ntermios not being compiled.\n\nSigned-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>\n---\n lib/librte_cmdline/cmdline.h | 2 --\n lib/librte_cmdline/cmdline_socket.c | 10 +---------\n 2 files changed, 1 insertion(+), 11 deletions(-)", "diff": "diff --git a/lib/librte_cmdline/cmdline.h b/lib/librte_cmdline/cmdline.h\nindex 4c28d37..06ae086 100644\n--- a/lib/librte_cmdline/cmdline.h\n+++ b/lib/librte_cmdline/cmdline.h\n@@ -71,9 +71,7 @@ struct cmdline {\n \tcmdline_parse_ctx_t *ctx;\n \tstruct rdline rdl;\n \tchar prompt[RDLINE_PROMPT_SIZE];\n-#ifdef RTE_EXEC_ENV_LINUXAPP\n \tstruct termios oldterm;\n-#endif\n };\n \n struct cmdline *cmdline_new(cmdline_parse_ctx_t *ctx, const char *prompt, int s_in, int s_out);\ndiff --git a/lib/librte_cmdline/cmdline_socket.c b/lib/librte_cmdline/cmdline_socket.c\nindex b51b537..6820b6d 100644\n--- a/lib/librte_cmdline/cmdline_socket.c\n+++ b/lib/librte_cmdline/cmdline_socket.c\n@@ -93,7 +93,6 @@ struct cmdline *\n cmdline_stdin_new(cmdline_parse_ctx_t *ctx, const char *prompt)\n {\n \tstruct cmdline *cl;\n-#ifdef RTE_EXEC_ENV_LINUXAPP\n \tstruct termios oldterm, term;\n \n \ttcgetattr(0, &oldterm);\n@@ -101,14 +100,12 @@ cmdline_stdin_new(cmdline_parse_ctx_t *ctx, const char *prompt)\n \tterm.c_lflag &= ~(ICANON | ECHO | ISIG);\n \ttcsetattr(0, TCSANOW, &term);\n \tsetbuf(stdin, NULL);\n-#endif\n \n \tcl = cmdline_new(ctx, prompt, 0, 1);\n \n-#ifdef RTE_EXEC_ENV_LINUXAPP\n \tif (cl)\n \t\tmemcpy(&cl->oldterm, &oldterm, sizeof(term));\n-#endif\n+\n \treturn cl;\n }\n \n@@ -118,10 +115,5 @@ cmdline_stdin_exit(struct cmdline *cl)\n \tif (!cl)\n \t\treturn;\n \n-#ifdef RTE_EXEC_ENV_LINUXAPP\n \ttcsetattr(fileno(stdin), TCSANOW, &cl->oldterm);\n-#else\n-\t/* silent the compiler */\n-\t(void)cl;\n-#endif\n }\n", "prefixes": [ "dpdk-dev" ] }{ "id": 1394, "url": "