Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139274/?format=api
{ "id": 139274, "url": "https://patches.dpdk.org/api/patches/139274/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240412125249.10625-5-VenkatKumar.Ande@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240412125249.10625-5-VenkatKumar.Ande@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240412125249.10625-5-VenkatKumar.Ande@amd.com", "date": "2024-04-12T12:52:30", "name": "[05/24] net/axgbe: remove unnecessary conversion to bool", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "95ae30e1db17abf6c5d53c6a8b1430e54b125fa7", "submitter": { "id": 3256, "url": "https://patches.dpdk.org/api/people/3256/?format=api", "name": "Venkat Kumar Ande", "email": "venkatkumar.ande@amd.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240412125249.10625-5-VenkatKumar.Ande@amd.com/mbox/", "series": [ { "id": 31734, "url": "https://patches.dpdk.org/api/series/31734/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31734", "date": "2024-04-12T12:52:26", "name": "[01/24] net/axgbe: remove use of comm_owned field", "version": 1, "mbox": "https://patches.dpdk.org/series/31734/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139274/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139274/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 06E4A43E52;\n\tFri, 12 Apr 2024 15:00:21 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CA2A0402A2;\n\tFri, 12 Apr 2024 15:00:20 +0200 (CEST)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2067.outbound.protection.outlook.com [40.107.94.67])\n by mails.dpdk.org (Postfix) with ESMTP id 9BAD5400D6\n for <dev@dpdk.org>; Fri, 12 Apr 2024 15:00:19 +0200 (CEST)", "from BLAPR03CA0003.namprd03.prod.outlook.com (2603:10b6:208:32b::8)\n by PH7PR12MB9101.namprd12.prod.outlook.com (2603:10b6:510:2f9::21)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 12 Apr\n 2024 12:53:46 +0000", "from BL6PEPF00020E60.namprd04.prod.outlook.com\n (2603:10b6:208:32b:cafe::9c) by BLAPR03CA0003.outlook.office365.com\n (2603:10b6:208:32b::8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.19 via Frontend\n Transport; Fri, 12 Apr 2024 12:53:45 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n BL6PEPF00020E60.mail.protection.outlook.com (10.167.249.21) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 12:53:44 +0000", "from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr\n 2024 07:53:43 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=ejA0PHmYdlbZ3UNZDd8+LLk9RS35+MFSFf+Prr+mWvdBnRVZUKObrsxRNP2OhNpBLPdX2uZC+VUGclH9lkw0ZCRS2z/oooQW0i9Q9LrrinurHeBDFA4oBzW5vzc97gFOk0nVorDmE8pUFnaF9fx6yZwbfI83+mZhH4F9fKxjsR+CMCY+pvvIlWXjnvVfpikI3tW0NO+XGa5j9xYprTOQSsqKFsHvZ09sDXaTieB5YNj+vqYUq9N9k/WevD2b20fSJI23qOUzMxKwoGPVJom4EszSHH8XPeFEyDFbEJscKbNlMuWT3q4OnbPzkQD51jC6jlw4ZaUQkDfjjV3svYNVKg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=KRmS7u7iGKzJv2B71cAVVC0lSup8IQYEqkJyeJ1L96k=;\n b=jZg2Ev8DzQqx35EUNzKETVSWMni958itpixcP9o4W2Fds9gaAvaCZle5p8GcXScAFfn0G31p/eQV7n7KGyPvRf3qC3yhcqB9Y/M1bwHU+r9CxhMjtY7OqqjoBV/MYj8vG4Tubj5USBOX1pCvXVHEK4n0k78pKKX2+7xXPBqbIG+ToRnWpU7xGjc2fArGbBhOAfsKoyL6YN6rq9fIMfkszAA2zctUJPHKV2b11+oAIKRiqPK2nUv49zK0HUbyH7niPcdHvF/99RNGpBjZ8DgODcbPVu6E/KyRuRz6bglbe9yx6XtXum91YT09F8mFpdDwmhMO4p0qHzMD9GB5KCvORQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=KRmS7u7iGKzJv2B71cAVVC0lSup8IQYEqkJyeJ1L96k=;\n b=jq9mhKxfsI4WJGltSokZ/UHNX7tI5t97JIYZOA36nqCQEXMZ4XVR8k0vCob7D7qXY54plGdo4l4zJLH79AUoInfp2W1Ux3yxdOOKSNe7gZ1XtiJ6Z1Nf2Vd8cJTLP/yvK23xq1vmXtS8Vq7Us9Q2TH+DEWN6+nu6kiFS3702U3I=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Venkat Kumar Ande <VenkatKumar.Ande@amd.com>", "To": "<dev@dpdk.org>", "CC": "<Selwin.Sebastian@amd.com>, Venkat Kumar Ande <VenkatKumar.Ande@amd.com>", "Subject": "[PATCH 05/24] net/axgbe: remove unnecessary conversion to bool", "Date": "Fri, 12 Apr 2024 08:52:30 -0400", "Message-ID": "<20240412125249.10625-5-VenkatKumar.Ande@amd.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240412125249.10625-1-VenkatKumar.Ande@amd.com>", "References": "<20240412125249.10625-1-VenkatKumar.Ande@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BL6PEPF00020E60:EE_|PH7PR12MB9101:EE_", "X-MS-Office365-Filtering-Correlation-Id": "ed6d51cf-1e7d-4e93-9e16-08dc5aef9693", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n E5woaEBJm7sRnsNaVRO5NYUwPMQOnvWpxCKAgCkd/uke35cpJAQ+iPppEwlkdRmWUUfMlZ2MsKqe3ZAkCu/wDOb4WfTN4IiznipP9YlSB7lVSUuzxf34Nqw0ZRV8MhfCe2iwEMzrpbtYE4rmxgeQT3ADZWhS5SW20je2Su4r/f6zw8zBwLBja2ppi4x8XeIY6EeUyrCCSyYSAgXOp1yKlcDmS7ozvbA2rC2HqKI8pbg9D2+ubO88WYA+3pWqXRmdoa7HYnqtQl9J3pi2EKMMDLPFTD4O0vLD9I/gLMgLLdHlt3Bjktw8paqjFq62LI8K2TroIELGBVxb5RrePhAvDGXDw3fgC6WZbE8Nj6F6Y/bCRQVmzjOj032yaZTx7+t5WPaXFTjbIXrkKipNG5mMLTjN0xhRCFXf5QOfAlw8wtkLOzTQoS/9uUJEojArf7pLChHO/q3KnAlSKKqhZCrJ+PKaUZExcbKg8bicmfCItJqtg6My/ZFc0PItl/wQs5PFZZl6xUuqDYBbuFPjyijFoS0kHeePN2+U6qdXOpmqwgLABKtdl6uMY9j40uO2TEVwHZIUKjJEkAp0IeCQ6kJoCLeJDmcfjzBXOYRHH7uR8gpK92GqHgJCJFugT6ZIBF4c6YFhMUX36Emyq2KqaE5DNgfuhMlrSik/HUrMXc3iRMzwtp3L4E7XUcU3ximWjiPoyalaHlpQNCQkMp6/Jp8ZMvS2IH1EwJnthLimfYD8bOHVUhOP1iWZ6DWj8KooOmNe", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(1800799015)(376005)(36860700004)(82310400014); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "12 Apr 2024 12:53:44.9239 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n ed6d51cf-1e7d-4e93-9e16-08dc5aef9693", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BL6PEPF00020E60.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH7PR12MB9101", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The conversion to bool is not needed, remove it.\n\nSigned-off-by: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>\n---\n drivers/net/axgbe/axgbe_phy_impl.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c\nindex 5acccf9146..b5796b13e0 100644\n--- a/drivers/net/axgbe/axgbe_phy_impl.c\n+++ b/drivers/net/axgbe/axgbe_phy_impl.c\n@@ -657,7 +657,7 @@ static bool axgbe_phy_sfp_verify_eeprom(uint8_t cc_in, uint8_t *buf,\n \tfor (cc = 0; len; buf++, len--)\n \t\tcc += *buf;\n \n-\treturn (cc == cc_in) ? true : false;\n+\treturn cc == cc_in;\n }\n \n static int axgbe_phy_sfp_read_eeprom(struct axgbe_port *pdata)\n", "prefixes": [ "05/24" ] }