Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139265/?format=api
{ "id": 139265, "url": "https://patches.dpdk.org/api/patches/139265/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240412125249.10625-15-VenkatKumar.Ande@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240412125249.10625-15-VenkatKumar.Ande@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240412125249.10625-15-VenkatKumar.Ande@amd.com", "date": "2024-04-12T12:52:40", "name": "[15/24] net/axgbe: check only the minimum speed for cables", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "2ab07ace9e1380907ce659537ee8eb8092848b62", "submitter": { "id": 3256, "url": "https://patches.dpdk.org/api/people/3256/?format=api", "name": "Venkat Kumar Ande", "email": "venkatkumar.ande@amd.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240412125249.10625-15-VenkatKumar.Ande@amd.com/mbox/", "series": [ { "id": 31734, "url": "https://patches.dpdk.org/api/series/31734/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31734", "date": "2024-04-12T12:52:26", "name": "[01/24] net/axgbe: remove use of comm_owned field", "version": 1, "mbox": "https://patches.dpdk.org/series/31734/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139265/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139265/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5C97843E52;\n\tFri, 12 Apr 2024 14:55:18 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D3EF442D26;\n\tFri, 12 Apr 2024 14:54:25 +0200 (CEST)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2047.outbound.protection.outlook.com [40.107.223.47])\n by mails.dpdk.org (Postfix) with ESMTP id 1DA9E42D66\n for <dev@dpdk.org>; Fri, 12 Apr 2024 14:54:24 +0200 (CEST)", "from BL0PR05CA0020.namprd05.prod.outlook.com (2603:10b6:208:91::30)\n by IA1PR12MB8309.namprd12.prod.outlook.com (2603:10b6:208:3fe::8)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 12 Apr\n 2024 12:54:18 +0000", "from BL6PEPF00020E5F.namprd04.prod.outlook.com\n (2603:10b6:208:91:cafe::97) by BL0PR05CA0020.outlook.office365.com\n (2603:10b6:208:91::30) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.13 via Frontend\n Transport; Fri, 12 Apr 2024 12:54:18 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n BL6PEPF00020E5F.mail.protection.outlook.com (10.167.249.20) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 12:54:18 +0000", "from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr\n 2024 07:54:07 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=kkQ3B+yMbZVFZelQnOPQHkHWWbGA4XJwiAaEKKwnYO0QuVfOCFrvIKOFwQuqbSALG/uHrZrBuKtqVfJFer98SAjZwfmv9kChADUaL0iuoRgav7wgLEnCaazxt3VRM1V1PDSNG8BWrGJMXix//jh+FyPlBHdq+ZoePVjXs3oCNOHJG/2ZvPdIgc6vhaZI0O9ZIEvHAoTIMnIhLVNs67MSWGnP+r5G34hrE16cccrwua2ibC2v5xyU4ENB623s1A/A8SZiJuRWbBt6CbMYgsN9XfwVXhtS7Ekf/X9immqHjk9/gbkYJNgHLUP8Y9Rwyi8NKHnbjoSHYCBINsj4tejlHw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=v/W6hg5/chTdlMxbhWM1XQ1OleLuvg2ljXH5WQzlqQI=;\n b=gpHSeoSElphkLsMByOXzTs6xAyrsugjXC0qP64h0hTTJOwGszf4dCDQUQ5Fktl3fX8PWVEvd/cIhs2vdDdRI6L+RsDVikHhc5RMnpcXR/CrdL+M1ZjxN3YfmRXyNbCLvM5UYzp2tLXAJi+NJDSo/8AHfqNT7eo2Jf2ITD5FIUWBAaCEcZACkmrM3nwg+q3JhAmJt0O2oSs35smEw7B18LNVFL9KMBeTTjr2SxYcvKEq4aYqUXFcnsciyuCgXQq4brzG5Sys0kRsCKnSq9nvy6ukWdwL2Mv5HLdTkRVn4byB8OIpEYX4EJjwRCqI/ts88Dvaaq5fUBb89ZARw7TItkQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=v/W6hg5/chTdlMxbhWM1XQ1OleLuvg2ljXH5WQzlqQI=;\n b=L5zlrTLUxFetx4a5HdZRuPgtDvwDnFGH9ZEWvKEL5Cu+q7wnCQbfsOZKtPdGTKqAmEMtnmSVl47WOyLvB7mqxDF6YqlValyMEDshnGXK+v0MZET3tG92VCr9b1SSMa63Aefn02K+w4/MzNDzy5ch9E28ovYsRlez8oudO/rWv+E=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Venkat Kumar Ande <VenkatKumar.Ande@amd.com>", "To": "<dev@dpdk.org>", "CC": "<Selwin.Sebastian@amd.com>, Venkat Kumar Ande <VenkatKumar.Ande@amd.com>", "Subject": "[PATCH 15/24] net/axgbe: check only the minimum speed for cables", "Date": "Fri, 12 Apr 2024 08:52:40 -0400", "Message-ID": "<20240412125249.10625-15-VenkatKumar.Ande@amd.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240412125249.10625-1-VenkatKumar.Ande@amd.com>", "References": "<20240412125249.10625-1-VenkatKumar.Ande@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BL6PEPF00020E5F:EE_|IA1PR12MB8309:EE_", "X-MS-Office365-Filtering-Correlation-Id": "822937e5-f724-4d82-a610-08dc5aefaaab", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n TBNLDIGtEUCnhjlGo8NqUHvqpxARNg7RRGjwRml06DNTUdlIQ8YGC8x80GN1Znm7tiU6gn1Y14+VVstrFx80umt8h3bup0lbjzaU3Mj+rV6QDrMBtHD4NUGKeGgnARChxNSh0fMWjr3UDF1/qhNe7k5yluQbP/oYazTrxE1+OMOwspV+GoUDI+/+Tw8otYXe/4VPHTuw1loIJ6jbVQL+HTWbPOH0Af4vmoxCdJUNcgI8Vp93dQwgUmVP8D/jaDsDLMFzx5uE87HwBV/rEMUJcgygdFadQ213wA5/1eSuAsBvlBE2kMrqDg9uXapZWg5diJVRqS8OirLXfWVYp42yqPN3um/ma5LfIZUn5aPyb9ufGQp5EneH7T5/Vm/A1fWakPVlq4rR1Zp3eLA6KTPBnu86vMggm+O5ABUv7/ShBcKuu9Pveh6mareBNWEUo1cCAPky7ZchOtAXsaok2p7bE/0eHloFdMvfSlpHYBow4Ynm+un+n1/TetSZBeT5AOJD+Ep7kRLQtO5L76Eo87Ey/vScuvoJeGa3sBgbNurlJcIW5w6zIGejrVCw+4OKx451VwMuD3a/UKOSyrDfitb/fK7mLgsFSTINaf8glaYEfCFzAnregQXJ/HCVBR4Q4+XK5sMDl8f7F2BLvWzHT4IaFf+EqPMZFJIjy6N9lyDUBAP7yRGIqz2pTkaLZvxYdHE87WpX0wXeV/pJFwDeXD9M8ejYmByFCBNTt+hYjS1XnJX5TCei4H5ngx4liL96nE0H", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(376005)(82310400014)(1800799015)(36860700004); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "12 Apr 2024 12:54:18.6516 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 822937e5-f724-4d82-a610-08dc5aefaaab", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BL6PEPF00020E5F.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "IA1PR12MB8309", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "There are cables that exist that can support speeds in excess of 10GbE.\nThe driver, however, restricts the EEPROM advertised nominal bitrate to\na specific range, which can prevent usage of cables that can support,\nfor example, up to 25GbE.\n\nRather than checking that an active or passive cable supports a specific\nrange, only check for a minimum supported speed.\n\nSigned-off-by: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>\n---\n drivers/net/axgbe/axgbe_phy_impl.c | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c\nindex 693590da53..67a18e7c55 100644\n--- a/drivers/net/axgbe/axgbe_phy_impl.c\n+++ b/drivers/net/axgbe/axgbe_phy_impl.c\n@@ -117,9 +117,7 @@ enum axgbe_sfp_speed {\n \n #define AXGBE_SFP_BASE_BR\t\t\t12\n #define AXGBE_SFP_BASE_BR_1GBE_MIN\t\t0x0a\n-#define AXGBE_SFP_BASE_BR_1GBE_MAX\t\t0x0d\n #define AXGBE_SFP_BASE_BR_10GBE_MIN\t\t0x64\n-#define AXGBE_SFP_BASE_BR_10GBE_MAX\t\t0x68\n \n #define AXGBE_SFP_BASE_CU_CABLE_LEN\t\t18\n \n@@ -519,25 +517,22 @@ static void axgbe_phy_sfp_phy_settings(struct axgbe_port *pdata)\n static bool axgbe_phy_sfp_bit_rate(struct axgbe_sfp_eeprom *sfp_eeprom,\n \t\t\t\t enum axgbe_sfp_speed sfp_speed)\n {\n-\tu8 *sfp_base, min, max;\n+\tu8 *sfp_base, min;\n \n \tsfp_base = sfp_eeprom->base;\n \n \tswitch (sfp_speed) {\n \tcase AXGBE_SFP_SPEED_1000:\n \t\tmin = AXGBE_SFP_BASE_BR_1GBE_MIN;\n-\t\tmax = AXGBE_SFP_BASE_BR_1GBE_MAX;\n \t\tbreak;\n \tcase AXGBE_SFP_SPEED_10000:\n \t\tmin = AXGBE_SFP_BASE_BR_10GBE_MIN;\n-\t\tmax = AXGBE_SFP_BASE_BR_10GBE_MAX;\n \t\tbreak;\n \tdefault:\n \t\treturn false;\n \t}\n \n-\treturn ((sfp_base[AXGBE_SFP_BASE_BR] >= min) &&\n-\t\t(sfp_base[AXGBE_SFP_BASE_BR] <= max));\n+\treturn sfp_base[AXGBE_SFP_BASE_BR] >= min;\n }\n \n static void axgbe_phy_sfp_external_phy(struct axgbe_port *pdata)\n", "prefixes": [ "15/24" ] }