Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139263/?format=api
{ "id": 139263, "url": "https://patches.dpdk.org/api/patches/139263/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240412125249.10625-14-VenkatKumar.Ande@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240412125249.10625-14-VenkatKumar.Ande@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240412125249.10625-14-VenkatKumar.Ande@amd.com", "date": "2024-04-12T12:52:39", "name": "[14/24] net/axgbe: improve logic around active and passive cables", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "fa58ba54c6d71de30f23b5ceefc2e09bc21db8a2", "submitter": { "id": 3256, "url": "https://patches.dpdk.org/api/people/3256/?format=api", "name": "Venkat Kumar Ande", "email": "venkatkumar.ande@amd.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240412125249.10625-14-VenkatKumar.Ande@amd.com/mbox/", "series": [ { "id": 31734, "url": "https://patches.dpdk.org/api/series/31734/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31734", "date": "2024-04-12T12:52:26", "name": "[01/24] net/axgbe: remove use of comm_owned field", "version": 1, "mbox": "https://patches.dpdk.org/series/31734/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139263/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139263/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BCBC743E52;\n\tFri, 12 Apr 2024 14:55:02 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4602742B71;\n\tFri, 12 Apr 2024 14:54:22 +0200 (CEST)", "from NAM12-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam12on2048.outbound.protection.outlook.com [40.107.243.48])\n by mails.dpdk.org (Postfix) with ESMTP id A96514113D\n for <dev@dpdk.org>; Fri, 12 Apr 2024 14:54:20 +0200 (CEST)", "from BL0PR05CA0023.namprd05.prod.outlook.com (2603:10b6:208:91::33)\n by DM4PR12MB7696.namprd12.prod.outlook.com (2603:10b6:8:100::10) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 12 Apr\n 2024 12:54:17 +0000", "from BL6PEPF00020E5F.namprd04.prod.outlook.com\n (2603:10b6:208:91:cafe::7) by BL0PR05CA0023.outlook.office365.com\n (2603:10b6:208:91::33) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.11 via Frontend\n Transport; Fri, 12 Apr 2024 12:54:12 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n BL6PEPF00020E5F.mail.protection.outlook.com (10.167.249.20) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 12:54:12 +0000", "from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr\n 2024 07:54:05 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=oIj1kpz22poJSL89FraPI/p7YRuCXnu7fgAH9eiYjh761+DYOQvIeK7k3nnl35kfdT3w10om7PmfOicPlAlDf+dXM/46xnYsJHLp4BC+ZeibdElhDW3TcKKznKjmVv3MD75IL7pWAuV/G068q6GhFW7Sh816wwq5nbPHmCFwAwNfidUOCr3Jr51NTfL871V3bxjvjPJCVeUhUcjNZ+LDFYfqeptkAIGWGA4TpYwXbBX3ENO1LxxeBa5eRQqEtx3o/FoWbNeropJ3B9wdOCn4akrg7f5CCn3S3noF3nbwT3kUhHa8QV0Ln0cHJ0a11wHnE/WWCDnz4jQa7tqPdNS9tg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=8q318KTNcCFmozCYb8NPVHO2lBHfzFAcA0rX1jY/sRY=;\n b=PQzWkP3wVd4eRHu1k9nRvEws53HB+YbmUeRbJxvW2rjLZQ0WlxspfHHAyGvBet78K9GZFphW+sQxOESN3EY4sICNxNGKkgePG1mI1nahrlzKBLhL7jcYRJF15HlT6iMt77dYL8vr+3QM4xyKKLVjeNPtYBhmAKYzdKyChOPsaScGh1Rt6BiXS7mEVVdZ7VbrEgC7xY429170nvOYHeE7aqJDZzoTuVLDBZ4j2faRK7ZvS6PXziOLAqXoW6uQ8I129OlROnewQYcthC8WmhcMsymtTuEvXhYYmPOW/F2oCvG2dfisa7QDjdFu+QjMFNHDH7mS6SV9a0nMirA8X1EnUw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=8q318KTNcCFmozCYb8NPVHO2lBHfzFAcA0rX1jY/sRY=;\n b=lEPsjTj6czgjy4X9bBGvAMVFKvdu8mlTr62f4D+sXwyj4Ncg21wjzFWmM+nHGLhN7lDxGHsF+3l5GhakIJtVYXpjVc0OqlGB6wWd1ro9HAk5WZzUwPkCghxCyxDiuTnf8+qdp3h+YDWk1bAWB+r6ZAODoFX9/eHGcjp/1Q24uco=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Venkat Kumar Ande <VenkatKumar.Ande@amd.com>", "To": "<dev@dpdk.org>", "CC": "<Selwin.Sebastian@amd.com>, Venkat Kumar Ande <VenkatKumar.Ande@amd.com>", "Subject": "[PATCH 14/24] net/axgbe: improve logic around active and passive\n cables", "Date": "Fri, 12 Apr 2024 08:52:39 -0400", "Message-ID": "<20240412125249.10625-14-VenkatKumar.Ande@amd.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240412125249.10625-1-VenkatKumar.Ande@amd.com>", "References": "<20240412125249.10625-1-VenkatKumar.Ande@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BL6PEPF00020E5F:EE_|DM4PR12MB7696:EE_", "X-MS-Office365-Filtering-Correlation-Id": "d546e2a6-309b-4790-86a4-08dc5aefa6dc", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n GfPqq+HxX+1ra14itfxMwAiQ/iA0K1lhIZpnZr8wvUmK6isLYVEbONYBR4XF3fsTfgukiswEP7bVvgxwG/weE36HrRO6Gbha2pf98oSFf84cc/h3X1J80sR7KAQnQc9lenhTDJqrRQwM9zhJs+X2B7uurewHcy7ysQRd/13M09gbtTTOpjF7F8OjurV2sRczi2zovayZcF2mWCzWQMWe6pI9QM+34ADhiaxw8KKsj0JNPu7KZ8Fj4+3tqoDJoIVjQ1CPy7NYZk7cnx/aen6nuPlgNut+Iw3gmCJO7LTEDh9S9pYXItTkWep1/fLAR2AOgv6lzmzBWimul61qyavfs1f8K5Op36zKN15WuYjvqf7INX/BYYyK0+xgWHmVRDC+i1zmgdSm2elwsilldM7CMZu9UXC8SBPKFoU/bYLGniyNr+WmTBt0WG7IjipMjz1Bv+6LAqCUod/hiDIVDERLeHqeohCLft9sHDBRxKIJpv78sBthHBuujino0T8ca+Av/bJ/D90sy1KyBNVy+BeIq+gSlWDINzxgBHmaTY3XSC+Ym1B2iwr8yUQqrF8A6gSjshAbdoPxCQ+Vrle1oD4ACF6ZCusrrDDnMa3fJ/iyJYcGC8VNmY7/+K9PnJyRPK3QmT1ma9tpt9NzcHPLJoZs5UyGJRXE0Q4wXNBoWWu/9IH22exs4DwfEUPRksvJ2PUl14QPK/kvHSNJ9nV+wW5H4vevad8bFvSCHDAd8dRZ9Pyi/eJRFe3YSdiP1jfusz7N", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(82310400014)(36860700004)(1800799015)(376005); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "12 Apr 2024 12:54:12.2609 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n d546e2a6-309b-4790-86a4-08dc5aefa6dc", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BL6PEPF00020E5F.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM4PR12MB7696", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "SFP+ active and passive cables are copper cables with fixed SFP+ end\nconnectors. Due to a misinterpretation of this, SFP+ active cables could\nend up not being recognized, causing the driver to fail to establish a\nconnection.\n\nIntroduce a new enum in SFP+ cable types, XGBE_SFP_CABLE_FIBER, that is\nthe default cable type, and handle active and passive cables when they are\nspecifically detected.\n\nSigned-off-by: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>\n---\n drivers/net/axgbe/axgbe_phy_impl.c | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c\nindex b5b962151d..693590da53 100644\n--- a/drivers/net/axgbe/axgbe_phy_impl.c\n+++ b/drivers/net/axgbe/axgbe_phy_impl.c\n@@ -69,6 +69,7 @@ enum axgbe_sfp_cable {\n \tAXGBE_SFP_CABLE_UNKNOWN = 0,\n \tAXGBE_SFP_CABLE_ACTIVE,\n \tAXGBE_SFP_CABLE_PASSIVE,\n+\tAXGBE_SFP_CABLE_FIBER,\n };\n \n enum axgbe_sfp_base {\n@@ -601,16 +602,18 @@ static void axgbe_phy_sfp_parse_eeprom(struct axgbe_port *pdata)\n \n \taxgbe_phy_sfp_parse_quirks(pdata);\n \n-\t/* Assume ACTIVE cable unless told it is PASSIVE */\n+\t/* Assume FIBER cable unless told otherwise */\n \tif (sfp_base[AXGBE_SFP_BASE_CABLE] & AXGBE_SFP_BASE_CABLE_PASSIVE) {\n \t\tphy_data->sfp_cable = AXGBE_SFP_CABLE_PASSIVE;\n \t\tphy_data->sfp_cable_len = sfp_base[AXGBE_SFP_BASE_CU_CABLE_LEN];\n-\t} else {\n+\t} else if (sfp_base[AXGBE_SFP_BASE_CABLE] & AXGBE_SFP_BASE_CABLE_ACTIVE) {\n \t\tphy_data->sfp_cable = AXGBE_SFP_CABLE_ACTIVE;\n+\t} else {\n+\t\tphy_data->sfp_cable = AXGBE_SFP_CABLE_FIBER;\n \t}\n \n \t/* Determine the type of SFP */\n-\tif (phy_data->sfp_cable == AXGBE_SFP_CABLE_PASSIVE &&\n+\tif (phy_data->sfp_cable != AXGBE_SFP_CABLE_FIBER &&\n \t\t axgbe_phy_sfp_bit_rate(sfp_eeprom, AXGBE_SFP_SPEED_10000))\n \t\tphy_data->sfp_base = AXGBE_SFP_BASE_10000_CR;\n \telse if (sfp_base[AXGBE_SFP_BASE_10GBE_CC] & AXGBE_SFP_BASE_10GBE_CC_SR)\n", "prefixes": [ "14/24" ] }