Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139258/?format=api
{ "id": 139258, "url": "https://patches.dpdk.org/api/patches/139258/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240412125249.10625-10-VenkatKumar.Ande@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240412125249.10625-10-VenkatKumar.Ande@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240412125249.10625-10-VenkatKumar.Ande@amd.com", "date": "2024-04-12T12:52:35", "name": "[10/24] net/axgbe: yellow carp devices do not need rrc", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "a14fcf7b07f30f4e9bd543d3e1f423f1d788d6ac", "submitter": { "id": 3256, "url": "https://patches.dpdk.org/api/people/3256/?format=api", "name": "Venkat Kumar Ande", "email": "venkatkumar.ande@amd.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240412125249.10625-10-VenkatKumar.Ande@amd.com/mbox/", "series": [ { "id": 31734, "url": "https://patches.dpdk.org/api/series/31734/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31734", "date": "2024-04-12T12:52:26", "name": "[01/24] net/axgbe: remove use of comm_owned field", "version": 1, "mbox": "https://patches.dpdk.org/series/31734/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139258/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139258/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1A42743E52;\n\tFri, 12 Apr 2024 14:54:24 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6BB534161A;\n\tFri, 12 Apr 2024 14:54:12 +0200 (CEST)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2048.outbound.protection.outlook.com [40.107.94.48])\n by mails.dpdk.org (Postfix) with ESMTP id 169B24111C\n for <dev@dpdk.org>; Fri, 12 Apr 2024 14:54:10 +0200 (CEST)", "from MN2PR22CA0012.namprd22.prod.outlook.com (2603:10b6:208:238::17)\n by CYYPR12MB8752.namprd12.prod.outlook.com (2603:10b6:930:b9::13)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Fri, 12 Apr\n 2024 12:54:08 +0000", "from BL6PEPF00020E5F.namprd04.prod.outlook.com\n (2603:10b6:208:238:cafe::6c) by MN2PR22CA0012.outlook.office365.com\n (2603:10b6:208:238::17) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.26 via Frontend\n Transport; Fri, 12 Apr 2024 12:54:07 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n BL6PEPF00020E5F.mail.protection.outlook.com (10.167.249.20) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 12:54:07 +0000", "from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr\n 2024 07:53:55 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=hDnSEIUZ8yTt1TI83W0oc5Hxrd33HClZAGy3g3WlC+TNVzfNxIWruj34TZQrwmaYTROpXD8iEDt0zis274kBCYzfwYX2fZNqwpLVt2DwNT2xzZNKE4CX+786zvr2CCMLekyNwhrLy3tn21jahCPOmzfJBjKAo/IxA6pXlRxBgVLuIkEL67B35GcadmDTW/NTFHNh/6VfFxpR3P9v14cnlYOWLFs3KvMby+sRuTaWeuizFEgiZfdyqWW5fHB2qgwVMPvtcOQ0XXALMu7drfsnqhrZV49WbzbIK1KAEl66Rp+p2vzFGv2UpU/dW7thvsotPle2Zw7zpm0V7hIQy1COjA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=2WZOXDPrS4x72U1x4HTpEaLVlQA3G9mprAqMDhh2g4I=;\n b=bSm064ontDM/5yxcQ/8O+NdyE7xCUqWo3JFbUMS3N7C2uCj8F4O6+45144exmnXrBQP/oV6af1VFRKqWfMEQ10XGEAvpeukFRrxGnBCp2Iy33YEaLgE/yWCH1hnx5eLozZKxPSs9Sfs2MrDoP2TVgdslFHQqIXiuv8SLgYQmJMTezY3352AHnKiVDmnCReMKgxqvNL80UTks3/DbRJiAvpd8FPnHd5vOEuuRLQM7oGokafPQ2VmJvZifHNlQtkFdJUwt6bfx1HAEfOyev+a6fEG3GWfc7B4zfvQRdBMQ1N/zxAzaVS6jooS5hLy3Vzw4gCrB3+rX+ZBk7PRIm3H98Q==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=2WZOXDPrS4x72U1x4HTpEaLVlQA3G9mprAqMDhh2g4I=;\n b=1qM5OtiTBdYPgiI3DanzIEJ1i+q0hQjXd4BMoiyzg3szJafplYpoUF4ATFjuiLxT7yN/KIPHchZ2GAeovjDuguFIH4mKkaZUn03wqB3mbps2RdN9YaSsZHp3w4gtaxyHmq6eRfdO1+0gtd++vXqHa8QEcuzSxh9R5lry3/n1ecE=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Venkat Kumar Ande <VenkatKumar.Ande@amd.com>", "To": "<dev@dpdk.org>", "CC": "<Selwin.Sebastian@amd.com>, Venkat Kumar Ande <VenkatKumar.Ande@amd.com>", "Subject": "[PATCH 10/24] net/axgbe: yellow carp devices do not need rrc", "Date": "Fri, 12 Apr 2024 08:52:35 -0400", "Message-ID": "<20240412125249.10625-10-VenkatKumar.Ande@amd.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240412125249.10625-1-VenkatKumar.Ande@amd.com>", "References": "<20240412125249.10625-1-VenkatKumar.Ande@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BL6PEPF00020E5F:EE_|CYYPR12MB8752:EE_", "X-MS-Office365-Filtering-Correlation-Id": "a16021cc-7950-471a-f5c3-08dc5aefa440", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n e1AdY5FUWtY/vJKWHahWQkejsixUunrEKT4+Yx2XVOicEI28SpLSyuR0DplqZiX9RIcrhQ6BvoF/vNdyfRI5Tg/JtieeSazRKEiuPH+uFxsDYEqGa6bYaRPkclBWWDDp3qOM4kuAe0HY2zWmG7L/M1O2mSPCpj0JJXD7yQNEWLs8A2IGkBLptilXjOw09dVcK63GSi5z4J/jI+M1vORMuz/o5TFhC4mGrlWYaW/U6pDV3tqRT3gDR34bU2pBvK6RK5sAnqTBzcKYgMxlIHEcm8iLDa3n+vXNT/yigo53CYzQpmhRFpSh5bxXeZ9ABEG/qsjhXhtpdZWDT5wIddlvdQJg7RFJfufEW7n5LQh1fL+AlryzQ6Krd/m5rtBMqrnqo801u9AIx10p6LAoPqyNgxlWw2zaRCrnzcmSki7/O7fzl8cNJyXZ/Cgrc3BV4jrLRrm3ZdtvRy7RhUPxld2uNOeKun9LCsTSP45GCdU9rfu4AvOMY4vre/6WUdH16xyGT8h0hU1rdx0I3AZX0OsGTb738v/qVnAS0zFBl/HsYOiRr9M/+SfCty+MnBm3ZAr4YYuOm8UQUpv/CUJdwonXkuwhQIYbeq1i/TeSisZOBUUi5nGxi3NgRrq9TBTQYH6HUii7iVjkqctNZJi6/DCyJEz2FzowKw2qHZvDWVwfB23CAKWfMtgNqQ4/lXHL4b0QiNP5CFDfhDJJkzcp0f1KRGfuPUR6v7nOvDDBP/CfPdY46pYgijM1xWN29aUjPTT/", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(1800799015)(376005)(82310400014)(36860700004); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "12 Apr 2024 12:54:07.8703 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n a16021cc-7950-471a-f5c3-08dc5aefa440", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BL6PEPF00020E5F.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CYYPR12MB8752", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Link stability issues are noticed on Yellow carp platforms when Receiver\nReset Cycle is issued. Since the CDR workaround is disabled on these\nplatforms, the Receiver Reset Cycle is not needed.\n\nSo, avoid issuing rrc on Yellow carp platforms.\n\nSigned-off-by: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>\n---\n drivers/net/axgbe/axgbe_ethdev.c | 5 +++++\n drivers/net/axgbe/axgbe_ethdev.h | 1 +\n drivers/net/axgbe/axgbe_phy_impl.c | 2 +-\n 3 files changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c\nindex e5d8f7db02..86c2ec64e0 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.c\n+++ b/drivers/net/axgbe/axgbe_ethdev.c\n@@ -208,6 +208,7 @@ static struct axgbe_version_data axgbe_v2a = {\n \t.ecc_support\t\t\t= 1,\n \t.i2c_support\t\t\t= 1,\n \t.an_cdr_workaround\t\t= 1,\n+\t.enable_rrc\t\t\t= 1,\n };\n \n static struct axgbe_version_data axgbe_v2b = {\n@@ -220,6 +221,7 @@ static struct axgbe_version_data axgbe_v2b = {\n \t.ecc_support\t\t\t= 1,\n \t.i2c_support\t\t\t= 1,\n \t.an_cdr_workaround\t\t= 1,\n+\t.enable_rrc\t\t\t= 1,\n };\n \n static const struct rte_eth_desc_lim rx_desc_lim = {\n@@ -2269,6 +2271,9 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)\n \n \t\t\t/* Yellow Carp devices do not need cdr workaround */\n \t\t\tpdata->vdata->an_cdr_workaround = 0;\n+\n+\t\t\t/* Yellow Carp devices do not need rrc */\n+\t\t\tpdata->vdata->enable_rrc = 0;\n \t\t} else {\n \t\t\tunknown_cpu = 1;\n \t\t}\ndiff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_ethdev.h\nindex 924a26ebe3..469b3876c0 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.h\n+++ b/drivers/net/axgbe/axgbe_ethdev.h\n@@ -463,6 +463,7 @@ struct axgbe_version_data {\n \tunsigned int ecc_support;\n \tunsigned int i2c_support;\n \tunsigned int an_cdr_workaround;\n+\tunsigned int enable_rrc;\n };\n \n struct axgbe_mmc_stats {\ndiff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c\nindex 1ccb95334e..a58d51d606 100644\n--- a/drivers/net/axgbe/axgbe_phy_impl.c\n+++ b/drivers/net/axgbe/axgbe_phy_impl.c\n@@ -1687,7 +1687,7 @@ static int axgbe_phy_link_status(struct axgbe_port *pdata, int *an_restart)\n \t}\n \n \t/* No link, attempt a receiver reset cycle */\n-\tif (phy_data->rrc_count++) {\n+\tif (pdata->vdata->enable_rrc && phy_data->rrc_count++) {\n \t\tphy_data->rrc_count = 0;\n \t\taxgbe_phy_rrc(pdata);\n \t}\n", "prefixes": [ "10/24" ] }