Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139257/?format=api
{ "id": 139257, "url": "https://patches.dpdk.org/api/patches/139257/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240412125249.10625-9-VenkatKumar.Ande@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240412125249.10625-9-VenkatKumar.Ande@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240412125249.10625-9-VenkatKumar.Ande@amd.com", "date": "2024-04-12T12:52:34", "name": "[09/24] net/axgbe: disable interrupts during device removal", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "3accdb516724fc533d729c50bd8f1c011d2e2071", "submitter": { "id": 3256, "url": "https://patches.dpdk.org/api/people/3256/?format=api", "name": "Venkat Kumar Ande", "email": "venkatkumar.ande@amd.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240412125249.10625-9-VenkatKumar.Ande@amd.com/mbox/", "series": [ { "id": 31734, "url": "https://patches.dpdk.org/api/series/31734/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31734", "date": "2024-04-12T12:52:26", "name": "[01/24] net/axgbe: remove use of comm_owned field", "version": 1, "mbox": "https://patches.dpdk.org/series/31734/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139257/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139257/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4CA9043E52;\n\tFri, 12 Apr 2024 14:54:16 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2B90A410EA;\n\tFri, 12 Apr 2024 14:54:11 +0200 (CEST)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2055.outbound.protection.outlook.com [40.107.237.55])\n by mails.dpdk.org (Postfix) with ESMTP id A4A6741156\n for <dev@dpdk.org>; Fri, 12 Apr 2024 14:54:09 +0200 (CEST)", "from MN2PR22CA0018.namprd22.prod.outlook.com (2603:10b6:208:238::23)\n by IA1PR12MB7663.namprd12.prod.outlook.com (2603:10b6:208:424::18)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 12 Apr\n 2024 12:54:07 +0000", "from BL6PEPF00020E5F.namprd04.prod.outlook.com\n (2603:10b6:208:238:cafe::a9) by MN2PR22CA0018.outlook.office365.com\n (2603:10b6:208:238::23) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.26 via Frontend\n Transport; Fri, 12 Apr 2024 12:54:07 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n BL6PEPF00020E5F.mail.protection.outlook.com (10.167.249.20) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 12:54:07 +0000", "from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr\n 2024 07:53:53 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Tr4UFSpmESUdYH5YSSURI3Rxz6XgECzKregSjHKRXfKLWEyUhRY+nG1mDRir0vBJRKeO+VzfRoQpgrx6lCD1Ya/YuhUMUqeZ+Bc/k/gdm+/C3dBR6E5I51hzqPYg6JWFkHlRaqXPm72WXYtmTpTPo7e06inDYXG1ZhBV6sT3Tk/ShplX17ky1znKdLk33eIwXCoN786utQ94Ks8XQNbDNbUaLZq99P1wSM90DpoKyFrXAFEZ96b7jjAbqECbq2rR5rM1z7jHevJ/ErrI+L22Lsf8AN/6LwE9rcYr7Nc0Z+z2YJN5/3jO7AcgB+WAE/EHhoZ2r84yLzxFb44lALHc1Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=fNB1b7SJecYdKIebCXU75EI5K5FU9d4cDURpyhBaWBA=;\n b=mjMhOYpmrHOrRjj4QmNxc+zeoh851sigjo1YPSa2YYe4ZUPAI+ByjS7HDkLb803hiti+8uPjbhfuhtwDayhUehoN/s1QrLZZXjsLZCcuUeYGaOfsj1RynFBdTSuXGL5L7gi95bHqk3zG5mFKM6gRwB1o5sdwJOOW6/U2HkZypML8nE7+XKRNR0rThSvF+xy1T1TEJ+jUplZ5Df8b0HWqz9nyeaoVMtScHcL6JiVby6zDeFpZr1tOADHmdTzy7/eLzesPNY99LXJK3MzUywwxTMeWtZhHYJJPGR7XGJNtSUxko+bLPHjnnaCzu4nVvAozW9iCP0IA815XvgpmDxObjg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=fNB1b7SJecYdKIebCXU75EI5K5FU9d4cDURpyhBaWBA=;\n b=FQ/8UytSKlKN3qyiZPKiK0cNf0+EKl7olOvtpKoj0TT5S6/6/W0k6khl2TndG0FU9FEZJhFd4PQFXeMDP0ggtr6kyyPdMwjtp0gQOZ1lgJuAyfOBVibEbaiAAGcebFT4mivHErquKLGHeMnFFnsj6j5fkKY75xoUV/qcM53klOU=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Venkat Kumar Ande <VenkatKumar.Ande@amd.com>", "To": "<dev@dpdk.org>", "CC": "<Selwin.Sebastian@amd.com>, Venkat Kumar Ande <VenkatKumar.Ande@amd.com>", "Subject": "[PATCH 09/24] net/axgbe: disable interrupts during device removal", "Date": "Fri, 12 Apr 2024 08:52:34 -0400", "Message-ID": "<20240412125249.10625-9-VenkatKumar.Ande@amd.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240412125249.10625-1-VenkatKumar.Ande@amd.com>", "References": "<20240412125249.10625-1-VenkatKumar.Ande@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BL6PEPF00020E5F:EE_|IA1PR12MB7663:EE_", "X-MS-Office365-Filtering-Correlation-Id": "f8efd960-08a7-47cb-342d-08dc5aefa3fe", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n qW7dsoFV+V9X8hoYki18WFxWHHsH0YTSJJ4u0r+WJ1e01aCOS614kJFQUgEikoioOj27G6jPp4P0pkWWgAR55k5Gak2mC4kmBVruIfIlafW5zVwgbE/yArNPZJBzAzEFt6O32itEfnOzkqActtdELcsz0FUQk23+WN11h/h1urxYL3wPazhPS1fSAspuhgyAcU9ChScz2DqEmbU3EUM2QxwkmdThvsTH6Llb4XuyxfwPMnZvEhVLLcehe1VXISE1LDsSnyUefVJkaVq98OpkiWD8IVgrKgdQXDgsYaBOC7CUb6XQ8JTlzLDilP9UqVVasbvjMtCT1t2P8kNb+4Pos1pCEx+VT+ssCkXcuXWp32sDKEYOjLl3iia+oTiaVBbaCyzAzCj+xhKFffjWbAR/KNIVKy9rJZ9o2LYcVj+P1kD5Bgo7M+VSMJVP11VhuKUXYYnlLknkKNCefr4Z3qPjdd8eM6k6l9FtdoEtIoPRpci/s/+7fMEFmwNZCybhxcdTDAA/UfnN9a+2Jxksgl6r63bDOm2nWXPd+LyaAGzRiGxrPAxi1j/psF/fqp5nHu4CJpw0j8x8uveqG9kOcDbDK1hRlIg1GCBwn7WUQPO6IcyTbJSniLUVHaKxB7N+yWoNHLPsx3XYAOJAUyFDMb9Wswgk83SmkD/tpeljmQ4Jjb3R1WMS3V50rzdtqdYFyc2kOG7zXzn+OlS2hZC8Ntm2Q7BOvOmolrmkJYyX2eYNoAbBQEv03nmwwDwtLRkaoT8P", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(82310400014)(36860700004)(1800799015)(376005); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "12 Apr 2024 12:54:07.4328 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n f8efd960-08a7-47cb-342d-08dc5aefa3fe", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BL6PEPF00020E5F.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "IA1PR12MB7663", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Hardware interrupts are enabled during the init, however,\nthey are not disabled during close.\n\nDisable all hardware interrupts during close operation to avoid any\nissues.\n\nSigned-off-by: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>\n---\n drivers/net/axgbe/axgbe_ethdev.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c\nindex dd681f15a0..e5d8f7db02 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.c\n+++ b/drivers/net/axgbe/axgbe_ethdev.c\n@@ -2411,12 +2411,14 @@ static int\n axgbe_dev_close(struct rte_eth_dev *eth_dev)\n {\n \tstruct rte_pci_device *pci_dev;\n+\tstruct axgbe_port *pdata;\n \n \tPMD_INIT_FUNC_TRACE();\n \n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n \n+\tpdata = eth_dev->data->dev_private;\n \tpci_dev = RTE_DEV_TO_PCI(eth_dev->device);\n \taxgbe_dev_clear_queues(eth_dev);\n \n@@ -2426,6 +2428,9 @@ axgbe_dev_close(struct rte_eth_dev *eth_dev)\n \t\t\t\t axgbe_dev_interrupt_handler,\n \t\t\t\t (void *)eth_dev);\n \n+\t/* Disable all interrupts in the hardware */\n+\tXP_IOWRITE(pdata, XP_INT_EN, 0x0);\n+\n \treturn 0;\n }\n \n", "prefixes": [ "09/24" ] }