Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139252/?format=api
{ "id": 139252, "url": "https://patches.dpdk.org/api/patches/139252/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240412125249.10625-2-VenkatKumar.Ande@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240412125249.10625-2-VenkatKumar.Ande@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240412125249.10625-2-VenkatKumar.Ande@amd.com", "date": "2024-04-12T12:52:27", "name": "[02/24] net/axgbe: remove field of SFP diagnostic support", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "ce2f32886b2a2380257f084bfe4905e4d6d7172e", "submitter": { "id": 3256, "url": "https://patches.dpdk.org/api/people/3256/?format=api", "name": "Venkat Kumar Ande", "email": "venkatkumar.ande@amd.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240412125249.10625-2-VenkatKumar.Ande@amd.com/mbox/", "series": [ { "id": 31734, "url": "https://patches.dpdk.org/api/series/31734/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31734", "date": "2024-04-12T12:52:26", "name": "[01/24] net/axgbe: remove use of comm_owned field", "version": 1, "mbox": "https://patches.dpdk.org/series/31734/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139252/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139252/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9F35043E52;\n\tFri, 12 Apr 2024 14:53:27 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8DD9C410EA;\n\tFri, 12 Apr 2024 14:53:27 +0200 (CEST)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2045.outbound.protection.outlook.com [40.107.94.45])\n by mails.dpdk.org (Postfix) with ESMTP id 0F087410E8\n for <dev@dpdk.org>; Fri, 12 Apr 2024 14:53:26 +0200 (CEST)", "from BL1P223CA0002.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:2c4::7)\n by DS0PR12MB7874.namprd12.prod.outlook.com (2603:10b6:8:141::11) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 12 Apr\n 2024 12:53:23 +0000", "from BL6PEPF00020E64.namprd04.prod.outlook.com\n (2603:10b6:208:2c4:cafe::4) by BL1P223CA0002.outlook.office365.com\n (2603:10b6:208:2c4::7) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.26 via Frontend\n Transport; Fri, 12 Apr 2024 12:53:23 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n BL6PEPF00020E64.mail.protection.outlook.com (10.167.249.25) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 12:53:23 +0000", "from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr\n 2024 07:53:21 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=lTDeBg3ugMpdlvhCVmt9C5BZ/8IP/UNFJ1ATHroN2bGAQa1a7h4Kz0I4SK4ZV83cfg+J81x5Xk25C0Te+P9iYLuYuMQbyRkPjkZCEf2DoDsYGEHScNmUGvTQHeJMkvkws5gvtT+XNo1O9v0Gut3/VEktieeIR+4wDFk0cArLqo6FodmF2+rbKcpIRS5qyiXKwL8s/jhvV0xLl06HefzldNRn30QsFtQyDgUGSZVNVG9r1pSJc/uUY6g5neRnemYyugQKPLFMmqMD7byLYUWEXoX9JWchYFBJ4v+deutAzcnRjZeyql9C1t6e9fjiZGXUQyEv46XhxeDph6Dkye3vDQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=3deEJNjXTjoA0mdRdPf5pfTdaVfXk5kH92Oju3WV4ao=;\n b=DvC9Yk45kCDPrsNMDH+Xaq7BATkNxa4wi4mA06/a0MQXQeK8tapDnXCtWnho8QbMJnkkmfBZrK/GihsxJn4Xr9zez9K6LB88A6Ijp8iL/KGBqOAYHvVEYEExOF5HW+Tr9WCbXZlfnddlBjunCbg+tXMnsbmp9y/j+/xq6T6mrqnAE3Jnlxmm/63fDTJw9viNTEIQUfXwzvChjzdUdaI8cscMn/4B6d+eeHVff7FPEsgZpuhu2Bt3ZEIXP1xCXFCs/4Cho+r4ZENILsJFd1G2FTqj+bB4lfxMLD2XVKWeqLMObR1Jigm47Rz+6I6sjdSjj2AG5oP4a8TmbbPTcK7Saw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=3deEJNjXTjoA0mdRdPf5pfTdaVfXk5kH92Oju3WV4ao=;\n b=ZZrSi7p7T27KEGvK3egmmCHec+v29TWB47+JZAhZnpqX4F8E4eb+k/DxGFq3WGtSr19KrXbLfgTx4W0pkfNC7Ab8RN1FmX963YjQh3U5IyGw86poyNc+ktSlxa2MusHhk/5G+4te9zL/1LsKPMyjh2jaM8I1loTj9fXmXjszwho=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Venkat Kumar Ande <VenkatKumar.Ande@amd.com>", "To": "<dev@dpdk.org>", "CC": "<Selwin.Sebastian@amd.com>, Venkat Kumar Ande <VenkatKumar.Ande@amd.com>", "Subject": "[PATCH 02/24] net/axgbe: remove field of SFP diagnostic support", "Date": "Fri, 12 Apr 2024 08:52:27 -0400", "Message-ID": "<20240412125249.10625-2-VenkatKumar.Ande@amd.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240412125249.10625-1-VenkatKumar.Ande@amd.com>", "References": "<20240412125249.10625-1-VenkatKumar.Ande@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BL6PEPF00020E64:EE_|DS0PR12MB7874:EE_", "X-MS-Office365-Filtering-Correlation-Id": "08e2b9dd-6bee-4d8d-14c7-08dc5aef899f", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n dpO4JFSkPczAXhdRTlKTxMrEvJbtOTNgwoqm//yAw+VoFi0KY4utDC8Af5IU40lbPY62bto5F+3RZnz7dCflIuJrSrfx3zUKqHK7Nwx1s/+5NWNeOIlNrmrza7Dv8XRH6b+q86DXTaW497YMSnPHxtvQuK4dSulvUXJhhX/RzYIrhFn0ODASrRYPuCQGZ+n9QI80bzWK1DKP0sGNBKHmX+03OoecR3UNExJy16PD0pEcR2rKpyI1ABeL5VCIojkAAM5lmD5h1ArOP1/h3IqrRdYFHyKBt/+we+K/HLJKrCr5B/y0Bjr0N/2taQL/FvPc9PHymIPiUaQiD36H+Eutt8VFuOBY9WC2WKWz8JawFh0ooc1KUZuP+10wP39CIvsZQfdxPQXhqdrgx+trnrYH9E9MJUmwbAgj35yPf6D+HOCsBguJ5MErusqN4XlVvcMtNYGJs8yxvwZuFemdTGQqUySucm1r0l14+jgeZqyw3dyDbmCVaG56pWchYefvF9RNBtzggfBWoKNNIQnFjeWSj2dISVhUqKAO7M2TXGsWghstR6fOmk3aTChLQhsxIBkZQbaxk/JoPlYCtWIr2VKUKRZODz9UGKFfn7cKGqvG5HIZOOO8SHYD6OYAl5zs2g4jco9SVbJaAXmU2zfB02FrHUJPghoRZqzd23ehd+UR4wPgsLgMuNbdj49E9kh8aKU2ydED5edlhgJcQpWf1MOHJXEWqoZf6gdivGAwMUvdH6fXIcvPrbWdf9a8Bu+S4EhT", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(82310400014)(36860700004)(376005)(1800799015); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "12 Apr 2024 12:53:23.1886 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 08e2b9dd-6bee-4d8d-14c7-08dc5aef899f", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BL6PEPF00020E64.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DS0PR12MB7874", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The driver currently sets an indication of whether the SFP supports, and\nthat the driver can obtain, diagnostics data. This isn't currently used\nby the driver. Remove this field and the logic supporting it.\n\nSigned-off-by: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>\n---\n drivers/net/axgbe/axgbe_phy_impl.c | 10 ----------\n 1 file changed, 10 deletions(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c\nindex 70e7c56439..e1b926d48a 100644\n--- a/drivers/net/axgbe/axgbe_phy_impl.c\n+++ b/drivers/net/axgbe/axgbe_phy_impl.c\n@@ -220,7 +220,6 @@ struct axgbe_phy_data {\n \tunsigned int sfp_rx_los;\n \tunsigned int sfp_tx_fault;\n \tunsigned int sfp_mod_absent;\n-\tunsigned int sfp_diags;\n \tunsigned int sfp_changed;\n \tunsigned int sfp_phy_avail;\n \tunsigned int sfp_cable_len;\n@@ -701,14 +700,6 @@ static int axgbe_phy_sfp_read_eeprom(struct axgbe_port *pdata)\n \tif (memcmp(&phy_data->sfp_eeprom, &sfp_eeprom, sizeof(sfp_eeprom))) {\n \t\tphy_data->sfp_changed = 1;\n \t\tmemcpy(&phy_data->sfp_eeprom, &sfp_eeprom, sizeof(sfp_eeprom));\n-\n-\t\tif (sfp_eeprom.extd[AXGBE_SFP_EXTD_SFF_8472]) {\n-\t\t\tuint8_t diag_type;\n-\t\t\tdiag_type = sfp_eeprom.extd[AXGBE_SFP_EXTD_DIAG];\n-\n-\t\t\tif (!(diag_type & AXGBE_SFP_EXTD_DIAG_ADDR_CHANGE))\n-\t\t\t\tphy_data->sfp_diags = 1;\n-\t\t}\n \t} else {\n \t\tphy_data->sfp_changed = 0;\n \t}\n@@ -769,7 +760,6 @@ static void axgbe_phy_sfp_reset(struct axgbe_phy_data *phy_data)\n \tphy_data->sfp_rx_los = 0;\n \tphy_data->sfp_tx_fault = 0;\n \tphy_data->sfp_mod_absent = 1;\n-\tphy_data->sfp_diags = 0;\n \tphy_data->sfp_base = AXGBE_SFP_BASE_UNKNOWN;\n \tphy_data->sfp_cable = AXGBE_SFP_CABLE_UNKNOWN;\n \tphy_data->sfp_speed = AXGBE_SFP_SPEED_UNKNOWN;\n", "prefixes": [ "02/24" ] }