Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139242/?format=api
{ "id": 139242, "url": "https://patches.dpdk.org/api/patches/139242/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240412111317.3530529-1-sebastian.brzezinka@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240412111317.3530529-1-sebastian.brzezinka@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240412111317.3530529-1-sebastian.brzezinka@intel.com", "date": "2024-04-12T11:13:16", "name": "[1/2] meson/mlx5: Suppress -Wunused-value diagnostic", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c9cd0c09f15bebdf72cb4b0cab503a26c845f06a", "submitter": { "id": 3289, "url": "https://patches.dpdk.org/api/people/3289/?format=api", "name": "Sebastian Brzezinka", "email": "sebastian.brzezinka@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240412111317.3530529-1-sebastian.brzezinka@intel.com/mbox/", "series": [ { "id": 31730, "url": "https://patches.dpdk.org/api/series/31730/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31730", "date": "2024-04-12T11:13:16", "name": "[1/2] meson/mlx5: Suppress -Wunused-value diagnostic", "version": 1, "mbox": "https://patches.dpdk.org/series/31730/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139242/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/139242/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 81F0B43E51;\n\tFri, 12 Apr 2024 13:13:23 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7012040685;\n\tFri, 12 Apr 2024 13:13:23 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.8])\n by mails.dpdk.org (Postfix) with ESMTP id D9502400D6\n for <dev@dpdk.org>; Fri, 12 Apr 2024 13:13:21 +0200 (CEST)", "from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Apr 2024 04:13:21 -0700", "from sbrzez.igk.intel.com ([10.211.11.150])\n by orviesa002.jf.intel.com with ESMTP; 12 Apr 2024 04:13:19 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1712920402; x=1744456402;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=XquGDLuqD33GUL9v6yBWUlcBnNG03+c9yEPeQlVZzME=;\n b=BfOJj1zqcI5gcx5cPUTofywGlTtMwJdFVrBojM7Tjz12cc7z36O+4ZIc\n CSQ9Qa+hrEnzX05esv4YFlQf0njUD6dkJaTDpeXU5o+KH5IZhOGSAPmGi\n 9ouHFIk+hBGcQwQh4zEeTy9Ilk+mUoGxfx6BwIDPvqiWdyCYCxd6u+E3M\n wh/v4QgUf9oPebmxMmKTiyWDbV/1pSfdLY88FzWn1cdNVHTwojz/uxuRY\n ubpPT4iqnNdatWZ4gZDueqivGjaUh/RTGwBm4qkbAguhUQCY3ByjevEM2\n yFUJC2bTbaoyNcpUflp+hH4rKD+HeNEt3UI2WcXa+CnRV6ixq+FeFCTlk Q==;", "X-CSE-ConnectionGUID": [ "0K7aHginTimRbddu827r1Q==", "/cnAjV+mSbasVsCFgnkgbA==" ], "X-CSE-MsgGUID": [ "w7lRd4rsQeeHdjd2MF/i6Q==", "mJGwzbMzRrKUoowQOIMdQg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11041\"; a=\"25886846\"", "E=Sophos;i=\"6.07,195,1708416000\"; d=\"scan'208\";a=\"25886846\"", "E=Sophos;i=\"6.07,195,1708416000\"; d=\"scan'208\";a=\"52176535\"" ], "X-ExtLoop1": "1", "From": "Sebastian Brzezinka <sebastian.brzezinka@intel.com>", "To": "dev@dpdk.org", "Cc": "Alexey Marchuk <alexeymar@mellanox.com>,\n Sebastian Brzezinka <sebastian.brzezinka@intel.com>", "Subject": "[PATCH 1/2] meson/mlx5: Suppress -Wunused-value diagnostic", "Date": "Fri, 12 Apr 2024 13:13:16 +0200", "Message-Id": "<20240412111317.3530529-1-sebastian.brzezinka@intel.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Alexey Marchuk <alexeymar@mellanox.com>\n\nmlx5 common library checks if several symbols/definitions\nare presented in system header files. If some are not\npresented, they will be enabled by mlx5_glue library.\nThe problem appears with clang and '-Werror' - code\ngenerated by meson is not compiled due to unused variable:\n\nCode:\n\n #include <infiniband/mlx5dv.h>\n int main(void) {\n /* If it's not defined as a macro, try to use as a symbol */\n #ifndef mlx5dv_create_flow_action_packet_reformat\n mlx5dv_create_flow_action_packet_reformat;\n #endif\n return 0;\n }\nCompiler stdout:\n\nCompiler stderr:\n /hpc/local/work/alexeymar/repo/spdk/dpdk/build-tmp/meson-private/tmp5obnak86/testfile.c:6:17: error: expression result unused [-Werror,-Wunused-value]\n mlx5dv_create_flow_action_packet_reformat;\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nAs result, almost all symbols are enabled in mlx5_glue while\nthey exist is system headers. As result, we get multiple\nsymbols redefenitions when we compile mlx5_common.\nAs a solution for this problem we can suppress\n-Wunused-vaurable using pragma\n\nDPDK 23.11 note:\nStarting with commit below, all cflags are passed to the has_header_symbol().\n(33d6694) build: use C11 standard\nTo make sure that the symbol is properly detected, the pedantic flags needs to\nbe removed.\n\nSigned-off-by: Alexey Marchuk <alexeymar@mellanox.com>\nSigned-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>\n---\n drivers/common/mlx5/linux/meson.build | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/common/mlx5/linux/meson.build b/drivers/common/mlx5/linux/meson.build\nindex cdee40c553..f3b8e5741b 100644\n--- a/drivers/common/mlx5/linux/meson.build\n+++ b/drivers/common/mlx5/linux/meson.build\n@@ -209,7 +209,11 @@ if libmtcr_ul_found\n endif\n \n foreach arg:has_sym_args\n- mlx5_config.set(arg[0], cc.has_header_symbol(arg[1], arg[2], dependencies: libs, args: cflags))\n+ file_prefix = '#pragma clang diagnostic ignored \"-Wunused-value\"'\n+ cflags += [\n+ '-Wno-pedantic',\n+ ]\n+ mlx5_config.set(arg[0], cc.has_header_symbol(arg[1], arg[2], prefix : file_prefix, dependencies: libs, args: cflags))\n endforeach\n foreach arg:has_member_args\n file_prefix = '#include <' + arg[1] + '>'\n", "prefixes": [ "1/2" ] }