Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/13900/?format=api
{ "id": 13900, "url": "https://patches.dpdk.org/api/patches/13900/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1466068597-3449-3-git-send-email-i.maximets@samsung.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1466068597-3449-3-git-send-email-i.maximets@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1466068597-3449-3-git-send-email-i.maximets@samsung.com", "date": "2016-06-16T09:16:37", "name": "[dpdk-dev,v2,2/2] vhost: unmap log memory on cleanup.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ab64257e273ea10b5e6573f684dac98494ee4a80", "submitter": { "id": 323, "url": "https://patches.dpdk.org/api/people/323/?format=api", "name": "Ilya Maximets", "email": "i.maximets@samsung.com" }, "delegate": { "id": 355, "url": "https://patches.dpdk.org/api/users/355/?format=api", "username": "yliu", "first_name": "Yuanhan", "last_name": "Liu", "email": "yuanhan.liu@linux.intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1466068597-3449-3-git-send-email-i.maximets@samsung.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/13900/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/13900/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 6CA28C604;\n\tThu, 16 Jun 2016 11:17:08 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n\t[210.118.77.12]) by dpdk.org (Postfix) with ESMTP id CBF0DC5F8\n\tfor <dev@dpdk.org>; Thu, 16 Jun 2016 11:17:07 +0200 (CEST)", "from eucpsbgm2.samsung.com (unknown [203.254.199.245])\n\tby mailout2.w1.samsung.com\n\t(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5\n\t2014)) with ESMTP id <0O8U005UOXSJU070@mailout2.w1.samsung.com> for\n\tdev@dpdk.org; Thu, 16 Jun 2016 10:17:07 +0100 (BST)", "from eusync4.samsung.com ( [203.254.199.214])\n\tby eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 37.73.04866.29E62675;\n\tThu, 16 Jun 2016 10:17:06 +0100 (BST)", "from imaximets.rnd.samsung.ru ([106.109.129.180])\n\tby eusync4.samsung.com\n\t(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5\n\t2014)) with ESMTPA id <0O8U000IUXRWS090@eusync4.samsung.com>; Thu,\n\t16 Jun 2016 10:17:06 +0100 (BST)" ], "X-AuditID": "cbfec7f5-f792a6d000001302-8a-57626e929800", "From": "Ilya Maximets <i.maximets@samsung.com>", "To": "dev@dpdk.org, Huawei Xie <huawei.xie@intel.com>,\n\tYuanhan Liu <yuanhan.liu@linux.intel.com>", "Cc": "Dyasly Sergey <s.dyasly@samsung.com>,\n\tHeetae Ahn <heetae82.ahn@samsung.com>,\n\tVladimir Shilkin <v.shilkin@samsung.com>,\n\tVictor Kaplansky <victork@redhat.com>,\n\tIlya Maximets <i.maximets@samsung.com>", "Date": "Thu, 16 Jun 2016 12:16:37 +0300", "Message-id": "<1466068597-3449-3-git-send-email-i.maximets@samsung.com>", "X-Mailer": "git-send-email 2.7.4", "In-reply-to": "<1466068597-3449-1-git-send-email-i.maximets@samsung.com>", "References": "<1466068597-3449-1-git-send-email-i.maximets@samsung.com>", "X-Brightmail-Tracker": "H4sIAAAAAAAAA+NgFprJLMWRmVeSWpSXmKPExsVy+t/xa7qT8pLCDfrf21i8+7SdyWLa59vs\n\tFu0zzzJZXGn/yW4xebaUxeRNKxgtFh84zGxxfcIFVgcOj18LlrJ6LN7zkslj3slAj/f7rrJ5\n\t9G1ZxRjAGsVlk5Kak1mWWqRvl8CV0TB7FlPBNt6KT8s+szYwtnN3MXJySAiYSPQcXcQEYYtJ\n\tXLi3nq2LkYtDSGApo8S/O0eZIZxWJolrE86CVbEJ6EicWn2EEcQWEUiQOLL/NytIEbPAOUaJ\n\tJVfWgBUJC1hL7LnUzQZiswioSrRcPcAOYvMKuEp8PrYLap2cxM1zncwgNqeAm8SbC4dYQWwh\n\toJpN/TOYJzDyLmBkWMUomlqaXFCclJ5rpFecmFtcmpeul5yfu4kREmBfdzAuPWZ1iFGAg1GJ\n\th1dgfWK4EGtiWXFl7iFGCQ5mJRFe+aykcCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8M3e9DxES\n\tSE8sSc1OTS1ILYLJMnFwSjUwqlVrOZ/fPPmUUf15T5YNarpsR5cIH93YoZR7617iHotTfuGh\n\tu1mSt6oc1WcKcIkSnJrq/dmhdOnyTx+PHXedftdHOtq8jPfsy2l8ZbeLotINJXd22p5abveA\n\t9/xha6Pt3ycv2RO2kctf2LGvWG5zeXg5T/iu7YX7Dlj67nzP+snPQP3B8dRAJZbijERDLeai\n\t4kQAlIJUzCwCAAA=", "Subject": "[dpdk-dev] [PATCH v2 2/2] vhost: unmap log memory on cleanup.", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fixes memory leak on QEMU migration.\n\nFixes: 54f9e32305d4 (\"vhost: handle dirty pages logging request\")\nSigned-off-by: Ilya Maximets <i.maximets@samsung.com>\n---\n lib/librte_vhost/vhost-net.h | 1 +\n lib/librte_vhost/vhost_user/virtio-net-user.c | 15 +++++++++++++--\n 2 files changed, 14 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost-net.h b/lib/librte_vhost/vhost-net.h\nindex ec8f964..38593a2 100644\n--- a/lib/librte_vhost/vhost-net.h\n+++ b/lib/librte_vhost/vhost-net.h\n@@ -134,6 +134,7 @@ struct virtio_net {\n \tchar\t\t\tifname[IF_NAME_SZ];\n \tuint64_t\t\tlog_size;\n \tuint64_t\t\tlog_base;\n+\tuint64_t\t\tlog_addr;\n \tstruct ether_addr\tmac;\n \n } __rte_cache_aligned;\ndiff --git a/lib/librte_vhost/vhost_user/virtio-net-user.c b/lib/librte_vhost/vhost_user/virtio-net-user.c\nindex e6a2aed..a867a43 100644\n--- a/lib/librte_vhost/vhost_user/virtio-net-user.c\n+++ b/lib/librte_vhost/vhost_user/virtio-net-user.c\n@@ -95,6 +95,10 @@ vhost_backend_cleanup(struct virtio_net *dev)\n \t\tfree(dev->mem);\n \t\tdev->mem = NULL;\n \t}\n+\tif (dev->log_addr) {\n+\t\tmunmap((void *)(uintptr_t)dev->log_addr, dev->log_size);\n+\t\tdev->log_addr = 0;\n+\t}\n }\n \n int\n@@ -407,8 +411,15 @@ user_set_log_base(int vid, struct VhostUserMsg *msg)\n \t\treturn -1;\n \t}\n \n-\t/* TODO: unmap on stop */\n-\tdev->log_base = (uint64_t)(uintptr_t)addr + off;\n+\t/*\n+\t * Free previously mapped log memory on occasionally\n+\t * multiple VHOST_USER_SET_LOG_BASE.\n+\t */\n+\tif (dev->log_addr) {\n+\t\tmunmap((void *)(uintptr_t)dev->log_addr, dev->log_size);\n+\t}\n+\tdev->log_addr = (uint64_t)(uintptr_t)addr;\n+\tdev->log_base = dev->log_addr + off;\n \tdev->log_size = size;\n \n \treturn 0;\n", "prefixes": [ "dpdk-dev", "v2", "2/2" ] }