Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138486/?format=api
{ "id": 138486, "url": "https://patches.dpdk.org/api/patches/138486/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240320014053.1040-1-vipin.varghese@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240320014053.1040-1-vipin.varghese@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240320014053.1040-1-vipin.varghese@amd.com", "date": "2024-03-20T01:40:53", "name": "[v3] app/dma-perf: calrify incorrect NUMA config", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "efb09523d1087832b19a958e5c63af2b80f190af", "submitter": { "id": 2511, "url": "https://patches.dpdk.org/api/people/2511/?format=api", "name": "Vipin Varghese", "email": "vipin.varghese@amd.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240320014053.1040-1-vipin.varghese@amd.com/mbox/", "series": [ { "id": 31561, "url": "https://patches.dpdk.org/api/series/31561/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31561", "date": "2024-03-20T01:40:53", "name": "[v3] app/dma-perf: calrify incorrect NUMA config", "version": 3, "mbox": "https://patches.dpdk.org/series/31561/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/138486/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/138486/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0A65143CEC;\n\tWed, 20 Mar 2024 02:41:48 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8D0DE4029F;\n\tWed, 20 Mar 2024 02:41:47 +0100 (CET)", "from NAM02-SN1-obe.outbound.protection.outlook.com\n (mail-sn1nam02on2046.outbound.protection.outlook.com [40.107.96.46])\n by mails.dpdk.org (Postfix) with ESMTP id A4D9240298\n for <dev@dpdk.org>; Wed, 20 Mar 2024 02:41:44 +0100 (CET)", "from BN1PR13CA0012.namprd13.prod.outlook.com (2603:10b6:408:e2::17)\n by PH0PR12MB7885.namprd12.prod.outlook.com (2603:10b6:510:28f::9)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.30; Wed, 20 Mar\n 2024 01:41:42 +0000", "from BN2PEPF000044A6.namprd04.prod.outlook.com\n (2603:10b6:408:e2:cafe::c8) by BN1PR13CA0012.outlook.office365.com\n (2603:10b6:408:e2::17) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.12 via Frontend\n Transport; Wed, 20 Mar 2024 01:41:42 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n BN2PEPF000044A6.mail.protection.outlook.com (10.167.243.100) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7409.10 via Frontend Transport; Wed, 20 Mar 2024 01:41:42 +0000", "from BLR-5CG134626B.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 19 Mar\n 2024 20:41:40 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=MidmYMEY2j2GJnWEdG9WP8z3nFIR8JHDwjLtE8m0cga1K2YAw/nrB+1D75X/LG8BtwMMQrxt3SGg4wMsFLSa9wLIbXvXtvQitA3qN+TIBZ2qhjmCcH/X0FMWpXMdLLwkqy+jLjxXP0+2Z03gnxVg2qF7pL+zYX0Ap6OOFkdqRstQKPFtyS0wxKoWkHHhBQFkxKCebAKYkj+upfBUBRrEZZJyyOvB8J7y4ngLzdSaISK+BNSFNby5f+6WRx4BtVWlUql0UIZU/qTlfaMQPGu07Aw5Uik6Au6JPdTJSfFxZNg/1h5aPgT5J1kE2X+hqYMgvtaSoxk2UsSwsXa6KtJ6hQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=zcMgMxny6zvnoxyrTAdyesRGZlIDmWag/KnubeQYmPg=;\n b=fSAG1zu7m0f7XovJCNnsg1GAu0JKr1IVLAuhFIhpPJ2IAczcJMgRXBrwVM+zOZGV/rvLlYqKiMvavJuiqCY8Lv8k38j4nCTKuJqs7UadIscM+NZQtblu0ZMAk6AwifRSMspeVidAzmggrXnLulrX3hNcfMN7J2ODiviFgPVVm6tNu1F4P/VHO0DKki8yQDv6er1SNHbRbYNaRGZMKh3LYaJK0imY3l+uR4cvP65PLIVQrFyWQV1lYUJcfaPEzMA4orgbi2kqBsZr6lKZjo6gMSsNYXQMFOstlDyZLDE8T1XzCAlkProdbSd/sFPxr3cw6jeBE4iwuVkvABowUxD91Q==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=zcMgMxny6zvnoxyrTAdyesRGZlIDmWag/KnubeQYmPg=;\n b=ksDmJWySQi7YxqEv3UI9X55mHmQ2L3620fEvIdwk2lai4FZJCwUdlDLxh/A2j1aKR1ouZYMujve82ZMSPKIQ8KPQQo0gtSq+uXK8JRiF2vkVNgK+Q+5/VWTkkzLe4FYmz8vnKhmegM1uGATKdChSgi8tXBSmFLZjDKpYInvMPwA=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Vipin Varghese <vipin.varghese@amd.com>", "To": "<dev@dpdk.org>, <fengchengwen@huawei.com>, <konstantin.ananyev@huawei.com>", "CC": "<ferruh.yigit@amd.com>, <neerav.parikh@amd.com>", "Subject": "[PATCH v3] app/dma-perf: calrify incorrect NUMA config", "Date": "Wed, 20 Mar 2024 07:10:53 +0530", "Message-ID": "<20240320014053.1040-1-vipin.varghese@amd.com>", "X-Mailer": "git-send-email 2.41.0.windows.3", "In-Reply-To": "<20240311060053.137-1-vipin.varghese@amd.com>", "References": "<20240311060053.137-1-vipin.varghese@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BN2PEPF000044A6:EE_|PH0PR12MB7885:EE_", "X-MS-Office365-Filtering-Correlation-Id": "ad1f2618-beac-4885-a5c0-08dc487ee4f3", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n /axUDwEqzBZ6QqF0bzvUmR2DgHtFv8ZVZst3/GbuHmVBdLbnxZbxLgHIVdTIOk0Q5r5FmNe35QpUsCQbyzmWHk2B8v30QTvzsaafxvynLtoFiXCtQNkSphrB1SHDeGOO9PlfhBp3Dk3GU4kKtqx9fcAssuDony1chdyGx7PJm0Cw+ESaad6j2aaH7uo6znVa8xKteVIR1AMedBV5E5BrPJYqL2n6ML0qOLnlQPNEuutx8crsKDslsrAqYY0LR2Rs7OUsv+fL1t273C4U2JCoPwvnAUy3UTBVeUKbjwDaJ3lJBjwQM/5zXc47S/ZQ1V5pUpw1xu81DnDQ6Ayn7Qmm1x182wz9yyhJsVXCW7pxFtZeT7nzImiUuF9kJGt4sn7yOOLWOxiCBiRf2ziJOsfi33EJF1JE5NKBqbAMU+Ik7ZJyQiNrzX0HyVmeyS0OGYoGt2S/expM42PV/XXIoEIGBp/g+T1Mw8fPFYI1EQcQdAeyY9wl41kcjVri6mfl7wk4w5eN7sVnR37198rU1rcLl9XgoAWwB5uyG/DKBfneXV9DimYX/sPGrjYHSjljD/k75vFFTNkuvFrSyTVgJ5MuMyMPwJXdefDQotDkTZ83NdmIGTBkZIeIH9J4JPYuyiUN6OiU3D+HA1ehKqxvl4etrf+kab4Ckng1cZnS48PJhmu46ZEryFX2yvglUTa+BXLbcoxNekeC9nV3c2UAKm2HF93vjl3SMsiPoJzaZ0xDliIqGTv1jQwBSdFkXrWfgd0G", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(1800799015)(82310400014)(36860700004)(376005); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "20 Mar 2024 01:41:42.3707 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n ad1f2618-beac-4885-a5c0-08dc487ee4f3", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN2PEPF000044A6.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH0PR12MB7885", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In case incorrect NUMA configuration, the current commit shares\n 1) either `source or destination numa is greater`\n 2) instead of `actual NUMA` it is `acture NUMA`\n 3) uses `printf` instead of PRINT_ERR\n\ncurrent patch changes the above to\n 1) identify if source or|and destination is incorrect\n 2) fix wording to incorrect\n 3) use PRINT_ERR macro\n\nSigned-off-by: Vipin Varghese <vipin.varghese@amd.com>\n---\n\nV3 changes:\n - use snake-case instead of camel case for static scope functions.\n - convert console words to lower case.\n\nV2 changes:\n - inform incorrect numa\n - fix spelling from acture to actual\n - use PRINT_ERR instead of printf\n---\n app/test-dma-perf/benchmark.c | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test-dma-perf/benchmark.c b/app/test-dma-perf/benchmark.c\nindex d167adc4d2..a437b715bd 100644\n--- a/app/test-dma-perf/benchmark.c\n+++ b/app/test-dma-perf/benchmark.c\n@@ -442,11 +442,16 @@ setup_memory_env(struct test_configure *cfg,\n \tunsigned int nr_sockets;\n \tuint32_t nr_buf = cfg->nr_buf;\n \tuint32_t i;\n+\tbool is_src_numa_incorrect, is_dst_numa_incorrect;\n \n \tnr_sockets = rte_socket_count();\n-\tif (cfg->src_numa_node >= nr_sockets ||\n-\t\tcfg->dst_numa_node >= nr_sockets) {\n-\t\tprintf(\"Error: Source or destination numa exceeds the acture numa nodes.\\n\");\n+\tis_src_numa_incorrect = (cfg->src_numa_node >= nr_sockets);\n+\tis_dst_numa_incorrect = (cfg->dst_numa_node >= nr_sockets);\n+\n+\tif (is_src_numa_incorrect || is_dst_numa_incorrect) {\n+\t\tPRINT_ERR(\"Error: Incorrect NUMA config for %s.\\n\",\n+\t\t\t(is_src_numa_incorrect && is_dst_numa_incorrect) ? \"source & destination\" :\n+\t\t\t\t(is_src_numa_incorrect) ? \"source\" : \"destination\");\n \t\treturn -1;\n \t}\n \n", "prefixes": [ "v3" ] }