Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/13834/?format=api
{ "id": 13834, "url": "https://patches.dpdk.org/api/patches/13834/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1466004333-18469-4-git-send-email-remy.horton@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1466004333-18469-4-git-send-email-remy.horton@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1466004333-18469-4-git-send-email-remy.horton@intel.com", "date": "2016-06-15T15:25:29", "name": "[dpdk-dev,v5,3/7] drivers/net/e1000: change xstats to use integer ids", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "83b084fe483269c6ecfcfa4c905404eaa1fce4e8", "submitter": { "id": 326, "url": "https://patches.dpdk.org/api/people/326/?format=api", "name": "Remy Horton", "email": "remy.horton@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1466004333-18469-4-git-send-email-remy.horton@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/13834/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/13834/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C5BFEC11A;\n\tWed, 15 Jun 2016 17:25:41 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 12441BDAE\n\tfor <dev@dpdk.org>; Wed, 15 Jun 2016 17:25:38 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP; 15 Jun 2016 08:25:39 -0700", "from rhorton-mobl.ger.corp.intel.com (HELO VM.ir.intel.com)\n\t([163.33.228.155])\n\tby orsmga003.jf.intel.com with ESMTP; 15 Jun 2016 08:25:37 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.26,476,1459839600\"; d=\"scan'208\";a=\"828641128\"", "From": "Remy Horton <remy.horton@intel.com>", "To": "dev@dpdk.org,\n\tThomas Monjalon <thomas.monjalon@6wind.com>", "Date": "Wed, 15 Jun 2016 16:25:29 +0100", "Message-Id": "<1466004333-18469-4-git-send-email-remy.horton@intel.com>", "X-Mailer": "git-send-email 2.5.5", "In-Reply-To": "<1466004333-18469-1-git-send-email-remy.horton@intel.com>", "References": "<1466004333-18469-1-git-send-email-remy.horton@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 3/7] drivers/net/e1000: change xstats to use\n\tinteger ids", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The current extended ethernet statistics fetching involve doing several\nstring operations, which causes performance issues if there are lots of\nstatistics and/or network interfaces. This patch changes the e1000 driver\nto use the new API that seperates name string and value queries.\n\nSigned-off-by: Remy Horton <remy.horton@intel.com>\n---\n drivers/net/e1000/igb_ethdev.c | 52 ++++++++++++++++++++++++++++++++++++++----\n 1 file changed, 48 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex f0921ee..dffa04f 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -100,6 +100,9 @@ static void eth_igb_stats_get(struct rte_eth_dev *dev,\n \t\t\t\tstruct rte_eth_stats *rte_stats);\n static int eth_igb_xstats_get(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_xstats *xstats, unsigned n);\n+static int eth_igb_xstats_get_names(struct rte_eth_dev *dev,\n+\t\t\t\t struct rte_eth_xstat_name *xstats_names,\n+\t\t\t\t unsigned limit);\n static void eth_igb_stats_reset(struct rte_eth_dev *dev);\n static void eth_igb_xstats_reset(struct rte_eth_dev *dev);\n static void eth_igb_infos_get(struct rte_eth_dev *dev,\n@@ -165,6 +168,9 @@ static void eth_igbvf_stats_get(struct rte_eth_dev *dev,\n \t\t\t\tstruct rte_eth_stats *rte_stats);\n static int eth_igbvf_xstats_get(struct rte_eth_dev *dev,\n \t\t\t\tstruct rte_eth_xstats *xstats, unsigned n);\n+static int eth_igbvf_xstats_get_names(struct rte_eth_dev *dev,\n+\t\t\t\t struct rte_eth_xstat_name *xstats_names,\n+\t\t\t\t unsigned limit);\n static void eth_igbvf_stats_reset(struct rte_eth_dev *dev);\n static int igbvf_vlan_filter_set(struct rte_eth_dev *dev,\n \t\tuint16_t vlan_id, int on);\n@@ -324,6 +330,7 @@ static const struct eth_dev_ops eth_igb_ops = {\n \t.link_update = eth_igb_link_update,\n \t.stats_get = eth_igb_stats_get,\n \t.xstats_get = eth_igb_xstats_get,\n+\t.xstats_get_names = eth_igb_xstats_get_names,\n \t.stats_reset = eth_igb_stats_reset,\n \t.xstats_reset = eth_igb_xstats_reset,\n \t.dev_infos_get = eth_igb_infos_get,\n@@ -385,6 +392,7 @@ static const struct eth_dev_ops igbvf_eth_dev_ops = {\n \t.link_update = eth_igb_link_update,\n \t.stats_get = eth_igbvf_stats_get,\n \t.xstats_get = eth_igbvf_xstats_get,\n+\t.xstats_get_names = eth_igbvf_xstats_get_names,\n \t.stats_reset = eth_igbvf_stats_reset,\n \t.xstats_reset = eth_igbvf_stats_reset,\n \t.vlan_filter_set = igbvf_vlan_filter_set,\n@@ -1691,6 +1699,26 @@ eth_igb_xstats_reset(struct rte_eth_dev *dev)\n \tmemset(stats, 0, sizeof(*stats));\n }\n \n+static int eth_igb_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n+\tstruct rte_eth_xstat_name *xstats_names,\n+\t__rte_unused unsigned limit)\n+{\n+\tunsigned i;\n+\n+\tif (xstats_names == NULL)\n+\t\treturn IGB_NB_XSTATS;\n+\n+\t/* Note: limit checked in rte_eth_xstats_names() */\n+\n+\tfor (i = 0; i < IGB_NB_XSTATS; i++) {\n+\t\tsnprintf(xstats_names[i].name, sizeof(xstats_names[i].name),\n+\t\t\t \"%s\", rte_igb_stats_strings[i].name);\n+\t\txstats_names[i].id = i;\n+\t}\n+\n+\treturn IGB_NB_XSTATS;\n+}\n+\n static int\n eth_igb_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstats *xstats,\n \t\t unsigned n)\n@@ -1713,8 +1741,8 @@ eth_igb_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstats *xstats,\n \n \t/* Extended stats */\n \tfor (i = 0; i < IGB_NB_XSTATS; i++) {\n-\t\tsnprintf(xstats[i].name, sizeof(xstats[i].name),\n-\t\t\t \"%s\", rte_igb_stats_strings[i].name);\n+\t\txstats[i].name[0] = '\\0';\n+\t\txstats[i].id = i;\n \t\txstats[i].value = *(uint64_t *)(((char *)hw_stats) +\n \t\t\trte_igb_stats_strings[i].offset);\n \t}\n@@ -1762,6 +1790,22 @@ igbvf_read_stats_registers(struct e1000_hw *hw, struct e1000_vf_stats *hw_stats)\n \t hw_stats->last_gotlbc, hw_stats->gotlbc);\n }\n \n+static int eth_igbvf_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n+\t\t\t\t struct rte_eth_xstat_name *xstats_names,\n+\t\t\t\t __rte_unused unsigned limit)\n+{\n+\tunsigned i;\n+\n+\tif (xstats_names != NULL)\n+\t\tfor (i = 0; i < IGBVF_NB_XSTATS; i++) {\n+\t\t\tsnprintf(xstats_names[i].name,\n+\t\t\t\tsizeof(xstats_names[i].name), \"%s\",\n+\t\t\t\trte_igbvf_stats_strings[i].name);\n+\t\t\txstats_names[i].id = i;\n+\t\t}\n+\treturn IGBVF_NB_XSTATS;\n+}\n+\n static int\n eth_igbvf_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstats *xstats,\n \t\t unsigned n)\n@@ -1780,8 +1824,8 @@ eth_igbvf_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstats *xstats,\n \t\treturn 0;\n \n \tfor (i = 0; i < IGBVF_NB_XSTATS; i++) {\n-\t\tsnprintf(xstats[i].name, sizeof(xstats[i].name), \"%s\",\n-\t\t\t rte_igbvf_stats_strings[i].name);\n+\t\txstats[i].name[0] = '\\0';\n+\t\txstats[i].id = i;\n \t\txstats[i].value = *(uint64_t *)(((char *)hw_stats) +\n \t\t\trte_igbvf_stats_strings[i].offset);\n \t}\n", "prefixes": [ "dpdk-dev", "v5", "3/7" ] }