Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138330/?format=api
https://patches.dpdk.org/api/patches/138330/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240313125932.1878279-3-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240313125932.1878279-3-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240313125932.1878279-3-maxime.coquelin@redhat.com", "date": "2024-03-13T12:59:32", "name": "[v2,2/2] net/virtio: fix notification area initialization", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "404bc1e37d674dd9ece330f80cd2a9a5795f797f", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240313125932.1878279-3-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 31495, "url": "https://patches.dpdk.org/api/series/31495/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31495", "date": "2024-03-13T12:59:30", "name": "net/virtio: vhost-vdpa fixes", "version": 2, "mbox": "https://patches.dpdk.org/series/31495/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/138330/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/138330/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F0EFB43C9F;\n\tWed, 13 Mar 2024 13:59:55 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0120742DE0;\n\tWed, 13 Mar 2024 13:59:49 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id A0FF542E00\n for <dev@dpdk.org>; Wed, 13 Mar 2024 13:59:46 +0100 (CET)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-511-vw0_-uMHPsyBT9l2zDoeTQ-1; Wed, 13 Mar 2024 08:59:41 -0400", "from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com\n [10.11.54.9])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7DBDA185A783;\n Wed, 13 Mar 2024 12:59:40 +0000 (UTC)", "from max-p1.redhat.com (unknown [10.39.208.24])\n by smtp.corp.redhat.com (Postfix) with ESMTP id E1F3B492BC6;\n Wed, 13 Mar 2024 12:59:38 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1710334786;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=/i+SXtfYn1BVlI6ByuN7TaSfInHuKBUtcswulgk58eQ=;\n b=CUotLWz0/WZEonUk4NmuPbGIbA+9r0z9mehD4wYCBWOi42qrRr+CCAUJxvdO5tjcjO6xPK\n 3cMu3xRaL/ZDyQK2lOKpzUXeIHrwUu4GXXUsGIsiyvkHJEiVfgpdrTrHMO6KRb5tb1Rup4\n Ad9CxmDPTJ5NFKtRpIUh6VMc5X8t/ys=", "X-MC-Unique": "vw0_-uMHPsyBT9l2zDoeTQ-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, david.marchand@redhat.com, chenbox@nvidia.com,\n schalla@marvell.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH v2 2/2] net/virtio: fix notification area initialization", "Date": "Wed, 13 Mar 2024 13:59:32 +0100", "Message-ID": "<20240313125932.1878279-3-maxime.coquelin@redhat.com>", "In-Reply-To": "<20240313125932.1878279-1-maxime.coquelin@redhat.com>", "References": "<20240313125932.1878279-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.9", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Notification area is a Virtio feature that requires to be\nnegotiated because not all devices support it. Currently,\nit is tried to be initialized as soon as the backend\nimplements the callback, so it assumes all Vhost-vDPA\ndevices support it.\n\nThis patch skips calling the notification area map callback\nif the device does not advertise its support.\n\nFixes: 0fd2782660c8 (\"net/virtio-user: support notification area mapping\")\n\nReviewed-by: David Marchand <david.marchand@redhat.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 54187fedf5..4fdfe70e7c 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -445,8 +445,9 @@ virtio_user_dev_init_notify(struct virtio_user_dev *dev)\n \t\tdev->kickfds[i] = kickfd;\n \t}\n \n-\tif (dev->ops->map_notification_area)\n-\t\tif (dev->ops->map_notification_area(dev))\n+\tif (dev->device_features & (1ULL << VIRTIO_F_NOTIFICATION_DATA))\n+\t\tif (dev->ops->map_notification_area &&\n+\t\t\t\tdev->ops->map_notification_area(dev))\n \t\t\tgoto err;\n \n \treturn 0;\n", "prefixes": [ "v2", "2/2" ] }{ "id": 138330, "url": "