Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138043/?format=api
{ "id": 138043, "url": "https://patches.dpdk.org/api/patches/138043/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240306122445.4350-31-shaibran@amazon.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240306122445.4350-31-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240306122445.4350-31-shaibran@amazon.com", "date": "2024-03-06T12:24:42", "name": "[v3,30/33] net/ena: exhaust interrupt callbacks in device close", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8465a9af9b9deb994783c7c85e14d4d923622d64", "submitter": { "id": 2930, "url": "https://patches.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240306122445.4350-31-shaibran@amazon.com/mbox/", "series": [ { "id": 31397, "url": "https://patches.dpdk.org/api/series/31397/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31397", "date": "2024-03-06T12:24:13", "name": "net/ena: v2.9.0 driver release", "version": 3, "mbox": "https://patches.dpdk.org/series/31397/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/138043/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/138043/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EF5A443C5B;\n\tWed, 6 Mar 2024 13:28:57 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 588B142EBF;\n\tWed, 6 Mar 2024 13:26:03 +0100 (CET)", "from smtp-fw-52005.amazon.com (smtp-fw-52005.amazon.com\n [52.119.213.156])\n by mails.dpdk.org (Postfix) with ESMTP id 839F942EBB\n for <dev@dpdk.org>; Wed, 6 Mar 2024 13:25:59 +0100 (CET)", "from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO\n smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.43.8.6])\n by smtp-border-fw-52005.iad7.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2024 12:25:59 +0000", "from EX19MTAEUB002.ant.amazon.com [10.0.17.79:46673]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.42.123:2525]\n with esmtp (Farcaster)\n id a774c57e-0830-44d5-be86-c3cf7fd07939; Wed, 6 Mar 2024 12:25:57 +0000 (UTC)", "from EX19D007EUA001.ant.amazon.com (10.252.50.133) by\n EX19MTAEUB002.ant.amazon.com (10.252.51.79) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Wed, 6 Mar 2024 12:25:52 +0000", "from EX19MTAUWA001.ant.amazon.com (10.250.64.204) by\n EX19D007EUA001.ant.amazon.com (10.252.50.133) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Wed, 6 Mar 2024 12:25:51 +0000", "from HFA15-CG15235BS.amazon.com (10.1.213.21) by\n mail-relay.amazon.com (10.250.64.204) with Microsoft SMTP Server id\n 15.2.1258.28 via Frontend Transport; Wed, 6 Mar 2024 12:25:50 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1709727960; x=1741263960;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=imMddOi02cP+x7fzEIddIAfYIdp2Tq1G/Eb+KN8IAM0=;\n b=QJwivZ60COcye9qcrqEz8P56IhTzpOGpkGP06yZBIgEr5MudZCjgDyNl\n ifLGoPQlVjraZzObOcSC1pK3jbcNYq/VjG2HyCJhX4xY3kFCGjgQ92zUe\n 2RRvbNTE5KnQnjfyvvrgBFLDyNJagFaB1MnfPDUW1e/c2SgsLSceY1/bC 4=;", "X-IronPort-AV": "E=Sophos;i=\"6.06,208,1705363200\"; d=\"scan'208\";a=\"638962104\"", "X-Farcaster-Flow-ID": "a774c57e-0830-44d5-be86-c3cf7fd07939", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>", "Subject": "[PATCH v3 30/33] net/ena: exhaust interrupt callbacks in device close", "Date": "Wed, 6 Mar 2024 14:24:42 +0200", "Message-ID": "<20240306122445.4350-31-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240306122445.4350-1-shaibran@amazon.com>", "References": "<20240306122445.4350-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\nChange rte_intr_callback_unregister to its synchronous variant to\nensure all active interrupt callbacks are completed before proceeding\nwith the flow. Relocate the interrupt deregistration to precede the\nrelease of stats memory, thereby preventing the interrupt handler\nfrom accessing memory that has already been freed.\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\n drivers/net/ena/ena_ethdev.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 2a7b7c0cba..d73e321d0f 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -871,6 +871,7 @@ static int ena_close(struct rte_eth_dev *dev)\n \tstruct rte_intr_handle *intr_handle = pci_dev->intr_handle;\n \tstruct ena_adapter *adapter = dev->data->dev_private;\n \tint ret = 0;\n+\tint rc;\n \n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n@@ -879,17 +880,17 @@ static int ena_close(struct rte_eth_dev *dev)\n \t\tret = ena_stop(dev);\n \tadapter->state = ENA_ADAPTER_STATE_CLOSED;\n \n+\trte_intr_disable(intr_handle);\n+\trc = rte_intr_callback_unregister_sync(intr_handle, ena_interrupt_handler_rte, dev);\n+\tif (unlikely(rc != 0))\n+\t\tPMD_INIT_LOG(ERR, \"Failed to unregister interrupt handler\\n\");\n+\n \tena_rx_queue_release_all(dev);\n \tena_tx_queue_release_all(dev);\n \n \trte_free(adapter->drv_stats);\n \tadapter->drv_stats = NULL;\n \n-\trte_intr_disable(intr_handle);\n-\trte_intr_callback_unregister(intr_handle,\n-\t\t\t\t ena_interrupt_handler_rte,\n-\t\t\t\t dev);\n-\n \t/*\n \t * MAC is not allocated dynamically. Setting NULL should prevent from\n \t * release of the resource in the rte_eth_dev_release_port().\n", "prefixes": [ "v3", "30/33" ] }