Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138036/?format=api
{ "id": 138036, "url": "https://patches.dpdk.org/api/patches/138036/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240306122445.4350-25-shaibran@amazon.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240306122445.4350-25-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240306122445.4350-25-shaibran@amazon.com", "date": "2024-03-06T12:24:36", "name": "[v3,24/33] net/ena/hal: handle command abort", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fc776df029a82adad2739c4c059ebc0ed0bf8ee5", "submitter": { "id": 2930, "url": "https://patches.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240306122445.4350-25-shaibran@amazon.com/mbox/", "series": [ { "id": 31397, "url": "https://patches.dpdk.org/api/series/31397/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31397", "date": "2024-03-06T12:24:13", "name": "net/ena: v2.9.0 driver release", "version": 3, "mbox": "https://patches.dpdk.org/series/31397/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/138036/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/138036/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E852143C5B;\n\tWed, 6 Mar 2024 13:28:01 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D3E2742DF6;\n\tWed, 6 Mar 2024 13:25:47 +0100 (CET)", "from smtp-fw-80009.amazon.com (smtp-fw-80009.amazon.com\n [99.78.197.220]) by mails.dpdk.org (Postfix) with ESMTP id A6C6A42DE9\n for <dev@dpdk.org>; Wed, 6 Mar 2024 13:25:45 +0100 (CET)", "from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO\n smtpout.prod.us-east-1.prod.farcaster.email.amazon.dev) ([10.25.36.210])\n by smtp-border-fw-80009.pdx80.corp.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2024 12:25:41 +0000", "from EX19MTAEUB001.ant.amazon.com [10.0.10.100:38030]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.16.96:2525]\n with esmtp (Farcaster)\n id 00a7a222-e9b1-4f64-acf2-4ee72586733d; Wed, 6 Mar 2024 12:25:40 +0000 (UTC)", "from EX19D007EUA004.ant.amazon.com (10.252.50.76) by\n EX19MTAEUB001.ant.amazon.com (10.252.51.26) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Wed, 6 Mar 2024 12:25:39 +0000", "from EX19MTAUWA001.ant.amazon.com (10.250.64.204) by\n EX19D007EUA004.ant.amazon.com (10.252.50.76) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Wed, 6 Mar 2024 12:25:39 +0000", "from HFA15-CG15235BS.amazon.com (10.1.213.21) by\n mail-relay.amazon.com (10.250.64.204) with Microsoft SMTP Server id\n 15.2.1258.28 via Frontend Transport; Wed, 6 Mar 2024 12:25:38 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1709727945; x=1741263945;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=GoS8TERay/ij48nRuXt/uG2U5nXux23ICXr+CMAiw8I=;\n b=GO/Taawmnhc5S4YLfQXAETxOQJTzH9OgRaQ0EunVk3clWtIo8SGRN59c\n +H/yugoSHYmrvIQxsHygo9L3mFTdgjpkmfwtDs7jsX7QdqQFHIdjgX1jq\n XmV4viXjFrGeOQl1jLLsMIu/C9ilxOsJMJkqIjG2Hz/CLBbqLMpQrx3pY c=;", "X-IronPort-AV": "E=Sophos;i=\"6.06,208,1705363200\"; d=\"scan'208\";a=\"71125416\"", "X-Farcaster-Flow-ID": "00a7a222-e9b1-4f64-acf2-4ee72586733d", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>", "Subject": "[PATCH v3 24/33] net/ena/hal: handle command abort", "Date": "Wed, 6 Mar 2024 14:24:36 +0200", "Message-ID": "<20240306122445.4350-25-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240306122445.4350-1-shaibran@amazon.com>", "References": "<20240306122445.4350-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\nCurrently admin_queue->stats.aborted_cmd counter is incremented if an\nadmin command status is ENA_CMD_ABORTED and only if the admin queue is\nin polling mode.\nThis commit fixes handling the case of incrementing\nadmin_queue->stats.aborted_cmd if the admin queue is in interrupt\nmode as well.\nAlso added a verification that the command status is a valid\ncompletion status which is currently verified only if the admin queue\nis in polling mode.\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\n drivers/net/ena/hal/ena_com.c | 11 +++++++++++\n 1 file changed, 11 insertions(+)", "diff": "diff --git a/drivers/net/ena/hal/ena_com.c b/drivers/net/ena/hal/ena_com.c\nindex 053e095585..b98540ba63 100644\n--- a/drivers/net/ena/hal/ena_com.c\n+++ b/drivers/net/ena/hal/ena_com.c\n@@ -824,8 +824,19 @@ static int ena_com_wait_and_process_admin_cq_interrupts(struct ena_comp_ctx *com\n \t\t\tret = ENA_COM_TIMER_EXPIRED;\n \t\t\tgoto err;\n \t\t}\n+\t} else if (unlikely(comp_ctx->status == ENA_CMD_ABORTED)) {\n+\t\tena_trc_err(admin_queue->ena_dev, \"Command was aborted\\n\");\n+\t\tENA_SPINLOCK_LOCK(admin_queue->q_lock, flags);\n+\t\tadmin_queue->stats.aborted_cmd++;\n+\t\tENA_SPINLOCK_UNLOCK(admin_queue->q_lock, flags);\n+\t\tret = ENA_COM_NO_DEVICE;\n+\t\tgoto err;\n \t}\n \n+\tENA_WARN(comp_ctx->status != ENA_CMD_COMPLETED,\n+\t\t admin_queue->ena_dev, \"Invalid comp status %d\\n\",\n+\t\t comp_ctx->status);\n+\n \tret = ena_com_comp_status_to_errno(admin_queue, comp_ctx->comp_status);\n err:\n \tcomp_ctxt_release(admin_queue, comp_ctx);\n", "prefixes": [ "v3", "24/33" ] }