Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138032/?format=api
{ "id": 138032, "url": "https://patches.dpdk.org/api/patches/138032/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240306122445.4350-20-shaibran@amazon.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240306122445.4350-20-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240306122445.4350-20-shaibran@amazon.com", "date": "2024-03-06T12:24:31", "name": "[v3,19/33] net/ena/hal: missing admin interrupt reset reason", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9884440b5dd118f9d730db111569a0fa586fdd72", "submitter": { "id": 2930, "url": "https://patches.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240306122445.4350-20-shaibran@amazon.com/mbox/", "series": [ { "id": 31397, "url": "https://patches.dpdk.org/api/series/31397/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31397", "date": "2024-03-06T12:24:13", "name": "net/ena: v2.9.0 driver release", "version": 3, "mbox": "https://patches.dpdk.org/series/31397/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/138032/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/138032/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AD56543C5B;\n\tWed, 6 Mar 2024 13:27:27 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8C18942E8B;\n\tWed, 6 Mar 2024 13:25:34 +0100 (CET)", "from smtp-fw-9106.amazon.com (smtp-fw-9106.amazon.com\n [207.171.188.206])\n by mails.dpdk.org (Postfix) with ESMTP id B600842E2D\n for <dev@dpdk.org>; Wed, 6 Mar 2024 13:25:31 +0100 (CET)", "from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO\n smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.25.36.210])\n by smtp-border-fw-9106.sea19.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2024 12:25:31 +0000", "from EX19MTAEUC002.ant.amazon.com [10.0.10.100:16435]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.20.189:2525]\n with esmtp (Farcaster)\n id 2f19aa9a-f364-429c-a958-eddf79339485; Wed, 6 Mar 2024 12:25:29 +0000 (UTC)", "from EX19D007EUB001.ant.amazon.com (10.252.51.82) by\n EX19MTAEUC002.ant.amazon.com (10.252.51.181) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Wed, 6 Mar 2024 12:25:29 +0000", "from EX19MTAUWA001.ant.amazon.com (10.250.64.204) by\n EX19D007EUB001.ant.amazon.com (10.252.51.82) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Wed, 6 Mar 2024 12:25:29 +0000", "from HFA15-CG15235BS.amazon.com (10.1.213.21) by\n mail-relay.amazon.com (10.250.64.204) with Microsoft SMTP Server id\n 15.2.1258.28 via Frontend Transport; Wed, 6 Mar 2024 12:25:27 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1709727932; x=1741263932;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=O0+oR5JplhxY96zOHRd2LLJ5SaMRR4Ok/D1V4hIxZ0I=;\n b=Y4zeatQpuaDl2gamcw9lot99GP5/BE2AGMLi+IXugYDUNCj782BIzj9+\n wvOfYq3OtNWo+hu8h9tPTFl5PmlRdi+aAcnttDPUZmJs/3qfmgm6SlE7Y\n fv/iCw/AGSfIfysowyXeT+GMvWqYQX8gnoh1/kV9FsrtfZyjuzvusPp5B 0=;", "X-IronPort-AV": "E=Sophos;i=\"6.06,208,1705363200\"; d=\"scan'208\";a=\"709065867\"", "X-Farcaster-Flow-ID": "2f19aa9a-f364-429c-a958-eddf79339485", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>", "Subject": "[PATCH v3 19/33] net/ena/hal: missing admin interrupt reset reason", "Date": "Wed, 6 Mar 2024 14:24:31 +0200", "Message-ID": "<20240306122445.4350-20-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240306122445.4350-1-shaibran@amazon.com>", "References": "<20240306122445.4350-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\nThere can be cases when we trigger reset if an admin interrupt\nis missing.\nIn order to identify this use-case specifically,\nthis commit adds a new reset reason.\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\n drivers/net/ena/hal/ena_com.c | 2 ++\n drivers/net/ena/hal/ena_com.h | 12 ++++++++++++\n drivers/net/ena/hal/ena_defs/ena_regs_defs.h | 1 +\n 3 files changed, 15 insertions(+)", "diff": "diff --git a/drivers/net/ena/hal/ena_com.c b/drivers/net/ena/hal/ena_com.c\nindex d2de5e172d..8e9c112715 100644\n--- a/drivers/net/ena/hal/ena_com.c\n+++ b/drivers/net/ena/hal/ena_com.c\n@@ -803,6 +803,7 @@ static int ena_com_wait_and_process_admin_cq_interrupts(struct ena_comp_ctx *com\n \t\tENA_SPINLOCK_UNLOCK(admin_queue->q_lock, flags);\n \n \t\tif (comp_ctx->status == ENA_CMD_COMPLETED) {\n+\t\t\tadmin_queue->is_missing_admin_interrupt = true;\n \t\t\tena_trc_err(admin_queue->ena_dev,\n \t\t\t\t \"The ena device sent a completion but the driver didn't receive a MSI-X interrupt (cmd %d), autopolling mode is %s\\n\",\n \t\t\t\t comp_ctx->cmd_opcode, admin_queue->auto_polling ? \"ON\" : \"OFF\");\n@@ -2138,6 +2139,7 @@ int ena_com_admin_init(struct ena_com_dev *ena_dev,\n \n \tadmin_queue->ena_dev = ena_dev;\n \tadmin_queue->running_state = true;\n+\tadmin_queue->is_missing_admin_interrupt = false;\n \n \treturn 0;\n error:\ndiff --git a/drivers/net/ena/hal/ena_com.h b/drivers/net/ena/hal/ena_com.h\nindex c62016cc06..c999cd2381 100644\n--- a/drivers/net/ena/hal/ena_com.h\n+++ b/drivers/net/ena/hal/ena_com.h\n@@ -237,6 +237,8 @@ struct ena_com_admin_queue {\n \t */\n \tbool running_state;\n \n+\tbool is_missing_admin_interrupt;\n+\n \t/* Count the number of outstanding admin commands */\n \tena_atomic32_t outstanding_cmds;\n \n@@ -1089,6 +1091,16 @@ int ena_com_config_dev_mode(struct ena_com_dev *ena_dev,\n \t\t\t struct ena_admin_feature_llq_desc *llq_features,\n \t\t\t struct ena_llq_configurations *llq_default_config);\n \n+/* ena_com_get_missing_admin_interrupt - Return if there is a missing admin interrupt\n+ * @ena_dev: ENA communication layer struct\n+ *\n+ * @return - true if there is a missing admin interrupt or false otherwise\n+ */\n+static inline bool ena_com_get_missing_admin_interrupt(struct ena_com_dev *ena_dev)\n+{\n+\treturn ena_dev->admin_queue.is_missing_admin_interrupt;\n+}\n+\n /* ena_com_io_sq_to_ena_dev - Extract ena_com_dev using contained field io_sq.\n * @io_sq: IO submit queue struct\n *\ndiff --git a/drivers/net/ena/hal/ena_defs/ena_regs_defs.h b/drivers/net/ena/hal/ena_defs/ena_regs_defs.h\nindex a94025dc77..db6a97d675 100644\n--- a/drivers/net/ena/hal/ena_defs/ena_regs_defs.h\n+++ b/drivers/net/ena/hal/ena_defs/ena_regs_defs.h\n@@ -24,6 +24,7 @@ enum ena_regs_reset_reason_types {\n \tENA_REGS_RESET_SUSPECTED_POLL_STARVATION = 15,\n \tENA_REGS_RESET_RX_DESCRIPTOR_MALFORMED\t = 16,\n \tENA_REGS_RESET_TX_DESCRIPTOR_MALFORMED\t = 17,\n+\tENA_REGS_RESET_MISSING_ADMIN_INTERRUPT = 18,\n \tENA_REGS_RESET_LAST,\n };\n \n", "prefixes": [ "v3", "19/33" ] }