Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138027/?format=api
{ "id": 138027, "url": "https://patches.dpdk.org/api/patches/138027/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240306122445.4350-14-shaibran@amazon.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240306122445.4350-14-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240306122445.4350-14-shaibran@amazon.com", "date": "2024-03-06T12:24:25", "name": "[v3,13/33] net/ena/hal: use correct read once on u8 field", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0639a647eb5c9e64ae3571aefdb69d203fba3b46", "submitter": { "id": 2930, "url": "https://patches.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240306122445.4350-14-shaibran@amazon.com/mbox/", "series": [ { "id": 31397, "url": "https://patches.dpdk.org/api/series/31397/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31397", "date": "2024-03-06T12:24:13", "name": "net/ena: v2.9.0 driver release", "version": 3, "mbox": "https://patches.dpdk.org/series/31397/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/138027/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/138027/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 493FE43C5B;\n\tWed, 6 Mar 2024 13:26:47 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 09BF342E57;\n\tWed, 6 Mar 2024 13:25:26 +0100 (CET)", "from smtp-fw-52005.amazon.com (smtp-fw-52005.amazon.com\n [52.119.213.156])\n by mails.dpdk.org (Postfix) with ESMTP id 1A94C42E54\n for <dev@dpdk.org>; Wed, 6 Mar 2024 13:25:24 +0100 (CET)", "from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO\n smtpout.prod.us-east-1.prod.farcaster.email.amazon.dev) ([10.43.8.6])\n by smtp-border-fw-52005.iad7.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2024 12:25:24 +0000", "from EX19MTAEUA001.ant.amazon.com [10.0.43.254:17957]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.41.19:2525]\n with esmtp (Farcaster)\n id 293ef85b-ec66-44d7-a251-2fcb8d688509; Wed, 6 Mar 2024 12:25:22 +0000 (UTC)", "from EX19D007EUA001.ant.amazon.com (10.252.50.133) by\n EX19MTAEUA001.ant.amazon.com (10.252.50.50) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Wed, 6 Mar 2024 12:25:22 +0000", "from EX19MTAUWA001.ant.amazon.com (10.250.64.204) by\n EX19D007EUA001.ant.amazon.com (10.252.50.133) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Wed, 6 Mar 2024 12:25:16 +0000", "from HFA15-CG15235BS.amazon.com (10.1.213.21) by\n mail-relay.amazon.com (10.250.64.204) with Microsoft SMTP Server id\n 15.2.1258.28 via Frontend Transport; Wed, 6 Mar 2024 12:25:15 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1709727925; x=1741263925;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=dI/+4j50ym1i6p7Y/+jdESCGnAYK60J+dlv/WbcCxD4=;\n b=hSdOUv/GDyzbJtUg0nldq60hlyxdjQcEg6fS34wckRsjTclaUptc1OEI\n ct6ylf4bF0FaDkBjkmwU2zjDS8BIR3UTPPeF0IvotYonpQR8sXEzEoijF\n pm3vuMXDTs1jYUOHaJa/bfci6V7g0rFIdgWX6md1gx4SqqN2/m3yHcwPp 0=;", "X-IronPort-AV": "E=Sophos;i=\"6.06,208,1705363200\"; d=\"scan'208\";a=\"638961965\"", "X-Farcaster-Flow-ID": "293ef85b-ec66-44d7-a251-2fcb8d688509", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>", "Subject": "[PATCH v3 13/33] net/ena/hal: use correct read once on u8 field", "Date": "Wed, 6 Mar 2024 14:24:25 +0200", "Message-ID": "<20240306122445.4350-14-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240306122445.4350-1-shaibran@amazon.com>", "References": "<20240306122445.4350-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\nThe flags field in ena_eth_io_tx_cdesc is 8-bits long.\nThe current macro used is READ_ONCE16.\nSwitching to READ_ONCE8 to avoid reading extra data.\nGiven that there's an implicit cast to u8 in the assignment,\nthe correct value is being read, but this change makes it\neven more accurate.\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\n drivers/net/ena/hal/ena_eth_com.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ena/hal/ena_eth_com.h b/drivers/net/ena/hal/ena_eth_com.h\nindex cee4f35124..6a7c17f84f 100644\n--- a/drivers/net/ena/hal/ena_eth_com.h\n+++ b/drivers/net/ena/hal/ena_eth_com.h\n@@ -219,7 +219,7 @@ static inline int ena_com_tx_comp_req_id_get(struct ena_com_io_cq *io_cq,\n \t * expected, it mean that the device still didn't update\n \t * this completion.\n \t */\n-\tcdesc_phase = READ_ONCE16(cdesc->flags) & ENA_ETH_IO_TX_CDESC_PHASE_MASK;\n+\tcdesc_phase = READ_ONCE8(cdesc->flags) & ENA_ETH_IO_TX_CDESC_PHASE_MASK;\n \tif (cdesc_phase != expected_phase)\n \t\treturn ENA_COM_TRY_AGAIN;\n \n", "prefixes": [ "v3", "13/33" ] }