Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137712/?format=api
{ "id": 137712, "url": "https://patches.dpdk.org/api/patches/137712/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240301171707.95242-23-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240301171707.95242-23-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240301171707.95242-23-stephen@networkplumber.org", "date": "2024-03-01T17:15:18", "name": "[v2,22/71] raw/ifpga: replace use of fixed size rte_memcpy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6175203160afb913593a812ee4cce159956a287b", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240301171707.95242-23-stephen@networkplumber.org/mbox/", "series": [ { "id": 31340, "url": "https://patches.dpdk.org/api/series/31340/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31340", "date": "2024-03-01T17:14:57", "name": "replace use of fixed size rte_mempcy", "version": 2, "mbox": "https://patches.dpdk.org/series/31340/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/137712/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/137712/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5DA4A43C12;\n\tFri, 1 Mar 2024 18:20:09 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2E10D433FB;\n\tFri, 1 Mar 2024 18:17:49 +0100 (CET)", "from mail-pl1-f169.google.com (mail-pl1-f169.google.com\n [209.85.214.169])\n by mails.dpdk.org (Postfix) with ESMTP id 196EF43380\n for <dev@dpdk.org>; Fri, 1 Mar 2024 18:17:35 +0100 (CET)", "by mail-pl1-f169.google.com with SMTP id\n d9443c01a7336-1dccb2edc6dso21726995ad.3\n for <dev@dpdk.org>; Fri, 01 Mar 2024 09:17:35 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 Mar 2024 09:17:33 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313454;\n x=1709918254; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8IXPh2XA6t/KG9Hv6IJExd3Kk0yelBv352QTLzXYV34=;\n b=vjZJPNnwzAv3GiP/5CCKEV19EoInzYh+AKX9nVTDh+kdJ0gBQwf9OknwYqEfxHFLXP\n hybSQt/a+OESVK21I/EsBgPPGTwDAnWiy2EoLzR7nXsXQRnt6k7+E+UsjPmHUxh3JPdm\n ZSPnZ1xtok4GmfW4Td8NPypcTfADPIM7ODHgT3v7Q5+I9gycbGq4+e6bntbKRfA17D6v\n ib38TtozvcpatBedp+IJ1WO1mjViB+xqODRzrKIHZN+7nPO2Z0BPSzagpTV1GB8znNC3\n fycfmV7vk7LzC8uu6yjMg4tMMmPoC/c3/DYlyMr1NWqBCA13+2zwy4CCqLnZdLzJXDZe\n 6fTg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1709313454; x=1709918254;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=8IXPh2XA6t/KG9Hv6IJExd3Kk0yelBv352QTLzXYV34=;\n b=xD2fJBj68eTfK80oFq6zf0CAkt+lw9/DXeLQZxjdtO+B8mLXrLdO7VnJtfy6qIowtc\n zavp+z5aKILnqStaxUiGH9Kc4mMYAApHo3E33iEWizesMVbNKejZhpxg6UiEPxnvDU61\n jtRddJ8+oThj0JaP6akKLSn+B8ZdbVelSKBY9wLATrKnERBvagLEr4nGlwJuWyZqCvx/\n qmlv6M8G9sFIgBmp43e0WrajLlOqGXw33rhluFcLK+qvb6880X+usfzGRKeKoy9yZbLV\n moBs237TviJEgtUwGzKu9Sn4LZ6MO6aj3tbylRHO5IxAhaNDfDXxXPPXMcMR/3Zg+SG7\n g6EQ==", "X-Gm-Message-State": "AOJu0YyN14cG+ENdskzrmu9gbNBAFaL1HGb5D2iUpaMBbumq7mtp81Sr\n qDe/juTmULyBfovOVz3bOiuvI7RJe4DFGQE4v+QgmhU31jbhy4xvn4FgHRgrok7OSlUMODbLeg6\n gFu1fvA==", "X-Google-Smtp-Source": "\n AGHT+IExXKQPZ8C3zBve9wq0LvSNQKTgmBWuA7JPR+4nFPgYW2kNZ0L7PK7ZMGhHfX1O7p8fs/a4NA==", "X-Received": "by 2002:a17:902:e943:b0:1db:cea0:9d62 with SMTP id\n b3-20020a170902e94300b001dbcea09d62mr2746013pll.9.1709313454268;\n Fri, 01 Mar 2024 09:17:34 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Rosen Xu <rosen.xu@intel.com>", "Subject": "[PATCH v2 22/71] raw/ifpga: replace use of fixed size rte_memcpy", "Date": "Fri, 1 Mar 2024 09:15:18 -0800", "Message-ID": "<20240301171707.95242-23-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240301171707.95242-1-stephen@networkplumber.org>", "References": "<20240229225936.483472-1-stephen@networkplumber.org>\n <20240301171707.95242-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Automatically generated by devtools/cocci/rte_memcpy.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/raw/ifpga/afu_pmd_he_hssi.c | 3 +--\n drivers/raw/ifpga/afu_pmd_he_lpbk.c | 3 +--\n drivers/raw/ifpga/afu_pmd_he_mem.c | 3 +--\n drivers/raw/ifpga/afu_pmd_n3000.c | 8 ++++----\n drivers/raw/ifpga/ifpga_rawdev.c | 11 +++++------\n 5 files changed, 12 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/raw/ifpga/afu_pmd_he_hssi.c b/drivers/raw/ifpga/afu_pmd_he_hssi.c\nindex 859f28dcc1f0..c2aaed9203ae 100644\n--- a/drivers/raw/ifpga/afu_pmd_he_hssi.c\n+++ b/drivers/raw/ifpga/afu_pmd_he_hssi.c\n@@ -15,7 +15,6 @@\n \n #include <rte_eal.h>\n #include <rte_malloc.h>\n-#include <rte_memcpy.h>\n #include <rte_io.h>\n #include <rte_vfio.h>\n #include <bus_pci_driver.h>\n@@ -314,7 +313,7 @@ static int he_hssi_config(struct afu_rawdev *dev, void *config,\n \tif (cfg->port >= NUM_HE_HSSI_PORTS)\n \t\treturn -EINVAL;\n \n-\trte_memcpy(&priv->he_hssi_cfg, cfg, sizeof(priv->he_hssi_cfg));\n+\tmemcpy(&priv->he_hssi_cfg, cfg, sizeof(priv->he_hssi_cfg));\n \n \treturn 0;\n }\ndiff --git a/drivers/raw/ifpga/afu_pmd_he_lpbk.c b/drivers/raw/ifpga/afu_pmd_he_lpbk.c\nindex c7c5cda48c35..ffb7075c84d2 100644\n--- a/drivers/raw/ifpga/afu_pmd_he_lpbk.c\n+++ b/drivers/raw/ifpga/afu_pmd_he_lpbk.c\n@@ -15,7 +15,6 @@\n \n #include <rte_eal.h>\n #include <rte_malloc.h>\n-#include <rte_memcpy.h>\n #include <rte_io.h>\n #include <rte_vfio.h>\n #include <bus_pci_driver.h>\n@@ -363,7 +362,7 @@ static int he_lpbk_config(struct afu_rawdev *dev, void *config,\n \tif ((cfg->end < cfg->begin) || (cfg->end > MAX_CACHE_LINES))\n \t\treturn -EINVAL;\n \n-\trte_memcpy(&priv->he_lpbk_cfg, cfg, sizeof(priv->he_lpbk_cfg));\n+\tmemcpy(&priv->he_lpbk_cfg, cfg, sizeof(priv->he_lpbk_cfg));\n \n \treturn 0;\n }\ndiff --git a/drivers/raw/ifpga/afu_pmd_he_mem.c b/drivers/raw/ifpga/afu_pmd_he_mem.c\nindex a1db533eeb93..b799e40d2db9 100644\n--- a/drivers/raw/ifpga/afu_pmd_he_mem.c\n+++ b/drivers/raw/ifpga/afu_pmd_he_mem.c\n@@ -14,7 +14,6 @@\n \n #include <rte_eal.h>\n #include <rte_malloc.h>\n-#include <rte_memcpy.h>\n #include <rte_io.h>\n #include <rte_vfio.h>\n #include <bus_pci_driver.h>\n@@ -126,7 +125,7 @@ static int he_mem_tg_config(struct afu_rawdev *dev, void *config,\n \tif (config_size != sizeof(struct rte_pmd_afu_he_mem_tg_cfg))\n \t\treturn -EINVAL;\n \n-\trte_memcpy(&priv->he_mem_tg_cfg, config, sizeof(priv->he_mem_tg_cfg));\n+\tmemcpy(&priv->he_mem_tg_cfg, config, sizeof(priv->he_mem_tg_cfg));\n \n \treturn 0;\n }\ndiff --git a/drivers/raw/ifpga/afu_pmd_n3000.c b/drivers/raw/ifpga/afu_pmd_n3000.c\nindex 67b394126595..9236c0b15371 100644\n--- a/drivers/raw/ifpga/afu_pmd_n3000.c\n+++ b/drivers/raw/ifpga/afu_pmd_n3000.c\n@@ -1867,8 +1867,8 @@ static int n3000_afu_config(struct afu_rawdev *dev, void *config,\n \t\tif ((cfg->nlb_cfg.end < cfg->nlb_cfg.begin) ||\n \t\t\t(cfg->nlb_cfg.end > MAX_CACHE_LINES))\n \t\t\treturn -EINVAL;\n-\t\trte_memcpy(&priv->nlb_cfg, &cfg->nlb_cfg,\n-\t\t\tsizeof(struct rte_pmd_afu_nlb_cfg));\n+\t\tmemcpy(&priv->nlb_cfg, &cfg->nlb_cfg,\n+\t\t sizeof(struct rte_pmd_afu_nlb_cfg));\n \t} else if (cfg->type == RTE_PMD_AFU_N3000_DMA) {\n \t\tif (cfg->dma_cfg.index >= NUM_N3000_DMA)\n \t\t\treturn -EINVAL;\n@@ -1887,8 +1887,8 @@ static int n3000_afu_config(struct afu_rawdev *dev, void *config,\n \t\t\t\t\tcfg->dma_cfg.length);\n \t\t\t}\n \t\t}\n-\t\trte_memcpy(&priv->dma_cfg, &cfg->dma_cfg,\n-\t\t\tsizeof(struct rte_pmd_afu_dma_cfg));\n+\t\tmemcpy(&priv->dma_cfg, &cfg->dma_cfg,\n+\t\t sizeof(struct rte_pmd_afu_dma_cfg));\n \t} else {\n \t\tIFPGA_RAWDEV_PMD_ERR(\"Invalid type of N3000 AFU\");\n \t\treturn -EINVAL;\ndiff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c\nindex f89bd3f9e2c3..d5d47e14dd0e 100644\n--- a/drivers/raw/ifpga/ifpga_rawdev.c\n+++ b/drivers/raw/ifpga/ifpga_rawdev.c\n@@ -14,7 +14,6 @@\n #include <rte_log.h>\n #include <rte_malloc.h>\n #include <rte_devargs.h>\n-#include <rte_memcpy.h>\n #include <rte_pci.h>\n #include <bus_pci_driver.h>\n #include <rte_kvargs.h>\n@@ -258,7 +257,7 @@ static int ifpga_rawdev_fill_info(struct ifpga_rawdev *ifpga_dev)\n \tif (point < 12)\n \t\treturn -1;\n \tpoint -= 12;\n-\trte_memcpy(ifpga_dev->parent_bdf, &link[point], 12);\n+\tmemcpy(ifpga_dev->parent_bdf, &link[point], 12);\n \n \tpoint = strlen(link1);\n \tif (point < 26)\n@@ -948,10 +947,10 @@ ifpga_rawdev_pr(struct rte_rawdev *dev,\n \t\tif (ret)\n \t\t\treturn ret;\n \n-\t\trte_memcpy(&afu_pr_conf->afu_id.uuid.uuid_low, uuid.b,\n-\t\t\tsizeof(u64));\n-\t\trte_memcpy(&afu_pr_conf->afu_id.uuid.uuid_high, uuid.b + 8,\n-\t\t\tsizeof(u64));\n+\t\tmemcpy(&afu_pr_conf->afu_id.uuid.uuid_low, uuid.b,\n+\t\t sizeof(u64));\n+\t\tmemcpy(&afu_pr_conf->afu_id.uuid.uuid_high, uuid.b + 8,\n+\t\t sizeof(u64));\n \n \t\tIFPGA_RAWDEV_PMD_INFO(\"%s: uuid_l=0x%lx, uuid_h=0x%lx\\n\",\n \t\t\t__func__,\n", "prefixes": [ "v2", "22/71" ] }