Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137683/?format=api
{ "id": 137683, "url": "https://patches.dpdk.org/api/patches/137683/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240301162553.30523-2-rnagadheeraj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240301162553.30523-2-rnagadheeraj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240301162553.30523-2-rnagadheeraj@marvell.com", "date": "2024-03-01T16:25:47", "name": "[v4,1/7] crypto/nitrox: move common code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "84fb7b246ae85633ae24e592b04027d417f6489b", "submitter": { "id": 1365, "url": "https://patches.dpdk.org/api/people/1365/?format=api", "name": "Nagadheeraj Rottela", "email": "rnagadheeraj@marvell.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240301162553.30523-2-rnagadheeraj@marvell.com/mbox/", "series": [ { "id": 31338, "url": "https://patches.dpdk.org/api/series/31338/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31338", "date": "2024-03-01T16:25:46", "name": "add Nitrox compress device support", "version": 1, "mbox": "https://patches.dpdk.org/series/31338/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/137683/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/137683/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4614E43C0C;\n\tFri, 1 Mar 2024 17:26:13 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E68904328F;\n\tFri, 1 Mar 2024 17:26:06 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 3E57642FFB\n for <dev@dpdk.org>; Fri, 1 Mar 2024 17:26:05 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id\n 4219qqee024794; Fri, 1 Mar 2024 08:26:04 -0800", "from dc5-exch05.marvell.com ([199.233.59.128])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3wjfay86wt-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Fri, 01 Mar 2024 08:26:04 -0800 (PST)", "from DC5-EXCH05.marvell.com (10.69.176.209) by\n DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.12; Fri, 1 Mar 2024 08:26:02 -0800", "from hyd1399.caveonetworks.com.com (10.69.176.80) by\n DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server id\n 15.2.1258.12 via Frontend Transport; Fri, 1 Mar 2024 08:26:00 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=\n pfpt0220; bh=Zo88+aRjswIPfN7XYP4P8NUEroL1ovIXwtTDGggGhmc=; b=Nni\n iqTi3qhtrlSp3EiJdw7UrT6LKHaufKCdDhZPU7KHvaMxGXl3+GbeTxiRzJlM8RW7\n JFN1TaWpa+FeiAyBXMfy2T088A9uUutKiygk2Tf+cgirDv3vkb9nKQaWIGBqlF3K\n O9Pv2uWS5PI3uJjIMuqW9lrMYcNk/x95OTzlKI8zfizLB0K4FdQdX0pz2reXGCGk\n BwFdbBgAFHhNakbiOwdiprdRad13nCyu5fsHi4CAZ8FG1gvdNUZN8TXJoSuKYLO6\n RMCHRUWzrixLzGmnKytb17PBEsnSnaAk034qujZ/50WIbI0dwbnOWKc34rZq7Axh\n TKrDa3K5g52f7rtBYuQ==", "From": "Nagadheeraj Rottela <rnagadheeraj@marvell.com>", "To": "<gakhil@marvell.com>, <fanzhang.oss@gmail.com>, <ashishg@marvell.com>", "CC": "<dev@dpdk.org>, Nagadheeraj Rottela <rnagadheeraj@marvell.com>", "Subject": "[PATCH v4 1/7] crypto/nitrox: move common code", "Date": "Fri, 1 Mar 2024 21:55:47 +0530", "Message-ID": "<20240301162553.30523-2-rnagadheeraj@marvell.com>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20240301162553.30523-1-rnagadheeraj@marvell.com>", "References": "<20240301162553.30523-1-rnagadheeraj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "soAb1pRxopHfERnCqTqYwIMcGHav_gmq", "X-Proofpoint-GUID": "soAb1pRxopHfERnCqTqYwIMcGHav_gmq", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2024-03-01_17,2024-03-01_02,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "A new compressdev Nitrox PMD will be added in next few patches.\nThis patch moves some of the common code which is shared across\nNitrox crypto and compress drivers to drivers/common/nitrox folder.\n\nSigned-off-by: Nagadheeraj Rottela <rnagadheeraj@marvell.com>\n---\n MAINTAINERS | 1 +\n drivers/common/nitrox/meson.build | 18 ++++++++++++++++++\n drivers/{crypto => common}/nitrox/nitrox_csr.h | 0\n .../{crypto => common}/nitrox/nitrox_device.c | 14 ++++++++++++++\n .../{crypto => common}/nitrox/nitrox_device.h | 1 -\n drivers/{crypto => common}/nitrox/nitrox_hal.c | 0\n drivers/{crypto => common}/nitrox/nitrox_hal.h | 0\n .../{crypto => common}/nitrox/nitrox_logs.c | 0\n .../{crypto => common}/nitrox/nitrox_logs.h | 0\n drivers/{crypto => common}/nitrox/nitrox_qp.c | 2 +-\n drivers/{crypto => common}/nitrox/nitrox_qp.h | 11 ++++++++++-\n drivers/common/nitrox/version.map | 9 +++++++++\n drivers/crypto/nitrox/meson.build | 11 +++++------\n drivers/meson.build | 1 +\n 14 files changed, 59 insertions(+), 9 deletions(-)\n create mode 100644 drivers/common/nitrox/meson.build\n rename drivers/{crypto => common}/nitrox/nitrox_csr.h (100%)\n rename drivers/{crypto => common}/nitrox/nitrox_device.c (92%)\n rename drivers/{crypto => common}/nitrox/nitrox_device.h (94%)\n rename drivers/{crypto => common}/nitrox/nitrox_hal.c (100%)\n rename drivers/{crypto => common}/nitrox/nitrox_hal.h (100%)\n rename drivers/{crypto => common}/nitrox/nitrox_logs.c (100%)\n rename drivers/{crypto => common}/nitrox/nitrox_logs.h (100%)\n rename drivers/{crypto => common}/nitrox/nitrox_qp.c (99%)\n rename drivers/{crypto => common}/nitrox/nitrox_qp.h (91%)\n create mode 100644 drivers/common/nitrox/version.map", "diff": "diff --git a/MAINTAINERS b/MAINTAINERS\nindex 962c359cdd..d6abebc55c 100644\n--- a/MAINTAINERS\n+++ b/MAINTAINERS\n@@ -1142,6 +1142,7 @@ Marvell Nitrox\n M: Nagadheeraj Rottela <rnagadheeraj@marvell.com>\n M: Srikanth Jampala <jsrikanth@marvell.com>\n F: drivers/crypto/nitrox/\n+F: drivers/common/nitrox/\n F: doc/guides/cryptodevs/nitrox.rst\n F: doc/guides/cryptodevs/features/nitrox.ini\n \ndiff --git a/drivers/common/nitrox/meson.build b/drivers/common/nitrox/meson.build\nnew file mode 100644\nindex 0000000000..99fadbbfc9\n--- /dev/null\n+++ b/drivers/common/nitrox/meson.build\n@@ -0,0 +1,18 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright (c) 2024 Marvell.\n+\n+if not is_linux\n+ build = false\n+ reason = 'only supported on Linux'\n+endif\n+\n+deps += ['bus_pci']\n+\n+sources += files(\n+ 'nitrox_device.c',\n+ 'nitrox_hal.c',\n+ 'nitrox_logs.c',\n+ 'nitrox_qp.c',\n+)\n+\n+includes += include_directories('../../crypto/nitrox')\ndiff --git a/drivers/crypto/nitrox/nitrox_csr.h b/drivers/common/nitrox/nitrox_csr.h\nsimilarity index 100%\nrename from drivers/crypto/nitrox/nitrox_csr.h\nrename to drivers/common/nitrox/nitrox_csr.h\ndiff --git a/drivers/crypto/nitrox/nitrox_device.c b/drivers/common/nitrox/nitrox_device.c\nsimilarity index 92%\nrename from drivers/crypto/nitrox/nitrox_device.c\nrename to drivers/common/nitrox/nitrox_device.c\nindex 5b319dd681..b2f638ec8a 100644\n--- a/drivers/crypto/nitrox/nitrox_device.c\n+++ b/drivers/common/nitrox/nitrox_device.c\n@@ -120,5 +120,19 @@ static struct rte_pci_driver nitrox_pmd = {\n \t.remove = nitrox_pci_remove,\n };\n \n+__rte_weak int\n+nitrox_sym_pmd_create(struct nitrox_device *ndev)\n+{\n+\tRTE_SET_USED(ndev);\n+\treturn 0;\n+}\n+\n+__rte_weak int\n+nitrox_sym_pmd_destroy(struct nitrox_device *ndev)\n+{\n+\tRTE_SET_USED(ndev);\n+\treturn 0;\n+}\n+\n RTE_PMD_REGISTER_PCI(nitrox, nitrox_pmd);\n RTE_PMD_REGISTER_PCI_TABLE(nitrox, pci_id_nitrox_map);\ndiff --git a/drivers/crypto/nitrox/nitrox_device.h b/drivers/common/nitrox/nitrox_device.h\nsimilarity index 94%\nrename from drivers/crypto/nitrox/nitrox_device.h\nrename to drivers/common/nitrox/nitrox_device.h\nindex 1ff7c59b63..b7c7ffd772 100644\n--- a/drivers/crypto/nitrox/nitrox_device.h\n+++ b/drivers/common/nitrox/nitrox_device.h\n@@ -6,7 +6,6 @@\n #define _NITROX_DEVICE_H_\n \n #include <bus_pci_driver.h>\n-#include <rte_cryptodev.h>\n \n struct nitrox_sym_device;\n \ndiff --git a/drivers/crypto/nitrox/nitrox_hal.c b/drivers/common/nitrox/nitrox_hal.c\nsimilarity index 100%\nrename from drivers/crypto/nitrox/nitrox_hal.c\nrename to drivers/common/nitrox/nitrox_hal.c\ndiff --git a/drivers/crypto/nitrox/nitrox_hal.h b/drivers/common/nitrox/nitrox_hal.h\nsimilarity index 100%\nrename from drivers/crypto/nitrox/nitrox_hal.h\nrename to drivers/common/nitrox/nitrox_hal.h\ndiff --git a/drivers/crypto/nitrox/nitrox_logs.c b/drivers/common/nitrox/nitrox_logs.c\nsimilarity index 100%\nrename from drivers/crypto/nitrox/nitrox_logs.c\nrename to drivers/common/nitrox/nitrox_logs.c\ndiff --git a/drivers/crypto/nitrox/nitrox_logs.h b/drivers/common/nitrox/nitrox_logs.h\nsimilarity index 100%\nrename from drivers/crypto/nitrox/nitrox_logs.h\nrename to drivers/common/nitrox/nitrox_logs.h\ndiff --git a/drivers/crypto/nitrox/nitrox_qp.c b/drivers/common/nitrox/nitrox_qp.c\nsimilarity index 99%\nrename from drivers/crypto/nitrox/nitrox_qp.c\nrename to drivers/common/nitrox/nitrox_qp.c\nindex 5e85ccbd51..79a26f0024 100644\n--- a/drivers/crypto/nitrox/nitrox_qp.c\n+++ b/drivers/common/nitrox/nitrox_qp.c\n@@ -2,7 +2,7 @@\n * Copyright(C) 2019 Marvell International Ltd.\n */\n \n-#include <rte_cryptodev.h>\n+#include <rte_memzone.h>\n #include <rte_malloc.h>\n \n #include \"nitrox_qp.h\"\ndiff --git a/drivers/crypto/nitrox/nitrox_qp.h b/drivers/common/nitrox/nitrox_qp.h\nsimilarity index 91%\nrename from drivers/crypto/nitrox/nitrox_qp.h\nrename to drivers/common/nitrox/nitrox_qp.h\nindex d42d53f92b..23dffd1268 100644\n--- a/drivers/crypto/nitrox/nitrox_qp.h\n+++ b/drivers/common/nitrox/nitrox_qp.h\n@@ -22,6 +22,13 @@ struct rid {\n \tstruct nitrox_softreq *sr;\n };\n \n+struct nitrox_qp_stats {\n+\tuint64_t enqueued_count;\n+\tuint64_t dequeued_count;\n+\tuint64_t enqueue_err_count;\n+\tuint64_t dequeue_err_count;\n+};\n+\n struct nitrox_qp {\n \tstruct command_queue cmdq;\n \tstruct rid *ridq;\n@@ -29,7 +36,7 @@ struct nitrox_qp {\n \tuint32_t head;\n \tuint32_t tail;\n \tstruct rte_mempool *sr_mp;\n-\tstruct rte_cryptodev_stats stats;\n+\tstruct nitrox_qp_stats stats;\n \tuint16_t qno;\n \trte_atomic16_t pending_count;\n };\n@@ -96,9 +103,11 @@ nitrox_qp_dequeue(struct nitrox_qp *qp)\n \trte_atomic16_dec(&qp->pending_count);\n }\n \n+__rte_internal\n int nitrox_qp_setup(struct nitrox_qp *qp, uint8_t *bar_addr,\n \t\t const char *dev_name, uint32_t nb_descriptors,\n \t\t uint8_t inst_size, int socket_id);\n+__rte_internal\n int nitrox_qp_release(struct nitrox_qp *qp, uint8_t *bar_addr);\n \n #endif /* _NITROX_QP_H_ */\ndiff --git a/drivers/common/nitrox/version.map b/drivers/common/nitrox/version.map\nnew file mode 100644\nindex 0000000000..43295171e4\n--- /dev/null\n+++ b/drivers/common/nitrox/version.map\n@@ -0,0 +1,9 @@\n+INTERNAL {\n+\tglobal:\n+\n+\tnitrox_logtype;\n+\tnitrox_qp_release;\n+\tnitrox_qp_setup;\n+\n+\tlocal: *;\n+};\ndiff --git a/drivers/crypto/nitrox/meson.build b/drivers/crypto/nitrox/meson.build\nindex 2cc47c4626..f8887713d2 100644\n--- a/drivers/crypto/nitrox/meson.build\n+++ b/drivers/crypto/nitrox/meson.build\n@@ -6,13 +6,12 @@ if not is_linux\n reason = 'only supported on Linux'\n endif\n \n-deps += ['bus_pci']\n-sources = files(\n- 'nitrox_device.c',\n- 'nitrox_hal.c',\n- 'nitrox_logs.c',\n+deps += ['common_nitrox', 'bus_pci', 'cryptodev']\n+\n+sources += files(\n 'nitrox_sym.c',\n 'nitrox_sym_capabilities.c',\n 'nitrox_sym_reqmgr.c',\n- 'nitrox_qp.c',\n )\n+\n+includes += include_directories('../../common/nitrox')\ndiff --git a/drivers/meson.build b/drivers/meson.build\nindex f2be71bc05..9fd66e3264 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -14,6 +14,7 @@ subdirs = [\n 'common/cnxk', # depends on bus.\n 'common/mlx5', # depends on bus.\n 'common/nfp', # depends on bus.\n+\t'common/nitrox', # depends on bus.\n 'common/qat', # depends on bus.\n 'common/sfc_efx', # depends on bus.\n 'mempool', # depends on common and bus.\n", "prefixes": [ "v4", "1/7" ] }