Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137646/?format=api
{ "id": 137646, "url": "https://patches.dpdk.org/api/patches/137646/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240301104129.3725-1-laitianli@tom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240301104129.3725-1-laitianli@tom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240301104129.3725-1-laitianli@tom.com", "date": "2024-03-01T10:41:29", "name": "app/dumpcap:fix coredump problem because pcap_dump 3th argument is null", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9fec995c158d526329ed32178d34c2b9f36dd21a", "submitter": { "id": 2404, "url": "https://patches.dpdk.org/api/people/2404/?format=api", "name": "Tianli Lai", "email": "laitianli@tom.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240301104129.3725-1-laitianli@tom.com/mbox/", "series": [ { "id": 31315, "url": "https://patches.dpdk.org/api/series/31315/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31315", "date": "2024-03-01T10:41:29", "name": "app/dumpcap:fix coredump problem because pcap_dump 3th argument is null", "version": 1, "mbox": "https://patches.dpdk.org/series/31315/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/137646/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/137646/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 27C2843B68;\n\tFri, 1 Mar 2024 03:41:48 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DC904402CD;\n\tFri, 1 Mar 2024 03:41:47 +0100 (CET)", "from smtp.tom.com (smtprz22.163.net [106.38.219.107])\n by mails.dpdk.org (Postfix) with ESMTP id BCECA4025C\n for <dev@dpdk.org>; Fri, 1 Mar 2024 03:41:45 +0100 (CET)", "from my-app01.tom.com (my-app01.tom.com [127.0.0.1])\n by freemail01.tom.com (Postfix) with ESMTP id BF0DA1EA00CF\n for <dev@dpdk.org>; Fri, 1 Mar 2024 10:41:42 +0800 (CST)", "from my-app01.tom.com (HELO smtp.tom.com) ([127.0.0.1])\n by my-app01 (TOM SMTP Server) with SMTP ID -1363278598\n for <dev@dpdk.org>; Fri, 01 Mar 2024 10:41:42 +0800 (CST)", "from antispam3.tom.com (unknown [172.25.16.54])\n by freemail01.tom.com (Postfix) with ESMTP id B0F1F1EA0091\n for <dev@dpdk.org>; Fri, 1 Mar 2024 10:41:42 +0800 (CST)", "from antispam3.tom.com (antispam3.tom.com [127.0.0.1])\n by antispam3.tom.com (Postfix) with ESMTP id 87CC39C1AED\n for <dev@dpdk.org>; Fri, 1 Mar 2024 10:41:42 +0800 (CST)", "from antispam3.tom.com ([127.0.0.1])\n by antispam3.tom.com (antispam3.tom.com [127.0.0.1]) (amavisd-new,\n port 10024)\n with ESMTP id GRL7Jr2xYNqj for <dev@dpdk.org>;\n Fri, 1 Mar 2024 10:41:41 +0800 (CST)", "from localhost.localdomain (unknown [61.141.254.104])\n by antispam3.tom.com (Postfix) with ESMTPA id 942649C19F9;\n Fri, 1 Mar 2024 10:41:41 +0800 (CST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=tom.com; s=201807;\n t=1709260902; bh=C+4DQhsW1AHE+G5oixVUDK5XC7V2J1P4PPnFmoVO7c8=;\n h=From:To:Cc:Subject:Date:From;\n b=AtDamu7BkE4u9vBShsadf+C3pKyGnurTiC8EiAn90bntgtldhF8lEInt5sTgyV7T6\n Bt2WxdAu/jQJzvlTWt0o8UtNHq0wSABxI/Wq2QESey/qYftoBDXZHow20i12414zbo\n 0/n3ksdLFMr5vrL8/SV2joUxuN1P/RaWrcwduQJU=", "X-Virus-Scanned": "Debian amavisd-new at antispam3.tom.com", "From": "Tianli Lai <laitianli@tom.com>", "To": "dev@dpdk.org", "Cc": "Reshma Pattan <reshma.pattan@intel.com>,\n Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH] app/dumpcap:fix coredump problem because pcap_dump 3th\n argument is null", "Date": "Fri, 1 Mar 2024 18:41:29 +0800", "Message-Id": "<20240301104129.3725-1-laitianli@tom.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "if rte_pktmbuf_read() return NULL, pcap_dump() would coredump.\n\nSigned-off-by: Tianli Lai <laitianli@tom.com>\n---\n app/dumpcap/main.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c\nindex d57db0589a..c941fb92bf 100644\n--- a/app/dumpcap/main.c\n+++ b/app/dumpcap/main.c\n@@ -878,6 +878,7 @@ pcap_write_packets(pcap_dumper_t *dumper,\n \tstruct pcap_pkthdr header;\n \tuint16_t i;\n \tsize_t total = 0;\n+\tconst void *data;\n \n \tgettimeofday(&header.ts, NULL);\n \n@@ -886,9 +887,12 @@ pcap_write_packets(pcap_dumper_t *dumper,\n \n \t\theader.len = rte_pktmbuf_pkt_len(m);\n \t\theader.caplen = RTE_MIN(header.len, sizeof(temp_data));\n-\n-\t\tpcap_dump((u_char *)dumper, &header,\n-\t\t\t rte_pktmbuf_read(m, 0, header.caplen, temp_data));\n+\t\tdata = rte_pktmbuf_read(m, 0, header.caplen, temp_data);\n+\t\tif (!data) {\n+\t\t\trte_pktmbuf_free(m);\n+\t\t\tcontinue;\n+\t\t}\n+\t\tpcap_dump((u_char *)dumper, &header, data);\n \n \t\ttotal += sizeof(header) + header.len;\n \t}\n", "prefixes": [] }