Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1376,
    "url": "https://patches.dpdk.org/api/patches/1376/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1416474399-16851-14-git-send-email-mukawa@igel.co.jp/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1416474399-16851-14-git-send-email-mukawa@igel.co.jp>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1416474399-16851-14-git-send-email-mukawa@igel.co.jp",
    "date": "2014-11-20T09:06:27",
    "name": "[dpdk-dev,13/25] eal/pci: Prevent double registration for devargs_list",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "556fc6e16e2b25a531129d5dc0c1729b0d48c861",
    "submitter": {
        "id": 64,
        "url": "https://patches.dpdk.org/api/people/64/?format=api",
        "name": "Tetsuya Mukawa",
        "email": "mukawa@igel.co.jp"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1416474399-16851-14-git-send-email-mukawa@igel.co.jp/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/1376/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/1376/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D8F2B8005;\n\tThu, 20 Nov 2014 09:57:23 +0100 (CET)",
            "from mail-pd0-f170.google.com (mail-pd0-f170.google.com\n\t[209.85.192.170]) by dpdk.org (Postfix) with ESMTP id 131F77F7C\n\tfor <dev@dpdk.org>; Thu, 20 Nov 2014 09:57:20 +0100 (CET)",
            "by mail-pd0-f170.google.com with SMTP id fp1so2722820pdb.1\n\tfor <dev@dpdk.org>; Thu, 20 Nov 2014 01:07:48 -0800 (PST)",
            "from localhost.localdomain (napt.igel.co.jp. [219.106.231.132])\n\tby mx.google.com with ESMTPSA id\n\ta6sm1432407pbu.64.2014.11.20.01.07.46 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 20 Nov 2014 01:07:48 -0800 (PST)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=GAPh75Nyt/OiMlG4dgu8R5V9PkfVv6MFPqBfivvaFbs=;\n\tb=NarW9W0VQJpn3YrhFA8+/+JSmvYSoCZIZHK1q/QBtDpEjO1ZmLPNaB8dyrzRT6kiEs\n\tn9sIJAU25BB7rBQr9WIv0w3+jKsfEfq9mvE+1RmZecJKKdH0vzSICI9pBlFiJ3vo+LD8\n\tgwLDozWf7F1qMLQT4hU0ZIoCBLB3RqdDZfbrRXOLNG7T5P+3L0R9/tUQFPBBDfcwZEmO\n\tsXj1LxyF19OdUaggWf7g6FG7mJqCuaFB27siIBuqg3JkY4qK20kAIATnL9GiVQxJxG6i\n\tRkG/28GMskGMXEFZ27BWQN0uFS5BjvvGD9u3pKeNBiEnhf2ovu1/dqYA4nfBSF0oW/Bf\n\t1xRw==",
        "X-Gm-Message-State": "ALoCoQkkNtFhEgEnfUJ3gzHcNc6KtmPGJUDEjGHkPZqD7Rv1ULP2LIUaD9OuBXpUa6Iw3Z4otTcM",
        "X-Received": "by 10.66.157.39 with SMTP id wj7mr29621326pab.117.1416474468780; \n\tThu, 20 Nov 2014 01:07:48 -0800 (PST)",
        "From": "Tetsuya Mukawa <mukawa@igel.co.jp>",
        "To": "dev@dpdk.org",
        "Date": "Thu, 20 Nov 2014 18:06:27 +0900",
        "Message-Id": "<1416474399-16851-14-git-send-email-mukawa@igel.co.jp>",
        "X-Mailer": "git-send-email 1.9.1",
        "In-Reply-To": "<1416474399-16851-1-git-send-email-mukawa@igel.co.jp>",
        "References": "<1414572576-21371-1-git-send-email-mukawa@igel.co.jp>\n\t<1416474399-16851-1-git-send-email-mukawa@igel.co.jp>",
        "Cc": "nakajima.yoshihiro@lab.ntt.co.jp, menrigh@brocade.com,\n\tmasutani.hitoshi@lab.ntt.co.jp",
        "Subject": "[dpdk-dev] [PATCH 13/25] eal/pci: Prevent double registration for\n\tdevargs_list",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The patch fixes rte_eal_devargs_add() not to register same device twice.\n\nSigned-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>\n---\n lib/librte_eal/common/eal_common_devargs.c | 32 ++++++++++++++++++++++++++++++\n 1 file changed, 32 insertions(+)",
    "diff": "diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex 4c7d11a..aaa6901 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -44,6 +44,32 @@\n struct rte_devargs_list devargs_list =\n \tTAILQ_HEAD_INITIALIZER(devargs_list);\n \n+\n+/* find a entry specified by pci address or device name */\n+static struct rte_devargs *\n+rte_eal_devargs_find(enum rte_devtype devtype, void *args)\n+{\n+\tstruct rte_devargs *devargs;\n+\n+\tTAILQ_FOREACH(devargs, &devargs_list, next) {\n+\t\tswitch (devtype) {\n+\t\tcase RTE_DEVTYPE_WHITELISTED_PCI:\n+\t\tcase RTE_DEVTYPE_BLACKLISTED_PCI:\n+\t\t\tif (eal_compare_pci_addr(&devargs->pci.addr, args) == 0)\n+\t\t\t\tgoto found;\n+\t\t\tbreak;\n+\t\tcase RTE_DEVTYPE_VIRTUAL:\n+\t\t\tif (memcmp(&devargs->virtual.drv_name, args,\n+\t\t\t\t\tstrlen((char *)args)) == 0)\n+\t\t\t\tgoto found;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\treturn NULL;\n+found:\n+\treturn devargs;\n+}\n+\n /* store a whitelist parameter for later parsing */\n int\n rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str)\n@@ -101,6 +127,12 @@ rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str)\n \t\tbreak;\n \t}\n \n+\t/* make sure there is no same entry */\n+\tif (rte_eal_devargs_find(devtype, &devargs->pci.addr)) {\n+\t\tRTE_LOG(ERR, EAL, \"device already registered: <%s>\\n\", buf);\n+\t\treturn -1;\n+\t}\n+\n \tTAILQ_INSERT_TAIL(&devargs_list, devargs, next);\n \treturn 0;\n }\n",
    "prefixes": [
        "dpdk-dev",
        "13/25"
    ]
}