Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137512/?format=api
{ "id": 137512, "url": "https://patches.dpdk.org/api/patches/137512/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240229173154.121491-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240229173154.121491-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240229173154.121491-3-stephen@networkplumber.org", "date": "2024-02-29T17:31:07", "name": "[2/3] net/tap: do not overwrite rte_flow errors", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c7419237e01c9690b638a7bc8542b3c7380bf1aa", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240229173154.121491-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 31305, "url": "https://patches.dpdk.org/api/series/31305/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31305", "date": "2024-02-29T17:31:05", "name": "TAP device fixes", "version": 1, "mbox": "https://patches.dpdk.org/series/31305/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/137512/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/137512/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 430AF43C3F;\n\tThu, 29 Feb 2024 18:32:18 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3D1CF42F8B;\n\tThu, 29 Feb 2024 18:32:09 +0100 (CET)", "from mail-io1-f42.google.com (mail-io1-f42.google.com\n [209.85.166.42]) by mails.dpdk.org (Postfix) with ESMTP id 798CE42F76\n for <dev@dpdk.org>; Thu, 29 Feb 2024 18:32:07 +0100 (CET)", "by mail-io1-f42.google.com with SMTP id\n ca18e2360f4ac-7c7db34d162so44873139f.2\n for <dev@dpdk.org>; Thu, 29 Feb 2024 09:32:07 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n r31-20020a63fc5f000000b005dc3fc53f19sm1584846pgk.7.2024.02.29.09.32.05\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 29 Feb 2024 09:32:05 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709227927;\n x=1709832727; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=FUQximORum8BhjyMMC3ErcEcgBw2b5paXd1ZD/Z8r0U=;\n b=HypURsZgRnP0Lo0Vskvzk6kceoN476EFsiAVdopxShRRniKE/xLMEQmyp4bdmZ2Axv\n 6ir7vo9SETN2SDApVwoyNhTYGhVk3COr/NG/Fyq9Rcq8RKyYeyToUUcjT8euUg5vUozx\n dkfgPmOyoZ3iJMRegaQ5lMoV59iC0GOa0l85nvz+wDLvBmtYgXSFKzF4syKeHRZo63sN\n +CEc2v63Uz/LtXSMLjxoG5H8/Gcnz1ro3gUZH0i0rPAr5w/FCbKpjEyaAPT/p8Qrm61j\n OdBy2vHxzBgyhuHvLpaeN3ml861tTj3cOwMdo/u964oBiIK49qrxnXiI8H+ZLctJ52ZY\n reMQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1709227927; x=1709832727;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=FUQximORum8BhjyMMC3ErcEcgBw2b5paXd1ZD/Z8r0U=;\n b=r05+0t+f7IX+ZxhBEFPXAiItGq+Rs3/mbXgU9mkkFjieccVjotlaq46e4GynfKWPTl\n OmjC7CehWhaEkNJbVhlSntkLx25DWwQ9biftG8l4DVpvf3TylJeY/J7ZoXJtPlhpG3qm\n 6+qhbsBlJboc3+2MIVTIWjuA4MFOLaaDqgavsKN0v4QF3u2MbI6jfjv82bRMKaEZAx/Q\n pZOgFw0PkUtM7eVD/w/0qgRM6iXvnsPkE3ABAX+a8W1O9XWNTl/T78Ao0qd7v3cchvwP\n 37KbdV5UxD4yD1izNZ7tzWvTQKu5yEjH736ylOaWHSrRUD3iBVsH1qxQ/aAyodsnCv1x\n 2fAw==", "X-Gm-Message-State": "AOJu0YxpAu5hLyYehKCeKy244P1FVp9WkUpqfUGSTkgyD554lI9RIieH\n ykvscaMT1MjW06RM9OmWLqysMHtw/Ojr/mWrEDNQD3bkFYT231nPEDEOMxDSa2HXgTedNK0AANs\n v", "X-Google-Smtp-Source": "\n AGHT+IHigGPwYXFq5fM6SSdb3GYNnb/cBr9P4qNcBcqilkkeWa/HZs+AohOBsElnB/MXAuQZruJpYg==", "X-Received": "by 2002:a05:6e02:1041:b0:365:5dbd:aa34 with SMTP id\n p1-20020a056e02104100b003655dbdaa34mr2703498ilj.12.1709227926774;\n Thu, 29 Feb 2024 09:32:06 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Pascal Mazon <pascal.mazon@6wind.com>, Ophir Munk <ophirmu@nvidia.com>,\n Olga Shern <olgas@nvidia.com>, Keith Wiles <keith.wiles@intel.com>", "Subject": "[PATCH 2/3] net/tap: do not overwrite rte_flow errors", "Date": "Thu, 29 Feb 2024 09:31:07 -0800", "Message-ID": "<20240229173154.121491-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240229173154.121491-1-stephen@networkplumber.org>", "References": "<20240229173154.121491-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "All flow errors were ending up being reported as not supported,\neven when the error path was previously setting a valid and\nbetter error message.\n\nExample, asking for a non-existent queue in flow.\n\nBefore:\ntestpmd> flow create 0 ingress pattern eth src is 06:05:04:03:02:01 \\\n / end actions queue index 12 / end\nport_flow_complain(): Caught PMD error type 16 (specific action):\ncause: 0x7fffc46c1e18, action not supported: Operation not supported\n\nAfter:\ntestpmd> flow create 0 ingress pattern eth src is 06:05:04:03:02:01 \\\n / end actions queue index 12 / end\nport_flow_complain(): Caught PMD error type 16 (specific action):\ncause: 0x7fffa54e1d88, queue index out of range: Numerical result out of range\n\nFixes: f46900d03823 (\"net/tap: fix flow and port commands\")\nFixes: de96fe68ae95 (\"net/tap: add basic flow API patterns and actions\")\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/tap/tap_flow.c | 21 ++++++++++++++-------\n 1 file changed, 14 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c\nindex ed4d42f92f9f..5b0fee906493 100644\n--- a/drivers/net/tap/tap_flow.c\n+++ b/drivers/net/tap/tap_flow.c\n@@ -1082,8 +1082,11 @@ priv_flow_process(struct pmd_internals *pmd,\n \t\t}\n \t\t/* use flower filter type */\n \t\ttap_nlattr_add(&flow->msg.nh, TCA_KIND, sizeof(\"flower\"), \"flower\");\n-\t\tif (tap_nlattr_nested_start(&flow->msg, TCA_OPTIONS) < 0)\n-\t\t\tgoto exit_item_not_supported;\n+\t\tif (tap_nlattr_nested_start(&flow->msg, TCA_OPTIONS) < 0) {\n+\t\t\trte_flow_error_set(error, ENOMEM, RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t actions, \"could not allocated netlink msg\");\n+\t\t\tgoto exit_return_error;\n+\t\t}\n \t}\n \tfor (; items->type != RTE_FLOW_ITEM_TYPE_END; ++items) {\n \t\tconst struct tap_flow_items *token = NULL;\n@@ -1199,9 +1202,12 @@ priv_flow_process(struct pmd_internals *pmd,\n \t\t\tif (action)\n \t\t\t\tgoto exit_action_not_supported;\n \t\t\taction = 1;\n-\t\t\tif (!queue ||\n-\t\t\t (queue->index > pmd->dev->data->nb_rx_queues - 1))\n-\t\t\t\tgoto exit_action_not_supported;\n+\t\t\tif (queue->index >= pmd->dev->data->nb_rx_queues) {\n+\t\t\t\trte_flow_error_set(error, ERANGE,\n+\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, actions,\n+\t\t\t\t\t\t \"queue index out of range\");\n+\t\t\t\tgoto exit_return_error;\n+\t\t\t}\n \t\t\tif (flow) {\n \t\t\t\tstruct action_data adata = {\n \t\t\t\t\t.id = \"skbedit\",\n@@ -1227,7 +1233,7 @@ priv_flow_process(struct pmd_internals *pmd,\n \t\t\tif (!pmd->rss_enabled) {\n \t\t\t\terr = rss_enable(pmd, attr, error);\n \t\t\t\tif (err)\n-\t\t\t\t\tgoto exit_action_not_supported;\n+\t\t\t\t\tgoto exit_return_error;\n \t\t\t}\n \t\t\tif (flow)\n \t\t\t\terr = rss_add_actions(flow, pmd, rss, error);\n@@ -1235,7 +1241,7 @@ priv_flow_process(struct pmd_internals *pmd,\n \t\t\tgoto exit_action_not_supported;\n \t\t}\n \t\tif (err)\n-\t\t\tgoto exit_action_not_supported;\n+\t\t\tgoto exit_return_error;\n \t}\n \t/* When fate is unknown, drop traffic. */\n \tif (!action) {\n@@ -1258,6 +1264,7 @@ priv_flow_process(struct pmd_internals *pmd,\n exit_action_not_supported:\n \trte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION,\n \t\t\t actions, \"action not supported\");\n+exit_return_error:\n \treturn -rte_errno;\n }\n \n", "prefixes": [ "2/3" ] }