Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137275/?format=api
{ "id": 137275, "url": "https://patches.dpdk.org/api/patches/137275/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1708971946-18231-34-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1708971946-18231-34-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1708971946-18231-34-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-26T18:25:40", "name": "[v6,33/39] compressdev: use C11 alignas", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4b27033179d8ecd7ca4e582a183d2e6fc2d99cb7", "submitter": { "id": 2077, "url": "https://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1708971946-18231-34-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31229, "url": "https://patches.dpdk.org/api/series/31229/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31229", "date": "2024-02-26T18:25:09", "name": "use C11 alignas", "version": 6, "mbox": "https://patches.dpdk.org/series/31229/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/137275/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/137275/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 00D5F43BF3;\n\tMon, 26 Feb 2024 19:30:11 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 44E8242F4B;\n\tMon, 26 Feb 2024 19:26:47 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 6560B42E3E\n for <dev@dpdk.org>; Mon, 26 Feb 2024 19:25:51 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 3B16420B74E1; Mon, 26 Feb 2024 10:25:49 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 3B16420B74E1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1708971950;\n bh=rFubX9acXQ2aXx/5OwXwzx5q1ufH2dQQvVcUaL0d2Ds=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=mz3zkc3aXi/ppCRrOXmNPzmIO80sChOPiUhwgD3wRpZTyMgNYOrV7lJMCyPmMkxyJ\n ITtKDOM8eFjpgJtQr1a36UrmqY5nZ6E206FIBlM8RxX12G7n324ytC6ZpZcyKWZ31y\n 37M6C50o1xDwDfTJ/c1BjYfHkq6nW1cbbQ0oHW9Y=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v6 33/39] compressdev: use C11 alignas", "Date": "Mon, 26 Feb 2024 10:25:40 -0800", "Message-Id": "<1708971946-18231-34-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1708971946-18231-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>\n <1708971946-18231-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The current location used for __rte_aligned(a) for alignment of types\nand variables is not compatible with MSVC. There is only a single\nlocation accepted by both toolchains.\n\nFor variables standard C11 offers alignas(a) supported by conformant\ncompilers i.e. both MSVC and GCC.\n\nFor types the standard offers no alignment facility that compatibly\ninteroperates with C and C++ but may be achieved by relocating the\nplacement of __rte_aligned(a) to the aforementioned location accepted\nby all currently supported toolchains.\n\nTo allow alignment for both compilers do the following:\n\n* Move __rte_aligned from the end of {struct,union} definitions to\n be between {struct,union} and tag.\n\n The placement between {struct,union} and the tag allows the desired\n alignment to be imparted on the type regardless of the toolchain being\n used for all of GCC, LLVM, MSVC compilers building both C and C++.\n\n* Replace use of __rte_aligned(a) on variables/fields with alignas(a).\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/compressdev/rte_comp.h | 4 ++--\n lib/compressdev/rte_compressdev_internal.h | 8 ++++----\n 2 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/compressdev/rte_comp.h b/lib/compressdev/rte_comp.h\nindex 3606ebf..830a240 100644\n--- a/lib/compressdev/rte_comp.h\n+++ b/lib/compressdev/rte_comp.h\n@@ -356,7 +356,7 @@ struct rte_comp_xform {\n * Comp operations are enqueued and dequeued in comp PMDs using the\n * rte_compressdev_enqueue_burst() / rte_compressdev_dequeue_burst() APIs\n */\n-struct rte_comp_op {\n+struct __rte_cache_aligned rte_comp_op {\n \tenum rte_comp_op_type op_type;\n \tunion {\n \t\tvoid *private_xform;\n@@ -478,7 +478,7 @@ struct rte_comp_op {\n \t * will be set to RTE_COMP_OP_STATUS_SUCCESS after operation\n \t * is successfully processed by a PMD\n \t */\n-} __rte_cache_aligned;\n+};\n \n /**\n * Creates an operation pool\ndiff --git a/lib/compressdev/rte_compressdev_internal.h b/lib/compressdev/rte_compressdev_internal.h\nindex 01b7764..8a626d3 100644\n--- a/lib/compressdev/rte_compressdev_internal.h\n+++ b/lib/compressdev/rte_compressdev_internal.h\n@@ -69,7 +69,7 @@ typedef uint16_t (*compressdev_enqueue_pkt_burst_t)(void *qp,\n \t\tstruct rte_comp_op **ops, uint16_t nb_ops);\n \n /** The data structure associated with each comp device. */\n-struct rte_compressdev {\n+struct __rte_cache_aligned rte_compressdev {\n \tcompressdev_dequeue_pkt_burst_t dequeue_burst;\n \t/**< Pointer to PMD receive function */\n \tcompressdev_enqueue_pkt_burst_t enqueue_burst;\n@@ -87,7 +87,7 @@ struct rte_compressdev {\n \t__extension__\n \tuint8_t attached : 1;\n \t/**< Flag indicating the device is attached */\n-} __rte_cache_aligned;\n+};\n \n /**\n *\n@@ -96,7 +96,7 @@ struct rte_compressdev {\n * This structure is safe to place in shared memory to be common among\n * different processes in a multi-process configuration.\n */\n-struct rte_compressdev_data {\n+struct __rte_cache_aligned rte_compressdev_data {\n \tuint8_t dev_id;\n \t/**< Compress device identifier */\n \tint socket_id;\n@@ -115,7 +115,7 @@ struct rte_compressdev_data {\n \n \tvoid *dev_private;\n \t/**< PMD-specific private data */\n-} __rte_cache_aligned;\n+};\n \n #ifdef __cplusplus\n }\n", "prefixes": [ "v6", "33/39" ] }