Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137032/?format=api
{ "id": 137032, "url": "https://patches.dpdk.org/api/patches/137032/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240222122342.16375-4-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240222122342.16375-4-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240222122342.16375-4-pbhagavatula@marvell.com", "date": "2024-02-22T12:23:41", "name": "[24.11,v3,4/5] node: add error stats for ip4 lookup node", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b48edc9fd0d9063b9e6e2e168d42149653fc79fc", "submitter": { "id": 1183, "url": "https://patches.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240222122342.16375-4-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 31181, "url": "https://patches.dpdk.org/api/series/31181/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31181", "date": "2024-02-22T12:23:39", "name": "[24.11,v3,1/5] graph: add support for node specific errors", "version": 3, "mbox": "https://patches.dpdk.org/series/31181/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/137032/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/137032/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B510843B74;\n\tThu, 22 Feb 2024 13:24:32 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 451D240E54;\n\tThu, 22 Feb 2024 13:24:10 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id DC59A40A7F\n for <dev@dpdk.org>; Thu, 22 Feb 2024 13:24:05 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id\n 41M9BWFI021919; Thu, 22 Feb 2024 04:24:02 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3we3dw8j6w-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Thu, 22 Feb 2024 04:24:02 -0800 (PST)", "from DC5-EXCH05.marvell.com (10.69.176.209) by\n DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id\n 15.0.1497.48; Thu, 22 Feb 2024 04:24:00 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH05.marvell.com\n (10.69.176.209) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Thu, 22 Feb\n 2024 04:24:00 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 22 Feb 2024 04:24:00 -0800", "from MININT-80QBFE8.corp.innovium.com (unknown [10.28.164.106])\n by maili.marvell.com (Postfix) with ESMTP id 119F33F71CF;\n Thu, 22 Feb 2024 04:23:56 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=\n pfpt0220; bh=Z8cq5e6L6bFw3u3xzLUEpmFPhasJoGYClZUnneRIIXo=; b=IvO\n FzhQc4bRmqMgpG5XC4aSQTIi7R5qOpdPo77ITkjxmdVyDnflU3/m8U05YzpElWw8\n /+l9e3+J2UuDlxE2zoBiIqF1tGs5fzCems680xotz5O6tyx1Ks7pDn5muLElDzhj\n hgRDlVT5NJWtMB2dV3Nj7PH6YUd1zOJmi1jyN0WEZgaSD7E4JM/j5+hoeMiJViGZ\n dlbSAqkzLsJ/ubOMQ6B9Y4xN8quXTJT25oOUCVw2VQJb2ni6j4aHXDs+aaaiWZUO\n Q0roF7fBFhF/S4l7n4EMVRu63P0FfP9MmHlMK8C60TpOFZCi5hl8eJe+gyuXiGBE\n 3fTnl+68lR+K5ykM3Jg==", "From": "<pbhagavatula@marvell.com>", "To": "<jerinj@marvell.com>, <ndabilpuram@marvell.com>,\n <kirankumark@marvell.com>,\n <zhirun.yan@intel.com>, Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, \"Bruce\n Richardson\" <bruce.richardson@intel.com>, Konstantin Ananyev\n <konstantin.v.ananyev@yandex.ru>", "CC": "<dev@dpdk.org>", "Subject": "[24.11 PATCH v3 4/5] node: add error stats for ip4 lookup node", "Date": "Thu, 22 Feb 2024 17:53:41 +0530", "Message-ID": "<20240222122342.16375-4-pbhagavatula@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240222122342.16375-1-pbhagavatula@marvell.com>", "References": "<20240222053639.15057-1-pbhagavatula@marvell.com>\n <20240222122342.16375-1-pbhagavatula@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "oMxLMPVYWRTl5Zo5rHQdAmfi_FgFUg9_", "X-Proofpoint-ORIG-GUID": "oMxLMPVYWRTl5Zo5rHQdAmfi_FgFUg9_", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2024-02-22_09,2024-02-22_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nAdd error counters for ip4 LPM lookup failures in\nip4_lookup node.\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n lib/node/ip4_lookup.c | 9 +++++++++\n lib/node/ip4_lookup_neon.h | 5 +++++\n lib/node/ip4_lookup_sse.h | 6 ++++++\n lib/node/node_private.h | 8 ++++++++\n 4 files changed, 28 insertions(+)", "diff": "diff --git a/lib/node/ip4_lookup.c b/lib/node/ip4_lookup.c\nindex 18955971f6..5a7921db75 100644\n--- a/lib/node/ip4_lookup.c\n+++ b/lib/node/ip4_lookup.c\n@@ -86,6 +86,7 @@ ip4_lookup_node_process_scalar(struct rte_graph *graph, struct rte_node *node,\n \t\trc = rte_lpm_lookup(lpm, rte_be_to_cpu_32(ipv4_hdr->dst_addr),\n \t\t\t\t &next_hop);\n \t\tnext_hop = (rc == 0) ? next_hop : drop_nh;\n+\t\tNODE_INCREMENT_ERROR_ID(node, 0, (rc != 0), 1);\n \n \t\tnode_mbuf_priv1(mbuf, dyn)->nh = (uint16_t)next_hop;\n \t\tnext_hop = next_hop >> 16;\n@@ -219,11 +220,19 @@ ip4_lookup_node_init(const struct rte_graph *graph, struct rte_node *node)\n \treturn 0;\n }\n \n+static struct rte_node_errors ip4_lookup_errors = {\n+\t.nb_errors = 1,\n+\t.err_desc = {\n+\t\t[0] = \"ip4_lookup_error\",\n+\t},\n+};\n+\n static struct rte_node_register ip4_lookup_node = {\n \t.process = ip4_lookup_node_process_scalar,\n \t.name = \"ip4_lookup\",\n \n \t.init = ip4_lookup_node_init,\n+\t.errs = &ip4_lookup_errors,\n \n \t.nb_edges = RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP + 1,\n \t.next_nodes = {\ndiff --git a/lib/node/ip4_lookup_neon.h b/lib/node/ip4_lookup_neon.h\nindex d5c8da3719..907c7c955a 100644\n--- a/lib/node/ip4_lookup_neon.h\n+++ b/lib/node/ip4_lookup_neon.h\n@@ -116,6 +116,10 @@ ip4_lookup_node_process_vec(struct rte_graph *graph, struct rte_node *node,\n \t\tpriv01.u16[4] = result.u16[2];\n \t\tpriv23.u16[0] = result.u16[4];\n \t\tpriv23.u16[4] = result.u16[6];\n+\t\tNODE_INCREMENT_ERROR_ID(node, 0, result.u16[1] == (drop_nh >> 16), 1);\n+\t\tNODE_INCREMENT_ERROR_ID(node, 0, result.u16[3] == (drop_nh >> 16), 1);\n+\t\tNODE_INCREMENT_ERROR_ID(node, 0, result.u16[5] == (drop_nh >> 16), 1);\n+\t\tNODE_INCREMENT_ERROR_ID(node, 0, result.u16[7] == (drop_nh >> 16), 1);\n \n \t\tnode_mbuf_priv1(mbuf0, dyn)->u = priv01.u64[0];\n \t\tnode_mbuf_priv1(mbuf1, dyn)->u = priv01.u64[1];\n@@ -202,6 +206,7 @@ ip4_lookup_node_process_vec(struct rte_graph *graph, struct rte_node *node,\n \t\t\t\t &next_hop);\n \t\tnext_hop = (rc == 0) ? next_hop : drop_nh;\n \n+\t\tNODE_INCREMENT_ERROR_ID(node, 0, (rc != 0), 1);\n \t\tnode_mbuf_priv1(mbuf0, dyn)->nh = (uint16_t)next_hop;\n \t\tnext_hop = next_hop >> 16;\n \t\tnext0 = (uint16_t)next_hop;\ndiff --git a/lib/node/ip4_lookup_sse.h b/lib/node/ip4_lookup_sse.h\nindex 74dbf97533..a38131e629 100644\n--- a/lib/node/ip4_lookup_sse.h\n+++ b/lib/node/ip4_lookup_sse.h\n@@ -115,6 +115,11 @@ ip4_lookup_node_process_vec(struct rte_graph *graph, struct rte_node *node,\n \t\t/* Perform LPM lookup to get NH and next node */\n \t\trte_lpm_lookupx4(lpm, dip, dst.u32, drop_nh);\n \n+\t\tNODE_INCREMENT_ERROR_ID(node, 0, dst.u16[1] == (drop_nh >> 16), 1);\n+\t\tNODE_INCREMENT_ERROR_ID(node, 0, dst.u16[3] == (drop_nh >> 16), 1);\n+\t\tNODE_INCREMENT_ERROR_ID(node, 0, dst.u16[5] == (drop_nh >> 16), 1);\n+\t\tNODE_INCREMENT_ERROR_ID(node, 0, dst.u16[7] == (drop_nh >> 16), 1);\n+\n \t\t/* Extract next node id and NH */\n \t\tnode_mbuf_priv1(mbuf0, dyn)->nh = dst.u32[0] & 0xFFFF;\n \t\tnext0 = (dst.u32[0] >> 16);\n@@ -206,6 +211,7 @@ ip4_lookup_node_process_vec(struct rte_graph *graph, struct rte_node *node,\n \t\trc = rte_lpm_lookup(lpm, rte_be_to_cpu_32(ipv4_hdr->dst_addr),\n \t\t\t\t &next_hop);\n \t\tnext_hop = (rc == 0) ? next_hop : drop_nh;\n+\t\tNODE_INCREMENT_ERROR_ID(node, 0, rc != 0, 1);\n \n \t\tnode_mbuf_priv1(mbuf0, dyn)->nh = next_hop & 0xFFFF;\n \t\tnext0 = (next_hop >> 16);\ndiff --git a/lib/node/node_private.h b/lib/node/node_private.h\nindex 2b9bad1a11..25870f97fe 100644\n--- a/lib/node/node_private.h\n+++ b/lib/node/node_private.h\n@@ -12,6 +12,8 @@\n #include <rte_mbuf.h>\n #include <rte_mbuf_dyn.h>\n \n+#include <rte_graph_worker_common.h>\n+\n extern int rte_node_logtype;\n #define RTE_LOGTYPE_NODE rte_node_logtype\n \n@@ -89,4 +91,10 @@ node_mbuf_priv2(struct rte_mbuf *m)\n \treturn (struct node_mbuf_priv2 *)rte_mbuf_to_priv(m);\n }\n \n+#define NODE_INCREMENT_ERROR_ID(node, id, cond, cnt) \\\n+\t{ \\\n+\t\tif (unlikely(rte_graph_has_stats_feature() && (cond))) \\\n+\t\t\t((uint64_t *)RTE_PTR_ADD(node, node->err_off))[id] += (cnt); \\\n+\t}\n+\n #endif /* __NODE_PRIVATE_H__ */\n", "prefixes": [ "24.11", "v3", "4/5" ] }