Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136938/?format=api
{ "id": 136938, "url": "https://patches.dpdk.org/api/patches/136938/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240220204226.27494-3-andrew.boyer@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240220204226.27494-3-andrew.boyer@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240220204226.27494-3-andrew.boyer@amd.com", "date": "2024-02-20T20:42:25", "name": "[v2,2/3] net/ionic: remove duplicate barriers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "96272e8a9548ab61afc0239afe6056e079372c74", "submitter": { "id": 2861, "url": "https://patches.dpdk.org/api/people/2861/?format=api", "name": "Andrew Boyer", "email": "Andrew.Boyer@amd.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240220204226.27494-3-andrew.boyer@amd.com/mbox/", "series": [ { "id": 31157, "url": "https://patches.dpdk.org/api/series/31157/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31157", "date": "2024-02-20T20:42:23", "name": "net/ionic, common/ionic: add vdev support", "version": 2, "mbox": "https://patches.dpdk.org/series/31157/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/136938/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/136938/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 18A0443B58;\n\tTue, 20 Feb 2024 21:43:09 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 90872406A2;\n\tTue, 20 Feb 2024 21:43:00 +0100 (CET)", "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2065.outbound.protection.outlook.com [40.107.93.65])\n by mails.dpdk.org (Postfix) with ESMTP id 1D2C24067A\n for <dev@dpdk.org>; Tue, 20 Feb 2024 21:42:58 +0100 (CET)", "from MW4PR02CA0012.namprd02.prod.outlook.com (2603:10b6:303:16d::35)\n by BY5PR12MB4323.namprd12.prod.outlook.com (2603:10b6:a03:211::10)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.20; Tue, 20 Feb\n 2024 20:42:56 +0000", "from CO1PEPF000044EE.namprd05.prod.outlook.com\n (2603:10b6:303:16d:cafe::31) by MW4PR02CA0012.outlook.office365.com\n (2603:10b6:303:16d::35) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.39 via Frontend\n Transport; Tue, 20 Feb 2024 20:42:56 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n CO1PEPF000044EE.mail.protection.outlook.com (10.167.241.68) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7292.25 via Frontend Transport; Tue, 20 Feb 2024 20:42:55 +0000", "from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 20 Feb\n 2024 14:42:54 -0600" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=IMX3RtqAZjjMmBaW4hxCiLLspBFikcl/Tx4ovbSwhecANAAhLvJy/8IQeCcCYtErwbZlQ0l0i9tunWwH1s/CaVcM4nFeKmk4nGL1f0zhX2hldckjmkujYicv1QH/LF1Fmo4MA7OMExwiJi3KyMIflI0vNS+u5gr1wWTVGViNpWGirPjH5gEpTALWqpf1L2buhOEfrwN009nbt2sQrdMku2QpsxaQDHrLhSqxKKtwtZ6EKg5UJPocEw/5o/mz6pA3tJUGISkqRvLeOTy8v1XOLsg17qcY3RdPyGuRxDlCJoWCfT4xpGxVtdZiVdZZ5L9sj/DU7Q85eGLav/BXJtXEIw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=6g9GZ2x3w2Lw+ONBuh26YIywhch60weTTQayx+Tr5CM=;\n b=FAwSQVgAGRZ3D5vk2rTi+1EYina9HnUWCKUes+Tb1hU+gDPGgq/Nug3o79MKEq0XMRBKokk/eRYOmE66RGuu69r0+ZxXWNhfzalMouIpiFnI/GAyuVPiR/spJZKJxsloQRp/i/8dv/lLv29wo8t0wykTZjdRWB+2wSMXKP2jQE1s21Rw+PRoe96+8CfucKj4wU1aoDxDvXUzqbKerh/WAq84XKQgfV96DuNv3S3GFD4vmojLyOYJBNS9CBM9fhkKhH/eqsCiDDNLngBBusOurrXElK8XfTvHO0/QVe1h1UtwEHmiaiz/7MoW1TKF0jbBChBu9MMp+2eUF/4I8mW3Zg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=6g9GZ2x3w2Lw+ONBuh26YIywhch60weTTQayx+Tr5CM=;\n b=kpnZDN7kBmSX2JDWGHsEl5Evn/ay2TnfQdt5H6X45DMJa66gyx8jgw5cvUAMFo4MEtS6txHMFOsyCIZ/iI4Ms8UkSKqzqzYuZRvvK64Z6GdYwh+/VmcQpvh76NZZbXrvUHtx4PNe7N7z/H5sd+fsPUOXZdp5aF4RdFtQWsZRt28=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Andrew Boyer <andrew.boyer@amd.com>", "To": "<dev@dpdk.org>", "CC": "Andrew Boyer <andrew.boyer@amd.com>, Neel Patel <neel.patel@amd.com>", "Subject": "[PATCH v2 2/3] net/ionic: remove duplicate barriers", "Date": "Tue, 20 Feb 2024 12:42:25 -0800", "Message-ID": "<20240220204226.27494-3-andrew.boyer@amd.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240220204226.27494-1-andrew.boyer@amd.com>", "References": "<20240216170704.55523-1-andrew.boyer@amd.com>\n <20240220204226.27494-1-andrew.boyer@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1PEPF000044EE:EE_|BY5PR12MB4323:EE_", "X-MS-Office365-Filtering-Correlation-Id": "700bb59c-aa1e-405a-737d-08dc32548478", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n dj0dYV/Xbl6OrXrTY9aSyN7WdwucAlRIa/sQutAbNJWcBMZChT5oB+37vEwGN4GeDQRYVaPd/PJnU3NieFR3fMsdJYPHYnDYXV+3jhgoaOTuLDxQlBjYRw6KvjMM425JDWnSsJq8HD3HOkTpD1KV8Lrl9lmsPQSb8dI1lgPt/FoB3tW7Fxt4Lbr+WFX1qKHolHln3Dm00WhndOUMR21bHFJql0iR3z9d1TT/oqusZ323wICanVpDmrh5YmXQz8QkUAh27O0l3nELDrNZR1pvCEQrHEj/O+6z4VBB7K/rBE5Ffsn9JEyRnd4kqPlvuvPLg4NugOKTQQGqnx5NDaLxcFfSscAHmjsy/qGLXVZmMwQVzA9TPRptJhq0+PBdUH0bShPry265H0k2QXjYA49zQ4KQ61VPAz1kncIebutEwAS4+EvQ9+D9nK9aQLwsZg4WQbJswoRbwrNTsTynIVY34jdB+VZBwA7+ZPNj0/Il/T9jgCYU3Uqn9KJiZuTGO1OsjqIP12xYNF12++/ra8stooEOkwBTYAj0uuPjiS/iRx6WPScpf9qYU98lYhsbr9F3ixp2ifhn6kk/d9UVr4S8kP2kmnerzPFiRLBXb8mbSzB28NZucjvdejirfUS9NEoZptR8we0PYvAwV4/LGEL7r7T+XXmg8nNmAMeekHsnw+c=", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(36860700004)(46966006)(40470700004); DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "20 Feb 2024 20:42:55.9333 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 700bb59c-aa1e-405a-737d-08dc32548478", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1PEPF000044EE.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BY5PR12MB4323", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "These barriers are duplicated by the barriers inside\nrte_write64(). Remove them to improve performance.\n\nSigned-off-by: Neel Patel <neel.patel@amd.com>\nSigned-off-by: Andrew Boyer <andrew.boyer@amd.com>\n---\n drivers/net/ionic/ionic_main.c | 1 -\n drivers/net/ionic/ionic_rxtx_sg.c | 1 -\n drivers/net/ionic/ionic_rxtx_simple.c | 1 -\n 3 files changed, 3 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_main.c b/drivers/net/ionic/ionic_main.c\nindex 1f24f64a33..814bb3b8f4 100644\n--- a/drivers/net/ionic/ionic_main.c\n+++ b/drivers/net/ionic/ionic_main.c\n@@ -223,7 +223,6 @@ ionic_adminq_post(struct ionic_lif *lif, struct ionic_admin_ctx *ctx)\n \tq->head_idx = Q_NEXT_TO_POST(q, 1);\n \n \t/* Ring doorbell */\n-\trte_wmb();\n \tionic_q_flush(q);\n \n err_out:\ndiff --git a/drivers/net/ionic/ionic_rxtx_sg.c b/drivers/net/ionic/ionic_rxtx_sg.c\nindex e8dec99c04..3820fd850f 100644\n--- a/drivers/net/ionic/ionic_rxtx_sg.c\n+++ b/drivers/net/ionic/ionic_rxtx_sg.c\n@@ -218,7 +218,6 @@ ionic_xmit_pkts_sg(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t}\n \n \tif (nb_tx > 0) {\n-\t\trte_wmb();\n \t\tionic_txq_flush(q);\n \n \t\ttxq->last_wdog_cycles = rte_get_timer_cycles();\ndiff --git a/drivers/net/ionic/ionic_rxtx_simple.c b/drivers/net/ionic/ionic_rxtx_simple.c\nindex 9674b4d1df..4c9b9415ad 100644\n--- a/drivers/net/ionic/ionic_rxtx_simple.c\n+++ b/drivers/net/ionic/ionic_rxtx_simple.c\n@@ -191,7 +191,6 @@ ionic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t}\n \n \tif (nb_tx > 0) {\n-\t\trte_wmb();\n \t\tionic_txq_flush(q);\n \n \t\ttxq->last_wdog_cycles = rte_get_timer_cycles();\n", "prefixes": [ "v2", "2/3" ] }