Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136810/?format=api
{ "id": 136810, "url": "https://patches.dpdk.org/api/patches/136810/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1707978080-28859-10-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1707978080-28859-10-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1707978080-28859-10-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-15T06:21:11", "name": "[v4,09/18] net/bnxt: stop using zero sized marker fields", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7828ffaf80be7487c97e10a801ca8242c5030114", "submitter": { "id": 2077, "url": "https://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1707978080-28859-10-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31113, "url": "https://patches.dpdk.org/api/series/31113/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31113", "date": "2024-02-15T06:21:02", "name": "stop using zero sized marker fields", "version": 4, "mbox": "https://patches.dpdk.org/series/31113/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/136810/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/136810/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7C23C43B06;\n\tThu, 15 Feb 2024 07:22:50 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 53E11433CA;\n\tThu, 15 Feb 2024 07:21:52 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 1FCD643392\n for <dev@dpdk.org>; Thu, 15 Feb 2024 07:21:38 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 86BB820B2002; Wed, 14 Feb 2024 22:21:36 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 86BB820B2002", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1707978096;\n bh=E73HGeXI2VX57uMeWwU+abIvWzf82jmj5rK3wnT1I7U=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=nOS2LoLPQIjASbxC9nl1ACdmOUCTkQpJx8zR7JeJBOHdikoRoyLMBXlMjxQmR3APx\n 53rbE1IjZv2Y9XT70sRE9lkmHzkIXjYJ4+2E2OkC8XnEDbC03aHf/sAkhok+OXKmqr\n icNbfAExsqYpUJ9swT657uHUoDJfEqkSrwOjWxtA=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Andrew Boyer <andrew.boyer@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chenbo Xia <chenbox@nvidia.com>, Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n Hyong Youb Kim <hyonkim@cisco.com>, Jerin Jacob <jerinj@marvell.com>,\n Jie Hai <haijie1@huawei.com>, Jingjing Wu <jingjing.wu@intel.com>,\n John Daley <johndale@cisco.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>, Ori Kam <orika@nvidia.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Satha Rao <skoteshwar@marvell.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v4 09/18] net/bnxt: stop using zero sized marker fields", "Date": "Wed, 14 Feb 2024 22:21:11 -0800", "Message-Id": "<1707978080-28859-10-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1707978080-28859-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com>\n <1707978080-28859-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Update to reference newly named anonymous union markers supported by\nstandard C and stop referencing zero sized compiler extension markers.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n drivers/net/bnxt/bnxt_rxtx_vec_avx2.c | 18 +++++++++---------\n drivers/net/bnxt/bnxt_rxtx_vec_common.h | 4 ++--\n drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 20 ++++++++++----------\n drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 20 ++++++++++----------\n 4 files changed, 31 insertions(+), 31 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_avx2.c b/drivers/net/bnxt/bnxt_rxtx_vec_avx2.c\nindex ea8dbaf..5f92e0f 100644\n--- a/drivers/net/bnxt/bnxt_rxtx_vec_avx2.c\n+++ b/drivers/net/bnxt/bnxt_rxtx_vec_avx2.c\n@@ -266,7 +266,7 @@\n \t\tif (num_valid == 0)\n \t\t\tbreak;\n \n-\t\t/* Update mbuf rearm_data for eight packets. */\n+\t\t/* Update mbuf mbuf_rearm_data for eight packets. */\n \t\tmbuf01 = _mm256_shuffle_epi8(rxcmp0_1, shuf_msk);\n \t\tmbuf23 = _mm256_shuffle_epi8(rxcmp2_3, shuf_msk);\n \t\tmbuf45 = _mm256_shuffle_epi8(rxcmp4_5, shuf_msk);\n@@ -310,13 +310,13 @@\n \t\t\t\t\t 0x04);\n \n \t\t/* Store all mbuf fields for first four packets. */\n-\t\t_mm256_storeu_si256((void *)&rx_pkts[i + 0]->rearm_data,\n+\t\t_mm256_storeu_si256((void *)&rx_pkts[i + 0]->mbuf_rearm_data,\n \t\t\t\t rearm0);\n-\t\t_mm256_storeu_si256((void *)&rx_pkts[i + 1]->rearm_data,\n+\t\t_mm256_storeu_si256((void *)&rx_pkts[i + 1]->mbuf_rearm_data,\n \t\t\t\t rearm1);\n-\t\t_mm256_storeu_si256((void *)&rx_pkts[i + 2]->rearm_data,\n+\t\t_mm256_storeu_si256((void *)&rx_pkts[i + 2]->mbuf_rearm_data,\n \t\t\t\t rearm2);\n-\t\t_mm256_storeu_si256((void *)&rx_pkts[i + 3]->rearm_data,\n+\t\t_mm256_storeu_si256((void *)&rx_pkts[i + 3]->mbuf_rearm_data,\n \t\t\t\t rearm3);\n \n \t\t/* Unpack rearm data, set fixed fields for final four mbufs. */\n@@ -336,13 +336,13 @@\n \t\t\t\t\t 0x04);\n \n \t\t/* Store all mbuf fields for final four packets. */\n-\t\t_mm256_storeu_si256((void *)&rx_pkts[i + 4]->rearm_data,\n+\t\t_mm256_storeu_si256((void *)&rx_pkts[i + 4]->mbuf_rearm_data,\n \t\t\t\t rearm4);\n-\t\t_mm256_storeu_si256((void *)&rx_pkts[i + 5]->rearm_data,\n+\t\t_mm256_storeu_si256((void *)&rx_pkts[i + 5]->mbuf_rearm_data,\n \t\t\t\t rearm5);\n-\t\t_mm256_storeu_si256((void *)&rx_pkts[i + 6]->rearm_data,\n+\t\t_mm256_storeu_si256((void *)&rx_pkts[i + 6]->mbuf_rearm_data,\n \t\t\t\t rearm6);\n-\t\t_mm256_storeu_si256((void *)&rx_pkts[i + 7]->rearm_data,\n+\t\t_mm256_storeu_si256((void *)&rx_pkts[i + 7]->mbuf_rearm_data,\n \t\t\t\t rearm7);\n \n \t\tnb_rx_pkts += num_valid;\ndiff --git a/drivers/net/bnxt/bnxt_rxtx_vec_common.h b/drivers/net/bnxt/bnxt_rxtx_vec_common.h\nindex 2294f0a..05a52d2 100644\n--- a/drivers/net/bnxt/bnxt_rxtx_vec_common.h\n+++ b/drivers/net/bnxt/bnxt_rxtx_vec_common.h\n@@ -44,9 +44,9 @@\n \tmb_def.port = rxq->port_id;\n \trte_mbuf_refcnt_set(&mb_def, 1);\n \n-\t/* prevent compiler reordering: rearm_data covers previous fields */\n+\t/* prevent compiler reordering: mbuf_rearm_data covers previous fields */\n \trte_compiler_barrier();\n-\tp = (uintptr_t)&mb_def.rearm_data;\n+\tp = (uintptr_t)&mb_def.mbuf_rearm_data;\n \trxq->mbuf_initializer = *(uint64_t *)p;\n \trxq->rxrearm_nb = 0;\n \trxq->rxrearm_start = 0;\ndiff --git a/drivers/net/bnxt/bnxt_rxtx_vec_neon.c b/drivers/net/bnxt/bnxt_rxtx_vec_neon.c\nindex 775400f..7156f05 100644\n--- a/drivers/net/bnxt/bnxt_rxtx_vec_neon.c\n+++ b/drivers/net/bnxt/bnxt_rxtx_vec_neon.c\n@@ -133,29 +133,29 @@\n \terrors = vorrq_u32(errors, vshrq_n_u32(is_tunnel, 1));\n \tindex = vorrq_u32(index, is_tunnel);\n \n-\t/* Update mbuf rearm_data for four packets. */\n+\t/* Update mbuf mbuf_rearm_data for four packets. */\n \tGET_OL_FLAGS(rss_flags, index, errors, 0, ol_flags);\n-\tvst1q_u32((uint32_t *)&mbuf[0]->rearm_data,\n+\tvst1q_u32((uint32_t *)&mbuf[0]->mbuf_rearm_data,\n \t\t vsetq_lane_u32(ol_flags, vreinterpretq_u32_u64(mb_init), 2));\n \tGET_OL_FLAGS(rss_flags, index, errors, 1, ol_flags);\n-\tvst1q_u32((uint32_t *)&mbuf[1]->rearm_data,\n+\tvst1q_u32((uint32_t *)&mbuf[1]->mbuf_rearm_data,\n \t\t vsetq_lane_u32(ol_flags, vreinterpretq_u32_u64(mb_init), 2));\n \tGET_OL_FLAGS(rss_flags, index, errors, 2, ol_flags);\n-\tvst1q_u32((uint32_t *)&mbuf[2]->rearm_data,\n+\tvst1q_u32((uint32_t *)&mbuf[2]->mbuf_rearm_data,\n \t\t vsetq_lane_u32(ol_flags, vreinterpretq_u32_u64(mb_init), 2));\n \tGET_OL_FLAGS(rss_flags, index, errors, 3, ol_flags);\n-\tvst1q_u32((uint32_t *)&mbuf[3]->rearm_data,\n+\tvst1q_u32((uint32_t *)&mbuf[3]->mbuf_rearm_data,\n \t\t vsetq_lane_u32(ol_flags, vreinterpretq_u32_u64(mb_init), 2));\n \n-\t/* Update mbuf rx_descriptor_fields1 for four packets. */\n+\t/* Update mbuf mbuf_rx_descriptor_fields1 for four packets. */\n \tGET_DESC_FIELDS(mm_rxcmp[0], mm_rxcmp1[0], shuf_msk, ptype_idx, 0, tmp);\n-\tvst1q_u32((uint32_t *)&mbuf[0]->rx_descriptor_fields1, tmp);\n+\tvst1q_u32((uint32_t *)&mbuf[0]->mbuf_rx_descriptor_fields1, tmp);\n \tGET_DESC_FIELDS(mm_rxcmp[1], mm_rxcmp1[1], shuf_msk, ptype_idx, 1, tmp);\n-\tvst1q_u32((uint32_t *)&mbuf[1]->rx_descriptor_fields1, tmp);\n+\tvst1q_u32((uint32_t *)&mbuf[1]->mbuf_rx_descriptor_fields1, tmp);\n \tGET_DESC_FIELDS(mm_rxcmp[2], mm_rxcmp1[2], shuf_msk, ptype_idx, 2, tmp);\n-\tvst1q_u32((uint32_t *)&mbuf[2]->rx_descriptor_fields1, tmp);\n+\tvst1q_u32((uint32_t *)&mbuf[2]->mbuf_rx_descriptor_fields1, tmp);\n \tGET_DESC_FIELDS(mm_rxcmp[3], mm_rxcmp1[3], shuf_msk, ptype_idx, 3, tmp);\n-\tvst1q_u32((uint32_t *)&mbuf[3]->rx_descriptor_fields1, tmp);\n+\tvst1q_u32((uint32_t *)&mbuf[3]->mbuf_rx_descriptor_fields1, tmp);\n }\n \n static uint16_t\ndiff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c\nindex 8ef51ce..b4e6fa6 100644\n--- a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c\n+++ b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c\n@@ -118,35 +118,35 @@\n \terrors = _mm_or_si128(errors, _mm_srli_epi32(is_tunnel, 1));\n \tindex = _mm_or_si128(index, is_tunnel);\n \n-\t/* Update mbuf rearm_data for four packets. */\n+\t/* Update mbuf mbuf_rearm_data for four packets. */\n \tGET_OL_FLAGS(rss_flags, index, errors, 0, ol_flags);\n-\t_mm_store_si128((void *)&mbuf[0]->rearm_data,\n+\t_mm_store_si128((void *)&mbuf[0]->mbuf_rearm_data,\n \t\t\t_mm_or_si128(mbuf_init, _mm_set_epi64x(ol_flags, 0)));\n \n \tGET_OL_FLAGS(rss_flags, index, errors, 1, ol_flags);\n-\t_mm_store_si128((void *)&mbuf[1]->rearm_data,\n+\t_mm_store_si128((void *)&mbuf[1]->mbuf_rearm_data,\n \t\t\t_mm_or_si128(mbuf_init, _mm_set_epi64x(ol_flags, 0)));\n \n \tGET_OL_FLAGS(rss_flags, index, errors, 2, ol_flags);\n-\t_mm_store_si128((void *)&mbuf[2]->rearm_data,\n+\t_mm_store_si128((void *)&mbuf[2]->mbuf_rearm_data,\n \t\t\t_mm_or_si128(mbuf_init, _mm_set_epi64x(ol_flags, 0)));\n \n \tGET_OL_FLAGS(rss_flags, index, errors, 3, ol_flags);\n-\t_mm_store_si128((void *)&mbuf[3]->rearm_data,\n+\t_mm_store_si128((void *)&mbuf[3]->mbuf_rearm_data,\n \t\t\t_mm_or_si128(mbuf_init, _mm_set_epi64x(ol_flags, 0)));\n \n-\t/* Update mbuf rx_descriptor_fields1 for four packes. */\n+\t/* Update mbuf mbuf_rx_descriptor_fields1 for four packes. */\n \tGET_DESC_FIELDS(mm_rxcmp[0], mm_rxcmp1[0], shuf_msk, ptype_idx, 0, t0);\n-\t_mm_store_si128((void *)&mbuf[0]->rx_descriptor_fields1, t0);\n+\t_mm_store_si128((void *)&mbuf[0]->mbuf_rx_descriptor_fields1, t0);\n \n \tGET_DESC_FIELDS(mm_rxcmp[1], mm_rxcmp1[1], shuf_msk, ptype_idx, 1, t0);\n-\t_mm_store_si128((void *)&mbuf[1]->rx_descriptor_fields1, t0);\n+\t_mm_store_si128((void *)&mbuf[1]->mbuf_rx_descriptor_fields1, t0);\n \n \tGET_DESC_FIELDS(mm_rxcmp[2], mm_rxcmp1[2], shuf_msk, ptype_idx, 2, t0);\n-\t_mm_store_si128((void *)&mbuf[2]->rx_descriptor_fields1, t0);\n+\t_mm_store_si128((void *)&mbuf[2]->mbuf_rx_descriptor_fields1, t0);\n \n \tGET_DESC_FIELDS(mm_rxcmp[3], mm_rxcmp1[3], shuf_msk, ptype_idx, 3, t0);\n-\t_mm_store_si128((void *)&mbuf[3]->rx_descriptor_fields1, t0);\n+\t_mm_store_si128((void *)&mbuf[3]->mbuf_rx_descriptor_fields1, t0);\n }\n \n static uint16_t\n", "prefixes": [ "v4", "09/18" ] }