Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136808/?format=api
{ "id": 136808, "url": "https://patches.dpdk.org/api/patches/136808/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1707978080-28859-11-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1707978080-28859-11-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1707978080-28859-11-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-15T06:21:12", "name": "[v4,10/18] net/enic: stop using zero sized marker fields", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3dbf16edeffb7e41caf5b2d5bb427329dedf01e3", "submitter": { "id": 2077, "url": "https://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1707978080-28859-11-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31113, "url": "https://patches.dpdk.org/api/series/31113/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31113", "date": "2024-02-15T06:21:02", "name": "stop using zero sized marker fields", "version": 4, "mbox": "https://patches.dpdk.org/series/31113/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/136808/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/136808/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5BA6643B06;\n\tThu, 15 Feb 2024 07:22:37 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EB5A3433BF;\n\tThu, 15 Feb 2024 07:21:49 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id E4B894338F\n for <dev@dpdk.org>; Thu, 15 Feb 2024 07:21:37 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 960B820B2003; Wed, 14 Feb 2024 22:21:36 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 960B820B2003", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1707978096;\n bh=0CGzCXRxrtaJWvf/hjQxF4L7KkLCQZ5l0DmIUqB9OV8=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=pTYTJcItlLgAZkif+n154ByiM52IzS1d/fdJ3I32LCZqK8Bbne1tWHL5tGTPzklQa\n cpJ+nAGmvUB5fdQknYbK8tXF2nl4o+bhj2y+KvhzC10ckMsL7cBvcy1oS+OUYKxbOO\n XgRQX+sfM1qtr46OB3532ZoKSaYqFJvKL9hi0fKw=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Andrew Boyer <andrew.boyer@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chenbo Xia <chenbox@nvidia.com>, Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n Hyong Youb Kim <hyonkim@cisco.com>, Jerin Jacob <jerinj@marvell.com>,\n Jie Hai <haijie1@huawei.com>, Jingjing Wu <jingjing.wu@intel.com>,\n John Daley <johndale@cisco.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>, Ori Kam <orika@nvidia.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Satha Rao <skoteshwar@marvell.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v4 10/18] net/enic: stop using zero sized marker fields", "Date": "Wed, 14 Feb 2024 22:21:12 -0800", "Message-Id": "<1707978080-28859-11-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1707978080-28859-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com>\n <1707978080-28859-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Update to reference newly named anonymous union markers supported by\nstandard C and stop referencing zero sized compiler extension markers.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n drivers/net/enic/enic.h | 2 +-\n drivers/net/enic/enic_main.c | 4 ++--\n drivers/net/enic/enic_rxtx_vec_avx2.c | 22 +++++++++++-----------\n 3 files changed, 14 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h\nindex 7877870..f2064ad 100644\n--- a/drivers/net/enic/enic.h\n+++ b/drivers/net/enic/enic.h\n@@ -92,7 +92,7 @@ struct enic {\n \tstruct vnic_dev *vdev;\n \n \t/*\n-\t * mbuf_initializer contains 64 bits of mbuf rearm_data, used by\n+\t * mbuf_initializer contains 64 bits of mbuf mbuf_rearm_data, used by\n \t * the avx2 handler at this time.\n \t */\n \tuint64_t mbuf_initializer;\ndiff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c\nindex a6aaa76..923f92f 100644\n--- a/drivers/net/enic/enic_main.c\n+++ b/drivers/net/enic/enic_main.c\n@@ -584,7 +584,7 @@ int enic_enable(struct enic *enic)\n \n \t\t/*\n \t\t * mbuf_initializer contains const-after-init fields of\n-\t\t * receive mbufs (i.e. 64 bits of fields from rearm_data).\n+\t\t * receive mbufs (i.e. 64 bits of fields from mbuf_rearm_data).\n \t\t * It is currently used by the vectorized handler.\n \t\t */\n \t\tmb_def.nb_segs = 1;\n@@ -592,7 +592,7 @@ int enic_enable(struct enic *enic)\n \t\tmb_def.port = enic->port_id;\n \t\trte_mbuf_refcnt_set(&mb_def, 1);\n \t\trte_compiler_barrier();\n-\t\tp = (uintptr_t)&mb_def.rearm_data;\n+\t\tp = (uintptr_t)&mb_def.mbuf_rearm_data;\n \t\tenic->mbuf_initializer = *(uint64_t *)p;\n \t}\n \ndiff --git a/drivers/net/enic/enic_rxtx_vec_avx2.c b/drivers/net/enic/enic_rxtx_vec_avx2.c\nindex 600efff..bd495d7 100644\n--- a/drivers/net/enic/enic_rxtx_vec_avx2.c\n+++ b/drivers/net/enic/enic_rxtx_vec_avx2.c\n@@ -19,7 +19,7 @@\n {\n \tbool tnl;\n \n-\t*(uint64_t *)&mb->rearm_data = enic->mbuf_initializer;\n+\t*(uint64_t *)&mb->mbuf_rearm_data = enic->mbuf_initializer;\n \tmb->data_len = cqd->bytes_written_flags &\n \t\tCQ_ENET_RQ_DESC_BYTES_WRITTEN_MASK;\n \tmb->pkt_len = mb->data_len;\n@@ -394,13 +394,13 @@\n \t * type_color - 15 (unused)\n \t *\n \t * --- mbuf fields --- offset\n-\t * rearm_data ---- 16\n+\t * mbuf_rearm_data ---- 16\n \t * data_off - 0 (mbuf_init) -+\n \t * refcnt - 2 (mbuf_init) |\n \t * nb_segs - 4 (mbuf_init) | 16B 128b\n \t * port - 6 (mbuf_init) |\n \t * ol_flag - 8 (from cqd) -+\n-\t * rx_descriptor_fields1 ---- 32\n+\t * mbuf_rx_descriptor_fields1 ---- 32\n \t * packet_type - 0 (from cqd) -+\n \t * pkt_len - 4 (from cqd) |\n \t * data_len - 8 (from cqd) | 16B 128b\n@@ -737,14 +737,14 @@\n \t\t * vlan_tci - 26 (from cqd)\n \t\t * rss - 28 (from cqd)\n \t\t */\n-\t\t_mm256_storeu_si256((__m256i *)&rxmb[0]->rearm_data, rearm0);\n-\t\t_mm256_storeu_si256((__m256i *)&rxmb[1]->rearm_data, rearm1);\n-\t\t_mm256_storeu_si256((__m256i *)&rxmb[2]->rearm_data, rearm2);\n-\t\t_mm256_storeu_si256((__m256i *)&rxmb[3]->rearm_data, rearm3);\n-\t\t_mm256_storeu_si256((__m256i *)&rxmb[4]->rearm_data, rearm4);\n-\t\t_mm256_storeu_si256((__m256i *)&rxmb[5]->rearm_data, rearm5);\n-\t\t_mm256_storeu_si256((__m256i *)&rxmb[6]->rearm_data, rearm6);\n-\t\t_mm256_storeu_si256((__m256i *)&rxmb[7]->rearm_data, rearm7);\n+\t\t_mm256_storeu_si256((__m256i *)&rxmb[0]->mbuf_rearm_data, rearm0);\n+\t\t_mm256_storeu_si256((__m256i *)&rxmb[1]->mbuf_rearm_data, rearm1);\n+\t\t_mm256_storeu_si256((__m256i *)&rxmb[2]->mbuf_rearm_data, rearm2);\n+\t\t_mm256_storeu_si256((__m256i *)&rxmb[3]->mbuf_rearm_data, rearm3);\n+\t\t_mm256_storeu_si256((__m256i *)&rxmb[4]->mbuf_rearm_data, rearm4);\n+\t\t_mm256_storeu_si256((__m256i *)&rxmb[5]->mbuf_rearm_data, rearm5);\n+\t\t_mm256_storeu_si256((__m256i *)&rxmb[6]->mbuf_rearm_data, rearm6);\n+\t\t_mm256_storeu_si256((__m256i *)&rxmb[7]->mbuf_rearm_data, rearm7);\n \n \t\tmax_rx -= 8;\n \t\tcqd += 8;\n", "prefixes": [ "v4", "10/18" ] }