Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136689/?format=api
{ "id": 136689, "url": "https://patches.dpdk.org/api/patches/136689/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1707873986-29352-15-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1707873986-29352-15-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1707873986-29352-15-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-14T01:26:26", "name": "[14/14] eal: redefine macro to be integer literal for MSVC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c90db242fa08880711581a05de12e0712123ccd7", "submitter": { "id": 2077, "url": "https://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1707873986-29352-15-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31100, "url": "https://patches.dpdk.org/api/series/31100/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31100", "date": "2024-02-14T01:26:12", "name": "use C11 alignas and normalize type alignment", "version": 1, "mbox": "https://patches.dpdk.org/series/31100/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/136689/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/136689/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CB04743B21;\n\tWed, 14 Feb 2024 02:27:46 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AF52842F0D;\n\tWed, 14 Feb 2024 02:26:43 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 1A52142E56\n for <dev@dpdk.org>; Wed, 14 Feb 2024 02:26:30 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id D5E1520B200E; Tue, 13 Feb 2024 17:26:28 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com D5E1520B200E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1707873988;\n bh=WEgs7UDGrCCcrwdChvxjaIAIReMbnxUKKCAy727sGLc=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=o7whYVyFQ23HIkzZdvVsSR95Oa0i6BkuMDHMxEtehyNpl03E6YvfrgkgMaql2lv6B\n Fpexotk1F2ZwsK+ZSqxybeX2CLefKtw2I78C9mNfdkhssiLoYqqv/7qsIsh73ML1D2\n NQlTI5weBP1kQfjpHTUnPqbT8ObvXuRsPW3ejWjs=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH 14/14] eal: redefine macro to be integer literal for MSVC", "Date": "Tue, 13 Feb 2024 17:26:26 -0800", "Message-Id": "<1707873986-29352-15-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "MSVC __declspec(align(#)) is limited and accepts only integer literals\nas opposed to constant expressions. define XMM_SIZE to be 16 instead of\nsizeof(xmm_t) and static_assert that sizeof(xmm_t) == 16 for\ncompatibility.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/eal/x86/include/rte_vect.h | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/eal/x86/include/rte_vect.h b/lib/eal/x86/include/rte_vect.h\nindex a1a537e..441f1a0 100644\n--- a/lib/eal/x86/include/rte_vect.h\n+++ b/lib/eal/x86/include/rte_vect.h\n@@ -11,6 +11,7 @@\n * RTE SSE/AVX related header.\n */\n \n+#include <assert.h>\n #include <stdint.h>\n #include <rte_config.h>\n #include <rte_common.h>\n@@ -33,9 +34,11 @@\n \n typedef __m128i xmm_t;\n \n-#define\tXMM_SIZE\t(sizeof(xmm_t))\n+#define\tXMM_SIZE\t16\n #define\tXMM_MASK\t(XMM_SIZE - 1)\n \n+static_assert(sizeof(xmm_t) == 16, \"\");\n+\n typedef union rte_xmm {\n \txmm_t x;\n \tuint8_t u8[XMM_SIZE / sizeof(uint8_t)];\n", "prefixes": [ "14/14" ] }