Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 136587,
    "url": "https://patches.dpdk.org/api/patches/136587/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240211191038.863120-1-brian.dooley@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20240211191038.863120-1-brian.dooley@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20240211191038.863120-1-brian.dooley@intel.com",
    "date": "2024-02-11T19:10:38",
    "name": "[v2] crypto/ipsec_mb: use new ipad/opad calculation API",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "912f72f5faf181f6ff156c8e9cb8dd264f7ddfc7",
    "submitter": {
        "id": 2520,
        "url": "https://patches.dpdk.org/api/people/2520/?format=api",
        "name": "Dooley, Brian",
        "email": "brian.dooley@intel.com"
    },
    "delegate": {
        "id": 6690,
        "url": "https://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240211191038.863120-1-brian.dooley@intel.com/mbox/",
    "series": [
        {
            "id": 31071,
            "url": "https://patches.dpdk.org/api/series/31071/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31071",
            "date": "2024-02-11T19:10:38",
            "name": "[v2] crypto/ipsec_mb: use new ipad/opad calculation API",
            "version": 2,
            "mbox": "https://patches.dpdk.org/series/31071/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/136587/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/136587/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0E79A43AF0;\n\tSun, 11 Feb 2024 20:10:47 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A83F54026B;\n\tSun, 11 Feb 2024 20:10:46 +0100 (CET)",
            "from mgamail.intel.com (mgamail.intel.com [192.198.163.14])\n by mails.dpdk.org (Postfix) with ESMTP id 4B2A54025D\n for <dev@dpdk.org>; Sun, 11 Feb 2024 20:10:45 +0100 (CET)",
            "from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Feb 2024 11:10:44 -0800",
            "from unknown (HELO silpixa00400886.ir.intel.com) ([10.243.23.150])\n by orviesa002.jf.intel.com with ESMTP; 11 Feb 2024 11:10:42 -0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1707678646; x=1739214646;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=/YlulV5M1G8Rh7BeH/FkfMWGTlmSu4VdQw6ggM5VYEs=;\n b=dWO5H4ZRgbFBR7oJ7EvTjWcVHsYd2s2YOVlCpY7BjXeXtmyz9tm4jiZ0\n UwBMaLNuAQg85yDONJWJBamoyVJeDL2rA4QVQjc0SVaSYu1ZgugMob09g\n lFoGgkUl7qnMbygAl13G/8ME1btUXdnchBhLW3iEPX19nNRDJH6T36SZb\n RyAd73UMCGHZQi2de9uu1BGKcAMcruCQEX9yAmEpuftGmD6gEQKvwBIpU\n Jq2McbYdejpa6BDDAR4Sdu/qUgy9dMUHIsWlcNyuLCOlBPxdOkeowqsqI\n amQVagsHKA/OvZ5glWWg82HeDhPhkMi3Os9Ss9y3ZNGRugVEDDdIczM5P Q==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6600,9927,10981\"; a=\"1795964\"",
            "E=Sophos;i=\"6.05,261,1701158400\";\n   d=\"scan'208\";a=\"1795964\"",
            "E=Sophos;i=\"6.05,261,1701158400\"; d=\"scan'208\";a=\"33193285\""
        ],
        "X-ExtLoop1": "1",
        "From": "Brian Dooley <brian.dooley@intel.com>",
        "To": "Kai Ji <kai.ji@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>",
        "Cc": "dev@dpdk.org, gakhil@marvell.com, Brian Dooley <brian.dooley@intel.com>,\n Ciara Power <ciara.power@intel.com>",
        "Subject": "[PATCH v2] crypto/ipsec_mb: use new ipad/opad calculation API",
        "Date": "Sun, 11 Feb 2024 19:10:38 +0000",
        "Message-Id": "<20240211191038.863120-1-brian.dooley@intel.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20231214164135.2193863-1-brian.dooley@intel.com>",
        "References": "<20231214164135.2193863-1-brian.dooley@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "IPSec Multi-buffer library v1.4 added a new API to\ncalculate inner/outer padding for HMAC-SHAx/MD5.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\nSigned-off-by: Brian Dooley <brian.dooley@intel.com>\nAcked-by: Ciara Power <ciara.power@intel.com>\n\nDepends-on: series-30989 (\"crypto/ipsec_mb: bump minimum IPsec Multi-buffer version\")\n\nv2:\n- Remove ipsec mb version checks\n---\n drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 75 ++------------------------\n 1 file changed, 5 insertions(+), 70 deletions(-)",
    "diff": "diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\nindex 4de4866cf3..251e18ec7a 100644\n--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\n+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\n@@ -13,49 +13,6 @@ struct aesni_mb_op_buf_data {\n \tuint32_t offset;\n };\n \n-/**\n- * Calculate the authentication pre-computes\n- *\n- * @param one_block_hash\tFunction pointer\n- *\t\t\t\tto calculate digest on ipad/opad\n- * @param ipad\t\t\tInner pad output byte array\n- * @param opad\t\t\tOuter pad output byte array\n- * @param hkey\t\t\tAuthentication key\n- * @param hkey_len\t\tAuthentication key length\n- * @param blocksize\t\tBlock size of selected hash algo\n- */\n-static void\n-calculate_auth_precomputes(hash_one_block_t one_block_hash,\n-\t\tuint8_t *ipad, uint8_t *opad,\n-\t\tconst uint8_t *hkey, uint16_t hkey_len,\n-\t\tuint16_t blocksize)\n-{\n-\tuint32_t i, length;\n-\n-\tuint8_t ipad_buf[blocksize] __rte_aligned(16);\n-\tuint8_t opad_buf[blocksize] __rte_aligned(16);\n-\n-\t/* Setup inner and outer pads */\n-\tmemset(ipad_buf, HMAC_IPAD_VALUE, blocksize);\n-\tmemset(opad_buf, HMAC_OPAD_VALUE, blocksize);\n-\n-\t/* XOR hash key with inner and outer pads */\n-\tlength = hkey_len > blocksize ? blocksize : hkey_len;\n-\n-\tfor (i = 0; i < length; i++) {\n-\t\tipad_buf[i] ^= hkey[i];\n-\t\topad_buf[i] ^= hkey[i];\n-\t}\n-\n-\t/* Compute partial hashes */\n-\t(*one_block_hash)(ipad_buf, ipad);\n-\t(*one_block_hash)(opad_buf, opad);\n-\n-\t/* Clean up stack */\n-\tmemset(ipad_buf, 0, blocksize);\n-\tmemset(opad_buf, 0, blocksize);\n-}\n-\n static inline int\n is_aead_algo(IMB_HASH_ALG hash_alg, IMB_CIPHER_MODE cipher_mode)\n {\n@@ -66,12 +23,10 @@ is_aead_algo(IMB_HASH_ALG hash_alg, IMB_CIPHER_MODE cipher_mode)\n \n /** Set session authentication parameters */\n static int\n-aesni_mb_set_session_auth_parameters(const IMB_MGR *mb_mgr,\n+aesni_mb_set_session_auth_parameters(IMB_MGR *mb_mgr,\n \t\tstruct aesni_mb_session *sess,\n \t\tconst struct rte_crypto_sym_xform *xform)\n {\n-\thash_one_block_t hash_oneblock_fn = NULL;\n-\tunsigned int key_larger_block_size = 0;\n \tuint8_t hashed_key[HMAC_MAX_BLOCK_SIZE] = { 0 };\n \tuint32_t auth_precompute = 1;\n \n@@ -267,18 +222,15 @@ aesni_mb_set_session_auth_parameters(const IMB_MGR *mb_mgr,\n \tswitch (xform->auth.algo) {\n \tcase RTE_CRYPTO_AUTH_MD5_HMAC:\n \t\tsess->template_job.hash_alg = IMB_AUTH_MD5;\n-\t\thash_oneblock_fn = mb_mgr->md5_one_block;\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA1_HMAC:\n \t\tsess->template_job.hash_alg = IMB_AUTH_HMAC_SHA_1;\n-\t\thash_oneblock_fn = mb_mgr->sha1_one_block;\n \t\tif (xform->auth.key.length > get_auth_algo_blocksize(\n \t\t\t\tIMB_AUTH_HMAC_SHA_1)) {\n \t\t\tIMB_SHA1(mb_mgr,\n \t\t\t\txform->auth.key.data,\n \t\t\t\txform->auth.key.length,\n \t\t\t\thashed_key);\n-\t\t\tkey_larger_block_size = 1;\n \t\t}\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA1:\n@@ -287,14 +239,12 @@ aesni_mb_set_session_auth_parameters(const IMB_MGR *mb_mgr,\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA224_HMAC:\n \t\tsess->template_job.hash_alg = IMB_AUTH_HMAC_SHA_224;\n-\t\thash_oneblock_fn = mb_mgr->sha224_one_block;\n \t\tif (xform->auth.key.length > get_auth_algo_blocksize(\n \t\t\t\tIMB_AUTH_HMAC_SHA_224)) {\n \t\t\tIMB_SHA224(mb_mgr,\n \t\t\t\txform->auth.key.data,\n \t\t\t\txform->auth.key.length,\n \t\t\t\thashed_key);\n-\t\t\tkey_larger_block_size = 1;\n \t\t}\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA224:\n@@ -303,14 +253,12 @@ aesni_mb_set_session_auth_parameters(const IMB_MGR *mb_mgr,\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA256_HMAC:\n \t\tsess->template_job.hash_alg = IMB_AUTH_HMAC_SHA_256;\n-\t\thash_oneblock_fn = mb_mgr->sha256_one_block;\n \t\tif (xform->auth.key.length > get_auth_algo_blocksize(\n \t\t\t\tIMB_AUTH_HMAC_SHA_256)) {\n \t\t\tIMB_SHA256(mb_mgr,\n \t\t\t\txform->auth.key.data,\n \t\t\t\txform->auth.key.length,\n \t\t\t\thashed_key);\n-\t\t\tkey_larger_block_size = 1;\n \t\t}\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA256:\n@@ -319,14 +267,12 @@ aesni_mb_set_session_auth_parameters(const IMB_MGR *mb_mgr,\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA384_HMAC:\n \t\tsess->template_job.hash_alg = IMB_AUTH_HMAC_SHA_384;\n-\t\thash_oneblock_fn = mb_mgr->sha384_one_block;\n \t\tif (xform->auth.key.length > get_auth_algo_blocksize(\n \t\t\t\tIMB_AUTH_HMAC_SHA_384)) {\n \t\t\tIMB_SHA384(mb_mgr,\n \t\t\t\txform->auth.key.data,\n \t\t\t\txform->auth.key.length,\n \t\t\t\thashed_key);\n-\t\t\tkey_larger_block_size = 1;\n \t\t}\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA384:\n@@ -335,14 +281,12 @@ aesni_mb_set_session_auth_parameters(const IMB_MGR *mb_mgr,\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA512_HMAC:\n \t\tsess->template_job.hash_alg = IMB_AUTH_HMAC_SHA_512;\n-\t\thash_oneblock_fn = mb_mgr->sha512_one_block;\n \t\tif (xform->auth.key.length > get_auth_algo_blocksize(\n \t\t\t\tIMB_AUTH_HMAC_SHA_512)) {\n \t\t\tIMB_SHA512(mb_mgr,\n \t\t\t\txform->auth.key.data,\n \t\t\t\txform->auth.key.length,\n \t\t\t\thashed_key);\n-\t\t\tkey_larger_block_size = 1;\n \t\t}\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA512:\n@@ -376,19 +320,10 @@ aesni_mb_set_session_auth_parameters(const IMB_MGR *mb_mgr,\n \t\treturn 0;\n \n \t/* Calculate Authentication precomputes */\n-\tif (key_larger_block_size) {\n-\t\tcalculate_auth_precomputes(hash_oneblock_fn,\n-\t\t\tsess->auth.pads.inner, sess->auth.pads.outer,\n-\t\t\thashed_key,\n-\t\t\txform->auth.key.length,\n-\t\t\tget_auth_algo_blocksize(sess->template_job.hash_alg));\n-\t} else {\n-\t\tcalculate_auth_precomputes(hash_oneblock_fn,\n-\t\t\tsess->auth.pads.inner, sess->auth.pads.outer,\n-\t\t\txform->auth.key.data,\n-\t\t\txform->auth.key.length,\n-\t\t\tget_auth_algo_blocksize(sess->template_job.hash_alg));\n-\t}\n+\timb_hmac_ipad_opad(mb_mgr, sess->template_job.hash_alg,\n+\t\txform->auth.key.data, xform->auth.key.length,\n+\t\tsess->auth.pads.inner, sess->auth.pads.outer);\n+\n \tsess->template_job.u.HMAC._hashed_auth_key_xor_ipad =\n \t\tsess->auth.pads.inner;\n \tsess->template_job.u.HMAC._hashed_auth_key_xor_opad =\n",
    "prefixes": [
        "v2"
    ]
}