Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136496/?format=api
{ "id": 136496, "url": "https://patches.dpdk.org/api/patches/136496/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240207161414.1583125-3-michaelba@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240207161414.1583125-3-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240207161414.1583125-3-michaelba@nvidia.com", "date": "2024-02-07T16:14:14", "name": "[v4,2/2] net/mlx5: add support to compare random value", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f11b3d31e0bcba0675981cbbee99c75adad45f62", "submitter": { "id": 1949, "url": "https://patches.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240207161414.1583125-3-michaelba@nvidia.com/mbox/", "series": [ { "id": 31041, "url": "https://patches.dpdk.org/api/series/31041/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31041", "date": "2024-02-07T16:14:12", "name": "net/mlx5: add random compare support", "version": 4, "mbox": "https://patches.dpdk.org/series/31041/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/136496/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/136496/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AD19943AA0;\n\tWed, 7 Feb 2024 17:15:08 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B129042E01;\n\tWed, 7 Feb 2024 17:15:03 +0100 (CET)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2057.outbound.protection.outlook.com [40.107.94.57])\n by mails.dpdk.org (Postfix) with ESMTP id 6C59E42DD5\n for <dev@dpdk.org>; Wed, 7 Feb 2024 17:15:01 +0100 (CET)", "from PH7PR10CA0013.namprd10.prod.outlook.com (2603:10b6:510:23d::9)\n by PH0PR12MB5403.namprd12.prod.outlook.com (2603:10b6:510:eb::19)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.14; Wed, 7 Feb\n 2024 16:14:56 +0000", "from SA2PEPF000015CA.namprd03.prod.outlook.com\n (2603:10b6:510:23d:cafe::d9) by PH7PR10CA0013.outlook.office365.com\n (2603:10b6:510:23d::9) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.38 via Frontend\n Transport; Wed, 7 Feb 2024 16:14:56 +0000", "from mail.nvidia.com (216.228.117.160) by\n SA2PEPF000015CA.mail.protection.outlook.com (10.167.241.200) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7249.19 via Frontend Transport; Wed, 7 Feb 2024 16:14:56 +0000", "from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 7 Feb 2024\n 08:14:31 -0800", "from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com\n (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Wed, 7 Feb\n 2024 08:14:30 -0800", "from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.7) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend\n Transport; Wed, 7 Feb 2024 08:14:28 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=dwg56KAm8MCZoutsuEnDlIoNeXFdE4Tr/2tgd1iXeUfjmy1YfKjRg6/GEFNWv1u+3c5IpxWiJhgzMtqqWo2wp0hNQTOj6xoaXgJaz+nEjUkaBY4j2H+BUA+2Qm5zv6cLZzYmeoVpksD47UYBdon4DxYO53hAbiG8BQme5jQivR3rUWvBSEXOG28dOPNhh5ZdDqmY+DpEbrUe9e9t/AUlkHkLu4vEHNUsnRM8cz+Bt6ocmjkx2wnd44H5oqR29cf1J4ZYuUbTyvkLkRr9FxMThy3YwX/qa93jWRXCSbbt17R9ZI4fzw6BphlApAj/qcP0byYJuZb9nNjiudCoV6POdA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=v2VSdEwMj6tihEgWamVgZr6s1ZIU1ndaoQygnGfy8+w=;\n b=MxGw8+9yYQtraMtQaQKau3wQDzE9bH2PfHxi9vvLrOKaiW2Mu2RqItUl6dhE1UUnFrROb1Sh1NH+DsQQgkXH4TbDPVBQ/g9Ur250j7ZdD5B+EeL3nBOnt4bpy3kgDy+3ekAMoWAnuCWriAh5UcbAHWtZ6N2bpInw+ZRwxtopTLrkES0xE5Z/0UV6H/DtADaIhhH8pCnSwuczYtduQUzQ0fQTGGR6YSydlDwy+Of8Wdd8hbDA4SR5Qm/CHI/2KuGkU2IJQ6nol2wm+Vg+1DmASSwSKoEqzVi0h/0paO1QwmEcPNVPr3f1A6yMpA7rgXwCMkeXkRMkzA3boLbyW+pSNg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=v2VSdEwMj6tihEgWamVgZr6s1ZIU1ndaoQygnGfy8+w=;\n b=kCrA/P+fIotujl1vBL40+tA9x915VpTCBfoiTYeWR3bLg/+Vdnay/Tpw4MBjIDldssucvUL7y0BXtp4mzJUGueJFHlGHOgetA1dsA6ySuiWcovj8o83/UiC7Q3y2raLFzYXiIQelfThWMd4SLA8ThKn2fLMb3fKLtCHJD7GPEsk8olATZjSFQxrriDiKa9yF3w5x0jd2z2AIi7UAgqmQdyPw79OhiIiU9R7v1umRfoBUFo38hfYsiz/I5Z6enuoapQBd5JFkS7gZNO4WbES0QS+NV/K5Ap0VP3jmOdsWnIpH7Lg1u76DSzD3uws8NPDzXM0tzjU7JMw3QG/RW008SA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Michael Baum <michaelba@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Matan Azrad <matan@nvidia.com>, Dariusz Sosnowski <dsosnowski@nvidia.com>,\n Raslan Darawsheh <rasland@nvidia.com>, Viacheslav Ovsiienko\n <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>, Suanming Mou\n <suanmingm@nvidia.com>", "Subject": "[PATCH v4 2/2] net/mlx5: add support to compare random value", "Date": "Wed, 7 Feb 2024 18:14:14 +0200", "Message-ID": "<20240207161414.1583125-3-michaelba@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240207161414.1583125-1-michaelba@nvidia.com>", "References": "<20240129134410.885145-1-michaelba@nvidia.com>\n <20240207161414.1583125-1-michaelba@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-NV-OnPremToCloud": "ExternallySecured", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SA2PEPF000015CA:EE_|PH0PR12MB5403:EE_", "X-MS-Office365-Filtering-Correlation-Id": "92216d84-d5f0-487d-265c-08dc27f7ecd9", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n NL3d+8vjSWc6d5zyfz0e+KLYjsxhT4VbKNVZqKbUXApYpyFuKfFTinREwxgymTYXM3J1ltZGpWnmR1StAZp/klBqf6hNDRkdOUG7Ub5wJEx6WXCq1m0cQAVbi9TVnzwphlm+SL6mzHhzwO3tH0AIS1GWcHw0jh19OYMOzliwOgee4lcxBSUxk0oLDcCnkaYhxae/KnFhqG/cvfD3Bc8j8lF2XdBs5EUZ79UVMZKLfPdO5L7O/QGVEfXaTkmxUCMK0rpVq5b5SAIllWvVbUVB0FtLprAG/60ruQtJQlFjBQrWUpOs3k5gNTyhAfY5qptSFBsoLcNASWhcwJMPgT3wmPDrG2E9x9HFhBk2HqnkUU5kl5NbA9785jxq1zA9xmj8BU1N9WYA7vTyZQ6xUpt28HotWpBfVGfj6Kcd0BoVG+TvP4pHdHc4TjYoSvo9LPl5ZPWk4ozso5olaCNISQW/nqtWiDbfJtAXW3nNT7RaIsd+8p1pbCGi4K1sWL3Qxqo3HufKgBRkVlwQZfgBB4APImo6rfogmPJKlSJd9UDef7pfkX9zcwbWo4pVNZ1P5kYV0384poDJ5PBHhjgtuJUU9rnLPoI6vMcJakF9lerQLptbaggEnxH2yaGup/KGohDVo7DsU51Jq1NiCG2RIuDEEUoqbfwDmoha/Iq8I9tLyCl84Psc45Etk/nKtWYMT+/sDARTZLSyr34EmecHu2z54J31ZQCd52FfQANqm+mfkmYsQjhi20/v3FPj/tl7ydMz", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(396003)(346002)(376002)(136003)(39860400002)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(82310400011)(36840700001)(40470700004)(46966006)(1076003)(4326008)(8676002)(8936002)(36756003)(2906002)(5660300002)(41300700001)(2616005)(336012)(107886003)(6666004)(86362001)(7696005)(36860700001)(55016003)(478600001)(426003)(356005)(70206006)(26005)(7636003)(6286002)(83380400001)(82740400003)(6916009)(316002)(40480700001)(70586007)(54906003)(47076005)(40460700003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 Feb 2024 16:14:56.2421 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 92216d84-d5f0-487d-265c-08dc27f7ecd9", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n SA2PEPF000015CA.namprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH0PR12MB5403", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add support to use \"RTE_FLOW_ITEM_TYPE_COMPARE\" with\n\"RTE_FLOW_FIELD_RAMDOM\" as an argument.\nThe random field is supported only when base is an immediate value,\nrandom field cannot be compared with enother field.\n\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\n---\n doc/guides/nics/mlx5.rst | 9 ++++-\n drivers/net/mlx5/mlx5_flow_hw.c | 70 ++++++++++++++++++++++++---------\n 2 files changed, 59 insertions(+), 20 deletions(-)", "diff": "diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst\nindex fa013b03bb..43ef8a99dc 100644\n--- a/doc/guides/nics/mlx5.rst\n+++ b/doc/guides/nics/mlx5.rst\n@@ -820,8 +820,13 @@ Limitations\n \n - Only supported in HW steering(``dv_flow_en`` = 2) mode.\n - Only single flow is supported to the flow table.\n- - Only 32-bit comparison is supported.\n- - Only match with compare result between packet fields is supported.\n+ - Only single item is supported per pattern template.\n+ - Only 32-bit comparison is supported or 16-bits for random field.\n+ - Only supported for ``RTE_FLOW_FIELD_META``, ``RTE_FLOW_FIELD_TAG``,\n+ ``RTE_FLOW_FIELD_RANDOM`` and ``RTE_FLOW_FIELD_VALUE``.\n+ - The field type ``RTE_FLOW_FIELD_VALUE`` must be the base (``b``) field.\n+ - The field type ``RTE_FLOW_FIELD_RANDOM`` can only be compared with\n+ ``RTE_FLOW_FIELD_VALUE``.\n \n \n Statistics\ndiff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex 3af5e1f160..b5741f0817 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -6717,18 +6717,55 @@ flow_hw_prepend_item(const struct rte_flow_item *items,\n \treturn copied_items;\n }\n \n-static inline bool\n-flow_hw_item_compare_field_supported(enum rte_flow_field_id field)\n+static int\n+flow_hw_item_compare_field_validate(enum rte_flow_field_id arg_field,\n+\t\t\t\t enum rte_flow_field_id base_field,\n+\t\t\t\t struct rte_flow_error *error)\n {\n-\tswitch (field) {\n+\tswitch (arg_field) {\n+\tcase RTE_FLOW_FIELD_TAG:\n+\tcase RTE_FLOW_FIELD_META:\n+\t\tbreak;\n+\tcase RTE_FLOW_FIELD_RANDOM:\n+\t\tif (base_field == RTE_FLOW_FIELD_VALUE)\n+\t\t\treturn 0;\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"compare random is supported only with immediate value\");\n+\tdefault:\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"compare item argument field is not supported\");\n+\t}\n+\tswitch (base_field) {\n \tcase RTE_FLOW_FIELD_TAG:\n \tcase RTE_FLOW_FIELD_META:\n \tcase RTE_FLOW_FIELD_VALUE:\n-\t\treturn true;\n+\t\tbreak;\n+\tdefault:\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"compare item base field is not supported\");\n+\t}\n+\treturn 0;\n+}\n+\n+static inline uint32_t\n+flow_hw_item_compare_width_supported(enum rte_flow_field_id field)\n+{\n+\tswitch (field) {\n+\tcase RTE_FLOW_FIELD_TAG:\n+\tcase RTE_FLOW_FIELD_META:\n+\t\treturn 32;\n+\tcase RTE_FLOW_FIELD_RANDOM:\n+\t\treturn 16;\n \tdefault:\n \t\tbreak;\n \t}\n-\treturn false;\n+\treturn 0;\n }\n \n static int\n@@ -6737,6 +6774,7 @@ flow_hw_validate_item_compare(const struct rte_flow_item *item,\n {\n \tconst struct rte_flow_item_compare *comp_m = item->mask;\n \tconst struct rte_flow_item_compare *comp_v = item->spec;\n+\tint ret;\n \n \tif (unlikely(!comp_m))\n \t\treturn rte_flow_error_set(error, EINVAL,\n@@ -6748,19 +6786,13 @@ flow_hw_validate_item_compare(const struct rte_flow_item *item,\n \t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n \t\t\t\t NULL,\n \t\t\t\t \"compare item only support full mask\");\n-\tif (!flow_hw_item_compare_field_supported(comp_m->a.field) ||\n-\t !flow_hw_item_compare_field_supported(comp_m->b.field))\n-\t\treturn rte_flow_error_set(error, ENOTSUP,\n-\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n-\t\t\t\t NULL,\n-\t\t\t\t \"compare item field not support\");\n-\tif (comp_m->a.field == RTE_FLOW_FIELD_VALUE &&\n-\t comp_m->b.field == RTE_FLOW_FIELD_VALUE)\n-\t\treturn rte_flow_error_set(error, EINVAL,\n-\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n-\t\t\t\t NULL,\n-\t\t\t\t \"compare between value is not valid\");\n+\tret = flow_hw_item_compare_field_validate(comp_m->a.field,\n+\t\t\t\t\t\t comp_m->b.field, error);\n+\tif (ret < 0)\n+\t\treturn ret;\n \tif (comp_v) {\n+\t\tuint32_t width;\n+\n \t\tif (comp_v->operation != comp_m->operation ||\n \t\t comp_v->a.field != comp_m->a.field ||\n \t\t comp_v->b.field != comp_m->b.field)\n@@ -6768,7 +6800,9 @@ flow_hw_validate_item_compare(const struct rte_flow_item *item,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n \t\t\t\t\t NULL,\n \t\t\t\t\t \"compare item spec/mask not matching\");\n-\t\tif ((comp_v->width & comp_m->width) != 32)\n+\t\twidth = flow_hw_item_compare_width_supported(comp_v->a.field);\n+\t\tMLX5_ASSERT(width > 0);\n+\t\tif ((comp_v->width & comp_m->width) != width)\n \t\t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n \t\t\t\t\t NULL,\n", "prefixes": [ "v4", "2/2" ] }