Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136393/?format=api
{ "id": 136393, "url": "https://patches.dpdk.org/api/patches/136393/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240205180328.131019-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240205180328.131019-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240205180328.131019-7-stephen@networkplumber.org", "date": "2024-02-05T17:43:34", "name": "[v9,06/23] eal: replace use of sanity check in comments and messages", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0f642c7cb40827541fcb9e3c93422e2090b5bd3d", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240205180328.131019-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 31003, "url": "https://patches.dpdk.org/api/series/31003/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31003", "date": "2024-02-05T17:43:28", "name": "Use inclusive naming in DPDK", "version": 9, "mbox": "https://patches.dpdk.org/series/31003/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/136393/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/136393/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A72D443A3D;\n\tMon, 5 Feb 2024 19:04:30 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BF53D40ED8;\n\tMon, 5 Feb 2024 19:03:47 +0100 (CET)", "from mail-pl1-f181.google.com (mail-pl1-f181.google.com\n [209.85.214.181])\n by mails.dpdk.org (Postfix) with ESMTP id DC88340269\n for <dev@dpdk.org>; Mon, 5 Feb 2024 19:03:44 +0100 (CET)", "by mail-pl1-f181.google.com with SMTP id\n d9443c01a7336-1d958e0d73dso27441465ad.1\n for <dev@dpdk.org>; Mon, 05 Feb 2024 10:03:44 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n x8-20020a170902b40800b001d9b0a15bbfsm144867plr.262.2024.02.05.10.03.43\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 05 Feb 2024 10:03:43 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1707156224;\n x=1707761024; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ApPm79+YUtT09EP+FY3CN8Jd9NvPoernSgFeoMJrzko=;\n b=YTY7Nb/lM8AWmgehOyuoZoLILsBPLHOfivJeCE6XvWfinqytVQ0bXQtfW8pFTUZaLM\n 3kDjb6nt5DZYieoPAL4Ix1Ofoq4baR7wyuCgCIU+9eEsNWyLVpeuxxTyS387xMUVI+NQ\n jDwAMLjKzJTnDZew1R7gMCR2iHmZFt7Ds4OcUh9lTiLmw/mN7TilvflvQ7lQEOhfRdhy\n lVjYqFPsEdbQuzSK0022FlvvqAaq4oc9XsntB7+C/i11RnJmF8i03OSb1mSYJ99UevFP\n HyeY1yUipdnPEzXpnRgG2724aZVkgBh15cDXvF9ycPRkIdphF6jS2eC1AS64ikxlbUiX\n ssBA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1707156224; x=1707761024;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=ApPm79+YUtT09EP+FY3CN8Jd9NvPoernSgFeoMJrzko=;\n b=AWYFNg7FLnq9bHjnDcz3ecnRB2YpC4U1wUL+wpDzKet/+5g9Csmpn0PFXW5zacDCd0\n dJqgyptJyS4s8eCIrryqQndTQrdh9HGQ2e79u67OWqcxESItF65wOJSZCp1caX/ADAVu\n bxVuNnbvYROI4IwbjKLZD2zV7mw7hrIG1q8ie4Jn4ONQUR/Xjxkj6s7duo1vLooH4/IB\n P8+OLLXbZRTsHqbcwpux5cZYtYaBlmXMDdb+bvHvUCxh6e3iDkeGJ/cj9AbkyYjCiqtq\n 7blMJqf6e9A1zcy1x00h1IjUf/akyIdT2n1CGdkmFcH/d3sArc4OcZtPOy47rHZFPbie\n zacQ==", "X-Gm-Message-State": "AOJu0YxJt6c/yAM+RHcWvD2/nDDuNNEcRF/GrPS1uBPW6+s8vqJqWWXS\n dxtL5uNCU4n1mJwdz/D4TjHLKqSTichnVYI10Bdi4BwihsR6VUKJcUWppuCdRHQRmI/T+r6f9q4\n b3fM=", "X-Google-Smtp-Source": "\n AGHT+IFj7BcOaA2GeW2bEZq9MYJr9R0b+pHl8OajeFJvEpmbWqGVdl8IDZewrhEyYuB+PWtppROXcg==", "X-Received": "by 2002:a17:902:fc90:b0:1d7:17e6:44fb with SMTP id\n mf16-20020a170902fc9000b001d717e644fbmr7334960plb.32.1707156224065;\n Mon, 05 Feb 2024 10:03:44 -0800 (PST)", "X-Forwarded-Encrypted": "i=0;\n AJvYcCVyqY4nkmaF49BRyPGLnJGfAfZa17LrDGHxYH7t+E3OZCOa/0u8dbeBw3SU770iTgmbbUqkyCc0+p0NaNsrtvQFcTkx1dsxC2f39uZ+vQ3zWRuQxVgX5DIcgad6EhLrrP7RhCWrjLbjWkld8YQkSAkkLBH359euMN69dqvTOty4E0qmBsRvX80TWCoNcDecy+7+r6vKR83Xs8TlDk2uTwg5pizaLq93m+7xQU8H4YiAeTZYGc8H+FxQ3RziLM++DnWGdn8qNNd3w/sJ+gjaY+C+pLsN9y5US0ufUX4BmQ==", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>", "Subject": "[PATCH v9 06/23] eal: replace use of sanity check in comments and\n messages", "Date": "Mon, 5 Feb 2024 09:43:34 -0800", "Message-ID": "<20240205180328.131019-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240205180328.131019-1-stephen@networkplumber.org>", "References": "<0230331200824.195294-1-stephen@networkplumber.org>\n <20240205180328.131019-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Sanity check is on the Tier 2 non-inclusive list.\nReplace or remove it.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/eal/common/eal_common_memory.c | 2 +-\n lib/eal/common/eal_common_proc.c | 3 ++-\n lib/eal/common/eal_common_trace.c | 2 +-\n lib/eal/common/eal_memcfg.h | 2 +-\n lib/eal/common/rte_malloc.c | 2 +-\n lib/eal/freebsd/eal.c | 2 +-\n lib/eal/linux/eal.c | 2 +-\n lib/eal/windows/eal.c | 2 +-\n 8 files changed, 9 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c\nindex 60ddc30580a7..9f4a8676f18f 100644\n--- a/lib/eal/common/eal_common_memory.c\n+++ b/lib/eal/common/eal_common_memory.c\n@@ -562,7 +562,7 @@ check_dma_mask(uint8_t maskbits, bool thread_unsafe)\n \tuint64_t mask;\n \tint ret;\n \n-\t/* Sanity check. We only check width can be managed with 64 bits\n+\t/* We only check width can be managed with 64 bits\n \t * variables. Indeed any higher value is likely wrong. */\n \tif (maskbits > MAX_DMA_MASK_BITS) {\n \t\tEAL_LOG(ERR, \"wrong dma mask size %u (Max: %u)\",\ndiff --git a/lib/eal/common/eal_common_proc.c b/lib/eal/common/eal_common_proc.c\nindex d24093937c1d..838602edef08 100644\n--- a/lib/eal/common/eal_common_proc.c\n+++ b/lib/eal/common/eal_common_proc.c\n@@ -309,7 +309,8 @@ read_msg(int fd, struct mp_msg_internal *m, struct sockaddr_un *s)\n \t\t\tbreak;\n \t\t}\n \t}\n-\t/* sanity-check the response */\n+\n+\t/* Check that the response is valid */\n \tif (m->msg.num_fds < 0 || m->msg.num_fds > RTE_MP_MAX_FD_NUM) {\n \t\tEAL_LOG(ERR, \"invalid number of fd's received\");\n \t\treturn -1;\ndiff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c\nindex 6ad87fc0df5d..b2bab5c45f1e 100644\n--- a/lib/eal/common/eal_common_trace.c\n+++ b/lib/eal/common/eal_common_trace.c\n@@ -468,7 +468,7 @@ __rte_trace_point_register(rte_trace_point_t *handle, const char *name,\n \tstruct trace_point *tp;\n \tuint16_t sz;\n \n-\t/* Sanity checks of arguments */\n+\t/* Check arguments */\n \tif (name == NULL || register_fn == NULL || handle == NULL) {\n \t\ttrace_err(\"invalid arguments\");\n \t\trte_errno = EINVAL;\ndiff --git a/lib/eal/common/eal_memcfg.h b/lib/eal/common/eal_memcfg.h\nindex 60e2089797a2..e8a85df35585 100644\n--- a/lib/eal/common/eal_memcfg.h\n+++ b/lib/eal/common/eal_memcfg.h\n@@ -18,7 +18,7 @@\n * Memory configuration shared across multiple processes.\n */\n struct rte_mem_config {\n-\tvolatile uint32_t magic; /**< Magic number - sanity check. */\n+\tvolatile uint32_t magic; /**< Magic number check. */\n \tuint32_t version;\n \t/**< Prevent secondary processes using different DPDK versions. */\n \ndiff --git a/lib/eal/common/rte_malloc.c b/lib/eal/common/rte_malloc.c\nindex 6d3c301a2368..dac077bc8e09 100644\n--- a/lib/eal/common/rte_malloc.c\n+++ b/lib/eal/common/rte_malloc.c\n@@ -654,7 +654,7 @@ rte_malloc_heap_destroy(const char *heap_name)\n \t\tret = -1;\n \t\tgoto unlock;\n \t}\n-\t/* sanity checks done, now we can destroy the heap */\n+\t/* checks done, now we can destroy the heap */\n \trte_spinlock_lock(&heap->lock);\n \tret = malloc_heap_destroy(heap);\n \trte_spinlock_unlock(&heap->lock);\ndiff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex bab77118e967..1500778b4f06 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -501,7 +501,7 @@ eal_parse_args(int argc, char **argv)\n \t\tgoto out;\n \t}\n \n-\t/* sanity checks */\n+\t/* options checks */\n \tif (eal_check_common_options(internal_conf) != 0) {\n \t\teal_usage(prgname);\n \t\tret = -1;\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex fd422f1f6236..50cebdbbd481 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -803,7 +803,7 @@ eal_parse_args(int argc, char **argv)\n \t\tgoto out;\n \t}\n \n-\t/* sanity checks */\n+\t/* options checks */\n \tif (eal_check_common_options(internal_conf) != 0) {\n \t\teal_usage(prgname);\n \t\tret = -1;\ndiff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c\nindex 52f0e7462dd8..915c8e569a5d 100644\n--- a/lib/eal/windows/eal.c\n+++ b/lib/eal/windows/eal.c\n@@ -194,7 +194,7 @@ eal_parse_args(int argc, char **argv)\n \tif (eal_adjust_config(internal_conf) != 0)\n \t\treturn -1;\n \n-\t/* sanity checks */\n+\t/* options checks */\n \tif (eal_check_common_options(internal_conf) != 0) {\n \t\teal_usage(prgname);\n \t\treturn -1;\n", "prefixes": [ "v9", "06/23" ] }