Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136131/?format=api
{ "id": 136131, "url": "https://patches.dpdk.org/api/patches/136131/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240125031755.657102-1-yajunw@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240125031755.657102-1-yajunw@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240125031755.657102-1-yajunw@nvidia.com", "date": "2024-01-25T03:17:55", "name": "vdpa/mlx5: fix queue enable drain CQ", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "534ffea0b9f01ed1169e60b6e93cf9ff5facc84d", "submitter": { "id": 2517, "url": "https://patches.dpdk.org/api/people/2517/?format=api", "name": "Yajun Wu", "email": "yajunw@nvidia.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240125031755.657102-1-yajunw@nvidia.com/mbox/", "series": [ { "id": 30911, "url": "https://patches.dpdk.org/api/series/30911/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=30911", "date": "2024-01-25T03:17:55", "name": "vdpa/mlx5: fix queue enable drain CQ", "version": 1, "mbox": "https://patches.dpdk.org/series/30911/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/136131/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/136131/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E276D439BA;\n\tThu, 25 Jan 2024 04:18:38 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 66DBA4029B;\n\tThu, 25 Jan 2024 04:18:38 +0100 (CET)", "from NAM12-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam12on2053.outbound.protection.outlook.com [40.107.243.53])\n by mails.dpdk.org (Postfix) with ESMTP id 97D7D4027B;\n Thu, 25 Jan 2024 04:18:36 +0100 (CET)", "from CH0PR07CA0004.namprd07.prod.outlook.com (2603:10b6:610:32::9)\n by CH0PR12MB8529.namprd12.prod.outlook.com (2603:10b6:610:18d::5) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Thu, 25 Jan\n 2024 03:18:34 +0000", "from CH1PEPF0000A34A.namprd04.prod.outlook.com\n (2603:10b6:610:32:cafe::97) by CH0PR07CA0004.outlook.office365.com\n (2603:10b6:610:32::9) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22 via Frontend\n Transport; Thu, 25 Jan 2024 03:18:34 +0000", "from mail.nvidia.com (216.228.117.161) by\n CH1PEPF0000A34A.mail.protection.outlook.com (10.167.244.5) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7228.16 via Frontend Transport; Thu, 25 Jan 2024 03:18:34 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 24 Jan\n 2024 19:18:14 -0800", "from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 24 Jan\n 2024 19:18:11 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=oQ8eo076971ZGLJpP2hzuBq4x8upD3uxP0hyNFCq7oVFg2ttcx++nwKaGgOXHp/PU/U6Ii/fK9NnhqPRKiFHtgE0nSsf/GuaC00E/Kwxs9cH5H8/qQTqq2beBBDFp8Ix6zftzajG2+IXs/Zjuv6ROcdSqHk5CgB4MX0nGRSGnIbI/j0rQOmWqSVbHVR2QsRrxzsMZjFujIS6jk9ULtCffJIUvb8brRJ5Q2b023HkjdLC+4nJqh83WjjNT5la/RxP3f9PKaj1rTsuQWqnaMHiWP4sExwEIDiH6oaToWvHyW5utJm1j+piOEBGe3ociszdPtQWbO8ZHS6bqVXZE9ztUA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=DPVOgG7HK3ZTWExa0WdBzx0QJxaRJMCxNVPR2O0xJu8=;\n b=W7yxbjM58SBXMDW1q4+g0qTJgDcCAHbbclrua2HKFPaS1iXKLx5t9LljFP7eYRzCnUw4K9DEiOXrZcWlrzO8XPCKVj5WJL0xi0WEFHqILBUVah0uA1YgnhVH2n+9mID1J0EeHAPcQZC/3M61dES+A2uppsZYjxSBsJjBKeSxESGPDR/VYcicUPOPJMtOvwaiTboc4+pVoOUSvtxrHsPUoMyCG7QqtYFqMyHh+o035bZay1yrSMQFPIN5pQLRDiNRbz1lY8kYRVxHri52SkK9iuIMpJAgVCp7U07Q55PL8Gko22NRmSkYr9EVLOQnEdwES0wvH1yw2zbw9V2PrJOPjg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=DPVOgG7HK3ZTWExa0WdBzx0QJxaRJMCxNVPR2O0xJu8=;\n b=o4/t6bNlRvDKrukskusm/U5UDtzmk8luwIao1Z/4LQWzeGEnK+rgVHVbftFVSZWRZM+W6lZKZ4FVl6aWSt3nsuc2/FtHHpY6k7IG0lFgiXyp2f2ES+zy4Vj8Jj5WTbmeGcOFUwLERboeLU4yftHMWMmdnzTRSFYruaOSrYegefjCc2JGN/EMHY8voHwoq0b08b0HW0537SDDhU3boqyLn1a3VhwZm26ZXR5s0YF8iopdKW8iZMtzTkrh8pdkimPtZAH++0N5m6aBa52geApuDqWs8JePgWuaIZvEjJwi+wvZAXosOneaGn/yeEZxWE11j6fNpQr3gZQT45eJBLyF/A==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Yajun Wu <yajunw@nvidia.com>", "To": "<matan@nvidia.com>, <maxime.coquelin@redhat.com>, Viacheslav Ovsiienko\n <viacheslavo@nvidia.com>", "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <mkashani@nvidia.com>,\n <stable@dpdk.org>", "Subject": "[PATCH] vdpa/mlx5: fix queue enable drain CQ", "Date": "Thu, 25 Jan 2024 11:17:55 +0800", "Message-ID": "<20240125031755.657102-1-yajunw@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "rnnvmail203.nvidia.com (10.129.68.9) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CH1PEPF0000A34A:EE_|CH0PR12MB8529:EE_", "X-MS-Office365-Filtering-Correlation-Id": "97e6a829-e47d-4557-ad84-08dc1d545075", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n XGiS2pIOR7eXQmJS5oZGDVyIKwnHDgRZ8nKZUWeCPzvGAlmQiTFSsga+pV3/uwQhe/gEJnGwUch1lGyKLg3uTSAw1camzFDN7jvo4TJFuxBDCO35GD9amRSACYgkUc91dJYaLWtstH2oasl2GR/9Wi2RI7by4WTeSaLZbl8mkdxeG/EzAjDvDsu276GrWpCtPJOMKNi9BD0xbtUhAPosWMEwGnxWezdolf1x39lrwyJgVYtTjHdYgpyCK5zE97zm5wzOYeAZQ3Ey8udj7WsTFBlVQB5k5I3Qk/k3O72MMJi9WLSpRP4ZrvdhbMmtdKZ3HWqQdwSUtapSJ6fVSnQqagj0jio/CjpLqQbARG/1t+/7PJt8rzI8k7rONm+fIagXtUtVoanYFaAoq0D5jnDlV0jia7/zRucA71YDKqyaSXJxzcGBAQ3tYgVA2Dim5TY/Bag8ptmezsfZLucf2nvurHqlq8tECchcnYuoYVQPyqdTqewDKH8Muh1UdrR22lPjMlEioTLLLlOefoKcAb/lkiFjFgMKYGlyimbwZgnmmejOXqJmBbRPsJ4d6iL+zDiZ8JPNPStoElHpVaUxRK0f1xFN04fk832iUInCVFcXPDSMar46pE574PiQKx9KxyS7oNMCcpFYcrbrA5ZhU1AdhNuwuGUkCJiltGNP2gxUEED7lVfkxWrY35pd53xtlFKAHIp8lgeHvnjmi0woTTQ7s/0PQbCaWxuEB2ZBt7E0ARmtdyTdWjulyz/+nn63+Qz7n2kQ5YHyD8yIJb0u8jDItyMNhZg5gYqZuNw4HXcA/Bw=", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(396003)(346002)(136003)(376002)(39860400002)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(82310400011)(40470700004)(46966006)(36840700001)(4326008)(83380400001)(8936002)(55016003)(40480700001)(40460700003)(8676002)(110136005)(70206006)(70586007)(54906003)(6636002)(316002)(426003)(1076003)(6286002)(16526019)(336012)(26005)(36860700001)(7696005)(82740400003)(2906002)(86362001)(47076005)(5660300002)(356005)(7636003)(2616005)(478600001)(6666004)(41300700001)(36756003)(21314003)(2101003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "25 Jan 2024 03:18:34.2396 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 97e6a829-e47d-4557-ad84-08dc1d545075", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CH1PEPF0000A34A.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CH0PR12MB8529", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "For the case: `ethtool -L eth0 combined xxx` in VM, VQ will disable\nand enable without calling device close. In such case, need add\ndrain CQ before reuse/reset event QP.\n\nFixes: 24969c7b62 (\"vdpa/mlx5: reuse event queues\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yajun Wu <yajunw@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/vdpa/mlx5/mlx5_vdpa_event.c | 29 +++++++++++++++++++----------\n 1 file changed, 19 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c b/drivers/vdpa/mlx5/mlx5_vdpa_event.c\nindex 9557c1042e..32430614d5 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c\n@@ -244,22 +244,30 @@ mlx5_vdpa_queues_complete(struct mlx5_vdpa_priv *priv)\n \treturn max;\n }\n \n+static void\n+mlx5_vdpa_drain_cq_one(struct mlx5_vdpa_priv *priv,\n+\tstruct mlx5_vdpa_virtq *virtq)\n+{\n+\tstruct mlx5_vdpa_cq *cq = &virtq->eqp.cq;\n+\n+\tmlx5_vdpa_queue_complete(cq);\n+\tif (cq->cq_obj.cq) {\n+\t\tcq->cq_obj.cqes[0].wqe_counter = rte_cpu_to_be_16(UINT16_MAX);\n+\t\tvirtq->eqp.qp_pi = 0;\n+\t\tif (!cq->armed)\n+\t\t\tmlx5_vdpa_cq_arm(priv, cq);\n+\t}\n+}\n+\n void\n mlx5_vdpa_drain_cq(struct mlx5_vdpa_priv *priv)\n {\n+\tstruct mlx5_vdpa_virtq *virtq;\n \tunsigned int i;\n \n \tfor (i = 0; i < priv->caps.max_num_virtio_queues; i++) {\n-\t\tstruct mlx5_vdpa_cq *cq = &priv->virtqs[i].eqp.cq;\n-\n-\t\tmlx5_vdpa_queue_complete(cq);\n-\t\tif (cq->cq_obj.cq) {\n-\t\t\tcq->cq_obj.cqes[0].wqe_counter =\n-\t\t\t\trte_cpu_to_be_16(UINT16_MAX);\n-\t\t\tpriv->virtqs[i].eqp.qp_pi = 0;\n-\t\t\tif (!cq->armed)\n-\t\t\t\tmlx5_vdpa_cq_arm(priv, cq);\n-\t\t}\n+\t\tvirtq = &priv->virtqs[i];\n+\t\tmlx5_vdpa_drain_cq_one(priv, virtq);\n \t}\n }\n \n@@ -632,6 +640,7 @@ mlx5_vdpa_event_qp_prepare(struct mlx5_vdpa_priv *priv, uint16_t desc_n,\n \tif (eqp->cq.cq_obj.cq != NULL && log_desc_n == eqp->cq.log_desc_n) {\n \t\t/* Reuse existing resources. */\n \t\teqp->cq.callfd = callfd;\n+\t\tmlx5_vdpa_drain_cq_one(priv, virtq);\n \t\t/* FW will set event qp to error state in q destroy. */\n \t\tif (reset && !mlx5_vdpa_qps2rst2rts(eqp))\n \t\t\trte_write32(rte_cpu_to_be_32(RTE_BIT32(log_desc_n)),\n", "prefixes": [] }