Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135734/?format=api
{ "id": 135734, "url": "https://patches.dpdk.org/api/patches/135734/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240104193633.2264-1-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240104193633.2264-1-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240104193633.2264-1-pbhagavatula@marvell.com", "date": "2024-01-04T19:36:33", "name": "event/cnxk: use WFE LDP loop for getwork routine", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "97f0dcbac839d560e735a2ec23b0c2025915d97c", "submitter": { "id": 1183, "url": "https://patches.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240104193633.2264-1-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 30725, "url": "https://patches.dpdk.org/api/series/30725/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=30725", "date": "2024-01-04T19:36:33", "name": "event/cnxk: use WFE LDP loop for getwork routine", "version": 1, "mbox": "https://patches.dpdk.org/series/30725/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/135734/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/135734/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D86D64381D;\n\tThu, 4 Jan 2024 20:36:52 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4B693402B9;\n\tThu, 4 Jan 2024 20:36:52 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 8BF844029A\n for <dev@dpdk.org>; Thu, 4 Jan 2024 20:36:51 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id\n 404I1Fi4029541 for <dev@dpdk.org>; Thu, 4 Jan 2024 11:36:50 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3ve1jv8d1u-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 04 Jan 2024 11:36:50 -0800 (PST)", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 4 Jan 2024 11:36:36 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 4 Jan 2024 11:36:36 -0800", "from MININT-80QBFE8.corp.innovium.com (MININT-80QBFE8.marvell.com\n [10.28.164.106])\n by maili.marvell.com (Postfix) with ESMTP id 1FD673F7073;\n Thu, 4 Jan 2024 11:36:34 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=\n from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding:content-type; s=pfpt0220; bh=mgySEyyr\n kqpar+NealpBTgtuVROX22BXX1AKw76cIYU=; b=VJPhnRfuWsVRFpLWKQGWlVPX\n iOwlRLdC17WDdn1SO0L0BykWtOyN4SR5yOt+p7jMtOhexEgZ5m9zZNy15HhR60uC\n JvPHX55Y99FdM/JQuiLbAUtD/CoyB0aNi3mgPCVvGvfZ3s/Z9SGjDizLiNp90FcU\n hMUnyu7Co82MXXc30EJ1ViAPaJ5lsJKKndo6x6vDqLlW86AFr2t2ZfKZSvlpMkxN\n gjYddfR6vZI8oEIKJgYy0zfOPZ1vI6M5S9zwX89D9daZlB9iUxFNjFQowfhzmDN6\n Gdsa/Bv7c4ThusU/eqnxlqVAATp4pj7cbh+RY/lqfBzztP7fuEFYrp7bzOMpGA==", "From": "<pbhagavatula@marvell.com>", "To": "<jerinj@marvell.com>, Pavan Nikhilesh <pbhagavatula@marvell.com>, \"Shijith\n Thotton\" <sthotton@marvell.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH] event/cnxk: use WFE LDP loop for getwork routine", "Date": "Fri, 5 Jan 2024 01:06:33 +0530", "Message-ID": "<20240104193633.2264-1-pbhagavatula@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "1y_hZprqigL4JSOBDwdoGuw4u9lIb3u_", "X-Proofpoint-GUID": "1y_hZprqigL4JSOBDwdoGuw4u9lIb3u_", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nUse WFE LDP loop while polling for GETWORK completion for better\npower savings.\nDisabled by default and can be enabled by setting\n`RTE_ARM_USE_WFE` to `true` in `config/arm/meson.build`\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n doc/guides/eventdevs/cnxk.rst | 9 ++++++\n drivers/event/cnxk/cn10k_worker.h | 52 +++++++++++++++++++++++++------\n 2 files changed, 52 insertions(+), 9 deletions(-)", "diff": "diff --git a/doc/guides/eventdevs/cnxk.rst b/doc/guides/eventdevs/cnxk.rst\nindex cccb8a0304..d62c143c77 100644\n--- a/doc/guides/eventdevs/cnxk.rst\n+++ b/doc/guides/eventdevs/cnxk.rst\n@@ -198,6 +198,15 @@ Runtime Config Options\n \n -a 0002:0e:00.0,tim_eclk_freq=122880000-1000000000-0\n \n+Power Savings on CN10K\n+----------------------\n+\n+ARM cores can additionally use WFE when polling for transactions on SSO bus\n+to save power i.e., in the event dequeue call ARM core can enter WFE and exit\n+when either work has been scheduled or dequeue timeout has reached.\n+This can be enabled by setting ``RTE_ARM_USE_WFE`` to ``true`` in\n+``config/arm/meson.build``.\n+\n Debugging Options\n -----------------\n \ndiff --git a/drivers/event/cnxk/cn10k_worker.h b/drivers/event/cnxk/cn10k_worker.h\nindex 8aa916fa12..92d5190842 100644\n--- a/drivers/event/cnxk/cn10k_worker.h\n+++ b/drivers/event/cnxk/cn10k_worker.h\n@@ -250,23 +250,57 @@ cn10k_sso_hws_get_work(struct cn10k_sso_hws *ws, struct rte_event *ev,\n \n \tgw.get_work = ws->gw_wdata;\n #if defined(RTE_ARCH_ARM64)\n-#if !defined(__clang__)\n-\tasm volatile(\n-\t\tPLT_CPU_FEATURE_PREAMBLE\n-\t\t\"caspal %[wdata], %H[wdata], %[wdata], %H[wdata], [%[gw_loc]]\\n\"\n-\t\t: [wdata] \"+r\"(gw.get_work)\n-\t\t: [gw_loc] \"r\"(ws->base + SSOW_LF_GWS_OP_GET_WORK0)\n-\t\t: \"memory\");\n-#else\n+#if defined(__clang__)\n \tregister uint64_t x0 __asm(\"x0\") = (uint64_t)gw.u64[0];\n \tregister uint64_t x1 __asm(\"x1\") = (uint64_t)gw.u64[1];\n+#if defined(RTE_ARM_USE_WFE)\n+\tplt_write64(gw.u64[0], ws->base + SSOW_LF_GWS_OP_GET_WORK0);\n+\tasm volatile(PLT_CPU_FEATURE_PREAMBLE\n+\t\t \"\t\tldp %[x0], %[x1], [%[tag_loc]]\t\\n\"\n+\t\t \"\t\ttbz %[x0], %[pend_gw], done%=\t\\n\"\n+\t\t \"\t\tsevl\t\t\t\t\t\\n\"\n+\t\t \"rty%=:\twfe\t\t\t\t\t\\n\"\n+\t\t \"\t\tldp %[x0], %[x1], [%[tag_loc]]\t\\n\"\n+\t\t \"\t\ttbnz %[x0], %[pend_gw], rty%=\t\\n\"\n+\t\t \"done%=:\t\t\t\t\t\t\\n\"\n+\t\t \"\t\tdmb ld\t\t\t\t\t\\n\"\n+\t\t : [x0] \"+r\" (x0), [x1] \"+r\" (x1)\n+\t\t : [tag_loc] \"r\"(ws->base + SSOW_LF_GWS_WQE0),\n+\t\t [pend_gw] \"i\"(SSOW_LF_GWS_TAG_PEND_GET_WORK_BIT)\n+\t\t : \"memory\");\n+#else\n \tasm volatile(\".arch armv8-a+lse\\n\"\n \t\t \"caspal %[x0], %[x1], %[x0], %[x1], [%[dst]]\\n\"\n-\t\t : [x0] \"+r\"(x0), [x1] \"+r\"(x1)\n+\t\t : [x0] \"+r\" (x0), [x1] \"+r\" (x1)\n \t\t : [dst] \"r\"(ws->base + SSOW_LF_GWS_OP_GET_WORK0)\n \t\t : \"memory\");\n+#endif\n \tgw.u64[0] = x0;\n \tgw.u64[1] = x1;\n+#else\n+#if defined(RTE_ARM_USE_WFE)\n+\tplt_write64(gw.u64[0], ws->base + SSOW_LF_GWS_OP_GET_WORK0);\n+\tasm volatile(PLT_CPU_FEATURE_PREAMBLE\n+\t\t \"\t\tldp %[wdata], %H[wdata], [%[tag_loc]]\t\\n\"\n+\t\t \"\t\ttbz %[wdata], %[pend_gw], done%=\t\\n\"\n+\t\t \"\t\tsevl\t\t\t\t\t\\n\"\n+\t\t \"rty%=:\twfe\t\t\t\t\t\\n\"\n+\t\t \"\t\tldp %[wdata], %H[wdata], [%[tag_loc]]\t\\n\"\n+\t\t \"\t\ttbnz %[wdata], %[pend_gw], rty%=\t\\n\"\n+\t\t \"done%=:\t\t\t\t\t\t\\n\"\n+\t\t \"\t\tdmb ld\t\t\t\t\t\\n\"\n+\t\t : [wdata] \"=&r\"(gw.get_work)\n+\t\t : [tag_loc] \"r\"(ws->base + SSOW_LF_GWS_WQE0),\n+\t\t [pend_gw] \"i\"(SSOW_LF_GWS_TAG_PEND_GET_WORK_BIT)\n+\t\t : \"memory\");\n+#else\n+\tasm volatile(\n+\t\tPLT_CPU_FEATURE_PREAMBLE\n+\t\t\"caspal %[wdata], %H[wdata], %[wdata], %H[wdata], [%[gw_loc]]\\n\"\n+\t\t: [wdata] \"+r\"(gw.get_work)\n+\t\t: [gw_loc] \"r\"(ws->base + SSOW_LF_GWS_OP_GET_WORK0)\n+\t\t: \"memory\");\n+#endif\n #endif\n #else\n \tplt_write64(gw.u64[0], ws->base + SSOW_LF_GWS_OP_GET_WORK0);\n", "prefixes": [] }