Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135700/?format=api
{ "id": 135700, "url": "https://patches.dpdk.org/api/patches/135700/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240103074721.832061-3-zhichaox.zeng@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240103074721.832061-3-zhichaox.zeng@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240103074721.832061-3-zhichaox.zeng@intel.com", "date": "2024-01-03T07:47:20", "name": "[v6,2/3] net/iavf: support Tx LLDP on AVX512", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "07cfd85b992968cd43da083bb137b18ce3e518e2", "submitter": { "id": 2644, "url": "https://patches.dpdk.org/api/people/2644/?format=api", "name": "Zhichao Zeng", "email": "zhichaox.zeng@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240103074721.832061-3-zhichaox.zeng@intel.com/mbox/", "series": [ { "id": 30708, "url": "https://patches.dpdk.org/api/series/30708/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=30708", "date": "2024-01-03T07:47:18", "name": "net/iavf: support Tx LLDP on scalar and AVX512", "version": 6, "mbox": "https://patches.dpdk.org/series/30708/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/135700/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/135700/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5C3BA43807;\n\tWed, 3 Jan 2024 08:37:37 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 425A040648;\n\tWed, 3 Jan 2024 08:37:33 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 0B92C4067D\n for <dev@dpdk.org>; Wed, 3 Jan 2024 08:37:30 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Jan 2024 23:37:30 -0800", "from unknown (HELO zhichao-dpdk..) ([10.239.252.103])\n by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Jan 2024 23:37:28 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1704267451; x=1735803451;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=KTgmdkVh1tN3PmDlUNRwjGizrR/bfbOAQ5eA0yuUEtk=;\n b=BBPbwY9YldBJ+Ca5RfzYePOI819x4YXuw3p+ICJSuNmT3pXzkZrCqCB6\n ZUASEz23A+CjqOV9dalqV0LUldi0EbcO+vlEKRu0OWYEUtjeIRpvF/vF8\n 4Ckc7x6tsCOCH4h37dlAVT0sIjG68TiXvwyIG5sqHf4i799KfYtRAXKkk\n Tbnb0G5nPzg/YXlHjNqvgKaRkytm5qR5VmuBaSx5EtoAl/9G+hybbOYgZ\n PZC43e1pR6bVyevB9NJ4aE+5o+n0yo7pcg4JHLNmmhyAZfWQPzt9ZsCOp\n ZpA5brOOb5kL/IlPCR2ljF/q0A7vLK13qYHle40D0qFuTx33Vd9SGiIci A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10941\"; a=\"387428606\"", "E=Sophos;i=\"6.04,327,1695711600\"; d=\"scan'208\";a=\"387428606\"", "E=McAfee;i=\"6600,9927,10941\"; a=\"779913059\"", "E=Sophos;i=\"6.04,327,1695711600\"; d=\"scan'208\";a=\"779913059\"" ], "X-ExtLoop1": "1", "From": "Zhichao Zeng <zhichaox.zeng@intel.com>", "To": "dev@dpdk.org", "Cc": "qi.z.zhang@intel.com, Zhichao Zeng <zhichaox.zeng@intel.com>,\n Jingjing Wu <jingjing.wu@intel.com>, Beilei Xing <beilei.xing@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>", "Subject": "[PATCH v6 2/3] net/iavf: support Tx LLDP on AVX512", "Date": "Wed, 3 Jan 2024 15:47:20 +0800", "Message-Id": "<20240103074721.832061-3-zhichaox.zeng@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240103074721.832061-1-zhichaox.zeng@intel.com>", "References": "<20231228032211.1127554-1-zhichaox.zeng@intel.com>\n <20240103074721.832061-1-zhichaox.zeng@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch adds an avx512 ctx Tx path that supports context descriptor,\nfilling in the SWTCH_UPLINK bit based on mbuf\ndynfield IAVF_TX_LLDP_DYNFIELD to support transmitting LLDP packet.\n\nSigned-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>\n---\n drivers/net/iavf/iavf_rxtx.c | 5 +++++\n drivers/net/iavf/iavf_rxtx.h | 3 +++\n drivers/net/iavf/iavf_rxtx_vec_avx512.c | 16 ++++++++++++++++\n drivers/net/iavf/iavf_rxtx_vec_common.h | 5 +++++\n 4 files changed, 29 insertions(+)", "diff": "diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c\nindex 4329809d1d..e54fb74b79 100644\n--- a/drivers/net/iavf/iavf_rxtx.c\n+++ b/drivers/net/iavf/iavf_rxtx.c\n@@ -4048,6 +4048,11 @@ iavf_set_tx_function(struct rte_eth_dev *dev)\n \t\t\t\tdev->tx_pkt_prepare = iavf_prep_pkts;\n \t\t\t\tPMD_DRV_LOG(DEBUG, \"Using AVX512 OFFLOAD Vector Tx (port %d).\",\n \t\t\t\t\t dev->data->port_id);\n+\t\t\t} else if (check_ret == IAVF_VECTOR_CTX_PATH) {\n+\t\t\t\tdev->tx_pkt_burst = iavf_xmit_pkts_vec_avx512_ctx;\n+\t\t\t\tdev->tx_pkt_prepare = iavf_prep_pkts;\n+\t\t\t\tPMD_DRV_LOG(DEBUG, \"Using AVX512 CONTEXT Vector Tx (port %d).\",\n+\t\t\t\t\t\tdev->data->port_id);\n \t\t\t} else {\n \t\t\t\tdev->tx_pkt_burst = iavf_xmit_pkts_vec_avx512_ctx_offload;\n \t\t\t\tdev->tx_pkt_prepare = iavf_prep_pkts;\ndiff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h\nindex 25df517bc6..a8af263d59 100644\n--- a/drivers/net/iavf/iavf_rxtx.h\n+++ b/drivers/net/iavf/iavf_rxtx.h\n@@ -66,6 +66,7 @@\n #define IAVF_VECTOR_PATH 0\n #define IAVF_VECTOR_OFFLOAD_PATH 1\n #define IAVF_VECTOR_CTX_OFFLOAD_PATH 2\n+#define IAVF_VECTOR_CTX_PATH 3\n \n #define DEFAULT_TX_RS_THRESH 32\n #define DEFAULT_TX_FREE_THRESH 32\n@@ -760,6 +761,8 @@ uint16_t iavf_xmit_pkts_vec_avx512_offload(void *tx_queue,\n \t\t\t\t\t uint16_t nb_pkts);\n uint16_t iavf_xmit_pkts_vec_avx512_ctx_offload(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\t\t uint16_t nb_pkts);\n+uint16_t iavf_xmit_pkts_vec_avx512_ctx(void *tx_queue, struct rte_mbuf **tx_pkts,\n+\t\t\t\t uint16_t nb_pkts);\n int iavf_txq_vec_setup_avx512(struct iavf_tx_queue *txq);\n \n uint8_t iavf_proto_xtr_type_to_rxdid(uint8_t xtr_type);\ndiff --git a/drivers/net/iavf/iavf_rxtx_vec_avx512.c b/drivers/net/iavf/iavf_rxtx_vec_avx512.c\nindex 7a7df6d258..3bb6f305df 100644\n--- a/drivers/net/iavf/iavf_rxtx_vec_avx512.c\n+++ b/drivers/net/iavf/iavf_rxtx_vec_avx512.c\n@@ -2206,6 +2206,9 @@ ctx_vtx1(volatile struct iavf_tx_desc *txdp, struct rte_mbuf *pkt,\n \t\t\tlow_ctx_qw |= (uint64_t)pkt->vlan_tci << IAVF_TXD_CTX_QW0_L2TAG2_PARAM;\n \t\t}\n \t}\n+\tif (IAVF_CHECK_TX_LLDP(pkt))\n+\t\thigh_ctx_qw |= IAVF_TX_CTX_DESC_SWTCH_UPLINK\n+\t\t\t<< IAVF_TXD_CTX_QW1_CMD_SHIFT;\n \tuint64_t high_data_qw = (IAVF_TX_DESC_DTYPE_DATA |\n \t\t\t\t((uint64_t)flags << IAVF_TXD_QW1_CMD_SHIFT) |\n \t\t\t\t((uint64_t)pkt->data_len << IAVF_TXD_QW1_TX_BUF_SZ_SHIFT));\n@@ -2258,6 +2261,9 @@ ctx_vtx(volatile struct iavf_tx_desc *txdp,\n \t\t\t\t\t(uint64_t)pkt[1]->vlan_tci << IAVF_TXD_QW1_L2TAG1_SHIFT;\n \t\t\t}\n \t\t}\n+\t\tif (IAVF_CHECK_TX_LLDP(pkt[1]))\n+\t\t\thi_ctx_qw1 |= IAVF_TX_CTX_DESC_SWTCH_UPLINK\n+\t\t\t\t<< IAVF_TXD_CTX_QW1_CMD_SHIFT;\n \n \t\tif (pkt[0]->ol_flags & RTE_MBUF_F_TX_VLAN) {\n \t\t\tif (vlan_flag & IAVF_TX_FLAGS_VLAN_TAG_LOC_L2TAG2) {\n@@ -2270,6 +2276,9 @@ ctx_vtx(volatile struct iavf_tx_desc *txdp,\n \t\t\t\t\t(uint64_t)pkt[0]->vlan_tci << IAVF_TXD_QW1_L2TAG1_SHIFT;\n \t\t\t}\n \t\t}\n+\t\tif (IAVF_CHECK_TX_LLDP(pkt[0]))\n+\t\t\thi_ctx_qw0 |= IAVF_TX_CTX_DESC_SWTCH_UPLINK\n+\t\t\t\t<< IAVF_TXD_CTX_QW1_CMD_SHIFT;\n \n \t\tif (offload) {\n \t\t\tiavf_txd_enable_offload(pkt[1], &hi_data_qw1);\n@@ -2520,3 +2529,10 @@ iavf_xmit_pkts_vec_avx512_ctx_offload(void *tx_queue, struct rte_mbuf **tx_pkts,\n {\n \treturn iavf_xmit_pkts_vec_avx512_ctx_cmn(tx_queue, tx_pkts, nb_pkts, true);\n }\n+\n+uint16_t\n+iavf_xmit_pkts_vec_avx512_ctx(void *tx_queue, struct rte_mbuf **tx_pkts,\n+\t\t\t\t uint16_t nb_pkts)\n+{\n+\treturn iavf_xmit_pkts_vec_avx512_ctx_cmn(tx_queue, tx_pkts, nb_pkts, false);\n+}\ndiff --git a/drivers/net/iavf/iavf_rxtx_vec_common.h b/drivers/net/iavf/iavf_rxtx_vec_common.h\nindex e18cdc3f11..5c5220048d 100644\n--- a/drivers/net/iavf/iavf_rxtx_vec_common.h\n+++ b/drivers/net/iavf/iavf_rxtx_vec_common.h\n@@ -249,6 +249,11 @@ iavf_tx_vec_queue_default(struct iavf_tx_queue *txq)\n \tif (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS)\n \t\treturn -1;\n \n+\tif (rte_pmd_iavf_tx_lldp_dynfield_offset > 0) {\n+\t\ttxq->use_ctx = 1;\n+\t\treturn IAVF_VECTOR_CTX_PATH;\n+\t}\n+\n \t/**\n \t * Vlan tci needs to be inserted via ctx desc, if the vlan_flag is L2TAG2.\n \t * Tunneling parameters and other fields need be configured in ctx desc\n", "prefixes": [ "v6", "2/3" ] }