Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135476/?format=api
{ "id": 135476, "url": "https://patches.dpdk.org/api/patches/135476/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231221180529.18687-2-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231221180529.18687-2-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231221180529.18687-2-ajit.khaparde@broadcom.com", "date": "2023-12-21T18:05:12", "name": "[01/18] net/bnxt: add support for UDP GSO", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "48011a41bed6d28fed95a4f2dc078213de35b587", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231221180529.18687-2-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 30650, "url": "https://patches.dpdk.org/api/series/30650/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=30650", "date": "2023-12-21T18:05:11", "name": "bnxt patchset", "version": 1, "mbox": "https://patches.dpdk.org/series/30650/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/135476/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/135476/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B814D43752;\n\tThu, 21 Dec 2023 19:05:44 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5826A42E59;\n\tThu, 21 Dec 2023 19:05:39 +0100 (CET)", "from mail-pl1-f172.google.com (mail-pl1-f172.google.com\n [209.85.214.172])\n by mails.dpdk.org (Postfix) with ESMTP id 37E87402F0\n for <dev@dpdk.org>; Thu, 21 Dec 2023 19:05:37 +0100 (CET)", "by mail-pl1-f172.google.com with SMTP id\n d9443c01a7336-1d3e6c86868so8948855ad.1\n for <dev@dpdk.org>; Thu, 21 Dec 2023 10:05:37 -0800 (PST)", "from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id\n j17-20020a170902da9100b001d3b3ac2d7bsm1916379plx.245.2023.12.21.10.05.34\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 21 Dec 2023 10:05:34 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=broadcom.com; s=google; t=1703181936; x=1703786736; darn=dpdk.org;\n h=mime-version:references:in-reply-to:message-id:date:subject:cc:to\n :from:from:to:cc:subject:date:message-id:reply-to;\n bh=IUh3Te6/tlwemJimPty9FXbBu9kflpvRKAttC5o/7IY=;\n b=QnWP6dCB0LlPqlopt/C//yvBlWVq726RTDqCYIWDEajjBcxF38VyGlZfXqvM8ffOzI\n PIg7IxqNgJM92pKrwcXLTufKQ5DWiX0bTjI87Gqp39oDhyZ1c97rgtF0O0l+T1MZZ1gt\n grwEmpPFGafAFa/iFstvmBvTixLYNpEcRseVc=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1703181936; x=1703786736;\n h=mime-version:references:in-reply-to:message-id:date:subject:cc:to\n :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=IUh3Te6/tlwemJimPty9FXbBu9kflpvRKAttC5o/7IY=;\n b=Q7VrtmByQjKiTuFhnMvSyQTGPeVmO14GKyfnRFTI/4Vr6zklJml2pAXE/pcNMFIb8O\n EBQb+FgeJuK4OBzn6Nfccm27s1MV4SV9RmyZnZz9Is4s+w1d1wE7UR8It51wSqjtJ50J\n U8qxXpRt51gMUm7na2HbR/bvjn5eppYu7SpgwhQ5LpGInIAOSaepj2neCnumfyB05P+w\n al+v3foVfeItleJrsavVPAglheo/RE5OV6AmIw3lrcFnNGVl0WNhEdgoUpK199ipguPM\n Igu5pWKqEpLEVYUo7tsp8IikElXBMIjtxrDbGU+9dV0OU38lLJ5rmH83huF5Dy2BCE5e\n ez3A==", "X-Gm-Message-State": "AOJu0Ywv8U8vCFUXu3EmjKlSaKylwsjXEUPSeZ29fGAE1senWwHp3KJq\n DJYxlrHWw+62XnygZXE1GVWGjrDNRx4CE3Ny/YsA1VTCfM3tqg9hQj/Af0z29G0jxqUT8pni+wd\n jOC8bLbofiJHtE0VTxeaj4Or6t28Tnwxe45LvacdZtr6724A/N/8sp9jM3m9wYmdPNXv4o2+Wwr\n 8=", "X-Google-Smtp-Source": "\n AGHT+IHm1Tc/cX6SjRt4xwdbyzg976w/ojlqPBarig+kVCJSxRagQUXfiK1jozBGA5Bv0i4bVJhg4w==", "X-Received": "by 2002:a17:903:252:b0:1d3:f02c:e82a with SMTP id\n j18-20020a170903025200b001d3f02ce82amr35241plh.36.1703181935830;\n Thu, 21 Dec 2023 10:05:35 -0800 (PST)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>", "Subject": "[PATCH 01/18] net/bnxt: add support for UDP GSO", "Date": "Thu, 21 Dec 2023 10:05:12 -0800", "Message-Id": "<20231221180529.18687-2-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.39.2 (Apple Git-143)", "In-Reply-To": "<20231221180529.18687-1-ajit.khaparde@broadcom.com>", "References": "<20231221180529.18687-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; protocol=\"application/pkcs7-signature\";\n micalg=sha-256; boundary=\"0000000000004d09a1060d08f255\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "UDP GSO aka UDP Fragmentation Offload allows an application or stack\nto provide a data payload larger than the MTU. The application then\nupdates the mbuf ol_flags and sets the PKT_TX_UDP_SEG flag. Then based\non the tso_segs and tso_mss fields in the mbuf the PMD can indicate\nthe UDP GSO transmit request to the hardware.\nThis feature is supported on Thor2 and will be enabled when the firmware\nsets the UDP GSO support via the HWRM_FUNC_QCAPS.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 +\n drivers/net/bnxt/bnxt_hwrm.c | 2 ++\n drivers/net/bnxt/bnxt_txq.c | 2 ++\n drivers/net/bnxt/bnxt_txr.c | 7 ++++++-\n 4 files changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 7aed4c3da3..4b5c2c4b8f 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -801,6 +801,7 @@ struct bnxt {\n \t(BNXT_CHIP_P5_P7((bp)) && \\\n \t (bp)->hwrm_spec_code >= HWRM_VERSION_1_9_2 && \\\n \t !BNXT_VF((bp)))\n+#define BNXT_FW_CAP_UDP_GSO\t\tBIT(13)\n #define BNXT_TRUFLOW_EN(bp)\t((bp)->fw_cap & BNXT_FW_CAP_TRUFLOW_EN &&\\\n \t\t\t\t (bp)->app_id != 0xFF)\n \ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex e56f7693af..37cf179938 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -950,6 +950,8 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp)\n \tflags_ext2 = rte_le_to_cpu_32(resp->flags_ext2);\n \tif (flags_ext2 & HWRM_FUNC_QCAPS_OUTPUT_FLAGS_EXT2_RX_ALL_PKTS_TIMESTAMPS_SUPPORTED)\n \t\tbp->fw_cap |= BNXT_FW_CAP_RX_ALL_PKT_TS;\n+\tif (flags_ext2 & HWRM_FUNC_QCAPS_OUTPUT_FLAGS_EXT2_UDP_GSO_SUPPORTED)\n+\t\tbp->fw_cap |= BNXT_FW_CAP_UDP_GSO;\n \n unlock:\n \tHWRM_UNLOCK();\ndiff --git a/drivers/net/bnxt/bnxt_txq.c b/drivers/net/bnxt/bnxt_txq.c\nindex 4df4604975..f99ad211db 100644\n--- a/drivers/net/bnxt/bnxt_txq.c\n+++ b/drivers/net/bnxt/bnxt_txq.c\n@@ -42,6 +42,8 @@ uint64_t bnxt_get_tx_port_offloads(struct bnxt *bp)\n \t\ttx_offload_capa |= RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO;\n \tif (BNXT_TUNNELED_OFFLOADS_CAP_IPINIP_EN(bp))\n \t\ttx_offload_capa |= RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO;\n+\tif (bp->fw_cap & BNXT_FW_CAP_UDP_GSO)\n+\t\ttx_offload_capa |= RTE_ETH_TX_OFFLOAD_UDP_TSO;\n \n \treturn tx_offload_capa;\n }\ndiff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c\nindex 899986764f..38da2d2829 100644\n--- a/drivers/net/bnxt/bnxt_txr.c\n+++ b/drivers/net/bnxt/bnxt_txr.c\n@@ -123,6 +123,10 @@ bnxt_xmit_need_long_bd(struct rte_mbuf *tx_pkt, struct bnxt_tx_queue *txq)\n \treturn false;\n }\n \n+/* Used for verifying TSO segments during TCP Segmentation Offload or\n+ * UDP Fragmentation Offload. tx_pkt->tso_segsz stores the number of\n+ * segments or fragments in those cases.\n+ */\n static bool\n bnxt_zero_data_len_tso_segsz(struct rte_mbuf *tx_pkt, uint8_t data_len_chk)\n {\n@@ -308,7 +312,8 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t\telse\n \t\t\ttxbd1->cfa_action = txq->bp->tx_cfa_action;\n \n-\t\tif (tx_pkt->ol_flags & RTE_MBUF_F_TX_TCP_SEG) {\n+\t\tif (tx_pkt->ol_flags & RTE_MBUF_F_TX_TCP_SEG ||\n+\t\t tx_pkt->ol_flags & RTE_MBUF_F_TX_UDP_SEG) {\n \t\t\tuint16_t hdr_size;\n \n \t\t\t/* TSO */\n", "prefixes": [ "01/18" ] }