Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135430/?format=api
{ "id": 135430, "url": "https://patches.dpdk.org/api/patches/135430/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231221122302.2834184-1-brian.dooley@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231221122302.2834184-1-brian.dooley@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231221122302.2834184-1-brian.dooley@intel.com", "date": "2023-12-21T12:23:02", "name": "[v1] common/qat: option to disable asym driver", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "07339c25dfe6136995aadec97336b1295f87a99d", "submitter": { "id": 2520, "url": "https://patches.dpdk.org/api/people/2520/?format=api", "name": "Dooley, Brian", "email": "brian.dooley@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231221122302.2834184-1-brian.dooley@intel.com/mbox/", "series": [ { "id": 30645, "url": "https://patches.dpdk.org/api/series/30645/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=30645", "date": "2023-12-21T12:23:02", "name": "[v1] common/qat: option to disable asym driver", "version": 1, "mbox": "https://patches.dpdk.org/series/30645/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/135430/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/135430/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0927543750;\n\tThu, 21 Dec 2023 13:23:10 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D0BB64027D;\n\tThu, 21 Dec 2023 13:23:09 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.9])\n by mails.dpdk.org (Postfix) with ESMTP id CED55400D6\n for <dev@dpdk.org>; Thu, 21 Dec 2023 13:23:07 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Dec 2023 04:23:07 -0800", "from unknown (HELO silpixa00400886.ir.intel.com) ([10.243.23.150])\n by fmsmga001.fm.intel.com with ESMTP; 21 Dec 2023 04:23:05 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1703161388; x=1734697388;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=fusbRQPYqih6PQHAUYr+67OJ6zqbrJ6yVHc20yRmjtc=;\n b=m5jY6UUhkcR4Fm5tKRBnQTKCMVZqiz0NNaBJv6bz9SFR4Ni5ZAyDG1Di\n 9UF2Hm+NG5GMtvnetI/pTro//mM8b9VCcYZDSxg8864WxvNrrIIMNbhVn\n gUrW36Qeyu1U/rViAIVj6VcgzYQ86i0pFL9a+N2kDFk26uCANShsVZh9q\n jYAtSQbJMB4MadtVsWv3FNfA9+3Eo1o0LuXzK1c5BJrHLmHha5v44mW76\n P9oSV//Q1aKXBtyZDwL0nmUeEBVy9u8vBPICg3v7flk1jox3XyWFxu954\n vhhkacJsgaskXd4qmZfRaHO/v5yMfHuAx8FfX1HhXjDBqe0jX53cv3qQK A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10930\"; a=\"14651812\"", "E=Sophos;i=\"6.04,293,1695711600\"; d=\"scan'208\";a=\"14651812\"", "E=McAfee;i=\"6600,9927,10930\"; a=\"920313581\"", "E=Sophos;i=\"6.04,293,1695711600\"; d=\"scan'208\";a=\"920313581\"" ], "X-ExtLoop1": "1", "From": "Brian Dooley <brian.dooley@intel.com>", "To": "Kai Ji <kai.ji@intel.com>", "Cc": "dev@dpdk.org,\n\tgakhil@marvell.com,\n\tBrian Dooley <brian.dooley@intel.com>", "Subject": "[PATCH v1] common/qat: option to disable asym driver", "Date": "Thu, 21 Dec 2023 12:23:02 +0000", "Message-Id": "<20231221122302.2834184-1-brian.dooley@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently the QAT sym and asym drivers can only be disabled together\nwhen building. Add an option to disable the QAT asym driver.\n\nSigned-off-by: Brian Dooley <brian.dooley@intel.com>\n---\n drivers/common/qat/meson.build | 22 +++++++++++++++++---\n drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c | 2 ++\n drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 2 ++\n drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 2 ++\n drivers/crypto/qat/qat_crypto.c | 4 ++++\n 5 files changed, 29 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/common/qat/meson.build b/drivers/common/qat/meson.build\nindex 5c36fbb270..2f50302d45 100644\n--- a/drivers/common/qat/meson.build\n+++ b/drivers/common/qat/meson.build\n@@ -9,6 +9,8 @@ endif\n \n qat_crypto = true\n qat_crypto_path = 'crypto/qat'\n+qat_crypto_asym = true\n+qat_crypto_asym_path = 'crypto/qat_asym'\n qat_crypto_relpath = '../../' + qat_crypto_path\n qat_compress = true\n qat_compress_path = 'compress/qat'\n@@ -20,6 +22,12 @@ if disable_drivers.contains(qat_crypto_path)\n set_variable(qat_crypto_path.underscorify() + '_disable_reason',\n 'Explicitly disabled via build config')\n endif\n+if get_option('disable_drivers').contains(qat_crypto_asym_path)\n+ qat_crypto_asym = false\n+ dpdk_drvs_disabled += qat_crypto_asym_path\n+ set_variable(qat_crypto_asym_path.underscorify() + '_disable_reason',\n+ 'Explicitly disabled via build config')\n+endif\n if disable_drivers.contains(qat_compress_path)\n qat_compress = false\n dpdk_drvs_disabled += qat_compress_path\n@@ -102,9 +110,8 @@ endif\n \n if qat_crypto\n foreach f: ['qat_sym.c', 'qat_sym_session.c',\n- 'qat_asym.c', 'qat_crypto.c',\n+ 'qat_crypto.c',\n 'dev/qat_sym_pmd_gen1.c',\n- 'dev/qat_asym_pmd_gen1.c',\n 'dev/qat_crypto_pmd_gen2.c',\n 'dev/qat_crypto_pmd_gen3.c',\n 'dev/qat_crypto_pmd_gen4.c',\n@@ -112,5 +119,14 @@ if qat_crypto\n sources += files(join_paths(qat_crypto_relpath, f))\n endforeach\n deps += ['security']\n- cflags += ['-DBUILD_QAT_SYM', '-DBUILD_QAT_ASYM']\n+ cflags += ['-DBUILD_QAT_SYM']\n+endif\n+\n+if qat_crypto_asym\n+ foreach f: [ 'qat_asym.c', 'dev/qat_asym_pmd_gen1.c', ]\n+ sources += files(join_paths(qat_crypto_relpath, f))\n+ endforeach\n+ deps += ['security']\n+ ext_deps += libcrypto\n+ cflags += ['-DBUILD_QAT_ASYM']\n endif\ndiff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c b/drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c\nindex df47767749..523e74f398 100644\n--- a/drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c\n+++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c\n@@ -337,6 +337,7 @@ RTE_INIT(qat_sym_crypto_gen2_init)\n \t\t\tqat_sym_create_security_gen1;\n }\n \n+#ifdef BUILD_QAT_ASYM\n RTE_INIT(qat_asym_crypto_gen2_init)\n {\n \tqat_asym_gen_dev_ops[QAT_GEN2].cryptodev_ops =\n@@ -348,3 +349,4 @@ RTE_INIT(qat_asym_crypto_gen2_init)\n \tqat_asym_gen_dev_ops[QAT_GEN2].set_session =\n \t\t\tqat_asym_crypto_set_session_gen1;\n }\n+#endif\ndiff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c\nindex 02bcdb06b1..3fa90bebc9 100644\n--- a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c\n+++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c\n@@ -773,6 +773,7 @@ RTE_INIT(qat_sym_crypto_gen3_init)\n \t\t\tqat_sym_create_security_gen1;\n }\n \n+#ifdef BUILD_QAT_ASYM\n RTE_INIT(qat_asym_crypto_gen3_init)\n {\n \tqat_asym_gen_dev_ops[QAT_GEN3].cryptodev_ops =\n@@ -784,3 +785,4 @@ RTE_INIT(qat_asym_crypto_gen3_init)\n \tqat_asym_gen_dev_ops[QAT_GEN3].set_session =\n \t\t\tqat_asym_crypto_set_session_gen1;\n }\n+#endif\ndiff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c b/drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c\nindex de72383d4b..d19db0c2aa 100644\n--- a/drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c\n+++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c\n@@ -419,6 +419,7 @@ RTE_INIT(qat_sym_crypto_gen4_init)\n \t\t\tqat_sym_create_security_gen1;\n }\n \n+#ifdef BUILD_QAT_ASYM\n RTE_INIT(qat_asym_crypto_gen4_init)\n {\n \tqat_asym_gen_dev_ops[QAT_GEN4].cryptodev_ops =\n@@ -430,3 +431,4 @@ RTE_INIT(qat_asym_crypto_gen4_init)\n \tqat_asym_gen_dev_ops[QAT_GEN4].set_session =\n \t\t\tqat_asym_crypto_set_session_gen1;\n }\n+#endif\ndiff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c\nindex 861679373b..57590b0086 100644\n--- a/drivers/crypto/qat/qat_crypto.c\n+++ b/drivers/crypto/qat/qat_crypto.c\n@@ -53,8 +53,10 @@ qat_cryptodev_info_get(struct rte_cryptodev *dev,\n \t\t\tqat_qps_per_service(qat_dev, service_type);\n \t\tinfo->feature_flags = dev->feature_flags;\n \t\tinfo->capabilities = qat_private->qat_dev_capabilities;\n+#ifdef BUILD_QAT_ASYM\n \t\tif (service_type == QAT_SERVICE_ASYMMETRIC)\n \t\t\tinfo->driver_id = qat_asym_driver_id;\n+#endif\n \n \t\tif (service_type == QAT_SERVICE_SYMMETRIC)\n \t\t\tinfo->driver_id = qat_sym_driver_id;\n@@ -168,8 +170,10 @@ qat_cryptodev_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \tfor (i = 0; i < qp->nb_descriptors; i++) {\n \t\tif (service_type == QAT_SERVICE_SYMMETRIC)\n \t\t\tqat_sym_init_op_cookie(qp->op_cookies[i]);\n+#ifdef BUILD_QAT_ASYM\n \t\telse\n \t\t\tqat_asym_init_op_cookie(qp->op_cookies[i]);\n+#endif\n \t}\n \n \tif (qat_private->cipher_crc_offload_enable) {\n", "prefixes": [ "v1" ] }